Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoothie lifecycle extension does not support arbitrary ViewModelStoreOwner, only Activity/Fragment #409

Open
Zhuinden opened this issue May 30, 2020 · 3 comments
Open

smoothie lifecycle extension does not support arbitrary ViewModelStoreOwner, only Activity/Fragment #409

Zhuinden opened this issue May 30, 2020 · 3 comments
Labels
enhancement
Milestone
4.0.0

Comments

@Zhuinden
Copy link

Zhuinden commented May 30, 2020 •
edited
Loading

This is a problem, because Jetpack Navigation allows for the creation of NavGraph-scoped ViewModels, bound to the lifecycle of a NavBackStackEntry.

Toothpick should be able to support this scenario.
@Zhuinden

This comment has been minimized.

Sign in to view
@dlemures dlemures added this to the 4.0.0 milestone Jun 13, 2020
@dlemures
Copy link
Collaborator

Interesting, will do some research and target 4.0.

Thanks for the issue!

@dlemures
Copy link
Collaborator

We just need to update toothpick.smoothie.viewmodel.ViewModelProvider to use the new API for androidx...ViewModelProvider:

https://developer.android.com/reference/androidx/lifecycle/ViewModelProvider

It takes a ViewModelStoreOwner as a constructor param, it will make it work with this use case and simplify TP code as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@dlemures @Zhuinden