Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Get runes from apis #30

Open
DanielmGM opened this issue Jul 26, 2019 · 4 comments
Open

[Feature Request] Get runes from apis #30

DanielmGM opened this issue Jul 26, 2019 · 4 comments
Labels
enhancement Enchancement to something already there

Comments

@DanielmGM
Copy link
Contributor

Add an option to automatically get runes for every champion in all their roles from mobafire, lolalytics, or another website with an api, and import them.
@stirante stirante added the enhancement Enchancement to something already there label Jul 26, 2019
@robinwithes
Copy link
Collaborator

The new gui is being worked on currently and this could fit really wel into it.

@stirante
Copy link
Owner

This is definitely something we're aiming for. BTW none of those websites actually have an API, so we will need to scrape them.

I'll probably be making at least one of those sites soon.

@robinwithes
Copy link
Collaborator

robinwithes commented Aug 16, 2019 •
edited
Loading

Champion.gg runesource is done and scheduled for release when the new gui is finished

@stirante
Copy link
Owner

Champion.gg source released with https://github.com/stirante/RuneChanger/releases/tag/1.12

@PixelHir PixelHir mentioned this issue Sep 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enchancement to something already there
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stirante @DanielmGM @robinwithes