From 87f687904929bbbb669840393c8204171e93be70 Mon Sep 17 00:00:00 2001 From: Vojtech Trefny Date: Tue, 3 Dec 2024 13:13:28 +0100 Subject: [PATCH 1/3] tests: Stop trying to fully fill the VG in LVM tests Some of the test cases try to use 100 % of the space in the VG and these tests are randomly failing with LVM claiming there isn't enough free space. It's not our job to test these LVM weird behaviours so let's just make the requested sizes smaller to always fit. --- src/tests/dbus-tests/test_20_LVM.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tests/dbus-tests/test_20_LVM.py b/src/tests/dbus-tests/test_20_LVM.py index 9244f0937..f5968a3aa 100644 --- a/src/tests/dbus-tests/test_20_LVM.py +++ b/src/tests/dbus-tests/test_20_LVM.py @@ -434,7 +434,7 @@ def test_30_snapshot(self): # Create the origin LV vgsize = int(self.get_property_raw(vg, '.VolumeGroup', 'FreeSize')) lvname = 'udisks_test_origin_lv' - lv_path = vg.CreatePlainVolume(lvname, dbus.UInt64(vgsize / 2), self.no_options, + lv_path = vg.CreatePlainVolume(lvname, dbus.UInt64(vgsize // 3), self.no_options, dbus_interface=self.iface_prefix + '.VolumeGroup') lv = self.bus.get_object(self.iface_prefix, lv_path) self.assertIsNotNone(lv) @@ -477,7 +477,7 @@ def test_40_cache(self): # Create the origin LV vgsize = int(self.get_property_raw(vg, '.VolumeGroup', 'FreeSize')) orig_lvname = 'udisks_test_origin_lv' - lv_path = vg.CreatePlainVolume(orig_lvname, dbus.UInt64(vgsize / 2), self.no_options, + lv_path = vg.CreatePlainVolume(orig_lvname, dbus.UInt64(vgsize // 3), self.no_options, dbus_interface=self.iface_prefix + '.VolumeGroup') lv = self.bus.get_object(self.iface_prefix, lv_path) self.assertIsNotNone(lv) @@ -489,7 +489,7 @@ def test_40_cache(self): cache_lvname = 'udisks_test_cache_lv' vgsize = int(self.get_property_raw(vg, '.VolumeGroup', 'FreeSize')) # 8 MiB reserved for the cache metadata created automatically by LVM - lv_cache_path = vg.CreatePlainVolume(cache_lvname, dbus.UInt64((vgsize / 2) - 8 * 1024**2), self.no_options, + lv_cache_path = vg.CreatePlainVolume(cache_lvname, dbus.UInt64((vgsize // 3) - 8 * 1024**2), self.no_options, dbus_interface=self.iface_prefix + '.VolumeGroup') cache_lv = self.bus.get_object(self.iface_prefix, lv_cache_path) self.assertIsNotNone(cache_lv) From 8b74e950498930ed746bc08bf36558bf8fb1434c Mon Sep 17 00:00:00 2001 From: Vojtech Trefny Date: Tue, 3 Dec 2024 13:15:25 +0100 Subject: [PATCH 2/3] tests: Enable LVM VDO tests on CentOS/RHEL 10 The VDO userspace tools are now available. --- src/tests/dbus-tests/skip.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/tests/dbus-tests/skip.yml b/src/tests/dbus-tests/skip.yml index 9b9d2b56b..7a7cef152 100644 --- a/src/tests/dbus-tests/skip.yml +++ b/src/tests/dbus-tests/skip.yml @@ -35,9 +35,3 @@ - distro: "fedora" version: ["39", "40", "41"] reason: Setting UUID with LC_ALL=C.UTF-8 is broken with recent exfatprogs - -- test: test_20_LVM.UdisksLVMVDOTest - skip_on: - - distro: "centos" - version: "10" - reason: "vdo userspace tools are not yet available on RHEL/CentOS 10" From 268b9b8ab6d96962c8014b240bdb9d5bd182f7e8 Mon Sep 17 00:00:00 2001 From: Vojtech Trefny Date: Tue, 3 Dec 2024 13:16:55 +0100 Subject: [PATCH 3/3] tests: Enable Exfat UUID tests on Fedora The exfatprogs bug was fixed and the fixed version is now available on all supported versions of Fedora. --- src/tests/dbus-tests/skip.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/tests/dbus-tests/skip.yml b/src/tests/dbus-tests/skip.yml index 7a7cef152..b95e87ac1 100644 --- a/src/tests/dbus-tests/skip.yml +++ b/src/tests/dbus-tests/skip.yml @@ -29,9 +29,3 @@ - distro: ["centos", "enterprise_linux"] version: "7" reason: "SCSI debug bug causing kernel panic on CentOS/RHEL 7" - -- test: test_80_filesystem.EXFATTestCase.test_uuid - skip_on: - - distro: "fedora" - version: ["39", "40", "41"] - reason: Setting UUID with LC_ALL=C.UTF-8 is broken with recent exfatprogs