From 92adb728ba2209f08641b925331dd3f4cc3f3e98 Mon Sep 17 00:00:00 2001 From: Sebastian Liu Date: Tue, 20 Aug 2024 14:49:49 -0700 Subject: [PATCH] chore: add missing comments and duplicated asserts --- contracts/StoryProtocolGateway.sol | 2 ++ contracts/interfaces/IStoryProtocolGateway.sol | 1 + test/StoryProtocolGateway.t.sol | 1 - 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/contracts/StoryProtocolGateway.sol b/contracts/StoryProtocolGateway.sol index b73b061..b6fa757 100644 --- a/contracts/StoryProtocolGateway.sol +++ b/contracts/StoryProtocolGateway.sol @@ -263,6 +263,7 @@ contract StoryProtocolGateway is IStoryProtocolGateway, ERC721Holder, AccessMana /// @param derivData The derivative data to be used for registerDerivative. /// @param nftMetadata OPTIONAL. The desired metadata for the newly minted NFT. /// @param ipMetadata OPTIONAL. The desired metadata for the newly registered IP. + /// @param recipient The address to receive the minted NFT. /// @return ipId The ID of the registered IP. /// @return tokenId The ID of the minted NFT. function mintAndRegisterIpAndMakeDerivative( @@ -556,6 +557,7 @@ contract StoryProtocolGateway is IStoryProtocolGateway, ERC721Holder, AccessMana /// @param licenseTemplate The address of the license template. /// @param licenseTermsId The ID of the license terms for the parent IP. /// @param amount The amount of licenses to mint. + /// @return The mint fee for the given parent IP. function _getMintFeeForSingleParent( address childIpId, address parentIpId, diff --git a/contracts/interfaces/IStoryProtocolGateway.sol b/contracts/interfaces/IStoryProtocolGateway.sol index f32a215..96439a1 100644 --- a/contracts/interfaces/IStoryProtocolGateway.sol +++ b/contracts/interfaces/IStoryProtocolGateway.sol @@ -136,6 +136,7 @@ interface IStoryProtocolGateway { /// @param derivData The derivative data to be used for registerDerivative. /// @param nftMetadata OPTIONAL. The desired metadata for the newly minted NFT. /// @param ipMetadata OPTIONAL. The desired metadata for the newly registered IP. + /// @param recipient The address to receive the minted NFT. /// @return ipId The ID of the registered IP. /// @return tokenId The ID of the minted NFT. function mintAndRegisterIpAndMakeDerivative( diff --git a/test/StoryProtocolGateway.t.sol b/test/StoryProtocolGateway.t.sol index a9c2e09..52392fc 100644 --- a/test/StoryProtocolGateway.t.sol +++ b/test/StoryProtocolGateway.t.sol @@ -594,7 +594,6 @@ contract StoryProtocolGatewayTest is BaseTest { assertTrue(ipAssetRegistry.isRegistered(ipIdChild)); assertEq(tokenIdChild, 2); assertMetadata(ipIdChild, ipMetadataDefault); - assertMetadata(ipIdChild, ipMetadataDefault); (address licenseTemplateChild, uint256 licenseTermsIdChild) = licenseRegistry.getAttachedLicenseTerms( ipIdChild, 0