[bug]: translation files not working

[LuisRodriguezLD]

What version of @strapi/sdk-plugin are you using?

• NPM 10.5.0
• NODE 20
• @strapi/sdk-plugin 5.2.6

What's Wrong?

The translation files aren't picked up properly.
In the past, there was a helper function that converted the object into an array

const importedTrads = await Promise.all(
      locales.map((locale) => {
        return import(`./translations/${locale}.json`)
          .then(({ default: data }) => {
            return {
              data: prefixPluginTranslations(data, pluginId),  // <--- this helper
              locale,
            };
          })
          .catch(() => {
            return {
              data: {},
              locale,
            };
          });
      })
    );

but that is gone when creating a new plugin with this package

To Reproduce

1. Create a new plugin
2. Attempt to use the translation/en.json
3. Link to a project
4. Project will not pick the translations

Expected Behaviour

Translation files should work automatically, I tested using the helperFunction and it worked
https://github.com/strapi/strapi/blob/504076d2165a82f124620a3f1f3e3a6017e97f3f/packages/core/email/admin/src/utils/prefixPluginTranslations.ts

Complete working example:

import { getTranslation } from './utils/getTranslation';
import { PLUGIN_ID } from './pluginId';
import { Initializer } from './components/Initializer';
import { PluginIcon } from './components/PluginIcon';

export default {
  register(app: any) {
    app.addMenuLink({
      to: `plugins/${PLUGIN_ID}`,
      icon: PluginIcon,
      intlLabel: {
        id: `${PLUGIN_ID}.plugin.name`,
        defaultMessage: PLUGIN_ID,
      },
      Component: async () => {
        const { App } = await import('./pages/App');

        return App;
      },
    });

    app.registerPlugin({
      id: PLUGIN_ID,
      initializer: Initializer,
      isReady: false,
      name: PLUGIN_ID,
    });
  },

  async registerTrads(app: any) {
    const { locales } = app;

    const importedTranslations = await Promise.all(
      (locales as string[]).map((locale) => {
        return import(`./translations/${locale}.json`)
          .then(({ default: data }) => {
            return {
              data: prefixPluginTranslations(data, PLUGIN_ID),
              locale,
            };
          })
          .catch(() => {
            return {
              data: {},
              locale,
            };
          });
      })
    );

    return importedTranslations;
  },
};

type TradOptions = Record<string, string>;
const prefixPluginTranslations = (trad: TradOptions, pluginId: string): TradOptions => {
  if (!pluginId) {
    throw new TypeError("pluginId can't be empty");
  }
  return Object.keys(trad).reduce((acc, current) => {
    acc[`${pluginId}.${current}`] = trad[current];
    return acc;
  }, {} as TradOptions);
};

[hanpaine]

Resolved by #66