Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: external dependency is included in output #77

Open
jorrit opened this issue Jan 24, 2025 · 0 comments
Open

[bug]: external dependency is included in output #77

jorrit opened this issue Jan 24, 2025 · 0 comments
Labels
issue: bug Issue reporting a bug

Comments

@jorrit
Copy link

jorrit commented Jan 24, 2025

What version of @strapi/sdk-plugin are you using?

  • NPM 11
  • Node 22
  • React 18.3.1
  • @strapi/sdk-plugin 5.3.0

What's Wrong?

I noticed that the admin build of strapi-plugin-navigation includes the entire lodash dependency. I think this related to some kind of configuration in @strapi/sdk-plugin and/or @strapi/pack-up.

See VirtusLab-Open-Source/strapi-plugin-navigation#509 for more discussion.

To Reproduce

  1. Checkout https://github.com/VirtusLab-Open-Source/strapi-plugin-navigation
  2. yarn + yarn build (which uses strapi-plugin build)
  3. Notice that dist/admin/index.js and dist/admin/index.mjs contain the source of the lodash dependency.

Expected Behaviour

All dependencies should be external.

@jorrit jorrit added the issue: bug Issue reporting a bug label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug
Projects
None yet
Development

No branches or pull requests

1 participant