Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded start on 2020 for building historical data #10

Open
verovaleros opened this issue Jul 26, 2023 · 1 comment · Fixed by #23
Open

Hardcoded start on 2020 for building historical data #10

verovaleros opened this issue Jul 26, 2023 · 1 comment · Fixed by #23
Assignees
Labels
bug Something isn't working

Comments

@verovaleros
Copy link
Member

verovaleros commented Jul 26, 2023

Describe the bug
When running AIP (development branch), it starts searching and attempting to find data from 2020:

DEBUG: PROCESSING DATE 2020-07-04
2023-07-26 14:59:15,647 - aip.data.access - DEBUG - Creating attacks for dates ['2020-07-04']
2023-07-26 14:59:15,647 - aip.data.access - DEBUG - Making  dataset from raw data for dates ['2020-07-04']
2023-07-26 14:59:15,776 - root - DEBUG - Downloading data for 2020-07-04

To Reproduce
Steps to reproduce the behavior:

  1. Git clone: git clone https://github.com/stratosphereips/AIP.git
  2. Docker build: 'docker build --build-arg uid=1000 --file etc/docker/Dockerfile --tag aip:latest .'
  3. Docker run: docker run -ti -v /root/AIP/:/home/aip/AIP -v /opt/zeek/logs/:/home/aip/AIP/data/raw:ro -v /root/AIP/data/:/home/aip/AIP/data/:rw --name aip aip:latest bin/aip
  4. See error:
    image

Looking at the code, it seems the starting date is hardcoded in the code:

start = '2020-07-05'

def build(self, start=date(2020, 7, 4), end=date.today() - timedelta(days=1), force=False):

Expected behavior
The starting date should be read from the earliest date seen on honeypots_public_ips.csv or from a parameter or variable.

@verovaleros verovaleros added the bug Something isn't working label Jul 26, 2023
@verovaleros verovaleros linked a pull request Aug 1, 2023 that will close this issue
@verovaleros
Copy link
Member Author

The hardcoded date on models/prioritize.py is fixed in #23. Not closing the issue as the others remain to be fixed.

@verovaleros verovaleros moved this to 🆕 New in Stratosphere AIP Aug 3, 2023
@verovaleros verovaleros self-assigned this Oct 23, 2024
@verovaleros verovaleros moved this from 🆕 New to 📋 Backlog in Stratosphere AIP Oct 23, 2024
@verovaleros verovaleros modified the milestone: v3.0.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

1 participant