Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crashed when calling client.end() from pubsub client #6

Open
ghostoy opened this issue Sep 18, 2017 · 0 comments · May be fixed by #7
Open

crashed when calling client.end() from pubsub client #6

ghostoy opened this issue Sep 18, 2017 · 0 comments · May be fixed by #7

Comments

@ghostoy
Copy link

ghostoy commented Sep 18, 2017

The cause was in that this.pubClient and this.subClient were undefined. See
https://github.com/strongloop/strong-pubsub-redis/blob/master/index.js#L73-L74.

Looks like these variables were not assigned in constructor or should they be changed to this.redisPubClient and this.redisSubClient.
ghostoy added a commit to ghostoy/strong-pubsub-redis that referenced this issue Sep 18, 2017
@ghostoy
fixed crash if closed from client
aa8b3fe 
fixed strongloop#6
@ghostoy ghostoy linked a pull request Sep 18, 2017 that will close this issue
Open
ghostoy added a commit to ghostoy/strong-pubsub-redis that referenced this issue Sep 18, 2017
@ghostoy
fixed crash if closed from client
1c2261e 
fixed strongloop#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed crash if closed from client ghostoy/strong-pubsub-redis
1 participant
@ghostoy