Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class tree rendering and miscellaneous improvements #201

Open
1 of 3 tasks
LunaY0Yuki opened this issue Oct 3, 2020 · 2 comments
Open
1 of 3 tasks

Class tree rendering and miscellaneous improvements #201

LunaY0Yuki opened this issue Oct 3, 2020 · 2 comments
Labels

Comments

@LunaY0Yuki
Copy link
Collaborator

LunaY0Yuki commented Oct 3, 2020

Some of the bugs/improvements of the tree:

  • When a user creates a resource and the resource modal closes, the new resource does not appear in the tree.

  • The URL for the tree is not working. When the tree is at a specific node, and the user reloads the url, the website shows that the page is not found.

  • When a user right-click on "All Classes", the menu should not light up "Add" because you cannot add a new resource to the root of the tree.

@LunaY0Yuki
Copy link
Collaborator Author

In order to animate a new resource appearing in the tree after you create it, we might need to call a function in the Tree class as our success callback function.

But... right now because the resource modal is just a bunch of functions, it's really hard to pass a reference to the Tree object around.

So... actually we might need to rewrite the resource_modal.js as a class.

@LunaY0Yuki
Copy link
Collaborator Author

We don't have any UI to create classes? Right now, "add" in the context menu only add new resources.

This might not be MVP. We could just make admins create classes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant