Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus order on search results page #1259

Open
dbranchini opened this issue Aug 26, 2024 · 7 comments
Open

Focus order on search results page #1259

dbranchini opened this issue Aug 26, 2024 · 7 comments

Comments

@dbranchini
Copy link

dbranchini commented Aug 26, 2024

Focus order is primarily correct but in the main content area, it's doing the following:

  • Start over/Active facets
  • Paging/options at the top of results
  • Results
  • Map
  • Paging at the bottom of results
  • Sidebar/Facet panel

I suggest the following (should be the same as visual layout/reading order):

  • Start over/Active facets (your selections)
  • Sidebar/Facet panel
  • Paging/options at the top of results
  • Results
  • Paging at the bottom of results
  • Map
@dbranchini dbranchini converted this from a draft issue Aug 26, 2024
@dbranchini
Copy link
Author

See related issue for Spotlight - sul-dlss/exhibits#2466.

@jcoyne
Copy link
Contributor

jcoyne commented Aug 26, 2024

At least part of this "Facets before results" must be fixed in Blacklight.

@jcoyne
Copy link
Contributor

jcoyne commented Aug 26, 2024

@dbranchini I talked with Chris and he felt that having results before facets is important for accessibility. This was an intentional design and I believe it came out of user testing. A user will need to see the results to know if they are any good before deciding to add filters to them.

@dbranchini
Copy link
Author

@cbeer @jcoyne , I understand what you're saying, and I had that same thought when I looked at this, but here's the guidance on keyboard navigation:

As a keyboard user navigates through the page, the order in which interactive items receive keyboard focus is important. The default keyboard navigation order must be logical and intuitive. This generally means that it follows the visual flow of the page—left to right, top to bottom. (https://webaim.org/techniques/keyboard/)

Also, I'd like to point out that SearchWorks follows the above guidance, so @cbeer, do you know when it was decided to do it differently and/or was it for EarthWorks only?

@dbranchini
Copy link
Author

Also, it was already fixed in Argo - sul-dlss/argo#4161 - to match this pattern.

@dnoneill
Copy link
Contributor

Both Argo and Searchworks are on Blacklight 7.38.0. Must have been changed in Blacklight 8.

@dbranchini
Copy link
Author

I discussed this with @alundgard and @astridu today, and we all feel this is a valid accessibility issue and should be addressed. We also decided that it was presumptuous to assume a user would prefer to go to the results first instead of the facets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

3 participants