Sidebar a11y updates: <aside>, aria-label #1437
Assignees
Labels
Comments
|
Also, if it's easy enough, "Also available at" and "Item belong to a collection" should be in the same gray box. See this Figma design - https://www.figma.com/design/nkgg905s5FyXoyPZjVMco0/EarthWorks?node-id=517-18605&t=N5nCgaAU3Yv8eOEv-4. |
thatbudakguy
changed the title
|
Opened projectblacklight/blacklight#3423 in blacklight to partially address this. |
thatbudakguy
added a commit
that referenced
this issue
Oct 31, 2024
This refactors the sidebar component to make it easier to determine what is being rendered in each of the two sections and to render it without accidentally duplicating the divider elements. It also ensures that items that should be grouped together in the second section are displayed in a single box, as noted in #1437. Fixes #1437
Merged
thatbudakguy
added a commit
that referenced
this issue
Nov 1, 2024
This refactors the sidebar component to make it easier to determine what is being rendered in each of the two sections and to render it without accidentally duplicating the divider elements. It also ensures that items that should be grouped together in the second section are displayed in a single box, as noted in #1437. Fixes #1437
|
Spacing is now fixed; waiting on Blacklight release to make it a labeled
|
|
I forgot to backport this 🤦🏻 opened projectblacklight/blacklight#3458 to get it into blacklight 8.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because we have a sidebar on the left, the H1 is not seen/read first. We discussed this with SODA and they agreed that a left sidebar is a very common pattern (and in fact used on the WCAG site). Also, it appears under the category of "best practice" in SiteImprove, so it's not as important as an A or AA error. It also doesn't show up in Axe.
All that said, SODA suggested it would be improved by making the entire sidebar area an
<aside>and giving it an aria-label that describes it, such as "Download, export and other options."The text was updated successfully, but these errors were encountered: