There are two thermal modules

[settwi]

Describe the bug

There are two thermal modules, one in sunkit_spex.legacy.thermal and one in sunkit_spex.models.physical.thermal.

Recently in #178 we patched some issues with the thermal emission continuum but only in the legacy module. So, things are starting to diverge between the two modules.

I guess, if things change in the new thermal emission version, it isn't really an issue because the legacy version will be independent. But, for now, if people want to use the thermal emission, it's unclear which should be used.

Should we move the legacy emission to the models.physical model and then just have the legacy version import the current one? Or, should it be the other way around?

[natsat0919]

Imo legacy should stay untouched and be independent from the refactored code (i.e no cross-imports). I think the best option is to apply the changes from #178 to sunkit_spex.models.physical.thermal as well. I can do that if needed

[settwi]

What if we just import legacy in the new module?

[samaloney]

But then if we need to change the thermal code for example to better integrate the astropy modelling API we have to update other that uses it in legacy. The way I look at it legacy basically a read only copy bar bug fixes.