Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo] switch to tempo-distributed and check if tempoQuery.enabled=true is still needed #1011

Open
jkleinlercher opened this issue Jan 23, 2025 · 1 comment

Comments

@jkleinlercher
Copy link
Contributor

See https://grafana.com/docs/tempo/latest/setup/helm-chart/ and https://grafana.com/docs/helm-charts/tempo-distributed/next/get-started-helm-charts/

and check if #824 (comment) can be ignored because

@jkleinlercher
Copy link
Contributor Author

According to grafana/helm-charts#3417 (comment) this tempoQuery.enabled is only needed when integrated with jaeger, not with grafana. So we can remove this setting and ignore the breaking change in the PR #824

jkleinlercher added a commit that referenced this issue Jan 24, 2025
…1018)

* fix(tempo): queryEnabled not needed with grafana integration (#1011)

* updated container image list

* run commit even when Scan is skipped so deleted reports get deleted too

* updated trivy scan results

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant