You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest version 7.0.0 is failing to build with Carthage due to SwiftLint 0.43.1 rule 'shorthand_operator'. File SKZoomingScrollView.swift at line 154 have this code:
maxScale = maxScale / scale
And it's causing the SwiftLint to generate error: Shorthand Operator Violation: Prefer shorthand operators (+=, -=, *=, /=) over doing the operation and assigning. (shorthand_operator)
I can see three possible solutions:
Fix the source code to maxScale /= scale (I've tested it and this fix the issue)
Add comment to remove this particular rule for this line // swiftlint:disable:next shorthand_operator
Exclude the shorthand_operator rule with .swiftlint.yml configuration file.
Which one do you prefer? I can make a PR for any of proposed solutions.
The text was updated successfully, but these errors were encountered:
The latest version 7.0.0 is failing to build with Carthage due to SwiftLint 0.43.1 rule 'shorthand_operator'. File SKZoomingScrollView.swift at line 154 have this code:
And it's causing the SwiftLint to generate error:
Shorthand Operator Violation: Prefer shorthand operators (+=, -=, *=, /=) over doing the operation and assigning. (shorthand_operator)
I can see three possible solutions:
maxScale /= scale
(I've tested it and this fix the issue)// swiftlint:disable:next shorthand_operator
shorthand_operator
rule with.swiftlint.yml
configuration file.Which one do you prefer? I can make a PR for any of proposed solutions.
The text was updated successfully, but these errors were encountered: