Inferno JSX transformer plugin for SWC #7912

Havunen · 2023-09-03T10:20:25Z

Havunen
Sep 3, 2023

Hi!

I started building Inferno JSX transformer plugin for SWC.
https://github.com/swc-project/swc/compare/main...Havunen:swc:inferno-transformer?expand=1

I have few questions how I should proceed.

I needed to add bunch of js_words to make the program compile. Should these words to be extended to main SWC program or can the plugin extend those somehow? What is the recommended way of doing this?
To make inferno JSX transformer work correctly I would like to replace the React JSX plugin in with Inferno JSX plugin in the configs. Can this be done from the plugin land?

kdy1 · 2023-09-03T10:22:41Z

kdy1
Sep 3, 2023
Maintainer

You can create non-static JsWord using "foo".into().
The plugin can remove all JSX from the AST, and if so the React JSX transform will do nothing.

0 replies

Havunen · 2023-09-03T10:41:35Z

Havunen
Sep 3, 2023
Author

You can create non-static JsWord using "foo".into()

How can I create static JsWords? There are some long lists ( about 200 new words) for HTML element mapping, it sounds expensive if it needs to create them over and over again?

4 replies

Havunen Sep 3, 2023
Author

here is example: https://github.com/Havunen/swc/blob/119525ca06af44bb2f28f4e82f8f41cd0896e53b/crates/swc_ecma_transforms_inferno/src/vnode_types/mod.rs

kdy1 Sep 3, 2023
Maintainer

You can't add them to swc_atoms. Alternatively, you can do static VAL: Lazy<JsWord> = Lazy::new(|| "foo".into());

Havunen Sep 3, 2023
Author

Is it so that there is no way to have these atoms declared in a way that I could use match statement over different values?

kdy1 Sep 3, 2023
Maintainer

Yes. It's not a something match can logically work after all. Those are not patterns.

Havunen · 2023-09-03T21:24:06Z

Havunen
Sep 3, 2023
Author

Thank you for all the help @kdy1 I got the plugin working! 🚀

The source codes are located here:
https://github.com/infernojs/swc-plugin-inferno

One more question, how can the plugin get access to source maps as Lrc<SourceMap> from TransformPluginProgramMetadata object?

ref: https://github.com/infernojs/swc-plugin-inferno/blob/main/src/lib.rs#L79

1 reply

kdy1 Sep 4, 2023
Maintainer

You should use SourceMapper trait instead.

See https://rustdoc.swc.rs/swc_plugin_proxy/struct.PluginSourceMapProxy.html

Havunen · 2023-09-09T07:57:41Z

Havunen
Sep 9, 2023
Author

Hey,

I found strange issue, when I try to emit error from the plugin it panics the program and the expected error message is not shown anywhere.

Webpack bundling...
thread '<unnamed>' panicked at 'You should perform this operation in the closure passed to `set` of swc_common::errors::HANDLER', /home/sampo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/better_scoped_tls-0.1.1/src/lib.rs:67:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread '<unnamed>' panicked at 'failed to invoke plugin: failed to invoke plugin on 'Some("/home/sampo/git/inferno/packages/inferno-clone-vnode/__tests__/cloneVNode.spec.tsx")'

Caused by:
    0: failed to invoke `swc-plugin-inferno` as js transform plugin at swc-plugin-inferno
    1: RuntimeError: unreachable
           at __rust_start_panic (<module>[15812]:0x486434)
           at rust_panic (<module>[8247]:0x40fc75)
           at std::panicking::rust_panic_with_hook::h589e35f849575601 (<module>[857]:0x1d4d0b)
           at std::panicking::begin_panic_handler::{{closure}}::ha47b8594e9fab8c0 (<module>[6745]:0x3def4f)
           at std::sys_common::backtrace::__rust_end_short_backtrace::h2bb9b99592cac281 (<module>[15752]:0x4862d3)
           at rust_begin_unwind (<module>[9544]:0x42dd85)
           at core::panicking::panic_fmt::h3cf304618d69e432 (<module>[14040]:0x475222)
           at better_scoped_tls::ScopedKey<T>::with::h8a61ede9d99e31ba (<module>[3932]:0x34d6ef)
           at swc_plugin_inferno::jsx::Jsx<C>::jsx_elem_to_expr::h6750f8c7e3961efc (<module>[25]:0x182ea)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_expr::h405759b709e252b2 (<module>[121]:0xb1949)
           at swc_ecma_visit::visit_mut_opt_expr::ha3dc2de255c8b78e (<module>[5715]:0x3b3975)
           at swc_ecma_visit::VisitMut::visit_mut_opt_expr::hf70fd5d5d8edc2a5 (<module>[11916]:0x4560cc)
           at swc_ecma_visit::visit_mut_var_declarator::h46a4747e651ba75d (<module>[7238]:0x3f13c0)
           at swc_ecma_visit::VisitMut::visit_mut_var_declarator::hf3acb9c6f07cc12e (<module>[12023]:0x457a4b)
           at swc_ecma_visit::visit_mut_var_declarators::{{closure}}::h7ffe04b80c4144df (<module>[10902]:0x4461a4)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::hb1496c1b53f59c5d (<module>[5220]:0x39b291)
           at swc_ecma_visit::visit_mut_var_declarators::h1b7974d9986aa017 (<module>[7447]:0x3f80a1)
           at swc_ecma_visit::VisitMut::visit_mut_var_declarators::h30368ccdbf4810b4 (<module>[12033]:0x457cad)
           at swc_ecma_visit::visit_mut_var_decl::h94c2ccb638b17e4d (<module>[7223]:0x3f0bb9)
           at swc_ecma_visit::VisitMut::visit_mut_var_decl::hb1bec28e1b42a517 (<module>[11923]:0x456277)
           at swc_ecma_visit::visit_mut_decl::h8669173606b67fe0 (<module>[1094]:0x208535)
           at swc_ecma_visit::VisitMut::visit_mut_decl::h5f8dbcdba9f0535f (<module>[11880]:0x455838)
           at swc_ecma_visit::visit_mut_stmt::h5fa120f4fc6f5d2c (<module>[1245]:0x2242a4)
           at swc_ecma_visit::VisitMut::visit_mut_stmt::h7db4946382df87bc (<module>[11885]:0x455969)
           at swc_ecma_visit::visit_mut_stmts::{{closure}}::h520bb03ced66907a (<module>[10773]:0x443f60)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::he363aa47bcfcbf16 (<module>[5240]:0x39c2d1)
           at swc_ecma_visit::visit_mut_stmts::heda2c93a1c69e127 (<module>[7390]:0x3f631c)
           at swc_ecma_visit::VisitMut::visit_mut_stmts::he38d891fcb9f909d (<module>[11891]:0x455ad7)
           at swc_ecma_visit::visit_mut_block_stmt::hf8b5d1e3775c0cba (<module>[8804]:0x41dcfc)
           at swc_ecma_visit::VisitMut::visit_mut_block_stmt::hf6b3ba579fa69053 (<module>[11940]:0x456684)
           at swc_ecma_visit::visit_mut_block_stmt_or_expr::h3f0cf4bb85f80c68 (<module>[5086]:0x394548)
           at swc_ecma_visit::VisitMut::visit_mut_block_stmt_or_expr::h8d9371e8de523127 (<module>[12052]:0x458134)
           at swc_ecma_visit::visit_mut_arrow_expr::h3ef412f66cf57d48 (<module>[4027]:0x35458a)
           at swc_ecma_visit::VisitMut::visit_mut_arrow_expr::h4c0e4d94e02c4437 (<module>[11937]:0x4565cd)
           at swc_ecma_visit::visit_mut_expr::h0ea713a195e42e55 (<module>[493]:0x16c28f)
           at <swc_ecma_ast::expr::Expr as swc_ecma_visit::VisitMutWith<V>>::visit_mut_children_with::h63101e1893eaf7e3 (<module>[13114]:0x467fcd)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_expr::h405759b709e252b2 (<module>[121]:0xb1b3c)
           at swc_ecma_visit::visit_mut_expr_or_spread::ha43eb175f70b7b8d (<module>[6141]:0x3c6517)
           at swc_ecma_visit::VisitMut::visit_mut_expr_or_spread::h2b48e546bbd57e2e (<module>[12007]:0x45767b)
           at swc_ecma_visit::visit_mut_expr_or_spreads::{{closure}}::h489df29338963f26 (<module>[10890]:0x445e74)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::hcc3c6fd4e942e679 (<module>[5232]:0x39bc51)
           at swc_ecma_visit::visit_mut_expr_or_spreads::hb9574d0c8f264186 (<module>[7438]:0x3f7bf4)
           at swc_ecma_visit::VisitMut::visit_mut_expr_or_spreads::haef541addac6b058 (<module>[12025]:0x457ac5)
           at swc_ecma_visit::visit_mut_call_expr::hcccecfe92b4c0b1f (<module>[7044]:0x3ea80f)
           at swc_ecma_visit::VisitMut::visit_mut_call_expr::hf4f65b6a33376de0 (<module>[11928]:0x4563a8)
           at swc_ecma_visit::visit_mut_expr::h0ea713a195e42e55 (<module>[493]:0x16c1cb)
           at <swc_ecma_ast::expr::Expr as swc_ecma_visit::VisitMutWith<V>>::visit_mut_children_with::h63101e1893eaf7e3 (<module>[13114]:0x467fcd)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_expr::h405759b709e252b2 (<module>[121]:0xb1b3c)
           at swc_ecma_visit::visit_mut_expr_stmt::h142889566cdb9113 (<module>[6089]:0x3c4265)
           at swc_ecma_visit::VisitMut::visit_mut_expr_stmt::h20db12308b561b68 (<module>[11931]:0x45645f)
           at swc_ecma_visit::visit_mut_stmt::h5fa120f4fc6f5d2c (<module>[1245]:0x2242c0)
           at swc_ecma_visit::VisitMut::visit_mut_stmt::h7db4946382df87bc (<module>[11885]:0x455969)
           at swc_ecma_visit::visit_mut_stmts::{{closure}}::h520bb03ced66907a (<module>[10773]:0x443f60)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::he363aa47bcfcbf16 (<module>[5240]:0x39c2d1)
           at swc_ecma_visit::visit_mut_stmts::heda2c93a1c69e127 (<module>[7390]:0x3f631c)
           at swc_ecma_visit::VisitMut::visit_mut_stmts::he38d891fcb9f909d (<module>[11891]:0x455ad7)
           at swc_ecma_visit::visit_mut_block_stmt::hf8b5d1e3775c0cba (<module>[8804]:0x41dcfc)
           at swc_ecma_visit::VisitMut::visit_mut_block_stmt::hf6b3ba579fa69053 (<module>[11940]:0x456684)
           at swc_ecma_visit::visit_mut_block_stmt_or_expr::h3f0cf4bb85f80c68 (<module>[5086]:0x394548)
           at swc_ecma_visit::VisitMut::visit_mut_block_stmt_or_expr::h8d9371e8de523127 (<module>[12052]:0x458134)
           at swc_ecma_visit::visit_mut_arrow_expr::h3ef412f66cf57d48 (<module>[4027]:0x35458a)
           at swc_ecma_visit::VisitMut::visit_mut_arrow_expr::h4c0e4d94e02c4437 (<module>[11937]:0x4565cd)
           at swc_ecma_visit::visit_mut_expr::h0ea713a195e42e55 (<module>[493]:0x16c28f)
           at <swc_ecma_ast::expr::Expr as swc_ecma_visit::VisitMutWith<V>>::visit_mut_children_with::h63101e1893eaf7e3 (<module>[13114]:0x467fcd)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_expr::h405759b709e252b2 (<module>[121]:0xb1b3c)
           at swc_ecma_visit::visit_mut_expr_or_spread::ha43eb175f70b7b8d (<module>[6141]:0x3c6517)
           at swc_ecma_visit::VisitMut::visit_mut_expr_or_spread::h2b48e546bbd57e2e (<module>[12007]:0x45767b)
           at swc_ecma_visit::visit_mut_expr_or_spreads::{{closure}}::h489df29338963f26 (<module>[10890]:0x445e74)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::hcc3c6fd4e942e679 (<module>[5232]:0x39bc51)
           at swc_ecma_visit::visit_mut_expr_or_spreads::hb9574d0c8f264186 (<module>[7438]:0x3f7bf4)
           at swc_ecma_visit::VisitMut::visit_mut_expr_or_spreads::haef541addac6b058 (<module>[12025]:0x457ac5)
           at swc_ecma_visit::visit_mut_call_expr::hcccecfe92b4c0b1f (<module>[7044]:0x3ea80f)
           at swc_ecma_visit::VisitMut::visit_mut_call_expr::hf4f65b6a33376de0 (<module>[11928]:0x4563a8)
           at swc_ecma_visit::visit_mut_expr::h0ea713a195e42e55 (<module>[493]:0x16c1cb)
           at <swc_ecma_ast::expr::Expr as swc_ecma_visit::VisitMutWith<V>>::visit_mut_children_with::h63101e1893eaf7e3 (<module>[13114]:0x467fcd)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_expr::h405759b709e252b2 (<module>[121]:0xb1b3c)
           at swc_ecma_visit::visit_mut_expr_stmt::h142889566cdb9113 (<module>[6089]:0x3c4265)
           at swc_ecma_visit::VisitMut::visit_mut_expr_stmt::h20db12308b561b68 (<module>[11931]:0x45645f)
           at swc_ecma_visit::visit_mut_stmt::h5fa120f4fc6f5d2c (<module>[1245]:0x2242c0)
           at swc_ecma_visit::VisitMut::visit_mut_stmt::h7db4946382df87bc (<module>[11885]:0x455969)
           at swc_ecma_visit::visit_mut_module_item::h05ebeb0a33405f4c (<module>[6483]:0x3d485b)
           at swc_ecma_visit::VisitMut::visit_mut_module_item::hf1e176da84afcadd (<module>[11974]:0x456e9e)
           at swc_ecma_visit::visit_mut_module_items::{{closure}}::hdb618122f61e8f2e (<module>[10848]:0x44534c)
           at <core::slice::iter::IterMut<T> as core::iter::traits::iterator::Iterator>::for_each::h875960273a76181e (<module>[5209]:0x39a9a1)
           at swc_ecma_visit::visit_mut_module_items::h76ac06a89491cb58 (<module>[7407]:0x3f6beb)
           at swc_ecma_visit::VisitMut::visit_mut_module_items::h559df7f5cceb9612 (<module>[11988]:0x4571f4)
           at swc_ecma_visit::visit_mut_module::he2801d8a2dc0cbfc (<module>[7805]:0x403105)
           at <swc_ecma_ast::module::Module as swc_ecma_visit::VisitMutWith<V>>::visit_mut_children_with::h9663f4ce6b46ccd1 (<module>[13120]:0x46813b)
           at <swc_plugin_inferno::jsx::Jsx<C> as swc_ecma_visit::VisitMut>::visit_mut_module::hb950768697ddefab (<module>[10668]:0x442320)
           at swc_ecma_visit::visit_mut_program::h9f5b87708acd111a (<module>[7694]:0x3ffc5d)
           at swc_ecma_visit::VisitMut::visit_mut_program::he6eae5854223d0bf (<module>[11905]:0x455e2d)
           at <swc_ecma_ast::module::Program as swc_ecma_visit::VisitMutWith<V>>::visit_mut_with::h9ffd8b42752db7b8 (<module>[13123]:0x4681f2)
           at <swc_ecma_visit::Folder<V> as swc_ecma_visit::Fold>::fold_program::h46a1b98621e82054 (<module>[6299]:0x3cd0d0)
           at <swc_ecma_ast::module::Program as swc_ecma_visit::FoldWith<V>>::fold_with::he35fa328fa5d5de0 (<module>[1883]:0x28641f)
           at swc_plugin_inferno::inferno_jsx_plugin::h90fb9d22c11695c5 (<module>[4378]:0x36be1a)
           at __transform_plugin_process_impl (<module>[184]:0xe0b83)
           at __transform_plugin_process_impl.command_export (<module>[15604]:0x485be9)

Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: <unknown>
  14: <unknown>
  15: <unknown>
  16: <unknown>
  17: <unknown>
  18: <unknown>
  19: _ZZN4node14ThreadPoolWork12ScheduleWorkEvENUlP9uv_work_sE_4_FUNES2_
  20: <unknown>
  21: <unknown>
  22: <unknown>', /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/swc-0.266.1/src/plugin.rs:162:14
stack backtrace:
   0:     0x7f0836e73421 - <unknown>
   1:     0x7f0836ea0a0f - <unknown>
   2:     0x7f0836e6f9a7 - <unknown>
   3:     0x7f0836e73235 - <unknown>
   4:     0x7f0836e749d3 - <unknown>
   5:     0x7f0836e74764 - <unknown>
   6:     0x7f0836e74f59 - <unknown>
   7:     0x7f0836e74e57 - <unknown>
   8:     0x7f0836e73856 - <unknown>
   9:     0x7f0836e74ba2 - <unknown>
  10:     0x7f08352c3e03 - <unknown>
  11:     0x7f08352c42a3 - <unknown>
  12:     0x7f0835993461 - <unknown>
  13:     0x7f08358e06ec - <unknown>
  14:     0x7f0835721d7d - <unknown>
  15:     0x7f0835721b89 - <unknown>
  16:     0x7f083582d74f - <unknown>
  17:     0x7f0835839fde - <unknown>
  18:     0x7f08358319a5 - <unknown>
  19:     0x7f0835838589 - <unknown>
  20:     0x7f08358390ea - <unknown>
  21:     0x7f083545bcbd - <unknown>
  22:     0x7f0835440fc3 - <unknown>
  23:     0x7f08353e6e30 - <unknown>
  24:     0x7f083543b9ac - <unknown>
  25:     0x7f083546e349 - <unknown>
  26:     0x7f0835511388 - <unknown>
  27:     0x5576cb3da5c0 - _ZZN4node14ThreadPoolWork12ScheduleWorkEvENUlP9uv_work_sE_4_FUNES2_
  28:     0x7f086158d816 - <unknown>
  29:     0x7f085fe8c9eb - <unknown>
  30:     0x7f085ff10dfc - <unknown>
  31:                0x0 - <unknown>

The error originates from here: https://github.com/infernojs/swc-plugin-inferno/blob/main/src/jsx/mod.rs#L555-L563 where I try to emit error message to the user.

Weird thing is that this works fine when running the tests through cargo test

<Comp children={bar} />

produces:

  × children property is not supported in JSX. Use nesting instead.
   ╭─[input.js:1:1]
 1 │ <Comp children={bar} />
   ·       ────────
   ╰────

I tried looking into swc_plugins repo but I couldn't find what I could be doing differently here.

I tested it with minimal plugin like this and same result.

#[plugin_transform]
fn inferno_jsx_plugin(
    program: Program,
    _data: TransformPluginProgramMetadata,
) -> Program {
    HANDLER.with(|handler| {
        handler
            .struct_span_err(
                DUMMY_SP,
                "JSX Namespace is disabled"
            )
            .emit()
    });

    return program
}

5 replies

kwonoj Sep 9, 2023
Maintainer

using global HANDLER sholuld work. How did you import HANDLER?

Havunen Sep 9, 2023
Author

All the code can be seen from here: https://github.com/infernojs/swc-plugin-inferno

kwonoj Sep 9, 2023
Maintainer

swc/crates/swc_plugin_runner/tests/fixture/swc_internal_plugin/src/lib.rs

Line 5 in d15eaf0

errors::HANDLER,

Havunen Sep 9, 2023
Author

Ah perfect! I will try it out tomorrow

Havunen Sep 10, 2023
Author

Yep works, thanks @kwonoj ❤️

Havunen · 2023-09-10T16:37:16Z

Havunen
Sep 10, 2023
Author

Everything is working great now! I'm closing this discussion. Thanks for all the help.

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inferno JSX transformer plugin for SWC #7912

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 5 comments 10 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Inferno JSX transformer plugin for SWC #7912

Havunen Sep 3, 2023

Replies: 5 comments · 10 replies

kdy1 Sep 3, 2023 Maintainer

Havunen Sep 3, 2023 Author

Havunen Sep 3, 2023 Author

kdy1 Sep 3, 2023 Maintainer

Havunen Sep 3, 2023 Author

kdy1 Sep 3, 2023 Maintainer

Havunen Sep 3, 2023 Author

kdy1 Sep 4, 2023 Maintainer

Havunen Sep 9, 2023 Author

kwonoj Sep 9, 2023 Maintainer

Havunen Sep 9, 2023 Author

kwonoj Sep 9, 2023 Maintainer

Havunen Sep 9, 2023 Author

Havunen Sep 10, 2023 Author

Havunen Sep 10, 2023 Author

Havunen
Sep 3, 2023

Replies: 5 comments 10 replies

kdy1
Sep 3, 2023
Maintainer

Havunen
Sep 3, 2023
Author

Havunen Sep 3, 2023
Author

kdy1 Sep 3, 2023
Maintainer

Havunen Sep 3, 2023
Author

kdy1 Sep 3, 2023
Maintainer

Havunen
Sep 3, 2023
Author

kdy1 Sep 4, 2023
Maintainer

Havunen
Sep 9, 2023
Author

kwonoj Sep 9, 2023
Maintainer

Havunen Sep 9, 2023
Author

kwonoj Sep 9, 2023
Maintainer

Havunen Sep 9, 2023
Author

Havunen Sep 10, 2023
Author

Havunen
Sep 10, 2023
Author