From eaebdcfbcdcf4e4364bf8adddbb1b5493a0ade9a Mon Sep 17 00:00:00 2001 From: Sebastian Wick Date: Wed, 27 Nov 2024 20:08:18 +0100 Subject: [PATCH] tests/notification: Test file-descriptor based icons/sounds Now that libportal support for notifications v2 landed, we can enable the file-descriptor based tests for icons and sounds. --- tests/notification.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/tests/notification.c b/tests/notification.c index 8001ae76d..2466403da 100644 --- a/tests/notification.c +++ b/tests/notification.c @@ -10,16 +10,12 @@ "" \ "" - -/* reenable when the proper PR in libportal is merged */ -#if 0 static const guchar SOUND_DATA[] = { 0x52, 0x49, 0x46, 0x46, 0x24, 0x00, 0x00, 0x00, 0x57, 0x41, 0x56, 0x45, 0x66, 0x6d, 0x74, 0x20, 0x10, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x44, 0xac, 0x00, 0x00, 0x88, 0x58, 0x01, 0x00, 0x02, 0x00, 0x10, 0x00, 0x64, 0x61, 0x74, 0x61, 0x00, 0x00, 0x00, 0x00 }; -#endif extern char outdir[]; @@ -373,8 +369,6 @@ test_bytes_icon (void) } -/* reenable when the proper PR in libportal is merged */ -#if 0 static void test_file_icon (void) { @@ -401,7 +395,6 @@ test_file_icon (void) g_file_delete (file, NULL, &error); g_assert_no_error (error); } -#endif void test_notification_icon (void) @@ -413,10 +406,7 @@ test_notification_icon (void) test_themed_icon (); test_bytes_icon (); -/* reenable when the proper PR in libportal is merged */ -#if 0 test_file_icon (); -#endif /* Tests that should fail */ test_icon ("('themed', <'test-icon-symbolic'>)", NULL, TRUE); @@ -448,8 +438,6 @@ test_sound (const char *serialized_sound, run_notification_test ("test-sound", notification_s, expected_notification_s, expect_failure); } -/* reenable when the proper PR in libportal is merged */ -#if 0 static void test_file_sound (void) { @@ -471,17 +459,14 @@ test_file_sound (void) g_file_delete (file, NULL, &error); g_assert_no_error (error); } -#endif void test_notification_sound (void) { test_sound ("'default'", NULL, FALSE); test_sound ("'silent'", NULL, FALSE); -/* reenable when the proper PR in libportal is merged */ -#if 0 + test_file_sound (); -#endif /* Tests that should fail */ test_sound ("('file-descriptor', <''>)", NULL, TRUE);