This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1
Allow specifying SwiftWasm version as an input #3
Labels
enhancement
New feature or request
Comments
MaxDesiatov
added a commit
to TokamakUI/Tokamak
that referenced
this issue
Dec 21, 2021
Configuration for simultaneous builds with SwiftWasm 5.4 and 5.5 can't be specified more succinctly due to swiftwasm/swiftwasm-action#3. I had to create almost duplicate job descriptions because of that.
MaxDesiatov
added a commit
to TokamakUI/Tokamak
that referenced
this issue
Apr 5, 2022
Configuration for simultaneous builds with SwiftWasm 5.4, 5.5, and 5.6 can't be specified more succinctly due to swiftwasm/swiftwasm-action#3. I had to create almost duplicate job descriptions because of that.
+1 for this. See OpenSwiftUIProject/OpenCombine@337f1a3 I saw WASM 5.8 and 5.9 is released recently. And I'd like to use matrices to test multi Swift version. I guess for now I have to continue to manually use multi jobs to workaround. |
Maintaining this docker-based github action is a little tricky, so I'd like to deprecate this action and navigate to use https://github.com/swiftwasm/setup-swiftwasm once we support SwiftPM build plugin in carton. So I don't have any plan to support version specifier in this action. It's already supported in setup-swiftwasm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This would allow creating multiple jobs with matrices. Currently GHA versions can't be specified via matrix substitutions, which is apparently a limitation of GHA.
When implementing this we need to make sure that appropriate versions of
carton
images are used for the specified version input.The text was updated successfully, but these errors were encountered: