Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Footer V2 link style incorrect #4445

Open
sandra-post opened this issue Jan 15, 2025 · 0 comments · May be fixed by #4510
Open

[bug]: Footer V2 link style incorrect #4445

sandra-post opened this issue Jan 15, 2025 · 0 comments · May be fixed by #4510
Assignees
@alionazherdetska
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@sandra-post
Copy link

Describe the bug
The links in the footer of DS V2 have an incorrect styling on hover. They should be underlined.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Storybook --> Modules --> Footer (https://next.design-system.post.ch/?path=/docs/d97528b3-a9ef-4201-bf28-9caf6e8997dc--docs)
  2. Hover over "Text link" in footer preview

Expected behavior
Text link should be underlined on hover, it is however not underlined. See Figma-Design. (In the sub-components, find the link styling of hover under "Links")

Screenshots
Image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Edge
  • Version v131

Additional context
FYI Footer links have a different styling than the regular text link styling.
@sandra-post sandra-post added the 🐞 bug Something isn't working label Jan 15, 2025
@sandra-post sandra-post added this to the PPNL Support milestone Jan 15, 2025
@gfellerph gfellerph added the 📦 components Related to the @swisspost/design-system-components package label Jan 22, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Jan 22, 2025
@alionazherdetska alionazherdetska self-assigned this Jan 23, 2025
@alionazherdetska alionazherdetska linked a pull request Jan 23, 2025 that will close this issue
fix(styles): correct hover style for links in post-footer #4510
Open
@alionazherdetska alionazherdetska moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alionazherdetska alionazherdetska

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

fix(styles): correct hover style for links in post-footer swisspost/design-system
3 participants
@gfellerph @alionazherdetska @sandra-post