Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Zenburn as default theme #895

Closed
tuhdo opened this issue Mar 21, 2015 · 12 comments
Closed

Use Zenburn as default theme #895

tuhdo opened this issue Mar 21, 2015 · 12 comments

Comments

@tuhdo
Copy link
Contributor

tuhdo commented Mar 21, 2015

The reasons:

  • It looks nicer with Spacemacs logo. The dark background makes Spacemacs logo standout because of the contrast. Here is how it look likes:

zenburn-spacemacs

  • Well support for many packages, and this is important. Until now, I only see Zenburn and Monokai and Tomorrow themes support Helm properly and make it look nice. Especially Zenburn, since it is the default of Prelude, it receives support for things Prelude includes. Here is an example of Info+:

info -spacemacs

  • The theme looks pleasant in general.
@tuhdo
Copy link
Contributor Author

tuhdo commented Mar 21, 2015

Btw, why Spacemacs doesn't use the text spacemacs_ like the logo in the homepage? I think the text looks nice and goes with the logo.

@CestDiego
Copy link
Contributor

I second this. I actually use zenburn as a default. But I think leuven theme is even more beautiful ;_; it just lacks a good dark version.

@syl20bnr
Copy link
Owner

I'm in the same boat as you, I don't use the default Spacemacs theme but it is not zenburn.

Zenburn is already in the cycle list so it very easy to reach it from the stock configuration of spacemacs.

Since colors and tastes are a user preference I won't change the default theme.

@tuhdo
Copy link
Contributor Author

tuhdo commented Mar 21, 2015

But if we talk about functionality, then solarized does not look support Helm well in terminal while Zenburn still looks the same as GUI version. And imo, solarized look is not comfortable in terminal

@tuhdo
Copy link
Contributor Author

tuhdo commented Mar 21, 2015

You can take a look at this issue that also links to this issue. And people suggest to use Zenburn (or if you find something equivalent, that's fine).

@syl20bnr
Copy link
Owner

I am aware of this issue, it is for the dark variant which is not the
default, solarized light is a good theme with as many people liking it as
people liking zenburn.

As I said I don't use solarized light as my theme and I won't change the
default of Spacemacs because of this, it is easily changeable in the
dotfile.

I will repeat myself but themes are user preferences, no matter the default
it cannot please everybody.

Le samedi 21 mars 2015, Tu Do [email protected] a écrit :

You can take a look at this issue
purcell/color-theme-sanityinc-solarized#16
that also links to this issue
bbatsov/solarized-emacs#18. And people
suggest to use Zenburn (or if you find something equivalent, that's fine).


Reply to this email directly or view it on GitHub
#895 (comment).

-syl20bnr-

@tuhdo
Copy link
Contributor Author

tuhdo commented Mar 21, 2015

Alright then.

@tuhdo tuhdo closed this as completed Mar 21, 2015
@syl20bnr
Copy link
Owner

For the spacemacs logo, the logo on the readme has a white background.

@ntcong
Copy link
Contributor

ntcong commented Apr 13, 2015

can I bump this issue?
There's some reason to switch away:

  • Solarized is a popular theme, there's a lot of implement which has a same package name and different features.
  • Most solarized theme has problem with 256 color terminal, having a built-in theme makes it harder to install other theme.
  • We have to manually update the theme.

@ifesdjeen
Copy link

+1, built-in solarized scheme is broken for 256 color terminal

@TheBB
Copy link
Contributor

TheBB commented Oct 25, 2015

We aren't using solarized as default any more, so this seems moot.

@ifesdjeen
Copy link

🎆 awesome! then i only need to upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants