diff --git a/sinabs/backend/dynapcnn/dynapcnn_visualizer.py b/sinabs/backend/dynapcnn/dynapcnn_visualizer.py index 5f54abf6..0c7f0799 100644 --- a/sinabs/backend/dynapcnn/dynapcnn_visualizer.py +++ b/sinabs/backend/dynapcnn/dynapcnn_visualizer.py @@ -109,7 +109,7 @@ def __init__( - `power_measurement`: Arguments that can be passed `power_measurement` plot. """ # Checks if the configuration passed is valid - if add_readout_plot and not readout_images: + if add_readout_plot and readout_images is None: raise ValueError( "If a readout plot is to be displayed image paths should be passed as a list." + "The order of the images, should match the model output." diff --git a/tests/test_dynapcnn/test_visualizer.py b/tests/test_dynapcnn/test_visualizer.py index 5e3c5136..2885fee6 100644 --- a/tests/test_dynapcnn/test_visualizer.py +++ b/tests/test_dynapcnn/test_visualizer.py @@ -28,9 +28,9 @@ def X_available() -> bool: True, reason="A window needs to pop. Needs UI. Makes sense to check this test manually", ) -@pytest.mark.parametrize("spike_count_plot,readout_plot", vis_init_args) +@pytest.mark.parametrize("spike_count_plot,readout_plot,readout_node", vis_init_args) def test_visualizer_initialization( - spike_count_plot: bool, readout_plot: bool, readout_filter: Union[str, Callable] + spike_count_plot: bool, readout_plot: bool, readout_node: Union[str, Callable] ): dvs_shape = (128, 128) spike_collection_interval = 500 @@ -40,8 +40,9 @@ def test_visualizer_initialization( dvs_shape=dvs_shape, spike_collection_interval=spike_collection_interval, add_spike_count_plot=spike_count_plot, - add_readout_plot=spike_readout_plot, - readout_filter=readout_filter, + add_readout_plot=readout_plot, + readout_node=readout_node, + readout_images=[], ) visualizer.create_visualizer_process( f"tcp://0.0.0.0:{visualizer.samna_visualizer_port}"