Open in dock instead of split pane?

[lettertwo]

Atom has a new Docks feature that might make wrangling narrow instances easier. What do you think?

[t9md]

Yes using dock allows narrow holding narrow ui without destroying it, it might be good for faster launch of each narrow call, and also for hide/show by mouse.
But I can't find strong necessity to move to it for now.

[despairblue]

@t9md Can I disable the dock-ability, since #283 narrow always opens in the dock and does neither render nor search anything:

[despairblue]

It actually throws an error that is not reported by atoms error indicator:

Uncaught (in promise) TypeError: atom.grammars.assignLanguageMode is not a function
    at NarrowEditor.initialize (/Users/despairblue/.atom/packages/narrow/lib/narrow-editor.js:88)
    at Ui.open (/Users/despairblue/.atom/packages/narrow/lib/ui.js:360)
  initialize @ /Users/despairblue/.atom/packages/narrow/lib/narrow-editor.js:88
  open @ /Users/despairblue/.atom/packages/narrow/lib/ui.js:360
  Promise.reject (async)
  start @ /Users/despairblue/.atom/packages/narrow/lib/provider/provider.js:259
  async function (async)
  start @ /Users/despairblue/.atom/packages/narrow/lib/provider/provider.js:260
  start @ /Users/despairblue/.atom/packages/narrow/lib/provider/search.js:51
  start @ /Users/despairblue/.atom/packages/narrow/lib/provider/provider.js:77
  narrow @ /Users/despairblue/.atom/packages/narrow/lib/main.js:186
  narrow:search @ /Users/despairblue/.atom/packages/narrow/lib/main.js:112
  handleCommandEvent @ <embedded>:23521
  didConfirmSelection @ command-palette-view.js [sm]:74
  confirmSelection @ /Users/despairblue/github/command-palette/node_modules/atom-select-list/src/select-list-view.js:307
  core:confirm @ /Users/despairblue/github/command-palette/node_modules/atom-select-list/src/select-list-view.js:64
  handleCommandEvent @ <embedded>:23521
  module.exports.KeymapManager.dispatchCommandEvent @ <embedded>:69933
  module.exports.KeymapManager.handleKeyboardEvent @ <embedded>:69724
  handleDocumentKeyEvent @ <embedded>:19407

Maybe it's using an API that is not available on the current stable atom? 🤷‍♂️

[despairblue]

Ok the API is in 1.24 which has been released Feb. 13th, but my atom instance is broken in a way that it does not find new versions...

I'll update in manually. Nevermind me 😄

[jdanbrown]

I'm seeing a similar problem as @despairblue on atom 1.24. I went ahead and opened a new issue for it: #288.

[t9md]

@jdanbrown
How similar?
Your issue seems different from @despairblue 's one.

@despairblue
Could you solve issue by upgrading atom to v1.24?

[jdanbrown]

How similar?

Yeah, sorry, not very similar. The effect is similar, but the cause seems unrelated. I'm not seeing the atom error and I'm on the newer atom version.

[t9md]

thanks for answering. now clear.

[despairblue]

@t9md upgrading did indeed fix it :)

Though I do have the same issue @jdanbrown describes. I'll subscribe to #288.

[t9md]

It’s closed. If you can reproduce it after restart atom, then put comment on #288.

[despairblue]

@t9md I can't reproduce it either now, thank you :)