Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cursor shouldn't move when editing search query #297

Closed
dwelle opened this issue May 9, 2018 · 4 comments
Closed

cursor shouldn't move when editing search query #297

dwelle opened this issue May 9, 2018 · 4 comments

Comments

@dwelle
Copy link

dwelle commented May 9, 2018

When editing the search query in narrow search provider, cursor is always moved at the end of query when search executes:

narrow_cursor_change

This makes editing query very annoying.

Narrow 0.65.0, Win7, Atom 1.26.1
@dwelle
Copy link
Author

dwelle commented May 10, 2018

related #257

t9md added a commit that referenced this issue Jun 11, 2018
@t9md
#297 don't move cursor to end of query on refresh kicked by inline qu…
79e5c41 
…ery modification
@t9md
Copy link
Owner

t9md commented Jun 11, 2018

@dwelle you are right, #257 have very similar issue and technically fixable by same approach I did to solve this issue.
But I need to give more careful, thorough thinking to it, since it breaks several assumptions I had when creating this package. So treat it separately.

@t9md t9md closed this as completed Jun 11, 2018
@t9md
Copy link
Owner

t9md commented Jun 11, 2018

For clarification issue you reported originally was fixed in the commit above, will be released in next version.

@t9md
Copy link
Owner

t9md commented Jun 11, 2018 •
edited
Loading

released as v0.65.1 just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t9md @dwelle