Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MMB click in the notifications page goes to home #228

Open
TomW1605 opened this issue Dec 9, 2024 · 0 comments
Open

[BUG] MMB click in the notifications page goes to home #228

TomW1605 opened this issue Dec 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TomW1605
Copy link

TomW1605 commented Dec 9, 2024

Describe the bug

Middle Mouse Button (MMB) click in the notifications page goes to home not the relavent card

How can we reproduce the behavior

have a notification and MMB click on the link to the card/issue in either the hover dropdown or the main notifications list

Workarounds

the only real work around is to open a new tab manually and navigate to the relevant issue from scratch but that doesn't clear the notification (see #159)

Screenshots

Taiga environment

Self hosted, docker
no error logs

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome
  • Version: 131.0.6778.109

Additional context

it looks like the issue is here. the ng-click doesn't catch the MMB click event and the blank href direct it to the home page.

it should be possible to achieve this by switching this to ng-mouseup/ng-mousedown and handling each button directly. however using javascript to open a new tab without focusing (thus replicating the correct behaviour for MMB click) can be a pain.
i think a better option would probably be to fix issue #159 so that viewing a card/issue will clear any notifications relevant to that item and then the link in the notifications list can be a simple link and does not need handling with javascript

@TomW1605 TomW1605 added the bug Something isn't working label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant