Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "external_account" credential type #635

Closed
mgraczyk opened this issue Sep 9, 2023 · 1 comment
Closed

Support for "external_account" credential type #635

mgraczyk opened this issue Sep 9, 2023 · 1 comment

Comments

@mgraczyk
Copy link

mgraczyk commented Sep 9, 2023

Google has added support for so-called "external_account" credentials:

https://googleapis.dev/python/google-auth/latest/reference/google.auth.external_account.html

These credentials can be used in Github Actions to authenticate more securely. Instead of storing long-lived Google credentials in Github, external_account credentials make it possible to authorized a particular github repository's actions to act as a service worker via workload identity federation.

I looked into writing a pull request for this feature, but found it very difficult to test. I'm also not super familiar with the details of Google's authentication flow. The relevant code in google.auth is pretty simple, but some of the metadata has to be routed around and I am not sure that it will automatically be available in Token.service_data:

https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/external_account.py#L376

I am happy to help work on this but probably need some guidance on how to test. There are also extra features that I don't think I need, but may be required to support this generically enough (impersonation for example.)

@mgraczyk
Copy link
Author

mgraczyk commented Sep 9, 2023

Ah sorry this is a duplicate of #578

@mgraczyk mgraczyk closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant