Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify opacity solver so that it doesn't need the entire plasma #2879

Open
andrewfullard opened this issue Nov 12, 2024 · 2 comments
Open
Labels
opacity Related to opacity extensions in TARDIS restructure

Comments

@andrewfullard
Copy link
Contributor

andrewfullard commented Nov 12, 2024

It should only need the specific plasma outputs- level number density, stimulated emission factor, atomic lines

@andrewfullard andrewfullard added restructure opacity Related to opacity extensions in TARDIS labels Nov 12, 2024
@karthik11135
Copy link

Hi,
Opacity solver is calling continnumstate's methods. those methods are overriding the attributes of that class with plasma's properties so its requiring the plasma obj. Could you please give a little context on how i can tackle this?

thanks.

@karthik11135
Copy link

karthik11135 commented Jan 22, 2025

@andrewfullard
I'm thinking of extracting ContinnumState out of OpacityState and pass it as input to OpacitySolver.solve and legacy solve methods. In that case, it wouldnt require the whole plasma object. Is this approach right?

thanks.

EDIT : Worked on this. New implementation doesnt need the entire plasma. Data class has been created which takes only necessary things from plasma. In addition, the continuum state (which opacity state requires) is computed beforehand and sent as parameter to solve methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opacity Related to opacity extensions in TARDIS restructure
Projects
None yet
Development

No branches or pull requests

2 participants