diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java index 41f879f2aa4..697646aa0ae 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java @@ -91,7 +91,7 @@ private enum Action { module.argMap.get("user-name") ).mput( Authn.InvokeKeys.CREDENTIALS, - getPassword((String)module.argMap.get("password")) + getPassword((String) module.argMap.get("password")) ) ); log.info( @@ -113,13 +113,13 @@ private enum Action { ), CHANGE_CREDENTIALS( module -> { - AAAProfile aaaprofile = module.new AAAProfile((String)module.argMap.get("profile")); + AAAProfile aaaprofile = module.new AAAProfile((String) module.argMap.get("profile")); if ((aaaprofile.getAuthnExtension().getContext().get(Authn.ContextKeys.CAPABILITIES, 0L) & Authn.Capabilities.CREDENTIALS_CHANGE) == 0 && - !(Boolean)module.argMap.get("ignore-capabilities")) { + !(Boolean) module.argMap.get("ignore-capabilities")) { throw new IllegalArgumentException("Unsupported operation: CREDENTIALS_CHANGE"); } - String user = aaaprofile.mapUser((String)module.argMap.get("user-name")); + String user = aaaprofile.mapUser((String) module.argMap.get("user-name")); log.info("API: -->Authn.InvokeCommands.CREDENTIALS_CHANGES profile='{}' user='{}'", aaaprofile.getProfile(), user); ExtMap outMap = aaaprofile.getAuthnExtension().invoke( new ExtMap().mput( @@ -130,10 +130,10 @@ private enum Action { user ).mput( Authn.InvokeKeys.CREDENTIALS, - getPassword((String)module.argMap.get("password")) + getPassword((String) module.argMap.get("password")) ).mput( Authn.InvokeKeys.CREDENTIALS_NEW, - getPassword((String)module.argMap.get("password-new"), "New password: ") + getPassword((String) module.argMap.get("password-new"), "New password: ") ) ); log.info( @@ -151,8 +151,8 @@ private enum Action { ), LOGIN_USER( module -> { - AAAProfile aaaprofile = module.new AAAProfile((String)module.argMap.get("profile")); - String user = aaaprofile.mapUser((String)module.argMap.get("user-name")); + AAAProfile aaaprofile = module.new AAAProfile((String) module.argMap.get("profile")); + String user = aaaprofile.mapUser((String) module.argMap.get("user-name")); log.info("API: -->Authn.InvokeCommands.AUTHENTICATE_CREDENTIALS profile='{}' user='{}'", aaaprofile.getProfile(), user); ExtMap outMap = aaaprofile.getAuthnExtension().invoke( new ExtMap().mput( @@ -163,7 +163,7 @@ private enum Action { user ).mput( Authn.InvokeKeys.CREDENTIALS, - getPassword((String)module.argMap.get("password")) + getPassword((String) module.argMap.get("password")) ) ); log.info( @@ -192,7 +192,7 @@ private enum Action { ); } - if(aaaprofile.getMappingExtension() != null) { + if (aaaprofile.getMappingExtension() != null) { log.info("API: -->Mapping.InvokeCommands.MAP_AUTH_RECORD"); Dump.AUTH_RECORD.dump(module, authRecord); authRecord = aaaprofile.getMappingExtension().invoke( @@ -302,7 +302,7 @@ private enum Action { SEARCH( module -> { ExtensionProxy authzExtension = module.getExtensionsManager().getExtensionByName((String) module.argMap.get("extension-name")); - ExtUUID entity = getQueryEntity((String)module.argMap.get("entity")); + ExtUUID entity = getQueryEntity((String) module.argMap.get("entity")); ExtMap filter = createQueryFilter(entity, module.argMap); Dump.QUERY_FILTER_RECORD.dump(module, filter, ""); @@ -311,7 +311,7 @@ private enum Action { Collections.emptyList() ); if (module.argMap.get("namespace") != null) { - namespaces = (Collection)module.argMap.get("namespace"); + namespaces = (Collection) module.argMap.get("namespace"); } for (String namespace : namespaces) { @@ -325,7 +325,7 @@ private enum Action { entity ).mput( Authz.InvokeKeys.QUERY_FLAGS, - getAuthzFlags((List)module.argMap.get("authz-flag")) + getAuthzFlags((List) module.argMap.get("authz-flag")) ).mput( Authz.InvokeKeys.QUERY_FILTER, filter @@ -395,12 +395,12 @@ Map parse(Map substitutions, Properties props, L parser.parse(actionArgs); Map argMap = parser.getParsedArgs(); - if((Boolean)argMap.get("help")) { + if ((Boolean) argMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -492,7 +492,7 @@ private static void dumpRecord(AAAServiceImpl module, ExtMap extMap, Set Collection keys = new HashSet<>(extMap.keySet()); if (module.argModuleMap.get("key") != null) { Collection k = new HashSet<>(); - for (String uuid : (List)module.argModuleMap.get("key")) { + for (String uuid : (List) module.argModuleMap.get("key")) { k.add(new ExtKey("Unknown", Object.class, uuid)); } keys.retainAll(k); @@ -505,7 +505,7 @@ private static void dumpRecord(AAAServiceImpl module, ExtMap extMap, Set continue; } module.output( - ((String)module.argModuleMap.get("format")).replace( + ((String) module.argModuleMap.get("format")).replace( "{key}", key.getUuid().getUuid().toString() ).replace( @@ -540,7 +540,7 @@ private static List safeList(List list) { } private ExtensionsManager getExtensionsManager() { - return (ExtensionsManager)context.get(ContextKeys.EXTENSION_MANAGER); + return (ExtensionsManager) context.get(ContextKeys.EXTENSION_MANAGER); } private ExtensionProxy getExtensionByProfile(String name) { @@ -554,7 +554,7 @@ private ExtensionProxy getExtensionByProfile(String name) { private ExtensionProxy getExtensionByConfigKey(String key, String value) { ExtensionProxy ret = null; - for(ExtensionProxy proxy : getExtensionsManager().getExtensionsByService(Authn.class.getName())) { + for (ExtensionProxy proxy : getExtensionsManager().getExtensionsByService(Authn.class.getName())) { if ( value.equals( proxy.getContext().get( @@ -591,7 +591,7 @@ private static String getPassword(String what, String prompt) { if ("pass".equals(type)) { password = value; } else if ("file".equals(type)) { - try( + try ( InputStream is = new FileInputStream(value); Reader reader = new InputStreamReader(is, StandardCharsets.UTF_8); BufferedReader breader = new BufferedReader(reader) @@ -652,12 +652,12 @@ public void parseArguments(List args) throws Exception { parser.parse(args); argModuleMap = parser.getParsedArgs(); - if((Boolean)argModuleMap.get("help")) { + if ((Boolean) argModuleMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -670,7 +670,7 @@ public void parseArguments(List args) throws Exception { try { action = Action.valueOf(args.get(0).toUpperCase().replace("-", "_")); - } catch(IllegalArgumentException e) { + } catch (IllegalArgumentException e) { log.error("Invalid action '{}'", args.get(0)); throw new ExitException("Invalid action", 1); } @@ -680,7 +680,7 @@ public void parseArguments(List args) throws Exception { @Override public void run() throws Exception { - int iterations = (Integer)argModuleMap.get("iterations"); + int iterations = (Integer) argModuleMap.get("iterations"); for (int i = 0; i < iterations; i++) { log.info("Iteration: {}", i); action.execute(this); @@ -699,7 +699,7 @@ private static ExtMap createQueryFilter(ExtUUID entity, Map argM ); } - for (String id : safeList((List)argMap.get("entity-id"))) { + for (String id : safeList((List) argMap.get("entity-id"))) { filter.add( createQueryFilterElement( Authz.QueryEntity.GROUP.equals(entity) ? Authz.GroupRecord.ID : Authz.PrincipalRecord.ID, @@ -733,7 +733,7 @@ private static ExtMap createQueryFilterElement(ExtKey key, String value) { ); } - private static ExtUUID getQueryEntity(String entity) { + private static ExtUUID getQueryEntity(String entity) { try { return (ExtUUID) Authz.QueryEntity.class.getDeclaredField( entity.toUpperCase() @@ -748,7 +748,7 @@ private static int getAuthzFlags(List flags) { for (String f : safeList(flags)) { try { ret |= Authz.QueryFlags.class.getDeclaredField(f.toUpperCase().replace("-", "_")).getInt(new Authz.QueryFlags()); - } catch(NoSuchFieldException | IllegalAccessException ex) { + } catch (NoSuchFieldException | IllegalAccessException ex) { log.error("Unknown Authz flag '{}' (ignored)", f); } } @@ -842,7 +842,7 @@ public AAAProfile(String profile) { this.authnName = this.authnExtension.getContext().get(Base.ContextKeys.INSTANCE_NAME); this.authzExtension = getExtensionsManager().getExtensionByName(authzName); - if(this.mappingName != null) { + if (this.mappingName != null) { this.mappingExtension = getExtensionsManager().getExtensionByName(mappingName); } @@ -856,7 +856,7 @@ public AAAProfile(String profile) { } public String mapUser(String user) { - if(getMappingExtension()!= null) { + if (getMappingExtension() != null) { log.info("API: -->Mapping.InvokeCommands.MAP_USER profile='{}' user='{}'", getProfile(), user); user = getMappingExtension().invoke( new ExtMap().mput( diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java index 63cada5f859..0f5f32c181f 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java @@ -78,15 +78,15 @@ public static void main(String... args) { log.debug("Version: {}-{} ({})", PACKAGE_NAME, PACKAGE_VERSION, PACKAGE_DISPLAY_NAME); - if((Boolean)argMap.get("help")) { + if ((Boolean) argMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); - } else if((Boolean)argMap.get("version")) { + } else if ((Boolean) argMap.get("version")) { System.out.format("%s-%s (%s)%n", PACKAGE_NAME, PACKAGE_VERSION, PACKAGE_DISPLAY_NAME); throw new ExitException("Version", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); log.debug(t.getMessage(), t); } @@ -120,7 +120,7 @@ public static void main(String... args) { log.info("========================================================================"); moduleService.run(); exitStatus = 0; - } catch(ExitException e) { + } catch (ExitException e) { log.debug(e.getMessage(), e); exitStatus = e.getExitCode(); } catch (Throwable t) { @@ -168,7 +168,7 @@ private static Path createTemporaryJAASconfiguration() throws IOException { principalName = String.format("principal=\"%s\"", AAA_JAAS_PRINCIPAL_NAME); } - String debug= ""; + String debug = ""; if (StringUtils.isNotEmpty(AAA_JAAS_ENABLE_DEBUG)) { debug = String.format("debug=\"%s\"", AAA_JAAS_ENABLE_DEBUG); } @@ -207,8 +207,8 @@ private static void loadExtensions( ModuleService moduleService, Map argMap ) { - List files = (List)argMap.get("extension-file"); - if(files == null) { + List files = (List) argMap.get("extension-file"); + if (files == null) { files = listFiles( (String) argMap.get("extensions-dir"), "properties" @@ -216,7 +216,7 @@ private static void loadExtensions( } List loadedExtensions = new LinkedList<>(); - for(File f : files) { + for (File f : files) { log.debug("Loading extension file '{}'", f.getName()); try { String name = extensionsManager.load(f); @@ -231,7 +231,7 @@ private static void loadExtensions( } } - for(String extension : loadedExtensions) { + for (String extension : loadedExtensions) { try { extensionsManager.initialize(extension); log.debug("Extension '{}' initialized", extension); @@ -245,7 +245,7 @@ private static void loadExtensions( private static Map loadModules(Class cls) { Map modules = new HashMap<>(); - if(cls != null) { + if (cls != null) { ServiceLoader loader = ServiceLoader.load(cls); for (ModuleService module : loader) { modules.put(module.getName(), module); @@ -266,14 +266,14 @@ private static void setupLogger() { private static void setupLogger(Map args) throws IOException { Logger log = Logger.getLogger(""); - String logfile = (String)args.get("log-file"); - if(logfile != null) { + String logfile = (String) args.get("log-file"); + if (logfile != null) { FileHandler fh = new FileHandler(logfile, true); fh.setFormatter(new SimpleFormatter()); log.addHandler(fh); } - OVIRT_LOGGER.setLevel((Level)args.get("log-level")); + OVIRT_LOGGER.setLevel((Level) args.get("log-level")); } private static List listFiles(String directory, String suffix) { @@ -293,7 +293,7 @@ private static List listFiles(String directory, String suffix) { private static String getModules(Map modules) { StringBuilder sb = new StringBuilder(); - for(Map.Entry entry : new TreeMap<>(modules).entrySet()) { + for (Map.Entry entry : new TreeMap<>(modules).entrySet()) { sb.append( String.format(" %-10s - %s%n", entry.getKey(), entry.getValue().getDescription()) ); diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/HelpServiceImpl.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/HelpServiceImpl.java index 490a222ed4f..f4e972c8b62 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/HelpServiceImpl.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/HelpServiceImpl.java @@ -33,7 +33,7 @@ public ExtMap getContext() { @Override public void parseArguments(List args) throws Exception { System.out.println("Available modules:"); - for(Map.Entry entry : new TreeMap<>(getContext().>get(ContextKeys.MODULES)).entrySet()) { + for (Map.Entry entry : new TreeMap<>(getContext().>get(ContextKeys.MODULES)).entrySet()) { System.out.printf( String.format(" %-10s - %s%n", entry.getKey(), diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java index 32163517795..de7e30b104e 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/InfoServiceImpl.java @@ -39,19 +39,19 @@ private interface Logic { private enum Action { CONFIGURATION( module -> { - ExtensionProxy extension = module.getExtensionsManager().getExtensionByName((String)module.argMap.get("extension-name")); + ExtensionProxy extension = module.getExtensionsManager().getExtensionByName((String) module.argMap.get("extension-name")); Collection sensitive = extension.getContext().get(Base.ContextKeys.CONFIGURATION_SENSITIVE_KEYS); Map config = extension.getContext().get(Base.ContextKeys.CONFIGURATION); Collection keys = new HashSet<>(config.keySet()); if (module.argMap.get("key") != null) { - keys.retainAll((List)module.argMap.get("key")); + keys.retainAll((List) module.argMap.get("key")); } for (Object key : keys) { module.output( - ((String)module.argMap.get("format")).replace( + ((String) module.argMap.get("format")).replace( "{key}", String.format("%s", key) ).replace( @@ -65,11 +65,11 @@ private enum Action { ), CONTEXT( module -> { - ExtensionProxy extension = module.getExtensionsManager().getExtensionByName((String)module.argMap.get("extension-name")); + ExtensionProxy extension = module.getExtensionsManager().getExtensionByName((String) module.argMap.get("extension-name")); Collection keys = new HashSet<>(extension.getContext().keySet()); if (module.argMap.get("key") != null) { Collection k = new HashSet<>(); - for (String uuid : (List)module.argMap.get("key")) { + for (String uuid : (List) module.argMap.get("key")) { k.add(new ExtKey("Unknown", Object.class, uuid)); } keys.retainAll(k); @@ -83,7 +83,7 @@ private enum Action { } module.output( - ((String)module.argMap.get("format")).replace( + ((String) module.argMap.get("format")).replace( "{key}", key.getUuid().getUuid().toString() ).replace( @@ -103,7 +103,7 @@ private enum Action { for (ExtensionProxy extension : module.getExtensionsManager().getExtensions()) { ExtMap extContext = extension.getContext(); module.output( - ((String)module.argMap.get("format")).replace( + ((String) module.argMap.get("format")).replace( "{instance}", extContext.get(Base.ContextKeys.INSTANCE_NAME, "") ).replace( @@ -137,12 +137,12 @@ Map parse(Map substitutions, Properties props, L parser.parse(actionArgs); Map argMap = parser.getParsedArgs(); - if((Boolean)argMap.get("help")) { + if ((Boolean) argMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -166,7 +166,7 @@ void execute(InfoServiceImpl module) { private Map argMap; private ExtensionsManager getExtensionsManager() { - return (ExtensionsManager)context.get(ContextKeys.EXTENSION_MANAGER); + return (ExtensionsManager) context.get(ContextKeys.EXTENSION_MANAGER); } private void output(String s, String logIndent) { @@ -214,12 +214,12 @@ public void parseArguments(List args) throws Exception { parser.parse(args); argModuleMap = parser.getParsedArgs(); - if((Boolean)argModuleMap.get("help")) { + if ((Boolean) argModuleMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -232,7 +232,7 @@ public void parseArguments(List args) throws Exception { try { action = Action.valueOf(args.get(0).toUpperCase().replace("-", "_")); - } catch(IllegalArgumentException e) { + } catch (IllegalArgumentException e) { log.error("Invalid action '{}'", args.get(0)); throw new ExitException("Invalid action", 1); } diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java index 00465255e75..4b8e2f3163c 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ModuleService.java @@ -25,6 +25,6 @@ public static class ContextKeys { public void parseArguments(List args) throws Exception; - public void run() throws Exception; + public void run() throws Exception; } diff --git a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java index 962e94e41e2..0e6ce043bc0 100644 --- a/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java +++ b/backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/logger/LoggerServiceImpl.java @@ -84,12 +84,12 @@ Map parse(Map substitutions, Properties props, L parser.parse(actionArgs); Map argMap = parser.getParsedArgs(); - if((Boolean)argMap.get("help")) { + if ((Boolean) argMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -113,7 +113,7 @@ void execute(LoggerServiceImpl module) { private Map argMap; private ExtensionsManager getExtensionsManager() { - return (ExtensionsManager)context.get(ContextKeys.EXTENSION_MANAGER); + return (ExtensionsManager) context.get(ContextKeys.EXTENSION_MANAGER); } @Override @@ -154,12 +154,12 @@ public void parseArguments(List args) throws Exception { parser.parse(args); argModuleMap = parser.getParsedArgs(); - if((Boolean)argModuleMap.get("help")) { + if ((Boolean) argModuleMap.get("help")) { System.out.format("Usage: %s", parser.getUsage()); throw new ExitException("Help", 0); } - if(!parser.getErrors().isEmpty()) { - for(Throwable t : parser.getErrors()) { + if (!parser.getErrors().isEmpty()) { + for (Throwable t : parser.getErrors()) { log.error(t.getMessage()); } throw new ExitException("Parsing error", 1); @@ -172,7 +172,7 @@ public void parseArguments(List args) throws Exception { try { action = Action.valueOf(args.get(0).toUpperCase().replace("-", "_")); - } catch(IllegalArgumentException e) { + } catch (IllegalArgumentException e) { log.error("Invalid action '{}'", args.get(0)); throw new ExitException("Invalid action", 1); } diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java index 00ee523c1f5..c56292c0768 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/EnforceAuthFilter.java @@ -35,8 +35,8 @@ public void init(FilterConfig filterConfig) { @Override public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException { - HttpServletRequest req = (HttpServletRequest)request; - HttpServletResponse res = (HttpServletResponse)response; + HttpServletRequest req = (HttpServletRequest) request; + HttpServletResponse res = (HttpServletResponse) response; if (FiltersHelper.isAuthenticated(req)) { chain.doFilter(request, response); diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java index 18a905eaa24..ca4f86f94b8 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java @@ -41,8 +41,8 @@ public static class Constants { public static final String LOGOUT_INPROGRESS = "LOGOUT_INPROGRESS"; } - public static final int PREFER_NEW_AUTH = 1<<0; - public static final int PREFER_PERSISTENCE_AUTH = 1<<1; + public static final int PREFER_NEW_AUTH = 1 << 0; + public static final int PREFER_PERSISTENCE_AUTH = 1 << 1; public static BackendLocal getBackend(Context context) { @@ -137,7 +137,7 @@ public static Map getPayloadForToken(String token) { } public static long copy(final InputStream input, final OutputStream output) throws IOException { - final byte[] buffer = new byte[8*1024]; + final byte[] buffer = new byte[8 * 1024]; long count = 0; int n; while ((n = input.read(buffer)) != -1) { diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java index 02794f1b95d..a3488eec9b6 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/NegotiationFilter.java @@ -91,7 +91,7 @@ private synchronized void cacheNegotiatingProfiles() { public void doFilter(ServletRequest req, ServletResponse rsp, FilterChain chain) throws IOException, ServletException { - HttpServletRequest httpreq = (HttpServletRequest)req; + HttpServletRequest httpreq = (HttpServletRequest) req; if (FiltersHelper.isAuthenticated(httpreq) || httpreq.getAttribute(FiltersHelper.Constants.REQUEST_AUTH_RECORD_KEY) != null) { chain.doFilter(req, rsp); @@ -100,7 +100,7 @@ public void doFilter(ServletRequest req, ServletResponse rsp, FilterChain chain) HttpSession session = httpreq.getSession(false); Deque stack = null; if (session != null) { - stack = (Deque)session.getAttribute(STACK_ATTR); + stack = (Deque) session.getAttribute(STACK_ATTR); } if (stack == null) { stack = new ArrayDeque<>(); diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java index f852ea89660..6be5831e9f0 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionValidationFilter.java @@ -29,7 +29,7 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha ServletException { boolean doFilter = false; try { - String requestEngineSession = (String)request.getAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY); + String requestEngineSession = (String) request.getAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY); if (requestEngineSession != null) { if (!FiltersHelper.isSessionValid(requestEngineSession)) { request.removeAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY); diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLogoutServlet.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLogoutServlet.java index 53deefcd973..dd1bdbcb5e2 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLogoutServlet.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoLogoutServlet.java @@ -65,7 +65,7 @@ protected void service(HttpServletRequest request, HttpServletResponse response) session.setAttribute(FiltersHelper.Constants.LOGOUT_INPROGRESS, true); } - Map revokeResponse = SsoOAuthServiceUtils.revoke(token); + Map revokeResponse = SsoOAuthServiceUtils.revoke(token); String error_description = (String) revokeResponse.get("error_description"); String error = (String) revokeResponse.get("error"); if (StringUtils.isNotEmpty(error_description)) { diff --git a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java index 57ed6d96b2b..707feb9d569 100644 --- a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java +++ b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SsoPostLoginServlet.java @@ -68,11 +68,11 @@ protected void service(HttpServletRequest request, HttpServletResponse response) try { String error_description = request.getParameter("error_description"); String error = request.getParameter("error"); - if (StringUtils.isNotEmpty(error_description) && StringUtils.isNotEmpty(error)){ + if (StringUtils.isNotEmpty(error_description) && StringUtils.isNotEmpty(error)) { throw new RuntimeException(String.format("%s: %s", error, error_description)); } String code = request.getParameter("code"); - if (StringUtils.isEmpty(code)){ + if (StringUtils.isEmpty(code)) { throw new RuntimeException("No authorization code found in request"); } //appUrl not encoded diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java index d1f98487148..6af8729f15f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractRngDeviceCommand.java @@ -24,7 +24,7 @@ /** * Base class for crud for random number generator devices */ -public abstract class AbstractRngDeviceCommand extends CommandBase { +public abstract class AbstractRngDeviceCommand extends CommandBase { @Inject private VmStaticDao vmStaticDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java index c18caa999fd..c36a837f2a8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java @@ -78,7 +78,7 @@ protected void executeCommand() { if (vds.getClusterSupportsGlusterService()) { // Check gluster service running status GlusterStatus isGlusterRunning = glusterUtil.isGlusterRunning(vds.getId()); - switch(isGlusterRunning) { + switch (isGlusterRunning) { case DOWN: log.info("Gluster service on host '{}' is down, starting it", vds.getHostName()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java index d6acd8ab6ad..3346808b58c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java @@ -66,7 +66,7 @@ protected void executeCommand() { String message = StringUtils.abbreviate(getEvent().getMessage(), Config.getValue(ConfigValues.MaxAuditLogMessageLength)); - switch (getEvent().getSeverity()){ + switch (getEvent().getSeverity()) { case NORMAL: auditLogDirector.log(event, AuditLogType.EXTERNAL_EVENT_NORMAL, message); break; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java index e6bf5b68f1b..f6cc2308966 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalJobCommand.java @@ -30,7 +30,7 @@ public AuditLogType getAuditLogTypeValue() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); permissionList.add(new PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID, VdcObjectType.System, ActionGroup.INJECT_EXTERNAL_TASKS)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java index 94731d0196f..eb566254828 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalStepCommand.java @@ -10,7 +10,7 @@ import org.ovirt.engine.core.common.businessentities.ActionGroup; import org.ovirt.engine.core.common.errors.EngineMessage; -public class AddExternalStepCommand extends AddStepCommand{ +public class AddExternalStepCommand extends AddStepCommand { public AddExternalStepCommand(T parameters, CommandContext cmdContext) { @@ -19,7 +19,7 @@ public AddExternalStepCommand(T parameters, CommandContext cmdContext) { @Override protected boolean validate() { - boolean retValue=super.validate(); + boolean retValue = super.validate(); if (job != null) { if (!job.isExternal()) { @@ -37,7 +37,7 @@ protected boolean validate() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); permissionList.add(new PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID, VdcObjectType.System, ActionGroup.INJECT_EXTERNAL_TASKS)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java index aea6afa1186..4a9a4ea805f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalJobCommand.java @@ -40,7 +40,7 @@ protected void executeCommand() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); if (getParameters().getJobEntityType() != null && getParameters().getJobEntityId() != null) { permissionList.add(new PermissionSubject(getParameters().getJobEntityId(), getParameters().getJobEntityType(), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalStepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalStepCommand.java index 27405c68c17..796e43af3b4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalStepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddInternalStepCommand.java @@ -11,7 +11,7 @@ * BLL command to create a Step for Jobs that are internal */ @InternalCommandAttribute -public class AddInternalStepCommand extends AddStepCommand{ +public class AddInternalStepCommand extends AddStepCommand { public AddInternalStepCommand(T parameters, CommandContext cmdContext) { super(parameters, cmdContext); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java index 520a72e2a30..d22bb9652ed 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddMacPoolCommand.java @@ -65,7 +65,7 @@ private MacPool getMacPoolEntity() { @Override protected void executeCommand() { - registerRollbackHandler((TransactionRollbackListener)() -> macPoolPerCluster.removePool(getMacPoolId())); + registerRollbackHandler((TransactionRollbackListener) () -> macPoolPerCluster.removePool(getMacPoolId())); getMacPoolEntity().setId(Guid.newGuid()); macPoolDao.save(getMacPoolEntity()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java index e7bd5b0d358..e402199ba05 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddStepCommand.java @@ -32,17 +32,17 @@ protected AddStepCommand(T parameters, CommandContext cmdContext) { @Override protected boolean validate() { - boolean retValue=true; + boolean retValue = true; job = jobDao.get(getParameters().getParentId()); if (job == null) { parentStep = stepDao.get(getParameters().getParentId()); } if (job == null && parentStep == null) { - retValue=false; + retValue = false; addValidationMessage(EngineMessage.ACTION_TYPE_NO_PARENT); } if (StringUtils.isBlank(getParameters().getDescription())) { - retValue=false; + retValue = false; addValidationMessage(EngineMessage.ACTION_TYPE_EMPTY_DESCRIPTION); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java index 1f5b7f9bb42..9a28cc543bd 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java @@ -187,7 +187,7 @@ protected void importHostedEngineVm(Map vmStruct) { } graphicsDevices.forEach(device -> vm.getManagedVmDeviceMap().put(device.getDeviceId(), device)); VmDevice consoleDevice = vdsBrokerObjectsBuilder.buildConsoleDevice(vmStruct, vm.getId()); - if(consoleDevice != null){ + if (consoleDevice != null) { vm.getManagedVmDeviceMap().put(consoleDevice.getDeviceId(), consoleDevice); } importHostedEngineVm(vm); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java index 4ed32da8cc5..2d53be9b29e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java @@ -403,7 +403,7 @@ protected void addVmImages() { // Create a disk to reflect the fact the disk existed during snapshot saveIllegalDisk(diskImage); } - } else {// Only legal images can be copied + } else { // Only legal images can be copied switch (diskImage.getDiskStorageType()) { case CINDER: CinderDisk cinder = (CinderDisk) diskImage; @@ -482,7 +482,7 @@ protected boolean isDisksVolumeFormatValid() { protected abstract VM getVmFromConfiguration(); - protected Guid getDestStorageDomain(Guid diskImageID){ + protected Guid getDestStorageDomain(Guid diskImageID) { return diskInfoDestinationMap.get(diskImageID).getStorageIds().get(0); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java index 96a790a9c16..524f63035af 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java @@ -879,7 +879,7 @@ protected MultipleDiskVmElementValidator createMultipleDiskVmElementValidator( protected boolean validateSpaceRequirements() { // update vm snapshots for storage free space check imagesHandler.fillImagesBySnapshots(getVm()); - List disksList = DisksFilter.filterImageDisks(getVm().getDiskMap().values(), ONLY_NOT_SHAREABLE, + List disksList = DisksFilter.filterImageDisks(getVm().getDiskMap().values(), ONLY_NOT_SHAREABLE, ONLY_ACTIVE); List disksListForStorageChecks = createDiskDummiesForSpaceValidations(disksList); MultipleStorageDomainsValidator multipleSdValidator = getStorageDomainsValidator( @@ -1040,7 +1040,7 @@ private void addTemplateDiskVmElement(Guid newDiskId, Guid oldDiskId) { diskVmElementDao.save(newDve); } - private Guid getVmIdFromImageParameters(){ + private Guid getVmIdFromImageParameters() { return getParameters().getMasterVm().getId(); } @@ -1298,7 +1298,7 @@ private Guid getQuotaIdForDisk(DiskImage diskImage) { // If the DiskInfoDestinationMap is available and contains information about the disk if (getParameters().getDiskInfoDestinationMap() != null && getParameters().getDiskInfoDestinationMap().get(diskImage.getId()) != null) { - return getParameters().getDiskInfoDestinationMap().get(diskImage.getId()).getQuotaId(); + return getParameters().getDiskInfoDestinationMap().get(diskImage.getId()).getQuotaId(); } return diskImage.getQuotaId(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCommandBase.java index 18e0dbdfc9d..505ecfe7260 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AnsibleCommandBase.java @@ -40,7 +40,7 @@ public AnsibleCommandBase(T parameters, CommandContext cmdContext) { } @Override - protected void init(){ + protected void init() { super.init(); setVdsId(getParameters().getHostId()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java index 420ebeee48b..f099ac4fdd4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java @@ -203,9 +203,9 @@ > void check(final AutoRecoverDao dao, log.debug("Checking autorecoverable {} done", logMsg); } - private > String getHostName(T entity) { + private > String getHostName(T entity) { if (entity instanceof VDS) { - return ", name : "+((VDS) entity).getName(); + return ", name : " + ((VDS) entity).getName(); } return ""; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index ff389d6c2a9..8ddcd295ad4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -176,7 +176,7 @@ public void create() { checkDBConnectivity(); try { initialize(); - } catch(Exception ex) { + } catch (Exception ex) { log.error("Error during initialization", ex); throw ex; } @@ -337,7 +337,7 @@ private void initAttestation() { try { AttestThread attestThread = new AttestThread(trustedVdsNames); - attestThread.start();//start a thread to attest the hosts + attestThread.start(); //start a thread to attest the hosts } catch (Exception e) { log.error("Failed to initialize attestation cache", e); } @@ -434,7 +434,7 @@ private ActionReturnValue runActionImpl(ActionType actionType, return result; } - private boolean isActionExternal(ActionType actionType){ + private boolean isActionExternal(ActionType actionType) { return actionType == ActionType.EndExternalJob || actionType == ActionType.EndExternalStep || actionType == ActionType.ClearExternalJob; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java index 56c6e4fb6d8..65c2d5817b3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java @@ -246,7 +246,7 @@ protected void executeCommand() { }); if (targetStoragePool != null - && (getSourceCluster().getStoragePoolId()== null || !targetStoragePool.getId().equals(getSourceCluster().getStoragePoolId()))) { + && (getSourceCluster().getStoragePoolId() == null || !targetStoragePool.getId().equals(getSourceCluster().getStoragePoolId()))) { VdsActionParameters addVdsSpmIdParams = new VdsActionParameters(getVdsIdRef()); addVdsSpmIdParams.setSessionId(getParameters().getSessionId()); addVdsSpmIdParams.setCompensationEnabled(true); @@ -276,7 +276,7 @@ protected void executeCommand() { } if (getSourceCluster().getStoragePoolId() != null - && (targetStoragePool== null || !getSourceCluster().getStoragePoolId().equals(targetStoragePool.getId()))) { + && (targetStoragePool == null || !getSourceCluster().getStoragePoolId().equals(targetStoragePool.getId()))) { vdsSpmIdMapDao.removeByVdsAndStoragePool(getVds().getId(), getSourceCluster().getStoragePoolId()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java index 3d51a94df6e..080d07f98d8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java @@ -80,7 +80,7 @@ public void doPolling(Guid cmdId, List childCmdIds) { childCommandsExecutionEnded(command, anyFailed, childCmdIds, status, completedChildren); } - private void logChildCommandFailed(Guid cmdId, Guid childCmdId, CommandStatus status){ + private void logChildCommandFailed(Guid cmdId, Guid childCmdId, CommandStatus status) { log.debug("Child command id: '{}' of command id: '{}' status is {}, set as failed.", childCmdId, cmdId, status); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java index 618ad3d87c3..18315262c16 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClearExternalJobCommand.java @@ -14,7 +14,7 @@ import org.ovirt.engine.core.common.job.Job; import org.ovirt.engine.core.dao.JobDao; -public class ClearExternalJobCommand extends CommandBase{ +public class ClearExternalJobCommand extends CommandBase { @Inject private JobDao jobDao; @@ -58,7 +58,7 @@ protected void executeCommand() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); permissionList.add(new PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID, VdcObjectType.System, ActionGroup.INJECT_EXTERNAL_TASKS)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java index a2fbae7e764..dc4fed281c7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java @@ -665,7 +665,7 @@ protected void updateOriginalTemplate(VmStatic vmStatic) { } @Override - protected Guid getDestStorageDomain(Guid diskImageID){ + protected Guid getDestStorageDomain(Guid diskImageID) { return getParameters().getDestStorageDomainId() != null ? getParameters().getDestStorageDomainId() : super.getDestStorageDomain(diskImageID); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java index 310d4d1a36b..1ebdc90b9be 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ClusterOperationCommandBase.java @@ -204,7 +204,7 @@ private boolean isX86Architecture(Cluster cluster) { private ClusterPolicy getClusterPolicy(final Cluster cluster) { ClusterPolicy clusterPolicy = null; - if (cluster == null){ + if (cluster == null) { return null; } if (cluster.getClusterPolicyId() != null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java index 8d49690561e..6a5c494d8ba 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java @@ -402,7 +402,7 @@ public ActionReturnValue executeAction() { String tempVar = getDescription(); getReturnValue().setDescription((tempVar != null) ? tempVar : getReturnValue().getDescription()); setActionMessageParameters(); - Step validatingStep=null; + Step validatingStep = null; boolean actionAllowed; boolean isExternal = this.getParameters().getJobId() != null || this.getParameters().getStepId() != null; if (!isExternal) { @@ -1315,7 +1315,7 @@ private StringBuilder getPermissionSubjectsAsStringBuilder(List { + registerRollbackHandler((TransactionRollbackListener) () -> { log.error("Transaction rolled-back for command '{}'.", getClass().getName()); try { if (isQuotaDependant()) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandCompensator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandCompensator.java index d5edcba10c2..9558a400592 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandCompensator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandCompensator.java @@ -48,7 +48,7 @@ public void compensate() { // get all command snapshot entries List commandSnapshots = businessEntitySnapshotDao.getAllCommands(); for (KeyValue commandSnapshot : commandSnapshots) { - if(skipCompensationOnStartup((Guid) commandSnapshot.getKey())) { + if (skipCompensationOnStartup((Guid) commandSnapshot.getKey())) { continue; } // create an instance of the related command by its class name and command id diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java index 1c48004ddea..43cedc10494 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java @@ -483,7 +483,7 @@ private void initTargetDomains() { private Map autoSelectTargetDomainAndVolumeFormat() { Map destinationMap = new HashMap<>(); for (Disk disk: templateDisks) { - DiskImage diskImage = (DiskImage)disk; + DiskImage diskImage = (DiskImage) disk; ArrayList storageIds = new ArrayList<>(); Guid storageId = findAvailableStorageDomain(disk.getSize(), diskToStorageIds.get(disk.getId())); storageIds.add(storageId); @@ -618,7 +618,7 @@ public List getQuotaStorageConsumptionParameters() { disk.getQuotaId(), QuotaConsumptionParameter.QuotaAction.CONSUME, disk.getStorageIds().get(0), - (double)(disk.getSizeInGigabytes() * getParameters().getVmsCount()))) + (double) (disk.getSizeInGigabytes() * getParameters().getVmsCount()))) .collect(Collectors.toList()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java index 6cd44194841..ed3756a4bc9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java @@ -386,7 +386,7 @@ public boolean checkIfCpusSameManufacture(String cpuName1, String cpuName2) { } if (ibmCpuByNameDictionary.containsKey(cpuName1)) { - return ibmCpuByNameDictionary.containsKey(cpuName2); + return ibmCpuByNameDictionary.containsKey(cpuName2); } if (s390CpuByNameDictionary.containsKey(cpuName1)) { @@ -462,13 +462,13 @@ public List getSupportedServerCpuList(String maxCpuName) { } } else if (ibmCpuByNameDictionary.containsKey(maxCpuName)) { ServerCpu selected = ibmCpuByNameDictionary.get(maxCpuName); - int selectedCpuIndex =ibmCpuList.indexOf(selected); + int selectedCpuIndex = ibmCpuList.indexOf(selected); for (int i = 0; i <= selectedCpuIndex; i++) { supportedCpus.add(ibmCpuList.get(i)); } } else if (amdCpuByNameDictionary.containsKey(maxCpuName)) { ServerCpu selected = amdCpuByNameDictionary.get(maxCpuName); - int selectedCpuIndex =amdCpuList.indexOf(selected); + int selectedCpuIndex = amdCpuList.indexOf(selected); for (int i = 0; i <= selectedCpuIndex; i++) { supportedCpus.add(amdCpuList.get(i)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvaCommand.java index 16ef44c7352..bd0fae251f9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateOvaCommand.java @@ -98,7 +98,7 @@ protected void executeCommand() { } private Pair createOvf(Collection disks) { - switch(getParameters().getEntityType()) { + switch (getParameters().getEntityType()) { case TEMPLATE: VmTemplate template = vmTemplateDao.get(getParameters().getEntityId()); vmHandler.updateVmInitFromDB(template, true); @@ -299,7 +299,7 @@ private void teardown() { @Override public boolean performNextOperation(int completedChildCount) { - switch(getParameters().getPhase()) { + switch (getParameters().getPhase()) { case MEASURE: getParameters().setPhase(CreateOvaParameters.Phase.PACK_OVA); break; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java index 578592aa99c..a1787ffa966 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalJobCommand.java @@ -18,7 +18,7 @@ import org.ovirt.engine.core.common.utils.ExecutionMethod; import org.ovirt.engine.core.dao.JobDao; -public class EndExternalJobCommand extends CommandBase{ +public class EndExternalJobCommand extends CommandBase { private Job job; @@ -73,7 +73,7 @@ protected void executeCommand() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); permissionList.add(new PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID, VdcObjectType.System, ActionGroup.INJECT_EXTERNAL_TASKS)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java index b16622519f3..813776eca5e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EndExternalStepCommand.java @@ -74,7 +74,7 @@ protected void executeCommand() { @Override public List getPermissionCheckSubjects() { - List permissionList = new ArrayList<>(); + List permissionList = new ArrayList<>(); permissionList.add(new PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID, VdcObjectType.System, ActionGroup.INJECT_EXTERNAL_TASKS)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java index 31325217a9c..f54c09d03b9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java @@ -155,7 +155,7 @@ protected boolean validateTag(String tagName) { protected static boolean isEmailValid(String email) { boolean valid = false; try { - if (email == null){ + if (email == null) { throw new AddressException(); } new InternetAddress(email, true); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java index 393b467fbd8..da1ff80ab53 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java @@ -17,7 +17,7 @@ public ExternalEventCommandBase(T parameters, CommandContext cmdContext) { super(parameters, cmdContext); } - protected List getPermissionList(AuditLog event){ + protected List getPermissionList(AuditLog event) { List permissionList = new ArrayList<>(); if (event.getStorageDomainId() != null) { permissionList.add(new PermissionSubject(new Guid(event.getStorageDomainId().toString()), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuditLogByIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuditLogByIdQuery.java index 8a4616023a4..0fe19cba0c9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuditLogByIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuditLogByIdQuery.java @@ -6,7 +6,7 @@ import org.ovirt.engine.core.common.queries.GetAuditLogByIdParameters; import org.ovirt.engine.core.dao.AuditLogDao; -public class GetAuditLogByIdQuery

extends QueriesCommandBase

{ +public class GetAuditLogByIdQuery

extends QueriesCommandBase

{ @Inject private AuditLogDao auditLogDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java index c6ed87cac68..fc3dec72524 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterEditWarningsQuery.java @@ -53,7 +53,7 @@ protected void executeQueryCommand() { List hostWarnings = getProblematicEntities(oldCluster, newCluster, hostCheckers, cluster -> vdsDao.getAllForCluster(cluster.getId())); - List vmWarnings = new ArrayList<>(); + List vmWarnings = new ArrayList<>(); if (oldCluster.supportsVirtService() && newCluster.supportsVirtService()) { vmWarnings = getProblematicEntities(oldCluster, newCluster, vmCheckers, diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFromOvaQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFromOvaQuery.java index ef27fc9a0bf..e33805ef75d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFromOvaQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetFromOvaQuery.java @@ -82,7 +82,7 @@ private String runAnsibleQueryOvaInfoPlaybook() { private Map parseOvfs(String stdout) { if (stdout.startsWith("{")) { - stdout = stdout.substring(1, stdout.length()-1); + stdout = stdout.substring(1, stdout.length() - 1); return Arrays.stream(stdout.split("::")) .map(this::splitToFileNameAndOvf) .map(arr -> new Object[] { parseOvf(arr[1]), arr[0] }) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java index 116d0901761..2e72243ecad 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java @@ -42,7 +42,7 @@ public GetPermissionsOnBehalfByAdElementIdQuery(P parameters, EngineContext engi protected void executeQueryCommand() { QueryReturnValue returnValue = backend.runInternalQuery(QueryType.GetAuthzGroupsByUserId, getParameters()); Collection authzGroups = returnValue.getReturnValue(); - List groupsIds = authzGroups.stream() + List groupsIds = authzGroups.stream() .map(g -> dbGroupDao.getByExternalId(g.getAuthz(), g.getId())) .filter(Objects::nonNull) .map(g -> g.getId()) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java index bf59ee5f290..bfd3d025393 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java @@ -14,7 +14,7 @@ import org.ovirt.engine.core.common.utils.customprop.VmPropertiesUtils; public class GetVmChangedFieldsForNextRunQuery

- extends QueriesCommandBase

{ + extends QueriesCommandBase

{ @Inject private VmHandler vmHandler; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java index 1636cb29e18..1acec2f5a73 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmFromConfigurationQuery.java @@ -24,7 +24,7 @@ protected void executeQueryCommand() { return; } - switch(getParameters().getConfigurationType()) { + switch (getParameters().getConfigurationType()) { case OVF: try { getQueryReturnValue().setReturnValue(ovfHelper.readVmFromOvf(getParameters().getVmConfiguration()).getVm()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateFromConfigurationQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateFromConfigurationQuery.java index 27d55ae3d2c..8559b783317 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateFromConfigurationQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateFromConfigurationQuery.java @@ -24,7 +24,7 @@ protected void executeQueryCommand() { return; } - switch(getParameters().getConfigurationType()) { + switch (getParameters().getConfigurationType()) { case OVF: try { getQueryReturnValue().setReturnValue(ovfHelper.readVmTemplateFromOvf(getParameters().getVmConfiguration()).getVm()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HaAutoStartVmsRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HaAutoStartVmsRunner.java index cf70800be32..a24b8ce9f26 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HaAutoStartVmsRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HaAutoStartVmsRunner.java @@ -76,7 +76,7 @@ protected AuditLogType getExceededMaxNumOfRestartsAuditLogType() { return AuditLogType.EXCEEDED_MAXIMUM_NUM_OF_RESTART_HA_VM_ATTEMPTS; } - private static class HaVmToRestart extends AutoStartVmToRestart { + private static class HaVmToRestart extends AutoStartVmToRestart { private static final int RETRY_TO_RUN_AUTO_START_VM_LONG_INTERVAL = Config. getValue(ConfigValues.RetryToRunAutoStartVmLongIntervalInSeconds); private static final long MAXIMUM_TIME_AUTO_START_BLOCKED_ON_PRIORITY = diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java index 84ee29fef85..3314eae2c6a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java @@ -112,6 +112,6 @@ private void reportNonOperationReason(NonOperationalReason reason, Map osIdToIconIdMap = new HashMap<>(); private final int DEFAULT_OS_ID = OsRepository.DEFAULT_X86_OS; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java index a7021a27299..fdcda484ea5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java @@ -112,7 +112,7 @@ public void create() { serviceLoader.load(CommandCallbacksPoller.class); serviceLoader.load(CommandEntityCleanupManager.class); - if(Config. getValue(ConfigValues.AffinityRulesEnforcementManagerEnabled)) { + if (Config. getValue(ConfigValues.AffinityRulesEnforcementManagerEnabled)) { serviceLoader.load(AffinityRulesEnforcementManager.class); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java index 9d213adbaac..d21043700ea 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitGlusterCommandHelper.java @@ -185,7 +185,7 @@ private boolean initGlusterPeerProcess(VDS vds) { // though gluster peer probe succeeds, it takes some time for the host to be // listed as a peer. Return success only when the host is acknowledged as peer // from another upServer. - VDS newUpServer = getNewUpServer(vds, upServer); + VDS newUpServer = getNewUpServer(vds, upServer); if (newUpServer == null) { //there's no other up server. so there's no issue with peer status results return true; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java index 5a0286e8250..ac62fff5b02 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceNumberOfVdssCommand.java @@ -280,7 +280,7 @@ protected boolean validate() { continue; } //TODO make a more efficient call but normally the command just loads one cluster anyway - if (!clusters.containsKey(vds.getClusterId())){ + if (!clusters.containsKey(vds.getClusterId())) { final Cluster cluster = clusterDao.get(vds.getClusterId()); clusters.put(cluster.getId(), cluster); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java index 94afa564781..187ad313e01 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintenanceVdsCommand.java @@ -289,10 +289,10 @@ public AuditLogType getAuditLogTypeValue() { return AuditLogType.VDS_MAINTENANCE_FAILED; } } else { - if (isSucceededWithReasonGiven()){ + if (isSucceededWithReasonGiven()) { addCustomValue("Reason", getVds().getMaintenanceReason()); return AuditLogType.USER_VDS_MAINTENANCE; - } else if(isSucceededWithoutReasonGiven()) { + } else if (isSucceededWithoutReasonGiven()) { return AuditLogType.USER_VDS_MAINTENANCE_WITHOUT_REASON; } else if (getSucceeded()) { return AuditLogType.USER_VDS_MAINTENANCE_MANUAL_HA; @@ -328,11 +328,11 @@ private boolean isSucceededWithHA() { return getSucceeded() && !haMaintenanceFailed; } - private boolean isSucceededWithReasonGiven(){ + private boolean isSucceededWithReasonGiven() { return isSucceededWithHA() && StringUtils.isNotEmpty(getVds().getMaintenanceReason()); } - private boolean isSucceededWithoutReasonGiven(){ + private boolean isSucceededWithoutReasonGiven() { return isSucceededWithHA() && !haMaintenanceFailed && StringUtils.isEmpty(getVds().getMaintenanceReason()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateMultipleVmsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateMultipleVmsCommand.java index e5be964b7ab..f6fbf92776c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateMultipleVmsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateMultipleVmsCommand.java @@ -92,7 +92,7 @@ protected boolean validate() { setVms(computeVmAffinityClosure()); // The permissions have to be checked for the new VMs. - if(!hasPermissionToMigrateVms(getVms())) { + if (!hasPermissionToMigrateVms(getVms())) { return failValidation(EngineMessage.USER_NOT_AUTHORIZED_TO_PERFORM_ACTION); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java index 2d9d7422515..635a30f712c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java @@ -233,7 +233,7 @@ protected Optional getVdsToRunOn() { private List getDestinationHostList() { List destinationHostGuidList = new LinkedList<>(); - if (getDestinationVdsId() != null){ + if (getDestinationVdsId() != null) { destinationHostGuidList.add(getDestinationVdsId()); } return destinationHostGuidList; @@ -270,7 +270,7 @@ protected boolean perform() { getParameters().setTotalMigrationTime(new Date()); getParameters().resetStartTime(); - BooleanSupplier attachMBSDisks = () -> managedBlockStorageCommandUtil + BooleanSupplier attachMBSDisks = () -> managedBlockStorageCommandUtil .attachManagedBlockStorageDisks(getVm(), vmHandler, getDestinationVds(), true); if (unplugPassthroughNics() && connectLunDisks(getDestinationVdsId()) && attachOrDetachMBSFromDest(attachMBSDisks) && @@ -343,7 +343,7 @@ private void plugPassthroughNics() { auditLogDirector.log(this, AuditLogType.VM_MIGRATION_NOT_ALL_VM_NICS_WERE_PLUGGED_BACK); } - } catch(Exception e) { + } catch (Exception e) { auditLogDirector.log(this, AuditLogType.VM_MIGRATION_PLUGGING_VM_NICS_FAILED); log.error("Failed to plug nics back after migration of vm {}: {}", getVmName(), e.getMessage()); log.debug("Exception: ", e); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java index ca80a1a421d..ea7e1126651 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultiLevelAdministrationHandler.java @@ -84,7 +84,7 @@ public void setIsAdminGUIFlag(Guid userId, boolean hasPermissions) { * @return true if role is the last with Super User privileges, otherwise, false */ public boolean isLastSuperUserPermission(Guid roleId) { - boolean retValue=false; + boolean retValue = false; if (PredefinedRoles.SUPER_USER.getId().equals(roleId)) { // check that there is at least one super-user left in the system List permissions = permissionDao.getAllForRole( @@ -104,15 +104,15 @@ public boolean isLastSuperUserPermission(Guid roleId) { * @return true if group is the last with Super User privileges, otherwise, false */ public boolean isLastSuperUserGroup(Guid groupId) { - boolean retValue=false; + boolean retValue = false; // check that there is at least one super-user left in the system List permissions = permissionDao.getAllForRole( PredefinedRoles.SUPER_USER.getId()); if (permissions.size() <= 1) { // get group role permissions = permissionDao.getAllForAdElement(groupId); - for (Permission permission : permissions){ - if (permission.getRoleId().equals(PredefinedRoles.SUPER_USER.getId())){ + for (Permission permission : permissions) { + if (permission.getRoleId().equals(PredefinedRoles.SUPER_USER.getId())) { retValue = true; break; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java index 75549a680c9..80b7c164ec8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunner.java @@ -126,7 +126,7 @@ private boolean canRunActions(List returnValues) { } private void freeLockForValidationPassedCommands() { - getCommands().stream().filter(command->command.getReturnValue().isValid()).forEach(command->command.freeLock()); + getCommands().stream().filter(command -> command.getReturnValue().isValid()).forEach(command -> command.freeLock()); } /** diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java index a8934edbd3f..080060944d7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java @@ -59,7 +59,7 @@ protected void executeCommand() { ONLY_ACTIVE); for (DiskImage template : imageTemplates) { // remove this disk in all domain that were sent - for (Guid domain : (Collection)CollectionUtils.intersection(getParameters().getStorageDomainsList(), template.getStorageIds())) { + for (Guid domain : (Collection) CollectionUtils.intersection(getParameters().getStorageDomainsList(), template.getStorageIds())) { ImagesContainterParametersBase tempVar = new ImagesContainterParametersBase(template.getImageId(), getVmTemplateId()); tempVar.setStorageDomainId(domain); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java index a7019e852d7..caa85cf27db 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java @@ -38,7 +38,7 @@ protected void executeCommand() { if (noGraphicsDevicesLeft()) { vmDeviceUtils.removeVideoDevices(getVmBaseId()); //Since getParameters().isVm() isn't set by REST api, try to set VM and if failed then try to set Template - if(!setVmToHeadlessMode()) { + if (!setVmToHeadlessMode()) { setTemplateToHeadlessMode(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java index 6510ebb50e5..2af6340b007 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveMacPoolCommand.java @@ -39,7 +39,7 @@ protected void setActionMessageParameters() { @Override protected void executeCommand() { - registerRollbackHandler((TransactionRollbackListener)() -> macPoolPerCluster.createPool(getOldMacPool())); + registerRollbackHandler((TransactionRollbackListener) () -> macPoolPerCluster.createPool(getOldMacPool())); macPoolDao.remove(getMacPoolId()); macPoolPerCluster.removePool(getMacPoolId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java index c27e0b40177..02f0c393b90 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemovePermissionCommand.java @@ -64,7 +64,7 @@ protected boolean validate() { ) { return failValidation(EngineMessage.SYSTEM_PERMISSIONS_CANT_BE_REMOVED_FROM_EVERYONE); } - if(!Objects.equals(p.getAdElementId(), getParameters().getTargetId()) + if (!Objects.equals(p.getAdElementId(), getParameters().getTargetId()) && dbUserDao.get(getParameters().getTargetId()) != null) { return failValidation(EngineMessage.INHERITED_PERMISSION_CANT_BE_REMOVED); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java index 2025fc0f03c..0e0df3623d2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java @@ -372,11 +372,11 @@ private RemoveAllVmImagesParameters buildRemoveAllVmImagesParameters(List m.getRepoImageName().equals(toolsName)) .findFirst() .orElse(null); - if (dataDisk != null){ + if (dataDisk != null) { return dataDisk.getRepoImageId(); } String isoDir = (String) runVdsCommand(VDSCommandType.IsoDirectory, diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java index 7dc4d698f6d..8affb5fe6c0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java @@ -146,7 +146,7 @@ protected void loadPayload() { @Override protected List getPredefinedVdsIdListToRunOn() { // destination VDS ID has priority over the dedicated VDS - if (getParameters().getDestinationVdsId() != null){ + if (getParameters().getDestinationVdsId() != null) { List destIdList = new LinkedList<>(); destIdList.add(getParameters().getDestinationVdsId()); return destIdList; @@ -217,7 +217,7 @@ public List getQuotaStorageConsumptionParameters() { @Override protected List getVdsWhiteList() { - if (getPredefinedVdsIdListToRunOn().size() > 0){ + if (getPredefinedVdsIdListToRunOn().size() > 0) { return getPredefinedVdsIdListToRunOn(); } return super.getVdsWhiteList(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java index d685773a274..b995af81558 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java @@ -409,7 +409,7 @@ private List searchClusters() { retVal.get().compareTo(cluster.getCompatibilityVersion()) > 0) ); } - for(Cluster cluster: clusters) { + for (Cluster cluster: clusters) { if (cluster.isManaged()) { List hostsWithMissingFlags = backend.runInternalQuery(QueryType.GetHostsWithMissingFlagsForCluster, new IdQueryParameters(cluster.getId())).getReturnValue(); @@ -540,7 +540,7 @@ private QueryData initQueryData(boolean useCache) { // search text. if (!isExistsValue || IsFromYesterday) { log.debug("ResourceManager::searchBusinessObjects(''{}'') - entered", searchText); - final char AT='@'; + final char AT = '@'; String queryAuthz = null; String queryNamespace = null; ISyntaxChecker curSyntaxChecker; @@ -549,7 +549,7 @@ private QueryData initQueryData(boolean useCache) { if (m.matches()) { final String COLON = ":"; String prefix = m.group("prefix"); - searchText = m.group("content"); + searchText = m.group("content"); // get profile List profiles = backend.runInternalQuery(QueryType.GetDomainList, new QueryParametersBase(getParameters().getSessionId())).getReturnValue(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java index 063ae3577ed..3f82443f202 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunner.java @@ -51,7 +51,7 @@ public SequentialMultipleActionsRunner(ActionType actionType, @Override public ArrayList execute() { for (ActionParametersBase parameter : parameters) { - if(!isInternal) { + if (!isInternal) { logExecution(log, sessionDataContainer, parameter.getSessionId(), String.format("command %s", actionType)); } CommandBase command = diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java index 5e7537e4564..68038c689d6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildExecutingCommand.java @@ -17,7 +17,7 @@ public interface SerialChildExecutingCommand { /** * method to handle immediately (before endWithFailure() is called) a failure. */ - default void handleFailure() {}; + default void handleFailure() { }; /** * method to indicate whether on failed execution of child commands the command diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java index 20803f558b9..127c64833bb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ShutdownVmCommand.java @@ -16,7 +16,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -@NonTransactiveCommandAttribute(forceCompensation=true) +@NonTransactiveCommandAttribute(forceCompensation = true) public class ShutdownVmCommand extends StopVmCommandBase { private static final Logger log = LoggerFactory.getLogger(ShutdownVmCommand.class); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java index 3250276973c..b23c0d303cc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshHostRebootCommand.java @@ -34,7 +34,7 @@ protected void executeCommand() { } private VDSStatus getStatusAfterReboot() { - switch(getParameters().getPrevVdsStatus()) { + switch (getParameters().getPrevVdsStatus()) { case Maintenance: case Installing: return getParameters().getPrevVdsStatus(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java index 1adcc3650de..ec1af427442 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommand.java @@ -8,10 +8,10 @@ import org.ovirt.engine.core.common.errors.EngineMessage; import org.ovirt.engine.core.compat.Guid; -@NonTransactiveCommandAttribute(forceCompensation=true) +@NonTransactiveCommandAttribute(forceCompensation = true) public class StopVmCommand extends StopVmCommandBase { - public StopVmCommand(T stopVmParams, CommandContext commandContext) { + public StopVmCommand(T stopVmParams, CommandContext commandContext) { super(stopVmParams, commandContext); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java index 07a359aeda7..88688a5b66b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java @@ -120,7 +120,7 @@ private VDSReturnValue destroyMigratingVm() { returnValueFromDestination = runVdsCommand( VDSCommandType.DestroyVm, buildDestroyVmVDSCommandParameters(getVm().getMigratingToVds())); - } catch(EngineException e) { + } catch (EngineException e) { switch (e.getErrorCode()) { case noVM: break; @@ -134,7 +134,7 @@ private VDSReturnValue destroyMigratingVm() { returnValueFromSource = runVdsCommand( VDSCommandType.DestroyVm, buildDestroyVmVDSCommandParameters(getVdsId())); - } catch(EngineException e) { + } catch (EngineException e) { switch (e.getErrorCode()) { case noVM: if (returnValueFromDestination == null) { @@ -242,7 +242,7 @@ public void addQuotaPermissionSubject(List quotaPermissionLis } @Override - protected boolean shouldSkipCommandExecution() { + protected boolean shouldSkipCommandExecution() { return getVm() != null && getVm().getStatus() == VMStatus.Down; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java index bfb027c3c4e..40747971447 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java @@ -86,7 +86,7 @@ @NonTransactiveCommandAttribute(forceCompensation = true) public class UpdateClusterCommand extends - ClusterOperationCommandBase implements RenamedEntityInfoProvider{ + ClusterOperationCommandBase implements RenamedEntityInfoProvider { @Inject private ClusterFeatureDao clusterFeatureDao; @@ -258,7 +258,7 @@ private void reDetectDefaultsForDeprecatedCPUs() { ServerCpu sc = cpuFlagsManagerHandler.findMaxServerCpuByFlags(vds.getCpuFlags(), getParameters().getCluster().getCompatibilityVersion()); - if (vds.getStatus() == VDSStatus.Up && sc != null && + if (vds.getStatus() == VDSStatus.Up && sc != null && (scMin == null || scMin.getLevel() > sc.getLevel()) && (!oldCpuExisted || oldCpuManufacturer.equals(cpuFlagsManagerHandler. getVendorByCpuName(sc.getCpuName(), getParameters().getCluster().getCompatibilityVersion())))) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java index c6f7fbc2ce7..a1fea651aff 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateMacPoolCommand.java @@ -74,7 +74,7 @@ public String getMacPoolName() { @Override protected void executeCommand() { - registerRollbackHandler((TransactionRollbackListener)() -> + registerRollbackHandler((TransactionRollbackListener) () -> TransactionSupport.executeInNewTransaction( (TransactionMethod) () -> { // if the update failed before the removal of the pool need to diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfilePropertyCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfilePropertyCommand.java index 861822bc65f..043cc046dac 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfilePropertyCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateUserProfilePropertyCommand.java @@ -56,7 +56,7 @@ protected void setActionMessageParameters() { @Override protected boolean validate() { UserProfileProperty propertyToUpdate = getParameters().getUserProfileProperty(); - if(!propertyToUpdate.getUserId().equals(getUserId())){ + if (!propertyToUpdate.getUserId().equals(getUserId())) { addCustomValue(PROFILE_USER, buildUserName(userDao, propertyToUpdate.getUserId())); } addCustomValue(PROFILE_PROPERTY, propertyToUpdate.getName()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java index 24680ec322b..4d0ae30b0ab 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java @@ -132,7 +132,7 @@ import org.ovirt.engine.core.vdsbroker.vdsbroker.CloudInitHandler; public class UpdateVmCommand extends VmManagementCommandBase - implements QuotaVdsDependent, RenamedEntityInfoProvider{ + implements QuotaVdsDependent, RenamedEntityInfoProvider { private static final Base64 BASE_64 = new Base64(0, null); private static final String AUDIT_LOG_MEMORY_HOT_UNPLUG_OPTIONS = "memoryHotUnplugOptions"; @@ -201,7 +201,7 @@ public class UpdateVmCommand extends VmMan private boolean isUpdateVmTemplateVersion = false; private String mdevType; // the value of the deprecated custom property mdev_type, if specified - private BiConsumer affinityGroupLoggingMethod = (a, b) -> {}; + private BiConsumer affinityGroupLoggingMethod = (a, b) -> { }; public UpdateVmCommand(T parameters, CommandContext commandContext) { super(parameters, commandContext); @@ -444,7 +444,7 @@ private boolean updateVmLease() { return true; } - private void liveUpdateCpuProfile(){ + private void liveUpdateCpuProfile() { if (getVm().getStatus().isQualifiedForQosChange() && !Objects.equals(oldVm.getCpuProfileId(), newVmStatic.getCpuProfileId())) { vmSlaPolicyUtils.refreshCpuQosOfRunningVm(getVm()); @@ -733,7 +733,7 @@ private void hotPlugMemory(int memoryHotPlugSize) { private boolean requiresSpecialBlock(int minimalHotPlugDeviceSizeMb) { if (!osRepository.requiresHotPlugSpecialBlock(getParameters().getVmStaticData().getOsId(), - getEffectiveCompatibilityVersion())){ + getEffectiveCompatibilityVersion())) { return false; } final List memoryDevices = getVmDeviceUtils().getMemoryDevices(getVmId()); @@ -813,7 +813,7 @@ private void updateWatchdog() { parameters.setAction(getParameters().getWatchdog().getAction()); parameters.setModel(getParameters().getWatchdog().getModel()); - if(watchdogs.isEmpty()) { + if (watchdogs.isEmpty()) { runInternalAction(ActionType.AddWatchdog, parameters, cloneContextAndDetachFromParent()); } else { // there is a watchdog in the vm, we have to update. @@ -1040,7 +1040,7 @@ protected boolean validate() { } else if (vmFromDB.getVmPoolId() != null) { isUpdateVmTemplateVersion = true; return true; // no more tests are needed because no more changes are allowed in this state - } else {// template id can be changed for pool VMs only + } else { // template id can be changed for pool VMs only return failValidation(EngineMessage.ACTION_TYPE_FAILED_TEMPLATE_ID_CANT_BE_CHANGED); } } @@ -1247,7 +1247,7 @@ protected boolean validate() { } } - if (isVirtioScsiEnabled()) { + if (isVirtioScsiEnabled()) { // Verify OS compatibility if (!validate(vmHandler.isOsTypeSupportedForVirtioScsi (vmFromParams.getOs(), getEffectiveCompatibilityVersion()))) { @@ -1258,7 +1258,7 @@ protected boolean validate() { VmValidator vmValidator = createVmValidator(vmFromParams); // A pinned VM, must run on one of its hosts - if (!validate(vmValidator.isPinnedVmRunningOnDedicatedHost(vmFromDB, vmFromParams.getStaticData()))){ + if (!validate(vmValidator.isPinnedVmRunningOnDedicatedHost(vmFromDB, vmFromParams.getStaticData()))) { return false; } @@ -1409,7 +1409,7 @@ && isHotSetEnabled() return false; } - if (!isIsoPathExists(vmFromParams.getStaticData(), getVm().getStoragePoolId())){ + if (!isIsoPathExists(vmFromParams.getStaticData(), getVm().getStoragePoolId())) { return failValidation(EngineMessage.ERROR_CANNOT_FIND_ISO_IMAGE_PATH); } if (!validate(vmHandler.validateCpuPinningPolicy(getParameters().getVmStaticData(), @@ -1433,7 +1433,7 @@ private boolean validateCPUHotplug(VmStatic vmStaticData) { boolean countThreadsAsCores = getCluster().getCountThreadsAsCores(); int availableCpus = SlaValidator.getEffectiveCpuCores(getVds(), countThreadsAsCores) - vdsCpuUnitPinningHelper.countUnavailableCpus( - getVdsManager(getVdsId()).getCpuTopology(), countThreadsAsCores); + getVdsManager(getVdsId()).getCpuTopology(), countThreadsAsCores); if (vmStaticData.getNumOfCpus(false) > availableCpus) { return false; } @@ -1577,14 +1577,14 @@ public List getPermissionCheckSubjects() { private boolean isDedicatedVmForVdsChanged() { List paramList = getParameters().getVmStaticData().getDedicatedVmForVdsList(); List vmList = getVm().getDedicatedVmForVdsList(); - if (vmList == null && paramList == null){ + if (vmList == null && paramList == null) { return false; } - if (vmList == null || paramList == null){ + if (vmList == null || paramList == null) { return true; } // vmList.equals(paramList) not good enough, the lists order could change - if (vmList.size() != paramList.size()){ + if (vmList.size() != paramList.size()) { return true; } return !paramList.containsAll(vmList); @@ -1603,7 +1603,7 @@ private boolean isEmulatedMachineChanged() { private boolean isChipsetChanged() { BiosType newBiosType = getParameters().getVmStaticData().getBiosType(); BiosType oldBiosType = getVm().getBiosType(); - return newBiosType.getChipsetType() != oldBiosType.getChipsetType(); + return newBiosType.getChipsetType() != oldBiosType.getChipsetType(); } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java index fbd6686f91c..4dcd14055b3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java @@ -61,7 +61,7 @@ import org.ovirt.engine.core.vdsbroker.vdsbroker.CloudInitHandler; public class UpdateVmTemplateCommand extends VmTemplateManagementCommand - implements QuotaVdsDependent, RenamedEntityInfoProvider{ + implements QuotaVdsDependent, RenamedEntityInfoProvider { @Inject private AuditLogDirector auditLogDirector; @@ -100,7 +100,7 @@ protected void init() { setVmTemplate(getParameters().getVmTemplateData()); setVmTemplateId(getVmTemplate().getId()); setClusterId(getVmTemplate().getClusterId()); - oldTemplate = vmTemplateDao.get(getVmTemplate().getId()); + oldTemplate = vmTemplateDao.get(getVmTemplate().getId()); if (getCluster() != null) { setStoragePoolId(getCluster().getStoragePoolId() != null ? getCluster().getStoragePoolId() @@ -180,7 +180,7 @@ protected boolean validate() { return false; } - if(!setAndValidateCpuProfile()) { + if (!setAndValidateCpuProfile()) { return false; } @@ -644,6 +644,6 @@ private boolean isChipsetChanged() { if (newEffectiveBiosType == null || oldEffectiveBiosType == null) { return false; } - return newEffectiveBiosType.getChipsetType() != oldEffectiveBiosType.getChipsetType(); + return newEffectiveBiosType.getChipsetType() != oldEffectiveBiosType.getChipsetType(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java index bda93366e6d..d270509a496 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java @@ -532,7 +532,7 @@ public void updateSlaPolicies(final List vmIds, final Guid vdsId) { Guid diskProfileId = diskImage.getDiskProfileId(); StorageQos storageQos = storageQosMap.get(diskProfileId); - if(storageQos != null) { + if (storageQos != null) { params.getStorageQos().put(diskImage, storageQos); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java index fc0541d944c..e550bdcc579 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java @@ -319,7 +319,7 @@ private void performToolsVersionCheck() { refreshVmsToolsVersion(storagePoolId, Set.of()); } } - } catch (Throwable t){ + } catch (Throwable t) { log.error("Exception while checking guest tools version: {}", ExceptionUtils.getRootCauseMessage(t)); log.debug("Exception", t); } @@ -1010,7 +1010,7 @@ private boolean addDeviceUpdateOnNextRun(Guid vmId, VmDeviceGeneralType generalT } else if (value instanceof VmWatchdog) { VmDevice watchdogDevice = ((VmWatchdog) value).createVmDevice(); if (vmDeviceUtils.vmDeviceChanged(vmId, generalType, typeName, watchdogDevice)) { - updates.add(new VmDeviceUpdate(generalType, type, readOnly, name, watchdogDevice)); + updates.add(new VmDeviceUpdate(generalType, type, readOnly, name, watchdogDevice)); } } else { log.warn("addDeviceUpdateOnNextRun: Unsupported value type: " + @@ -1037,7 +1037,7 @@ public ValidationResult isCpuSupported(int osId, Version version, String cpuName return ValidationResult.VALID; } - public void updateNumaNodesFromDb(VM vm){ + public void updateNumaNodesFromDb(VM vm) { List nodes = vmNumaNodeDao.getAllVmNumaNodeByVmId(vm.getId()); vm.setvNumaNodeList(nodes); @@ -1084,7 +1084,7 @@ public Set getResultingVmGraphics(List srcEntityGrap } } - if (result.isEmpty()) {// if graphics are set in params, do not use template graphics + if (result.isEmpty()) { // if graphics are set in params, do not use template graphics for (GraphicsType type : GraphicsType.values()) { if (srcEntityGraphics.contains(type) && !graphicsResetInParams(type, graphicsDevices)) { // graphics is in template and is not nulled in params result.add(type); @@ -1202,7 +1202,7 @@ private void maybeUpdateOvirtGuestAgentStatus(String latestVersion, VM vm) { } public String currentOvirtGuestAgentVersion(VM vm) { - if (vm.getAppList() != null){ + if (vm.getAppList() != null) { if (!FeatureSupported.isWindowsGuestToolsSupported(vm.getCompatibilityVersion())) { if (vm.getAppList().toLowerCase().contains("qemu-guest-agent")) { Matcher m = QEMU_GA_PATTERN_VER.matcher(vm.getAppList().toLowerCase()); @@ -1449,7 +1449,7 @@ public void autoSelectDefaultDisplayType(Guid srcEntityId, } if (defaultDisplayType == null) { - if (!displayGraphicsSupport.isEmpty()) {// when not found otherwise, let's take osinfo's record as the default + if (!displayGraphicsSupport.isEmpty()) { // when not found otherwise, let's take osinfo's record as the default for (Map.Entry> entry : displayGraphicsSupport.entrySet()) { if (defaultDisplayType == null) { // prioritize first display type based on osinfo @@ -1461,7 +1461,7 @@ public void autoSelectDefaultDisplayType(Guid srcEntityId, break; } } - } else {// no osinfo record + } else { // no osinfo record defaultDisplayType = DisplayType.vga; } } @@ -1494,7 +1494,7 @@ public void autoSelectGraphicsDevice(Guid srcEntityId, } if (defaultGraphicsType != null) { - for (GraphicsType graphicsType : GraphicsType.values()) {// reset graphics devices + for (GraphicsType graphicsType : GraphicsType.values()) { // reset graphics devices graphicsDevices.put(graphicsType, null); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java index 1b6f49788ab..6dfede49f03 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmSlaPolicyCommand.java @@ -76,7 +76,7 @@ public AuditLogType getAuditLogTypeValue() { int logId = 0; if (getParameters().getCpuQos() != null) { Integer limit = getParameters().getCpuQos().getCpuLimit(); - addCustomValue(LOGABLE_FIELD_CPU_LIMIT, (limit != null) ? String.valueOf(limit): "unlimited"); + addCustomValue(LOGABLE_FIELD_CPU_LIMIT, (limit != null) ? String.valueOf(limit) : "unlimited"); logId += 1; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java index 82d2faaaaae..1aca07f2554 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/DirectoryUtils.java @@ -36,7 +36,7 @@ public class DirectoryUtils { public DbUser mapPrincipalRecordToDbUser(String authz, ExtMap principal) { principal = principal.clone(); flatGroups(principal); - DbUser dbUser = dbUserDao.getByExternalId(authz, principal.get(PrincipalRecord.ID)); + DbUser dbUser = dbUserDao.getByExternalId(authz, principal.get(PrincipalRecord.ID)); Guid userId = dbUser != null ? dbUser.getId() : Guid.newGuid(); dbUser = new DbUser(mapPrincipalRecordToDirectoryUser(authz, principal)); dbUser.setId(userId); @@ -105,7 +105,7 @@ private DirectoryGroup mapGroupRecordToDirectoryGroup( for (ExtMap memberOf : group.> get( Authz.GroupRecord.GROUPS, Collections.emptyList())) { - if(!loopPrevention.contains(memberOf.get(GroupRecord.ID))) { + if (!loopPrevention.contains(memberOf.get(GroupRecord.ID))) { directoryGroup.getGroups().add(mapGroupRecordToDirectoryGroup(authzName, memberOf, loopPrevention)); } } @@ -121,7 +121,7 @@ public void flatGroups(ExtMap principal) { private void flatGroups(ExtMap entity, ExtKey key, Map accumulator) { for (ExtMap group : entity.>get(key, Collections. emptyList())) { - if(!accumulator.containsKey(group.get(GroupRecord.ID))) { + if (!accumulator.containsKey(group.get(GroupRecord.ID))) { accumulator.put(group.get(GroupRecord.ID), group); flatGroups(group, GroupRecord.GROUPS, accumulator); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java index e44a982a5ad..ed119caddeb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LoginOnBehalfCommand.java @@ -106,7 +106,7 @@ private DbUser getDbUserForPrincipalName(String principalName, String authzName) throw new EngineException(EngineError.PRINCIPAL_NOT_FOUND, String.format("%s in domain '%s", principalName, authzName)); } - DbUser user = new DbUser(directoryUtils.mapPrincipalRecordToDirectoryUser(authzName, principalRecord)); + DbUser user = new DbUser(directoryUtils.mapPrincipalRecordToDirectoryUser(authzName, principalRecord)); user.setId(Guid.newGuid()); return user; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveGroupCommand.java index b7120c266b6..bf0ccb196c7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/RemoveGroupCommand.java @@ -58,7 +58,7 @@ protected void executeCommand() { @Override public AuditLogType getAuditLogTypeValue() { - return getSucceeded()? AuditLogType.USER_REMOVE_AD_GROUP : AuditLogType.USER_REMOVE_AD_GROUP_FAILED; + return getSucceeded() ? AuditLogType.USER_REMOVE_AD_GROUP : AuditLogType.USER_REMOVE_AD_GROUP_FAILED; } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java index acee521c66c..86090d2975b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java @@ -228,7 +228,7 @@ public final void cleanExpiredUsersSessions() { public final void cleanExpiredUsersSessionsImpl() { Date now = new Date(); - Iterator> iter = sessionInfoMap.entrySet().iterator(); + Iterator> iter = sessionInfoMap.entrySet().iterator(); Set tokens = sessionInfoMap.values().stream() .map(sessionInfo -> (String) sessionInfo.contentOfSession.get(SSO_ACCESS_TOKEN_PARAMETER_NAME)) .collect(Collectors.toSet()); @@ -402,7 +402,7 @@ public void setSsoOvirtAppApiScope(String engineSessionId, String scope) { public boolean isSsoOvirtAppApiScope(String engineSessionId) { return isSessionExists(engineSessionId) ? - (boolean) getData(engineSessionId, SSO_IS_OVIRT_APP_API_SCOPE_PARAMETER_NAME, false): + (boolean) getData(engineSessionId, SSO_IS_OVIRT_APP_API_SCOPE_PARAMETER_NAME, false) : false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java index 1ec99cca42f..3e61baab93e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestThread.java @@ -40,7 +40,7 @@ public void run() { if (trustedHostsNames.size() > FIRST_STAGE_QUERY_SIZE) { values = AttestationService.INSTANCE.attestHosts(trustedHostsNames.subList(0, FIRST_STAGE_QUERY_SIZE)); handleValues(values); - for (int from = FIRST_STAGE_QUERY_SIZE; from < trustedHostsNames.size(); from+= SECOND_STAGE_QUERY_SIZE) { + for (int from = FIRST_STAGE_QUERY_SIZE; from < trustedHostsNames.size(); from += SECOND_STAGE_QUERY_SIZE) { int to = (from + SECOND_STAGE_QUERY_SIZE < trustedHostsNames.size()) ? from + SECOND_STAGE_QUERY_SIZE : trustedHostsNames.size(); values = AttestationService.INSTANCE. attestHosts(trustedHostsNames.subList(from, to)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java index dd554524ca8..887fc3ae9c8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CompensationContext.java @@ -76,7 +76,7 @@ public interface CompensationContext { * @param status * The status to snapshot. */ - > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status); + > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status); /** * Snapshot the entity status only, so that in case of compensation for the entity, the status will be updated to diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java index e4d7d9ec4f3..4a9bb5ad125 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/DefaultCompensationContext.java @@ -113,7 +113,7 @@ public void snapshotNewEntity(BusinessEntity entity) { } @Override - public > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status) { + public > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status) { EntityStatusSnapshot snapshot = new EntityStatusSnapshot(); snapshot.setId(entity.getId()); snapshot.setStatus(status); @@ -168,7 +168,7 @@ private BusinessEntitySnapshot createBusinessEntitySnapshot(BusinessEntity en } private void checkEntityForRollback(BusinessEntity entity) { - if(entity == null) { + if (entity == null) { throw new IllegalArgumentException("Can not create snapshot from a null entity"); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java index 933421284f4..be9f2eaabc5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/NoOpCompensationContext.java @@ -31,7 +31,7 @@ public void snapshotNewEntity(BusinessEntity entity) { } @Override - public > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status) { + public > void snapshotEntityStatus(BusinessEntityWithStatus entity, T status) { } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportOvaCommand.java index fb12c52990e..073ef15f972 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportOvaCommand.java @@ -51,7 +51,7 @@ protected void init() { } String path = getParameters().getDirectory(); if (path != null && path.endsWith("/")) { - getParameters().setDirectory(path.substring(0, path.length()-1)); + getParameters().setDirectory(path.substring(0, path.length() - 1)); } if (StringUtils.isEmpty(getParameters().getName())) { getParameters().setName(String.format("%s.ova", getEntity().getName())); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java index 48e48d2a8ea..8f5a1b99633 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmCommand.java @@ -558,7 +558,7 @@ private void endCopyCollapseOperations(VM vm) { updateCopyVmInSpm(getVm().getStoragePoolId(), vm, getParameters() .getStorageDomainId()); - } catch(EngineException e) { + } catch (EngineException e) { log.error("Updating VM OVF in export domain failed.", e); auditLogDirector.log(this, AuditLogType.IMPORTEXPORT_IMPORT_VM_FAILED_UPDATING_OVF); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmToOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmToOvaCommand.java index a32252eeb25..8e32704894b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmToOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmToOvaCommand.java @@ -195,7 +195,7 @@ public CommandCallback getCallback() { @Override public boolean performNextOperation(int completedChildCount) { - switch(getParameters().getPhase()) { + switch (getParameters().getPhase()) { case CREATE_SNAPSHOT: getParameters().setPhase(Phase.CREATE_OVA); break; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java index 95a604efdc8..8b32640c6f5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExtractOvaCommand.java @@ -94,7 +94,7 @@ protected void executeVmCommand() { } storeExternalData(runAnsibleOvaExternalDataPlaybook()); setSucceeded(true); - } catch(EngineException e) { + } catch (EngineException e) { log.error("Failed to extract OVA file", e); setCommandStatus(CommandStatus.FAILED); } @@ -135,7 +135,7 @@ private boolean runAnsibleImportOvaPlaybook(String disksPathToFormat) { .playAction("Import OVA") .playbook(AnsibleConstants.IMPORT_OVA_PLAYBOOK); - AnsibleReturnValue ansibleReturnValue = ansibleExecutor.runCommand(commandConfig); + AnsibleReturnValue ansibleReturnValue = ansibleExecutor.runCommand(commandConfig); boolean succeeded = ansibleReturnValue.getAnsibleReturnCode() == AnsibleReturnCode.OK; if (!succeeded) { log.error("Failed to extract OVA. Please check logs for more details: {}", ansibleReturnValue.getLogFile()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java index 0da170ae38f..9ce3dedd43f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandBase.java @@ -129,7 +129,7 @@ public abstract class ImportVmCommandBase extends private static VmStatic vmStaticForDefaultValues = new VmStatic(); private MacPool macPool; - private Runnable logOnExecuteEndMethod = () -> {}; + private Runnable logOnExecuteEndMethod = () -> { }; ImportVmCommandBase(T parameters, CommandContext commandContext) { super(parameters, commandContext); @@ -418,7 +418,7 @@ private void logOnExecuteEnd(Runnable method) { */ protected void generateNewDiskId(List diskImagesList, DiskImage disk) { Guid generatedGuid = generateNewDiskId(disk); - diskImagesList.forEach(diskImage -> diskImage.setId(generatedGuid)); + diskImagesList.forEach(diskImage -> diskImage.setId(generatedGuid)); } /** diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java index edcaa320c2c..b159cb40a7f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromExternalProviderCommand.java @@ -301,7 +301,7 @@ public List getQuotaStorageConsumptionParameters() { diskImage.getQuotaId(), QuotaConsumptionParameter.QuotaAction.CONSUME, getStorageDomainId(), - (double)diskImage.getSizeInGigabytes())); + (double) diskImage.getSizeInGigabytes())); } return list; } @@ -522,7 +522,7 @@ public CommandCallback getCallback() { @Override public boolean performNextOperation(int completedChildCount) { - switch(getParameters().getImportPhase()) { + switch (getParameters().getImportPhase()) { case CREATE_DISKS: getParameters().setImportPhase(Phase.CONVERT); if (getParameters().getProxyHostId() == null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandBase.java index a10b70c4de3..5568263aaa5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommandBase.java @@ -76,7 +76,7 @@ public abstract class ImportVmTemplateCommandBase {}; + private Runnable logOnExecuteEndMethod = () -> { }; public ImportVmTemplateCommandBase(T parameters, CommandContext commandContext) { super(parameters, commandContext); @@ -387,7 +387,7 @@ private void addVmTemplateToDb() { getVmTemplate().setClusterId(getParameters().getClusterId()); // if "run on host" field points to a non existent vds (in the current cluster) -> remove field and continue - if(!vmHandler.validateDedicatedVdsExistOnSameCluster(getVmTemplate()).isValid()) { + if (!vmHandler.validateDedicatedVdsExistOnSameCluster(getVmTemplate()).isValid()) { getVmTemplate().setDedicatedVmForVdsList(Collections.emptyList()); getVmTemplate().setCpuPinning(null); } @@ -503,7 +503,7 @@ public VmTemplate getVmTemplate() { @Override protected List> getValidationGroups() { - if(getParameters().isImportAsNewEntity()){ + if (getParameters().isImportAsNewEntity()) { return addValidationGroup(ImportClonedEntity.class); } return addValidationGroup(ImportEntity.class); @@ -512,7 +512,7 @@ protected List> getValidationGroups() { @Override public Map getJobMessageProperties() { if (jobProperties == null) { - jobProperties = super.getJobMessageProperties(); + jobProperties = super.getJobMessageProperties(); jobProperties.put(VdcObjectType.VmTemplate.name().toLowerCase(), (getVmTemplateName() == null) ? "" : getVmTemplateName()); jobProperties.put(VdcObjectType.Cluster.name().toLowerCase(), getClusterName()); @@ -549,7 +549,7 @@ public List getQuotaStorageConsumptionParameters() { disk.getQuotaId(), QuotaConsumptionParameter.QuotaAction.CONSUME, imageToDestinationDomainMap.get(disk.getId()), - (double)disk.getSizeInGigabytes())); + (double) disk.getSizeInGigabytes())); } return list; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromOvaCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromOvaCommand.java index e09382a720d..7f3fc3780f7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromOvaCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateFromOvaCommand.java @@ -113,7 +113,7 @@ protected AddDiskParameters buildAddDiskParameters(DiskImage image) { @Override public boolean performNextOperation(int completedChildCount) { - switch(getParameters().getImportPhase()) { + switch (getParameters().getImportPhase()) { case CREATE_DISKS: getParameters().setImportPhase(Phase.CONVERT); if (getParameters().getProxyHostId() == null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmCommand.java index f371de77ba7..546604a05fd 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmCommand.java @@ -39,7 +39,7 @@ protected void setUnregisteredEntityAndImages() throws OvfReaderException { } @Override - protected boolean isUnregisteredEntityExists(){ + protected boolean isUnregisteredEntityExists() { return vmFromConfiguration != null; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmTemplateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmTemplateCommand.java index 8f875dc9e68..5ccc2dc12ce 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmTemplateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveUnregisteredVmTemplateCommand.java @@ -39,7 +39,7 @@ protected void setUnregisteredEntityAndImages() throws OvfReaderException { } @Override - protected boolean isUnregisteredEntityExists(){ + protected boolean isUnregisteredEntityExists() { return vmTemplateFromConfiguration != null; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java index d98b54527a1..b0315a45e11 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/RemoveVmFromImportExportCommand.java @@ -47,7 +47,7 @@ import org.ovirt.engine.core.dao.VmDao; @NonTransactiveCommandAttribute -public class RemoveVmFromImportExportCommand extends RemoveVmCommand{ +public class RemoveVmFromImportExportCommand extends RemoveVmCommand { @Inject diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicContext.java index d08132e9989..5c6f6e2cbc0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicContext.java @@ -85,7 +85,7 @@ public Class getLastHandler() { * @return the last outcome of the flow */ public HandlerOutcome getLastOutcome() { - return (HandlerOutcome) flowTrace.peek().get(0); + return (HandlerOutcome) flowTrace.peek().get(0); } public boolean isSuccessful() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicHandlers.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicHandlers.java index 45fcf6a9f39..33c5dab9823 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicHandlers.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicHandlers.java @@ -103,7 +103,7 @@ public static class ProfileMappingSpecified extends AbstractHandler { @Override public HandlerOutcome handle(MapVnicContext ctx) { - if(ctx.getProfileMapping().hasTargetId()) { + if (ctx.getProfileMapping().hasTargetId()) { ctx.trace(SUCCESS, TargetIdSpecified.class); return SUCCESS; } @@ -215,7 +215,7 @@ public static class TargetNamesAreEmptyString extends AbstractHandler @Override public HandlerOutcome handle(MapVnicContext ctx) { - if(ctx.getProfileMapping().hasTargetNames()) { + if (ctx.getProfileMapping().hasTargetNames()) { ctx.trace(SUCCESS, TargetNamesSpecified.class); return SUCCESS; } @@ -263,7 +263,7 @@ public static class TargetProfileSpecified extends AbstractHandler { + vnicsContext.getContexts().forEach(ctx -> { ctx.getFlow().getHead().process(ctx); vnicsContext.trace(SUCCESS, RunContextPerMatchedMapping.class, ctx); }); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java index ce59249bcd3..ebaa3c03ae5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java @@ -348,8 +348,8 @@ private void addGlusterVolumeBricksInDb(List newBricks, int int brickCount = volumeBricks.get(volumeBricks.size() - 1).getBrickOrder(); //If the volume is an arbiter volume then make every third brick as arbiter brick. - if(volume.getIsArbiter()){ - for(int i=2;i glusterServers = new HashMap<>(); VDS upServer = glusterUtil.getUpServer(getParameters().getClusterId()); - if(upServer != null ) { + if (upServer != null ) { VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterServersList, new VdsIdVDSCommandParametersBase(upServer.getId())); glusterServers = getAddedGlusterServers((List) returnValue.getReturnValue()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionsForStorageDomainQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionsForStorageDomainQuery.java index 4b58f26d67c..e0a90887fbe 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionsForStorageDomainQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionsForStorageDomainQuery.java @@ -59,7 +59,7 @@ protected void executeQueryCommand() { //retrieve the gluster volume associated with path String path = connection.getConnection(); String[] pathElements = path.split(StorageConstants.GLUSTER_VOL_SEPARATOR); - if (pathElements.length !=2 ) { + if (pathElements.length != 2 ) { // return empty as volume name could not be determined log.info("Volume name could not be determined from storage connection '{}' ", path); getQueryReturnValue().setSucceeded(false); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterClusterServiceByClusterIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterClusterServiceByClusterIdQuery.java index 1d584469307..a2d93679ea0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterClusterServiceByClusterIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterClusterServiceByClusterIdQuery.java @@ -17,7 +17,7 @@ public GetGlusterClusterServiceByClusterIdQuery(P parameters, EngineContext engi protected void executeQueryCommand() { List serviceList = null; - if(getParameters().getServiceType() == null) { + if (getParameters().getServiceType() == null) { serviceList = glusterClusterServiceDao.getByClusterId(getParameters().getId()); } else { serviceList = new ArrayList<>(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java index da838e5667b..ba8d79b8202 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterGeoReplicationEligibleVolumesQuery.java @@ -35,7 +35,7 @@ protected void executeQueryCommand() { public List getEligibleVolumes(GlusterVolumeEntity masterVolume) { List possiblyEligibleVolumes = getAllGlusterVolumesWithMasterCompatibleVersion(masterVolume.getId()); Map> eligibilityPredicateMap = getGeoRepUtilInstance().getEligibilityPredicates(masterVolume); - Predicate andPredicate = eligibilityPredicateMap.values().stream().reduce(Predicate::and).orElse(t->true); + Predicate andPredicate = eligibilityPredicateMap.values().stream().reduce(Predicate::and).orElse(t -> true); return possiblyEligibleVolumes.stream().filter(andPredicate).collect(Collectors.toList()); } @@ -44,9 +44,9 @@ protected List getAllGlusterVolumesWithMasterCompatibleVers Cluster masterCluster = clusterDao.get(masterVolume.getClusterId()); List clusters = clusterDao.getClustersByServiceAndCompatibilityVersion(true, false, masterCluster.getCompatibilityVersion().getValue()); List volumes = new ArrayList<>(); - if(clusters != null) { - for(Cluster currentCluster : clusters) { - if(!currentCluster.getId().equals(masterCluster.getId())) { + if (clusters != null) { + for (Cluster currentCluster : clusters) { + if (!currentCluster.getId().equals(masterCluster.getId())) { volumes.addAll(glusterVolumeDao.getByClusterId(currentCluster.getId())); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByClusterIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByClusterIdQuery.java index 23af861bd03..805b22fb08e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByClusterIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByClusterIdQuery.java @@ -16,7 +16,7 @@ public GetGlusterServerServicesByClusterIdQuery(P parameters, EngineContext engi protected void executeQueryCommand() { List serviceList = null; - if(getParameters().getServiceType() == null) { + if (getParameters().getServiceType() == null) { serviceList = glusterServerServiceDao.getByClusterId(getParameters().getId()); } else { serviceList = glusterServerServiceDao.getByClusterIdAndServiceType(getParameters().getId(), getParameters().getServiceType()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByServerIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByServerIdQuery.java index 9527e66a1cd..064c910786b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByServerIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServerServicesByServerIdQuery.java @@ -16,7 +16,7 @@ public GetGlusterServerServicesByServerIdQuery(P parameters, EngineContext engin protected void executeQueryCommand() { List serviceList = null; - if(getParameters().getServiceType() == null) { + if (getParameters().getServiceType() == null) { serviceList = glusterServerServiceDao.getByServerId(getParameters().getId()); } else { serviceList = glusterServerServiceDao.getByServerIdAndServiceType(getParameters().getId(), getParameters().getServiceType()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java index 8c6d73f3aa2..a0d5c16638e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterStorageDevicesQuery.java @@ -54,7 +54,7 @@ private String getMountPointsFilterPattern() { // Mounts to be ignored can be exact mount point or a regular expression which should be with the starting part // of the mount point. So create a regex which can match against any given pattern in the list. StringBuilder pattern = new StringBuilder(); - for(String mointPoint:mountPointsToIgnore){ + for (String mointPoint:mountPointsToIgnore) { pattern.append("^"); pattern.append(mointPoint); pattern.append("$"); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java index e84823eb8f0..98c7741a892 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java @@ -177,7 +177,7 @@ private GlusterVolumeAdvancedDetails fetchAdvancedDetails(String volumeName) { } }); } - return advancedDetails; + return advancedDetails; } private GlusterVolumeEntity getReplicateVolume(Guid clusterId) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionByIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionByIdQuery.java index fb95a2948f7..e610fbfbf92 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionByIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionByIdQuery.java @@ -4,7 +4,7 @@ import org.ovirt.engine.core.common.businessentities.gluster.GlusterGeoRepSession; import org.ovirt.engine.core.common.queries.IdQueryParameters; -public class GetGlusterVolumeGeoRepSessionByIdQuery

extends GlusterQueriesCommandBase

{ +public class GetGlusterVolumeGeoRepSessionByIdQuery

extends GlusterQueriesCommandBase

{ public GetGlusterVolumeGeoRepSessionByIdQuery(P parameters, EngineContext engineContext) { super(parameters, engineContext); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java index 7fa2a694619..cddd99431a3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQuery.java @@ -10,7 +10,7 @@ import org.ovirt.engine.core.common.queries.IdQueryParameters; import org.ovirt.engine.core.compat.Guid; -public class GetGlusterVolumeGeoRepSessionsQuery

extends GlusterQueriesCommandBase

{ +public class GetGlusterVolumeGeoRepSessionsQuery

extends GlusterQueriesCommandBase

{ public GetGlusterVolumeGeoRepSessionsQuery(P parameters, EngineContext engineContext) { super(parameters, engineContext); @@ -30,7 +30,7 @@ protected void executeQueryCommand() { * Session details could be null, if they are not yet synced. possible if session detail command failed for some unexpected reason * such as network failure even though the sessions in the cluster are synced(sessionListCommand) */ - if(geoRepSessionDetails == null) { + if (geoRepSessionDetails == null) { continue; } /* @@ -38,11 +38,11 @@ protected void executeQueryCommand() { * as obtained by using masterbrickId */ for (GlusterGeoRepSessionDetails currentDetail : geoRepSessionDetails) { - if(currentDetail == null) { + if (currentDetail == null) { continue; } Guid currentMasterBrickId = currentDetail.getMasterBrickId(); - if(currentMasterBrickId == null) { + if (currentMasterBrickId == null) { continue; } GlusterBrickEntity currentBrick = glusterBrickDao.getById(currentMasterBrickId); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java index bcf0b1f4465..67556e0697e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java @@ -39,8 +39,8 @@ protected void executeQueryCommand() { } protected GlusterVolumeProfileInfo populateBrickNames(GlusterVolumeProfileInfo profileInfo) { - List brickProfiles= profileInfo.getBrickProfileDetails(); - for(BrickProfileDetails brickProfileDetails : brickProfiles) { + List brickProfiles = profileInfo.getBrickProfileDetails(); + for (BrickProfileDetails brickProfileDetails : brickProfiles) { brickProfileDetails.setIdentity(glusterBrickDao.getById(brickProfileDetails.getBrickId()).getQualifiedName()); } return profileInfo; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java index 6111d1bb7d3..5fd76f27d0f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeRemoveBricksStatusQuery.java @@ -24,7 +24,7 @@ protected GlusterVolumeTaskStatusEntity fetchTaskStatusDetails() { getParameters().getBricks(), volume.getReplicaCount())); - GlusterVolumeTaskStatusEntity entity = (GlusterVolumeTaskStatusEntity)returnValue.getReturnValue(); + GlusterVolumeTaskStatusEntity entity = (GlusterVolumeTaskStatusEntity) returnValue.getReturnValue(); // Update the latest status details GlusterAsyncTask asyncTask = volume.getAsyncTask(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java index c67f9abbdd5..ec28b752781 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetNonEligibilityReasonsOfVolumeForGeoRepSessionQuery.java @@ -28,8 +28,8 @@ protected void executeQueryCommand() { protected List getNonEligibilityReasons(GlusterVolumeEntity masterVolume, GlusterVolumeEntity slaveVolume) { List nonEligibilityreasons = new ArrayList<>(); Map> eligibilityPredicateMap = getGeoRepUtilInstance().getEligibilityPredicates(masterVolume); - for(Map.Entry> eligibilityPredicateMapEntries : eligibilityPredicateMap.entrySet()) { - if(!eligibilityPredicateMapEntries.getValue().test(slaveVolume)) { + for (Map.Entry> eligibilityPredicateMapEntries : eligibilityPredicateMap.entrySet()) { + if (!eligibilityPredicateMapEntries.getValue().test(slaveVolume)) { nonEligibilityreasons.add(eligibilityPredicateMapEntries.getKey()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java index dd8c09da23b..02fcc702863 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java @@ -75,7 +75,7 @@ public void refreshHooksInCluster(Cluster cluster, boolean throwError) { List>> taskList = new ArrayList<>(); for (final VDS upServer : upServers) { taskList.add(() -> { - VDSReturnValue returnValue =runVdsCommand(VDSCommandType.GlusterHooksList, + VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterHooksList, new VdsIdVDSCommandParametersBase(upServer.getId())); return new Pair<>(upServer, returnValue); }); @@ -91,7 +91,7 @@ public void refreshHooksInCluster(Cluster cluster, boolean throwError) { } } - private void addOrUpdateHooks(Guid clusterId, List> pairResults ) { + private void addOrUpdateHooks(Guid clusterId, List> pairResults ) { try { List existingHooks = hooksDao.getByClusterId(clusterId); @@ -130,7 +130,7 @@ private void addOrUpdateHooks(Guid clusterId, List> p List fetchedHooks = (List) pairResult.getSecond().getReturnValue(); for (GlusterHookEntity fetchedHook : fetchedHooks) { - String key= fetchedHook.getHookKey(); + String key = fetchedHook.getHookKey(); fetchedHookKeyList.add(key); GlusterHookEntity existingHook = existingHookMap.get(key); @@ -145,7 +145,7 @@ private void addOrUpdateHooks(Guid clusterId, List> p existingHook.setConflictStatus(conflictStatus | existingHookMap.get(key).getConflictStatus()); - if (conflictStatus!=0) { + if (conflictStatus != 0) { //there is a conflict. we need to either add or update entry in server hook if (serverHook == null) { newServerHooks.add(buildServerHook(server.getId(), existingHook.getId(), fetchedHook)); @@ -241,7 +241,7 @@ private void saveHookContent(List> existingHookServersMap, Guid hookId, VDS server) { - Set hookServers = existingHookServersMap.get(hookId); + Set hookServers = existingHookServersMap.get(hookId); hookServers.add(server); existingHookServersMap.put(hookId, hookServers); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidator.java index 7c6f5b78a0c..a83fe84b3db 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHostValidator.java @@ -26,7 +26,7 @@ public class GlusterHostValidator { private final GlusterVolumeDao volumeDao; @Inject - public GlusterHostValidator(GlusterVolumeDao volumeDao, GlusterBrickDao brickDao){ + public GlusterHostValidator(GlusterVolumeDao volumeDao, GlusterBrickDao brickDao) { Validate.notNull(volumeDao, "volumeDao can not be null"); Validate.notNull(brickDao, "brickDao can not be null"); this.volumeDao = volumeDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java index e63bddfefdc..29fee25165e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterJobsManager.java @@ -33,7 +33,7 @@ public void init() { log.debug("Initializing Gluster Jobs Manager"); - jobs.forEach(j-> j.schedule()); + jobs.forEach(j -> j.schedule()); cronJobs.scheduleAllJobs(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java index 54e9bed6deb..20fa8234632 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java @@ -159,7 +159,7 @@ private void refreshServerData(Cluster cluster, VDS upServer, List existing if (fetchedServers != null) { syncServers(cluster, existingServers, fetchedServers); } - } catch(Exception e) { + } catch (Exception e) { log.error("Error while refreshing server data for cluster '{}' from database: {}", cluster.getName(), e.getMessage()); @@ -863,8 +863,8 @@ public void updateVolumeProperties(GlusterVolumeEntity existingVolume, final Glu boolean changed = false; boolean volumeTypeUnSupported = false; if (existingVolume.getVolumeType() != fetchedVolume.getVolumeType()) { - if(existingVolume.getVolumeType().isSupported() && !fetchedVolume.getVolumeType().isSupported()){ - volumeTypeUnSupported= true; + if (existingVolume.getVolumeType().isSupported() && !fetchedVolume.getVolumeType().isSupported()) { + volumeTypeUnSupported = true; } existingVolume.setVolumeType(fetchedVolume.getVolumeType()); changed = true; @@ -1057,12 +1057,12 @@ private void logBrickStatusChange(GlusterVolumeEntity volume, final GlusterBrick null, AuditLogType.GLUSTER_BRICK_STATUS_CHANGED, customValues); - if(fetchedStatus == GlusterStatus.DOWN){ + if (fetchedStatus == GlusterStatus.DOWN) { logUtil.logAuditMessage(volume, AuditLogType.GLUSTER_BRICK_STATUS_DOWN, brick.getId(), brick.getQualifiedName()); - }else if(fetchedStatus == GlusterStatus.UP){ + } else if (fetchedStatus == GlusterStatus.UP) { alertDirector.removeAlertsByBrickIdLogType(brick.getId(), AuditLogType.GLUSTER_BRICK_STATUS_DOWN); } } @@ -1199,9 +1199,9 @@ private Map getGlusterVolumeHealInfo(VDS upServer, String volumeN VDSReturnValue result = runVdsCommand(VDSCommandType.GetGlusterVolumeHealInfo, new GlusterVolumeVDSParameters(upServer.getId(), volumeName)); - if(result.getSucceeded()){ + if (result.getSucceeded()) { return (Map) result.getReturnValue(); - }else{ + } else { return Collections.emptyMap(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java index 01c68c8ca15..1e26c6757c8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java @@ -51,7 +51,7 @@ import org.slf4j.LoggerFactory; @Singleton -public class GlusterTasksSyncJob extends GlusterJob { +public class GlusterTasksSyncJob extends GlusterJob { private static final Logger log = LoggerFactory.getLogger(GlusterTasksSyncJob.class); @Inject @@ -101,9 +101,9 @@ public void updateGlusterAsyncTasks() { private void updateTasksInCluster(final Cluster cluster, final Map runningTasks) { - for (Entry entry : runningTasks.entrySet()) { + for (Entry entry : runningTasks.entrySet()) { Guid taskId = entry.getKey(); - final GlusterAsyncTask task = entry.getValue(); + final GlusterAsyncTask task = entry.getValue(); List steps = stepDao.getStepsByExternalId(taskId); @@ -311,7 +311,7 @@ private void cleanUpOrphanTasks(Map> runningTasksInClusterMap) { log.debug("Tasks to be cleaned up in db '{}'", tasksNotRunning); for (Guid taskId: tasksNotRunning) { - GlusterVolumeEntity vol= volumeDao.getVolumeByGlusterTask(taskId); + GlusterVolumeEntity vol = volumeDao.getVolumeByGlusterTask(taskId); if (vol != null && (vol.getStatus() != GlusterStatus.UP || !runningTasksInClusterMap.keySet() .contains(vol.getClusterId()))) { @@ -325,7 +325,7 @@ private void cleanUpOrphanTasks(Map> runningTasksInClusterMap) { //will mark job ended with status unknown. List steps = stepDao.getStepsByExternalId(taskId); Map values = new HashMap<>(); - values.put(GlusterConstants.CLUSTER, vol == null ? "" :vol.getClusterName()); + values.put(GlusterConstants.CLUSTER, vol == null ? "" : vol.getClusterName()); values.put(GlusterConstants.VOLUME, vol == null ? "" : vol.getName()); values.put(GlusterConstants.JOB_STATUS, JobExecutionStatus.UNKNOWN.toString()); values.put(GlusterConstants.JOB_INFO, " "); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterThinDeviceService.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterThinDeviceService.java index 990a0379eb7..2acbe0811d6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterThinDeviceService.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterThinDeviceService.java @@ -175,7 +175,7 @@ private R calculateConfirmedVolume(GlusterVolumeEntity volume, Function set = new ArrayList<>(); - while(replicaCounter < volume.getReplicaCount() && !bricks.isEmpty()) { + while (replicaCounter < volume.getReplicaCount() && !bricks.isEmpty()) { set.add(bricks.get(0)); bricks.remove(0); replicaCounter++; @@ -199,7 +199,7 @@ private Function>, Long> reduceBricksToSize(GlusterVolumeEnt return data.stream() .map(b -> b.map(v -> v * SizeConverter.BYTES_IN_MB).map(Double::longValue).min(Long::compare).orElse(null)) .filter(Objects::nonNull) - .mapToLong(s-> s) + .mapToLong(s -> s) .sum(); case DISTRIBUTE: case STRIPE: diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java index 9bc8792add9..904cc1fab95 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java @@ -203,7 +203,7 @@ private void performActionForServicesOfServer() { glusterServerDao.updatePeerStatus(getParameters().getServerId(), PeerStatus.CONNECTED); //only if cluster supports only gluster service if (!getCluster().supportsVirtService()) { - runVdsCommand(VDSCommandType.SetVdsStatus, new SetVdsStatusVDSCommandParameters(getVdsId(), VDSStatus.Initializing)); + runVdsCommand(VDSCommandType.SetVdsStatus, new SetVdsStatusVDSCommandParameters(getVdsId(), VDSStatus.Initializing)); } } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommand.java index 6a3870619ba..343bbcdfee4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommand.java @@ -41,7 +41,7 @@ protected boolean validate() { return false; } - if(!super.validate()) { + if (!super.validate()) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java index 512e11926da..3b7f7929c84 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java @@ -32,7 +32,7 @@ protected void setActionMessageParameters() { @Override protected boolean validate() { - if(!super.validate()) { + if (!super.validate()) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java index 4c189721199..214b7cb0728 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RemoveGlusterHookCommand.java @@ -115,7 +115,7 @@ protected void executeCommand() { if (errors.size() > 0) { setSucceeded(false); - errorType = AuditLogType.GLUSTER_HOOK_REMOVE_FAILED; + errorType = AuditLogType.GLUSTER_HOOK_REMOVE_FAILED; handleVdsErrors(getAuditLogTypeValue(), errors); addCustomValue(GlusterConstants.FAILURE_MESSAGE , StringUtils.join(errors, System.lineSeparator())); } else { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java index 5f4e70b3233..9cd3514b03e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommand.java @@ -48,7 +48,7 @@ protected void executeCommand() { if (getParameters().getVolumeOption() != null && !getParameters().getVolumeOption().getKey().isEmpty()) { GlusterVolumeOptionEntity entity = getGlusterVolume().getOption(getParameters().getVolumeOption().getKey()); isResetAllOptions = false; - if(entity != null) { + if (entity != null) { removeOptionInDb(entity); String optionValue = entity.getValue(); getParameters().getVolumeOption().setValue(optionValue != null ? optionValue : ""); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java index 1b7d0f733bf..4d5ac4bd1ff 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommand.java @@ -10,7 +10,7 @@ import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; import org.ovirt.engine.core.common.vdscommands.gluster.GlusterVolumeGeoRepSessionVDSParameters; -public class ResumeGeoRepSessionCommand extends GeoRepSessionCommandBase{ +public class ResumeGeoRepSessionCommand extends GeoRepSessionCommandBase { private GlusterVolumeGeoRepSessionParameters parameters; @@ -57,7 +57,7 @@ protected void executeCommand() { @Override public AuditLogType getAuditLogTypeValue() { - if(getSucceeded()) { + if (getSucceeded()) { return AuditLogType.GLUSTER_VOLUME_GEO_REP_RESUME; } else { return AuditLogType.GLUSTER_VOLUME_GEO_REP_RESUME_FAILED; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java index 06ba1f63e33..12c1a9ea8dc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGeoRepConfigCommand.java @@ -62,7 +62,7 @@ protected void executeCommand() { geoRepSessionConfig.setValue(configValue); geoRepSessionConfig.setKey(configKey); geoRepSessionConfig.setId(session.getId()); - if(glusterGeoRepDao.getGeoRepSessionConfigByKey(session.getId(), configKey) == null) { + if (glusterGeoRepDao.getGeoRepSessionConfigByKey(session.getId(), configKey) == null) { glusterGeoRepDao.saveConfig(geoRepSessionConfig); } else { glusterGeoRepDao.updateConfig(geoRepSessionConfig); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java index f94ec588198..e3ee417ff15 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetGlusterVolumeOptionCommand.java @@ -67,7 +67,7 @@ private void updateOptionInDb(final GlusterVolumeOptionEntity option) { // update the option value if it exists, else add it GlusterVolumeOptionEntity existingOption = getGlusterVolume().getOption(option.getKey()); if (existingOption != null) { - if(option.getValue().equalsIgnoreCase(existingOption.getValue())) { + if (option.getValue().equalsIgnoreCase(existingOption.getValue())) { return; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java index 665675afae9..3280efb1b00 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetUpPasswordLessSSHInternalCommand.java @@ -72,7 +72,7 @@ protected void executeCommand() { if (canProceed) { List errors = new ArrayList<>(); List updateKeyReturnValues = updatePubKeysToRemoteHosts(pubKeys, getParameters().getDestinationHostIds(), getParameters().getUserName()); - for(ActionReturnValue currentReturnValue : updateKeyReturnValues) { + for (ActionReturnValue currentReturnValue : updateKeyReturnValues) { if (!currentReturnValue.getSucceeded()) { errors.addAll(currentReturnValue.getExecuteFailedMessages()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java index fa1fbcaaee8..139bd1f0eef 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java @@ -42,7 +42,7 @@ protected void setActionMessageParameters() { @Override protected boolean validate() { - if(! super.validate()) { + if (! super.validate()) { return false; } @@ -63,7 +63,7 @@ protected void executeCommand() { new GlusterVolumeActionVDSParameters(upServer.getId(), getGlusterVolumeName(), getParameters().isForceAction())); setSucceeded(returnValue.getSucceeded()); - if(getSucceeded()) { + if (getSucceeded()) { glusterDBUtils.updateVolumeStatus(getParameters().getVolumeId(), GlusterStatus.UP); /* Refresh volume details once the volume is started. * A specific requirement for this was user might create a volume for the sake of using it for geo-replication. diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java index 9ece5b1f15e..6d2af52e797 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeGeoRepCommand.java @@ -56,7 +56,7 @@ protected boolean validate() { @Override public AuditLogType getAuditLogTypeValue() { - if(getSucceeded()) { + if (getSucceeded()) { return AuditLogType.GLUSTER_VOLUME_GEO_REP_START; } else { return errorType == null ? AuditLogType.GLUSTER_VOLUME_GEO_REP_START_FAILED_EXCEPTION : errorType; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java index a8cda64be3b..8c7239bdb57 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java @@ -45,7 +45,7 @@ protected void setActionMessageParameters() { @Override protected boolean validate() { - if(! super.validate()) { + if (! super.validate()) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncHealClusterVolumesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncHealClusterVolumesCommand.java index cf364238283..1b3d11dbd57 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncHealClusterVolumesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncHealClusterVolumesCommand.java @@ -52,7 +52,7 @@ protected void executeCommand() { @Override protected boolean validate() { - if(cluster == null) { + if (cluster == null) { return failValidation(EngineMessage.VDS_CLUSTER_IS_NOT_VALID); } if (!cluster.supportsGlusterService()) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java index 98a7f0aef54..49fdba9a61a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java @@ -42,7 +42,7 @@ protected boolean validate() { //Host status will not checked in case of force. Storage devices will be synced as part of host install/activation //and host status will not be up during host activation. So BLL will be called with force in this case. - if(!getParameters().isForceAction()){ + if (!getParameters().isForceAction()) { HostValidator validator = HostValidator.createInstance(getVds()); return validate(validator.isUp()); } @@ -62,7 +62,7 @@ protected void setActionMessageParameters() { protected void executeCommand() { VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GetStorageDeviceList, new VdsIdVDSCommandParametersBase(getVds().getId())); - if (returnValue.getSucceeded()){ + if (returnValue.getSucceeded()) { List storageDevices = (List) returnValue.getReturnValue(); getStorageDeviceSyncJobInstance().updateStorageDevices(getVds(), storageDevices); setSucceeded(true); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java index 30e35e50ef3..48a9bf4eede 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java @@ -181,7 +181,7 @@ protected void executeCommand() { if (errors.size() > 0) { setSucceeded(false); - errorType = AuditLogType.GLUSTER_HOOK_UPDATE_FAILED; + errorType = AuditLogType.GLUSTER_HOOK_UPDATE_FAILED; handleVdsErrors(getAuditLogTypeValue(), errors); addCustomValue(GlusterConstants.FAILURE_MESSAGE , StringUtils.join(errors, System.lineSeparator())); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessor.java index 4213788c453..52b520c88c6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessor.java @@ -23,7 +23,7 @@ public class GlusterEventsProcessor { private ConcurrentMap subscribers = new ConcurrentHashMap<>(); - public GlusterEventsProcessor(){ + public GlusterEventsProcessor() { subscribers.put("EVENT_GEOREP_.*", Injector.injectMembers(new GeorepEventSubscriber())); subscribers.put("BRICK.*", Injector.injectMembers(new GlusterBrickEventSubscriber())); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java index 834a96eff3d..4d1a2421019 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java @@ -210,16 +210,16 @@ public void updateSteps(Cluster cluster, GlusterAsyncTask task, List steps public void logEventMessage(GlusterAsyncTask task, JobExecutionStatus oldStatus, Cluster cluster) { GlusterVolumeEntity volume = volumeDao.getVolumeByGlusterTask(task.getTaskId()); - if ( volume == null){ - if(task.getTaskParameters() != null) { + if ( volume == null) { + if (task.getTaskParameters() != null) { String volName = task.getTaskParameters().getVolumeName(); volume = volumeDao.getByName(cluster.getId(), volName); } else { return; } } - if (JobExecutionStatus.ABORTED == task.getStatus() || JobExecutionStatus.FINISHED == task.getStatus() || JobExecutionStatus.FAILED == task.getStatus()){ - if(oldStatus != task.getStatus()){ + if (JobExecutionStatus.ABORTED == task.getStatus() || JobExecutionStatus.FINISHED == task.getStatus() || JobExecutionStatus.FAILED == task.getStatus()) { + if (oldStatus != task.getStatus()) { logMessage(cluster.getId(), volume , taskTypeStrMap.get(task.getType()), task.getStatus().name().toLowerCase(), taskTypeAuditMsg.get(task.getType())); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java index 55011e97f32..171811f7a83 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java @@ -42,10 +42,10 @@ public Map getTaskListForCluster(Guid id) { log.info("No up server in cluster"); return null; } - VDSReturnValue returnValue =runVdsCommand(VDSCommandType.GlusterTasksList, + VDSReturnValue returnValue = runVdsCommand(VDSCommandType.GlusterTasksList, new VdsIdVDSCommandParametersBase(upServer.getId())); if (returnValue.getSucceeded()) { - List tasks = (List)returnValue.getReturnValue(); + List tasks = (List) returnValue.getReturnValue(); Map tasksMap = new HashMap<>(); for (GlusterAsyncTask task: tasks) { tasksMap.put(task.getTaskId(), task); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java index 51c4c80f81c..69d6f2ab8b7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/KatelloProvider.java @@ -25,7 +25,7 @@ /** * A base class for Katello providers */ -public abstract class KatelloProvider implements ContentHostProvider { +public abstract class KatelloProvider implements ContentHostProvider { private static final Logger log = LoggerFactory.getLogger(KatelloProvider.class); protected static final Integer UNLIMITED_PAGE_SIZE = 999999; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java index ee79a8c5bb9..df6def7f314 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/AddVdsCommand.java @@ -101,7 +101,7 @@ public class AddVdsCommand extends VdsCommand< @Inject private AffinityValidator affinityValidator; - private BiConsumer affinityGroupLoggingMethod = (a, b) -> {}; + private BiConsumer affinityGroupLoggingMethod = (a, b) -> { }; /** * Constructor for command creation when compensation is applied on startup */ @@ -434,7 +434,7 @@ private String getInstalledVdsIdIfExists(SSHClient client) { ByteArrayOutputStream out = new ConstraintByteArrayOutputStream(256); client.executeCommand(Config.getValue(ConfigValues.GetVdsmIdByVdsmToolCommand), null, out, err); return new String(out.toByteArray(), StandardCharsets.UTF_8).trim(); - } catch(Exception e) { + } catch (Exception e) { log.warn( "Failed to initiate vdsm-id request on host: {} with error: {}", e.getMessage(), @@ -512,8 +512,8 @@ private boolean isValidGlusterPeer(SSHClient sshclient, Guid clusterId) { // Must not allow adding a server that already is part of another gluster cluster Set peers = glusterUtil.getPeers(sshclient); if (peers.size() > 0) { - for(String peer : peers) { - if(glusterDBUtils.serverExists(clusterId, peer)) { + for (String peer : peers) { + if (glusterDBUtils.serverExists(clusterId, peer)) { // peer present in cluster. so server being added is valid. return true; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java index a9df0fa0da7..26207c31527 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/InstallVdsInternalCommand.java @@ -154,8 +154,8 @@ protected void executeCommand() { runAnsibleHostDeployPlaybook(); List hostlist = vdsDao.getAllForCluster(getClusterId()); - hostlist = getOnlyActiveHosts(hostlist); - if(getVds().getClusterSupportsGlusterService() && getParameters().getReplaceHostConfiguration()!=null && getParameters(). + hostlist = getOnlyActiveHosts(hostlist); + if (getVds().getClusterSupportsGlusterService() && getParameters().getReplaceHostConfiguration() != null && getParameters(). getReplaceHostConfiguration().getDeployAction() != ReplaceHostConfiguration.Action.NONE && hostlist.size() >= 2) { String firstGlusterClusterNode = hostlist.get(0).getName(); @@ -167,14 +167,14 @@ protected void executeCommand() { Map map = glusterUtil.getGlusterIpaddressAsMap(stringNetworkMap, getVds(), hostlist); - if(map != null){ + if (map != null) { oldGlusterClusterNode = map.get(getVds()); firstGlusterClusterNode = map.get(hostlist.get(0)); secondGlusterClusterNode = map.get(hostlist.get(1)); } - if(getParameters().getReplaceHostConfiguration().getDeployAction() == ReplaceHostConfiguration.Action.DIFFERENTFQDN) { + if (getParameters().getReplaceHostConfiguration().getDeployAction() == ReplaceHostConfiguration.Action.DIFFERENTFQDN) { newGlusterClusterNode = getParameters().getFqdnBox(); //put the editor value here @@ -186,12 +186,12 @@ protected void executeCommand() { runAnsibleReconfigureGluster(oldGlusterClusterNode, firstGlusterClusterNode, secondGlusterClusterNode, newGlusterClusterNode, maintenanceVds); } else { - if(getParameters().getReplaceHostConfiguration()!=null && getParameters().getReplaceHostConfiguration().getDeployAction() == - ReplaceHostConfiguration.Action.NONE){ + if (getParameters().getReplaceHostConfiguration() != null && getParameters().getReplaceHostConfiguration().getDeployAction() == + ReplaceHostConfiguration.Action.NONE) { log.info("Replace host is disabled"); - } else if(!getVds().getClusterSupportsGlusterService()) { + } else if (!getVds().getClusterSupportsGlusterService()) { log.info("Skipping Replace host since cluster does not support gluster"); - } else if(vdsDao.getAllForCluster(getClusterId()).size()<3) { + } else if (vdsDao.getAllForCluster(getClusterId()).size() < 3) { log.info("Skipping Replace host since minimum of three hosts are required in the same cluster"); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java index 3ee363527c7..1f2d62316de 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java @@ -55,7 +55,7 @@ import org.ovirt.engine.core.vdsbroker.ResourceManager; @NonTransactiveCommandAttribute(forceCompensation = true) -public class UpdateVdsCommand extends VdsCommand implements RenamedEntityInfoProvider{ +public class UpdateVdsCommand extends VdsCommand implements RenamedEntityInfoProvider { @Inject private AuditLogDirector auditLogDirector; @@ -99,7 +99,7 @@ public class UpdateVdsCommand extends VdsC @Inject private LabelDao labelDao; - private BiConsumer affinityGroupLoggingMethod = (a, b) -> {}; + private BiConsumer affinityGroupLoggingMethod = (a, b) -> { }; public UpdateVdsCommand(T parameters, CommandContext cmdContext) { this(parameters, cmdContext, ActionType.InstallVdsInternal); @@ -125,7 +125,7 @@ protected boolean validate() { // if fence agents list is null, try to fill it from database // so we can enable changing other host attributes from API // without failing validation or removing the persisted fence agents - boolean validateAgents=true; + boolean validateAgents = true; if (getParameters().getFenceAgents() == null) { getParameters().setFenceAgents(fenceAgentDao.getFenceAgentsForHost(getVdsId())); validateAgents = false; @@ -183,7 +183,7 @@ protected void executeCommand() { InstallVdsParameters tempVar = new InstallVdsParameters(getVdsId(), getParameters().getPassword()); tempVar.setIsReinstallOrUpgrade(getParameters().isReinstallOrUpgrade()); tempVar.setoVirtIsoFile(getParameters().getoVirtIsoFile()); - if (vdsDynamicDao.get(getVdsId()).getStatus() == VDSStatus.InstallingOS) { + if (vdsDynamicDao.get(getVdsId()).getStatus() == VDSStatus.InstallingOS) { // TODO: remove hack when reinstall api will provider override-firewall parameter. // https://bugzilla.redhat.com/show_bug.cgi?id=1177126 - for now we override firewall // configurations on each deploy for provisioned host to avoid wrong deployment. @@ -266,7 +266,7 @@ private void updateVdsData() { public Void runInTransaction() { getCompensationContext().snapshotEntity(getVds().getStaticData()); vdsStaticDao.update(getParameters().getVdsStaticData()); - updateFenceAgents();// TODO: what compensation needed for fencing? + updateFenceAgents(); // TODO: what compensation needed for fencing? getCompensationContext().stateChanged(); return null; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java index 7944c17f75e..3f87110a42c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java @@ -78,17 +78,17 @@ public StorageDomainStatic getStorageDomain() { return storageDomainStatic; } - private void initHostedEngineStorageDomain(){ - if(hostedEngineVm == null){ + private void initHostedEngineStorageDomain() { + if (hostedEngineVm == null) { return; } List diskList = hostedEngineVm.getDiskList(); - if(diskList == null || diskList.isEmpty()){ + if (diskList == null || diskList.isEmpty()) { return; } DiskImage disk = diskList.get(0); List allStorageDomainsByImageId = storageDomainDao.getAllStorageDomainsByImageId(disk.getImageId()); - if(allStorageDomainsByImageId == null || allStorageDomainsByImageId.isEmpty()){ + if (allStorageDomainsByImageId == null || allStorageDomainsByImageId.isEmpty()) { return; } StorageDomain storageDomain = allStorageDomainsByImageId.get(0); @@ -120,7 +120,7 @@ public Guid getRunningHostId() { return hostedEngineVm.getRunOnVds(); } - public boolean updateHaLocalMaintenanceMode(VDS vds, boolean localMaintenance){ + public boolean updateHaLocalMaintenanceMode(VDS vds, boolean localMaintenance) { SetHaMaintenanceModeVDSCommandParameters param = new SetHaMaintenanceModeVDSCommandParameters(vds, HaMaintenanceMode.LOCAL, localMaintenance); return vdsBroker.runVdsCommand(VDSCommandType.SetHaMaintenanceMode, param).getSucceeded(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java index 69aed38d03c..a7fc1c1c436 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionContext.java @@ -19,7 +19,7 @@ *

  • stepsList will contain a selective list of Steps to be printed. Should be used with isMonitored = null.
  • * */ -public class ExecutionContext implements Serializable{ +public class ExecutionContext implements Serializable { /** * Automatic generated serial version ID diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java index 34a64c1ab1a..c74ee9106a0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java @@ -412,7 +412,7 @@ public void removeMessage(String message) { @Override public String toString() { - if(exclusive) { + if (exclusive) { return "The lock is exclusive"; } return "The lock is shared and a number of shared locks is " + count; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderImpl.java index 77299e9bbc4..46314c77c97 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/ManageNetworksParametersBuilderImpl.java @@ -58,7 +58,7 @@ public PersistentHostSetupNetworksParameters buildParameters(Guid vdsId, .map(networkIdToAttachmentMap::get) .collect(Collectors.toList()); - updatedNetworkAttachments.forEach(networkAttachment->networkAttachment.setOverrideConfiguration(true)); + updatedNetworkAttachments.forEach(networkAttachment -> networkAttachment.setOverrideConfiguration(true)); updatedNetworksParams.getNetworkAttachments().addAll(updatedNetworkAttachments); final PersistentHostSetupNetworksParameters combinedParams = diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java index 6b4c5b8aa21..943a67697b0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/transformer/NetworkClustersToSetupNetworksParametersTransformerImpl.java @@ -133,7 +133,7 @@ private Map> getUpdatedNetworksByHost(Collection clusterNetworksByName = networkDao.getAllForCluster(clusterId) .stream() - .filter(network->idsOfUpdatedNetworks.contains(network.getId())) + .filter(network -> idsOfUpdatedNetworks.contains(network.getId())) .collect(Collectors.toMap(Network::getName, Function.identity())); List interfacesOfCluster = interfaceDao.getAllInterfacesByClusterId(clusterId); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java index a020e40a9d8..655376072da 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java @@ -110,7 +110,7 @@ private Provider getProvider() { } private Guid getProviderId() { - return (getNetwork()==null || !getNetwork().isExternal()) ? + return (getNetwork() == null || !getNetwork().isExternal()) ? null : getNetwork().getProvidedBy().getProviderId(); } @@ -190,7 +190,7 @@ && validate(getRemoveExternalNetworkValidationResult()) private ValidationResult getRemoveExternalNetworkValidationResult() { ProviderNetwork providerNetwork = getNetwork().getProvidedBy(); - if (providerNetwork == null || !getParameters().isRemoveFromNetworkProvider()){ + if (providerNetwork == null || !getParameters().isRemoveFromNetworkProvider()) { return ValidationResult.VALID; } ProviderValidator providerValidator = new ProviderValidator(getProvider()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java index 95ee3074dfd..84eea8b0042 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java @@ -576,7 +576,7 @@ private static boolean labelRenamed(Network network, Network oldNetwork) { } private Guid getProviderId() { - return (getNetwork()==null || !getNetwork().isExternal()) ? + return (getNetwork() == null || !getNetwork().isExternal()) ? null : getNetwork().getProvidedBy().getProviderId(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java index 6832be2a1d1..7a801b8357d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java @@ -382,7 +382,7 @@ private void removeUnchangedBonds(List existingNics) { List createOrUpdateBonds = getParameters().getCreateOrUpdateBonds(); for (Iterator iterator = createOrUpdateBonds.iterator(); iterator.hasNext();) { - CreateOrUpdateBond bondFromRequest = iterator.next(); + CreateOrUpdateBond bondFromRequest = iterator.next(); Guid idOfBondFromRequest = bondFromRequest.getId(); boolean bondFromRequestIsNewBond = idOfBondFromRequest == null; @@ -417,7 +417,7 @@ private void removeUnchangedAttachments() { Map existingAttachmentsById = Entities.businessEntitiesById(getExistingAttachments()); for (Iterator iterator = getParameters().getNetworkAttachments().iterator(); iterator.hasNext();) { - NetworkAttachment attachmentFromRequest = iterator.next(); + NetworkAttachment attachmentFromRequest = iterator.next(); Guid idOfAttachmentFromRequest = attachmentFromRequest.getId(); boolean attachmentFromRequestIsNewAttachment = idOfAttachmentFromRequest == null; @@ -988,12 +988,12 @@ private List getClusterNetworks() { return clusterNetworks; } - private boolean isManagementNetworkChanged(List networksToConfigure){ + private boolean isManagementNetworkChanged(List networksToConfigure) { Network managementNetwork = managementNetworkUtil.getManagementNetwork(getClusterNetworks(), getClusterId()); String managementNetworkName = managementNetwork.getName(); for (HostNetwork network : networksToConfigure) { - if (managementNetworkName.equals(network.getNetworkName())){ + if (managementNetworkName.equals(network.getNetworkName())) { return true; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java index 1de7ffb21d7..2fa7a113876 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java @@ -181,15 +181,15 @@ protected ValidationResult validateBondModeVsNetworksAttachedToIt( Map hostInterfacesByNetworkName = NetworkUtils.hostInterfacesByNetworkName(existingInterfaces); - for (NetworkAttachment attachment : attachmentsToConfigure){ - if (!mustAttachementBeCheckedForBondMode(attachment, hostInterfacesByNetworkName)){ + for (NetworkAttachment attachment : attachmentsToConfigure) { + if (!mustAttachementBeCheckedForBondMode(attachment, hostInterfacesByNetworkName)) { continue; } CreateOrUpdateBond bondToCheck = createOrUpdateBondBusinessEntityMap.get(attachment.getNicName()); - if (bondToCheck == null){ + if (bondToCheck == null) { VdsNetworkInterface existingNetworkInterfaceForAttachement = existingInterfacesMap.get(attachment.getNicName()); - if(existingNetworkInterfaceForAttachement == null || !existingNetworkInterfaceForAttachement.isBond()){ + if (existingNetworkInterfaceForAttachement == null || !existingNetworkInterfaceForAttachement.isBond()) { continue; } bondToCheck = CreateOrUpdateBond.fromBond((Bond) existingNetworkInterfaceForAttachement); @@ -197,7 +197,7 @@ protected ValidationResult validateBondModeVsNetworksAttachedToIt( String networkLabel = networkBusinessEntityMap.get(attachment.getNetworkName()).getLabel(); ValidationResult validationResult = checkBondMode(bondToCheck, networkLabel, attachment.getNetworkName()); - if (!validationResult.isValid()){ + if (!validationResult.isValid()) { return validationResult; } } @@ -205,11 +205,11 @@ protected ValidationResult validateBondModeVsNetworksAttachedToIt( } private ValidationResult checkBondMode(CreateOrUpdateBond createOrUpdateBond, String networkLabel, String networkName) { - if (BondMode.isBondModeValidForVmNetwork(createOrUpdateBond.getBondOptions())){ + if (BondMode.isBondModeValidForVmNetwork(createOrUpdateBond.getBondOptions())) { return ValidationResult.VALID; } - if (networkLabel != null && isNicToConfigureContainTheLabel(createOrUpdateBond.getName(), networkLabel)){ + if (networkLabel != null && isNicToConfigureContainTheLabel(createOrUpdateBond.getName(), networkLabel)) { return new ValidationResult(EngineMessage.INVALID_BOND_MODE_FOR_BOND_WITH_LABELED_VM_NETWORK, ReplacementUtils.createSetVariableString(VAR_BOND_NAME, createOrUpdateBond.getName()), ReplacementUtils.createSetVariableString(VAR_LABEL, networkLabel), @@ -222,14 +222,14 @@ private ValidationResult checkBondMode(CreateOrUpdateBond createOrUpdateBond, St } private boolean mustAttachementBeCheckedForBondMode(NetworkAttachment attachment, - Map hostInterfacesByNetworkName){ + Map hostInterfacesByNetworkName) { Network network = networkBusinessEntityMap.get(attachment.getNetworkName()); String networkName = attachment.getNetworkName(); - if (!network.isVmNetwork()){ + if (!network.isVmNetwork()) { return false; } VdsNetworkInterface nic = hostInterfacesByNetworkName.get(networkName); - if (nic == null){ + if (nic == null) { return true; } NetworkImplementationDetails networkImplementationDetails = nic.getNetworkImplementationDetails(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfaceConfigurationMapper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfaceConfigurationMapper.java index 6ba55c94eaf..be80d5dd018 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfaceConfigurationMapper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/InterfaceConfigurationMapper.java @@ -90,7 +90,7 @@ private void calcBondsByName() { } private List filterNicsWithoutManagement(List vdsNetworkInterfaces) { - return filterInterfacesWithoutManagment(vdsNetworkInterfaces) + return filterInterfacesWithoutManagment(vdsNetworkInterfaces) .stream() .filter(noBondAndVlanPredicate()) .map(nic -> (Nic) nic) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllClusterNetworksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllClusterNetworksCommand.java index e77d24dbfc4..77e7d24d2c1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllClusterNetworksCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SyncAllClusterNetworksCommand.java @@ -76,9 +76,9 @@ protected void executeCommand() { public AuditLogType getAuditLogTypeValue() { switch (getActionState()) { case EXECUTE: - if (!getSucceeded()){ + if (!getSucceeded()) { return CLUSTER_SYNC_ALL_NETWORKS_START_ERROR; - } else if (!outOfSyncHostsExist()){ + } else if (!outOfSyncHostsExist()) { return CLUSTER_SYNC_NOTHING_TO_DO; } else { return CLUSTER_SYNC_ALL_NETWORKS_STARTED; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java index 10f73acf19a..6141ab60377 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java @@ -46,7 +46,7 @@ public UnmanagedNetworkValidator() { public ValidationResult validate(HostSetupNetworksParameters params, List existingInterfaces, - BusinessEntityMap networkBusinessEntityMap){ + BusinessEntityMap networkBusinessEntityMap) { ValidationResult result = validateRemovedUnmanagedNetworks(params.getRemovedUnmanagedNetworks(), existingInterfaces, networkBusinessEntityMap); if (!result.isValid()) { @@ -55,7 +55,7 @@ public ValidationResult validate(HostSetupNetworksParameters params, Set nicsWithUnmanagedNetworks = filterNicsWithUnmanagedNetworks( existingInterfaces, params.getRemovedUnmanagedNetworks()); - for (String nicWithUnmanagedNetwork : nicsWithUnmanagedNetworks){ + for (String nicWithUnmanagedNetwork : nicsWithUnmanagedNetworks) { result = validateLabels(nicWithUnmanagedNetwork, params.getLabels()); if (!result.isValid()) { return result; @@ -74,16 +74,16 @@ protected ValidationResult validateRemovedUnmanagedNetworks( Collection existingInterfaces, BusinessEntityMap networkBusinessEntityMap) { - for (String removedUnmanagedNetworkName : removedUnmanagedNetworks){ + for (String removedUnmanagedNetworkName : removedUnmanagedNetworks) { Network network = networkBusinessEntityMap.get(removedUnmanagedNetworkName); - if (network != null){ + if (network != null) { EngineMessage engineMessage = EngineMessage.REMOVED_UNMANAGED_NETWORK_IS_A_CLUSTER_NETWORK; return new ValidationResult(engineMessage, ReplacementUtils.createSetVariableString(NETWORK, removedUnmanagedNetworkName)); } ValidationResult result = validateNetworkIsAnUnmanagedNetworkOnHost(removedUnmanagedNetworkName, existingInterfaces); - if (!result.isValid()){ + if (!result.isValid()) { return result; } } @@ -95,10 +95,10 @@ private ValidationResult validateNetworkIsAnUnmanagedNetworkOnHost( String removedUnmanagedNetworkName, Collection existingInterfaces) { - for (VdsNetworkInterface existingInterface : existingInterfaces){ + for (VdsNetworkInterface existingInterface : existingInterfaces) { if (removedUnmanagedNetworkName.equals(existingInterface.getNetworkName()) && existingInterface.getNetworkImplementationDetails() != null && - !existingInterface.getNetworkImplementationDetails().isManaged()){ + !existingInterface.getNetworkImplementationDetails().isManaged()) { return ValidationResult.VALID; } } @@ -107,7 +107,7 @@ private ValidationResult validateNetworkIsAnUnmanagedNetworkOnHost( } ValidationResult validateLabels(String nicWithUnmanagedNetwork, Collection labels) { - for (NicLabel label : labels){ + for (NicLabel label : labels) { if (label.getNicName().equals(nicWithUnmanagedNetwork)) { return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_HOST_NETWORK_LABEL_ON_UNMANAGED_NETWORK, ReplacementUtils.createSetVariableString(LABEL, label.getName()), @@ -118,7 +118,7 @@ ValidationResult validateLabels(String nicWithUnmanagedNetwork, Collection networkAttachments) { - for (NetworkAttachment attachement:networkAttachments){ + for (NetworkAttachment attachement:networkAttachments) { if (attachement.getNicName().equals(nicWithUnmanagedNetwork)) { return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_HOST_NETWORK_ATTACHEMENT_ON_UNMANAGED_NETWORK, ReplacementUtils.createSetVariableString(NETWORK, attachement.getNetworkName()), @@ -128,10 +128,10 @@ ValidationResult validateAttachements(String nicWithUnmanagedNetwork, List filterNicsWithUnmanagedNetworks( List existingInterfaces, Collection removedUnmanagedNetworks){ + Set filterNicsWithUnmanagedNetworks( List existingInterfaces, Collection removedUnmanagedNetworks) { Set nicsWithUnmanagedNetworks = new HashSet<>(); - for(VdsNetworkInterface nic : existingInterfaces){ - if(nic.getNetworkImplementationDetails() != null && !nic.getNetworkImplementationDetails().isManaged()) { + for (VdsNetworkInterface nic : existingInterfaces) { + if (nic.getNetworkImplementationDetails() != null && !nic.getNetworkImplementationDetails().isManaged()) { if (!removedUnmanagedNetworks.contains(nic.getNetworkName())) { nicsWithUnmanagedNetworks.add(NetworkCommonUtils.stripVlan(nic)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java index 0a40554f7f6..1d1e48821bb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacsStorage.java @@ -125,7 +125,7 @@ Range getRangeWithAvailableMac() { private Range findRangeWithAvailableMac(int startIndex, int endIndex, int numberOfRanges) { - for(int i = startIndex; i < endIndex; i++) { + for (int i = startIndex; i < endIndex; i++) { Range range = ranges.get(i); boolean hasAvailableMacs = range.getAvailableCount() > 0; if (hasAvailableMacs) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounter.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounter.java index 9bcf6c742f9..2ec96dec861 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounter.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ObjectCounter.java @@ -10,7 +10,7 @@ * Associative array counting instances of given object. * @param class of instances being count. */ -class ObjectCounter implements Iterable{ +class ObjectCounter implements Iterable { private Map map = new HashMap<>(); private final boolean allowDuplicate; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/Range.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/Range.java index 6d4314fd13b..24e58b16d39 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/Range.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/Range.java @@ -24,7 +24,7 @@ class Range { public Range(LongRange range) { this.range = range; - long numberOfMacsLong = (range.getMaximumLong() - range.getMinimumLong()) + 1; + long numberOfMacsLong = (range.getMaximumLong() - range.getMinimumLong()) + 1; Validate.isTrue(numberOfMacsLong <= Integer.MAX_VALUE, String.format("Range too big; Range shouldn't be bigger than %1$s, but passed one " + "contains %2$s elements.", Integer.MAX_VALUE, numberOfMacsLong)); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java index cc899b2e607..e2b8d9bb4c7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java @@ -89,14 +89,14 @@ private List filterOutUnusedMacs(List macs) { @Override public String allocateNewMac() { String allocatedMacAddress = super.allocateNewMac(); - getStrategyForMacAllocation().forEach(e->e.releaseMacsInCaseOfRollback(Collections.singletonList(allocatedMacAddress))); + getStrategyForMacAllocation().forEach(e -> e.releaseMacsInCaseOfRollback(Collections.singletonList(allocatedMacAddress))); return allocatedMacAddress; } @Override public final List allocateMacAddresses(int numberOfAddresses) { List allocatedMacAddresses = super.allocateMacAddresses(numberOfAddresses); - getStrategyForMacAllocation().forEach(e->e.releaseMacsInCaseOfRollback(allocatedMacAddresses)); + getStrategyForMacAllocation().forEach(e -> e.releaseMacsInCaseOfRollback(allocatedMacAddresses)); return allocatedMacAddresses; } @@ -104,7 +104,7 @@ public final List allocateMacAddresses(int numberOfAddresses) { public final boolean addMac(String mac) { boolean added = super.addMac(mac); if (added) { - getStrategyForMacAllocation().forEach(e->e.releaseMacsInCaseOfRollback(Collections.singletonList(mac))); + getStrategyForMacAllocation().forEach(e -> e.releaseMacsInCaseOfRollback(Collections.singletonList(mac))); } return added; @@ -116,8 +116,8 @@ public List addMacs(List macs) { boolean atLeastOneAddedMac = notAddedMacs.size() < macs.size(); if (atLeastOneAddedMac) { - List addedMacs = macs.stream().filter(e->!notAddedMacs.contains(e)).collect(toList()); - getStrategyForMacAllocation().forEach(e->e.releaseMacsInCaseOfRollback(addedMacs)); + List addedMacs = macs.stream().filter(e -> !notAddedMacs.contains(e)).collect(toList()); + getStrategyForMacAllocation().forEach(e -> e.releaseMacsInCaseOfRollback(addedMacs)); } return notAddedMacs; @@ -214,7 +214,7 @@ private class UsingTxDecoratorState implements TransactionalStrategyState { @Override public void releaseMacsInCaseOfRollback(List macs) { - registerRollbackHandler((TransactionRollbackListener)() -> { + registerRollbackHandler((TransactionRollbackListener) () -> { log.debug("Rollback occurred, releasing macs {}.", macs); macPool.freeMacs(macs); }); @@ -222,7 +222,7 @@ public void releaseMacsInCaseOfRollback(List macs) { @Override public void releaseMacsOnCommit(List macs) { - registerRollbackHandler((TransactionSuccessListener)() -> { + registerRollbackHandler((TransactionSuccessListener) () -> { log.debug("Command succeeded, releasing macs {}.", macs); macPool.freeMacs(macs); }); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java index 37c594d8988..ce17b049fe8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java @@ -405,27 +405,27 @@ private void clearPassthroughData(String vfToUse) { } private void clearAddressIfPciSlotIsDuplicated(VmDevice vmDeviceToHotplug) { - if (searchForDuplicatesWithExistingVmDevices(vmDeviceToHotplug)){ + if (searchForDuplicatesWithExistingVmDevices(vmDeviceToHotplug)) { vmDeviceToHotplug.setAddress(""); } } - private boolean searchForDuplicatesWithExistingVmDevices(VmDevice vmDeviceToHotplug){ + private boolean searchForDuplicatesWithExistingVmDevices(VmDevice vmDeviceToHotplug) { String deviceAddress = vmDeviceToHotplug.getAddress(); - if (StringUtils.isEmpty(deviceAddress)){ + if (StringUtils.isEmpty(deviceAddress)) { return false; } Map addressMapToHotplug = StringMapUtils.string2Map(deviceAddress); List allVmDevices = vmDeviceDao.getVmDeviceByVmId(getVm().getId()); for (VmDevice vmDevice : allVmDevices) { - if (!vmDeviceToHotplug.getId().equals(vmDevice.getId())){ + if (!vmDeviceToHotplug.getId().equals(vmDevice.getId())) { Map deviceAddressMap = StringMapUtils.string2Map(vmDevice.getAddress()); boolean duplicatedAddress = deviceAddressMap.equals(addressMapToHotplug); boolean ambiguousInterfaceState = StringUtils.isEmpty(vmDevice.getAddress()) && vmDevice.isPlugged() && VmDeviceGeneralType.INTERFACE.equals(vmDevice.getType()); - if(duplicatedAddress || ambiguousInterfaceState) { + if (duplicatedAddress || ambiguousInterfaceState) { return true; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java index acccc39b7db..28deac662f9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java @@ -162,7 +162,7 @@ protected boolean validate() { Version compatibilityVersion = getVm().getClusterCompatibilityVersion(); VmNicValidator nicValidator = new VmNicValidator(getInterface(), compatibilityVersion, getVm().getOs()); if (!validate(nicValidator.isCompatibleWithOs()) - ||!validate(nicValidator.isNetworkSupportedByClusterSwitchType(getCluster())) + || !validate(nicValidator.isNetworkSupportedByClusterSwitchType(getCluster())) || !validate(nicValidator.profileValid(getVm().getClusterId())) || !validate(nicValidator.typeMatchesProfile()) || !validate(nicValidator.passthroughIsLinked()) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommand.java index cd5d8ae2baa..57a73f1f3c3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommand.java @@ -11,7 +11,7 @@ import org.ovirt.engine.core.dao.network.VmNicFilterParameterDao; public class RemoveVmNicFilterParameterCommand - extends AbstractVmNicFilterParameterCommand { + extends AbstractVmNicFilterParameterCommand { @Inject private VmNicFilterParameterDao vmNicFilterParameterDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterLiveCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterLiveCommand.java index c511fe987d7..885232e742e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterLiveCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterLiveCommand.java @@ -13,7 +13,7 @@ import org.ovirt.engine.core.dao.network.VmNicFilterParameterDao; public class RemoveVmNicFilterParameterLiveCommand - extends AbstractVmNicFilterParameterCommand { + extends AbstractVmNicFilterParameterCommand { @Inject private VmNicFilterParameterDao vmNicFilterParameterDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java index 39ff0560c30..fa42d522b25 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java @@ -189,7 +189,7 @@ private boolean updateHost() { setVdsId(getVm().getRunOnVds()); } - if (getRequiredAction() != null){ + if (getRequiredAction() != null) { switch (getRequiredAction()) { case PLUG: return activateOrDeactivateExistingNic(getInterface(), PlugAction.PLUG); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java index 2a06aa48038..becf658eaf7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/VnicProfileCommandBase.java @@ -35,15 +35,15 @@ protected VnicProfile getVnicProfile() { return getParameters().getVnicProfile(); } - protected void setNetworkFilterId(Guid networkFilterId){ + protected void setNetworkFilterId(Guid networkFilterId) { getVnicProfile().setNetworkFilterId(networkFilterId); } - protected Guid getNetworkId(){ + protected Guid getNetworkId() { return getNetwork().getId(); } - protected Guid getNetworkFilterId(){ + protected Guid getNetworkFilterId() { return getVnicProfile().getNetworkFilterId(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java index 997c3ef3717..f67ebbf8e56 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java @@ -72,7 +72,7 @@ public class PmHealthCheckManager implements BackendService { */ @PostConstruct private void initialize() { - if(Config.getValue(ConfigValues.PMHealthCheckEnabled)) { + if (Config.getValue(ConfigValues.PMHealthCheckEnabled)) { log.info("Start initializing {}", getClass().getSimpleName()); long pmHealthCheckInterval = Config. getValue(ConfigValues.PMHealthCheckIntervalInSec); executor.scheduleWithFixedDelay(this::pmHealthCheck, @@ -279,7 +279,7 @@ public void startHosts(List hostWithPMInStatusReboot) { } ActionReturnValue retValue = backend.get().runInternalAction(ActionType.RestartVds, restartVdsCommand.getParameters()); - if (retValue!= null && retValue.getSucceeded()) { + if (retValue != null && retValue.getSucceeded()) { log.info("Host '{}' was started successfully by PM Health Check Manager", host.getName()); } else { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java index 3a2dcef4bf0..c849826ec05 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SingleAgentFenceActionExecutor.java @@ -30,7 +30,7 @@ *
  • Usage of {@code FenceAgentExecutor} to execute "simple" fence actions
  • * */ -public class SingleAgentFenceActionExecutor implements FenceActionExecutor{ +public class SingleAgentFenceActionExecutor implements FenceActionExecutor { private static final Logger log = LoggerFactory.getLogger(SingleAgentFenceActionExecutor.class); private AuditLogDirector auditLogDirector; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java index 247a4834998..37f57bfe46b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java @@ -104,7 +104,7 @@ private boolean executeSshSoftFencingCommand(String version) { cmdErr); log.debug("Exception", ex); } - } catch(IOException e) { + } catch (IOException e) { log.error("IOException", e); } return ret; @@ -124,10 +124,10 @@ private boolean checkIfHostBecomeUp() { // and another host will be selected for the SPM role. long graceTime = TimeUnit.SECONDS.toMillis( Config.getValue(ConfigValues.TimeoutToResetVdsInSeconds)); - long passedTime=0; + long passedTime = 0; log.info("Waiting to host {} {} seconds to become up after soft fencing execution", vdsManager.getCopyVds().getHostName(), - graceTime/100); + graceTime / 100); while (passedTime <= graceTime) { if (vdsManager.getCopyVds().getStatus() == VDSStatus.Up) { // host became Up during grace period diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java index 38cd400ae20..4007be3027a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java @@ -267,7 +267,7 @@ private boolean isConnectivityBrokenThresholdReached(VDS vds) { double hostsNumber = hosts.size(); double hostsWithBrokenConnectivityNumber = hosts.stream().filter(h -> h.getStatus() == VDSStatus.Connecting || h.getStatus() == VDSStatus.NonResponsive).count(); - percents = (int) ((hostsWithBrokenConnectivityNumber/hostsNumber)*100); + percents = (int) ((hostsWithBrokenConnectivityNumber / hostsNumber) * 100); result = percents >= cluster.getFencingPolicy().getHostsWithBrokenConnectivityThreshold(); } if (result) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java index 7dd8b83b44f..fa985e7800d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/AddProfileCommandBase.java @@ -27,7 +27,7 @@ protected void executeCommand() { getProfileDao().save(getParameters().getProfile()); getReturnValue().setActionReturnValue(getParameters().getProfile().getId()); - if(getParameters().isAddPermissions()) { + if (getParameters().isAddPermissions()) { addPermissions(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java index 0e49e46d6c3..e552f15602a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelper.java @@ -61,7 +61,7 @@ public ValidationResult setAndValidateCpuProfile(VmBase vmBase, Guid userId) { return assignFirstCpuProfile(vmBase, userId); } - Guid clusterId = vmBase.getClusterId(); + Guid clusterId = vmBase.getClusterId(); if (clusterId == null) { return new ValidationResult(EngineMessage.ACTION_TYPE_CPU_PROFILE_CLUSTER_NOT_PROVIDED); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java index 8ce2cdcaa44..430d7d57e66 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderValidator.java @@ -127,7 +127,7 @@ public ValidationResult validateRemoveProvider() { * Validate that this action can be performed for read only providers */ public ValidationResult validateReadOnlyActions() { - if (provider.getType() != ProviderType.EXTERNAL_NETWORK){ + if (provider.getType() != ProviderType.EXTERNAL_NETWORK) { return ValidationResult.VALID; } boolean isReadOnly = ((OpenstackNetworkProviderProperties) provider.getAdditionalProperties()).getReadOnly(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/UnmanagedNetworkProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/UnmanagedNetworkProviderProxy.java index 4bf48022a96..c1744bd22a5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/UnmanagedNetworkProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/UnmanagedNetworkProviderProxy.java @@ -40,7 +40,7 @@ public String add(Network network) { } @Override - public void remove(String id) {} + public void remove(String id) { } @Override public List getAll() { @@ -85,10 +85,10 @@ public Map allocate(Network network, VnicProfile vnicProfile, Vm } @Override - public void deallocate(VmNic nic) {} + public void deallocate(VmNic nic) { } @Override - public void testConnection() {} + public void testConnection() { } @Override public ProviderValidator getProviderValidator() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java index c9d38dfc1d5..2d8ec0b396b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java @@ -226,7 +226,7 @@ public Map allocate( Network network, VnicProfile vnicProfile, VmNic nic, VDS host, boolean ignoreSecurityGroupsOnUpdate, String hostBindingId) { - if (hostBindingId==null) { + if (hostBindingId == null) { hostBindingId = host.getHostName(); log.warn("Host binding id for external network {} on host {} is null, using host id {} to allocate vNIC " + " {} instead. Please provide an after_get_caps hook for the plugin type {} on host {}", @@ -374,7 +374,7 @@ private static class ApiRootResponse { @Override public Provider

    getProvider() { - return (Provider

    )super.getProvider(); + return (Provider

    ) super.getProvider(); } private R execute(OpenStackRequest request) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java index 08e9a29d4ce..32a54d9e586 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java @@ -50,12 +50,12 @@ public void removeSubnet(String id) { super.removeSubnet(id); } - private boolean isReadOnly(){ + private boolean isReadOnly() { return getProvider().getAdditionalProperties().getReadOnly(); } private void testProviderIsNotReadOnly() { - if (isReadOnly()){ + if (isReadOnly()) { throw new EngineException(EngineError.NO_IMPLEMENTATION); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/KeystoneV3TokenProvider.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/KeystoneV3TokenProvider.java index 07121fb193e..96af907887a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/KeystoneV3TokenProvider.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/KeystoneV3TokenProvider.java @@ -26,7 +26,7 @@ public void expireToken() { @Override public String getToken() { if (token == null) { - token = createToken(); + token = createToken(); } return token; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java index 4ff67960c1c..04c5e0b6358 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java @@ -103,7 +103,7 @@ public static OpenStackImageProviderProxy getFromStorageDomainId(Guid storageDom @Override protected Glance getClient() { if (client == null) { - client = new Glance(getProvider().getUrl() + API_VERSION, new CustomizedRESTEasyConnector()); + client = new Glance(getProvider().getUrl() + API_VERSION, new CustomizedRESTEasyConnector()); if (getProvider().isRequiringAuthentication()) { setClientTokenProvider(client); } @@ -170,7 +170,7 @@ public List getAllImagesAsRepoImages(Integer listSize, Integer totalL repoImage.setLastRefreshed(currentTime); repoImages.add(repoImage); } - } while(images.getList().size() >= listSize && + } while (images.getList().size() >= listSize && totalListSize != null && repoImages.size() < totalListSize); return repoImages; @@ -316,7 +316,7 @@ public String getImageUrl(Version compatibilityVersion, String id) { } private String getImageUrl(String apiVersion, String id) { - return removeTrailingSlash(getProvider().getUrl()) + apiVersion + "/images/" + id; + return removeTrailingSlash(getProvider().getUrl()) + apiVersion + "/images/" + id; } private String removeTrailingSlash(String s) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java index 3bf5012ca1a..c69b9a09e5f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java @@ -8,7 +8,7 @@ public class InvalidQuotaParametersException extends RuntimeException { public InvalidQuotaParametersException() { } - public InvalidQuotaParametersException(String errorStr){ + public InvalidQuotaParametersException(String errorStr) { super(errorStr); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java index a80d8d04bf8..6c1548104a9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java @@ -2,7 +2,7 @@ import org.ovirt.engine.core.compat.Guid; -public abstract class QuotaConsumptionParameter implements Cloneable{ +public abstract class QuotaConsumptionParameter implements Cloneable { private Guid quotaGuid; private QuotaAction quotaAction; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java index bc72f28b86b..b8b8995e836 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java @@ -379,7 +379,7 @@ private synchronized void updateQuotaCacheImpl() { lock.writeLock().unlock(); } long timeEnd = System.currentTimeMillis(); - log.info("Quota Cache updated. ({} msec)", timeEnd-timeStart); + log.info("Quota Cache updated. ({} msec)", timeEnd - timeStart); } public boolean isCacheUpdateNeeded() { @@ -388,14 +388,14 @@ public boolean isCacheUpdateNeeded() { lock.readLock().lock(); try { - for(Map quotaMap : storagePoolQuotaMap.values()) { + for (Map quotaMap : storagePoolQuotaMap.values()) { cacheCount += quotaMap.size(); } } finally { lock.readLock().unlock(); } - return cacheCount < quotaCount * Config. getValue(ConfigValues.MinimumPercentageToUpdateQuotaCache)/100; + return cacheCount < quotaCount * Config. getValue(ConfigValues.MinimumPercentageToUpdateQuotaCache) / 100; } public boolean isVmStatusQuotaCountable(VMStatus status) { @@ -464,7 +464,7 @@ private boolean consumeQuotaParameters(List parameter // Validate that all requests satisfy the quota limits for (Request request : requests.get()) { ValidationResult validation = request.validate(hardEnforcement, auditLogger); - if(!validation.isValid()) { + if (!validation.isValid()) { command.getReturnValue().getValidationMessages().addAll(validation.getMessagesAsStrings()); return false; } @@ -494,7 +494,7 @@ private Optional> createRequests(List p for (QuotaConsumptionParameter param: parameters) { // Use default quota if the id is empty - if(Guid.isNullOrEmpty(param.getQuotaGuid())) { + if (Guid.isNullOrEmpty(param.getQuotaGuid())) { param.setQuotaGuid(storagePoolDefaultQuotaIdMap.get(command.getStoragePoolId())); } @@ -555,7 +555,7 @@ private ValidationResult validateAndAddToClusterRequests(QuotaClusterConsumption return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_QUOTA_IS_NOT_VALID); } - Pair key = quota.isGlobalClusterQuota()? + Pair key = quota.isGlobalClusterQuota() ? new Pair<>(quota.getId(), null) : new Pair<>(quota.getId(), param.getClusterId()); @@ -668,7 +668,7 @@ public Quota getQuota() { /** * Request for cluster quota */ - private class ClusterRequest extends Request{ + private class ClusterRequest extends Request { private QuotaCluster quotaCluster; private int coresRequest = 0; private long memoryRequestMB = 0L; @@ -702,7 +702,7 @@ public ValidationResult validate(boolean hardEnforcement, QuotaManagerAuditLogge } // Valid if the request releases quota, not consumes it. - if (coresRequest <=0 && memoryRequestMB <= 0) { + if (coresRequest <= 0 && memoryRequestMB <= 0) { return ValidationResult.VALID; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java index b29144861de..65ef0f5391c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java @@ -88,7 +88,7 @@ public void logClusterGraceExceeded(String quotaName, addClusterRequested(cpuRequestPercentage, memRequestPercentage); auditLogDirector.log(auditLogable, hardEnforcement ? - AuditLogType.USER_EXCEEDED_QUOTA_CLUSTER_GRACE_LIMIT: + AuditLogType.USER_EXCEEDED_QUOTA_CLUSTER_GRACE_LIMIT : AuditLogType.USER_EXCEEDED_QUOTA_CLUSTER_GRACE_LIMIT_PERMISSIVE_MODE); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java index 9626ae5fa3a..d97fd9649e2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/HaReservationHandling.java @@ -91,7 +91,7 @@ private boolean findReplacementForHost(Cluster cluster, VDS host, for (VM vm : vmList) { int curVmMemSize = 0; - if(vm.getUsageMemPercent() != null) { + if (vm.getUsageMemPercent() != null) { curVmMemSize = (int) Math.round(vm.getMemSizeMb() * (vm.getUsageMemPercent() / 100.0)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/OvirtGlusterSchedulingService.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/OvirtGlusterSchedulingService.java index 61b72690e9a..bdd4792ad19 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/OvirtGlusterSchedulingService.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/OvirtGlusterSchedulingService.java @@ -134,7 +134,7 @@ public void programmaticTimeout(Timer config) { clazz = Class.forName(job.getJobClassName()); } methodToRun = clazz.getDeclaredMethod(job.getJobName(), (Class[]) parameterTypes); - if(methodToRun == null) { + if (methodToRun == null) { log.error("could not find the required method '{}' on instance of {}", job.getJobName(), clazz.getClass().getSimpleName()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingContext.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingContext.java index 54b88994b31..0ffda388141 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingContext.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingContext.java @@ -47,7 +47,7 @@ public SchedulingContext(Cluster cluster, Map policyParameters) this(cluster, policyParameters, false, false); } - public Cluster getCluster() { + public Cluster getCluster() { return cluster; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java index b95f13045a6..8bbb6d5a614 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java @@ -291,7 +291,7 @@ private void loadPolicyUnits() { try { PolicyUnitImpl unit = InternalPolicyUnits.instantiate(unitType, getPendingResourceManager()); policyUnits.put(unit.getGuid(), Injector.injectMembers(unit)); - } catch (Exception e){ + } catch (Exception e) { log.error("Could not instantiate a policy unit {}.", unitType.getName(), e); } } @@ -300,7 +300,7 @@ private void loadPolicyUnits() { try { PolicyUnitImpl unit = InternalPolicyUnits.instantiate(mandatoryUnitType, getPendingResourceManager()); mandatoryFilters.add(Injector.injectMembers(unit)); - } catch (Exception e){ + } catch (Exception e) { log.error("Could not instantiate a policy unit {}.", mandatoryUnitType.getName(), e); } } @@ -539,7 +539,7 @@ private void updateHostNumaNodes(VDS host, Map numaConsumption, List dedicatedCpus) { + private void addPendingResources(VM vm, VDS host, Map numaConsumption, List dedicatedCpus) { int numOfCpus = VmCpuCountHelper.getRuntimeNumOfCpu(vm, host); int numOfCores = VmCpuCountHelper.getRuntimeNumOfCores(vm, host); Guid hostId = host.getId(); @@ -578,7 +578,7 @@ private void addPendingResources(VM vm, VDS host, Map> vmNumaRequirements(List vmGroup, VDS host) { + private Map> vmNumaRequirements(List vmGroup, VDS host) { List filteredVms = vmGroup.stream() .filter(vm -> vm.getvNumaNodeList().stream().map(VmNumaNode::getNumaTuneMode) .allMatch(tune -> tune != NumaTuneMode.PREFERRED)) @@ -786,7 +786,7 @@ private Optional selectBestHost(List vmGroup, runnableHosts = availableVdsList; } - switch (runnableHosts.size()){ + switch (runnableHosts.size()) { case 0: // no runnable hosts found, nothing found return Optional.empty(); @@ -1182,10 +1182,10 @@ public Set positiveAffinityClosure(Cluster cluster, List vms) { } public boolean isHostAffinityMoreImportantThanVmAffinity(Cluster cluster) { - Guid hostAffinityPolicyUnitId = Guid.createGuidFromString( + Guid hostAffinityPolicyUnitId = Guid.createGuidFromString( VmToHostAffinityWeightPolicyUnit.class.getAnnotation(SchedulingUnit.class).guid()); - Guid vmAffinityPolicyUnitId = Guid.createGuidFromString( + Guid vmAffinityPolicyUnitId = Guid.createGuidFromString( VmAffinityWeightPolicyUnit.class.getAnnotation(SchedulingUnit.class).guid()); ClusterPolicy policy = policyMap.get(cluster.getClusterPolicyId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java index a68b56a449f..a3f9ba34486 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesEnforcer.java @@ -123,7 +123,7 @@ private Pair, Iterable> getCandidateVmsFromVmsToHostAffinit .collect(Collectors.toList()); if (allVmToHostsAffinityGroups.isEmpty()) { - return new Pair<>(IteratorUtils::emptyIterator, IteratorUtils::emptyIterator); + return new Pair<>(IteratorUtils::emptyIterator, IteratorUtils::emptyIterator); } List vmIds = allVmToHostsAffinityGroups.stream() @@ -363,7 +363,7 @@ private Map> groupVmsByHostFiltered(Cache cache, List vms Set removedHosts = new HashSet<>(); Map> res = new HashMap<>(); - for(Guid vmId : vms) { + for (Guid vmId : vms) { VM vm = cache.getVm(vmId); Guid host = vm.getRunOnVds(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java index d4d7891f553..6fbaa0f255b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/arem/AffinityRulesUtils.java @@ -76,11 +76,11 @@ public static Set> getUnifiedPositiveAffinityGroups(List mergedGroup = new HashSet<>(); - for(Guid id : ag.getVmIds()) { + for (Guid id : ag.getVmIds()) { // Get the current groups VM(id) belongs to Set existingGroup = vmIndex.get(id); @@ -114,7 +114,7 @@ public static Set> getUnifiedPositiveAffinityGroups(List setsToAffinityGroups(Set> uag) { List output = new ArrayList<>(uag.size()); - for(Set s : uag) { + for (Set s : uag) { AffinityGroup temp = new AffinityGroup(); temp.setVmAffinityRule(EntityAffinityRule.POSITIVE); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddVmLabelToAffinityGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddVmLabelToAffinityGroupCommand.java index 60b2833beb0..0a7c2155db5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddVmLabelToAffinityGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/AddVmLabelToAffinityGroupCommand.java @@ -9,7 +9,7 @@ import org.ovirt.engine.core.dao.scheduling.AffinityGroupDao; public class AddVmLabelToAffinityGroupCommand - extends EditAffinityGroupCommand{ + extends EditAffinityGroupCommand { @Inject private AffinityGroupDao affinityGroupDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java index 480e10ad566..1306bceec8f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/ClusterPolicyCRUDCommand.java @@ -52,7 +52,7 @@ protected boolean checkAddEditValidations() { // check filter policy units if (getClusterPolicy().getFilters() != null) { for (Guid filterId : getClusterPolicy().getFilters()) { - if(isPolicyUnitExists(filterId, existingPolicyUnits)) { + if (isPolicyUnitExists(filterId, existingPolicyUnits)) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_CLUSTER_POLICY_DUPLICATE_POLICY_UNIT); } PolicyUnitImpl policyUnitImpl = map.get(filterId); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java index b7338d85b1d..facdc31c543 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/commands/RemoveExternalPolicyUnitCommand.java @@ -26,7 +26,7 @@ public RemoveExternalPolicyUnitCommand(RemoveExternalPolicyUnitParameters parame @Override protected boolean validate() { - if(!schedulingManager.getPolicyUnitsMap().containsKey(getPolicyUnitId())){ + if (!schedulingManager.getPolicyUnitsMap().containsKey(getPolicyUnitId())) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_CLUSTER_POLICY_UNKNOWN_POLICY_UNIT); } List clusterPoliciesNames = diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java index 2a66b7a2939..75ca1523739 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerObjectBuilder.java @@ -61,7 +61,7 @@ private static Object populateCommonFields(Object xmlRpcStruct, SchedulerResult if (result.getResultCode() != RESULT_OK) { plugin_errors = (Map) castedResult.get("plugin_errors"); - errors = (Object[])castedResult.get("errors"); + errors = (Object[]) castedResult.get("errors"); if (plugin_errors != null) { for (Map.Entry entry: plugin_errors.entrySet()) { @@ -74,8 +74,8 @@ private static Object populateCommonFields(Object xmlRpcStruct, SchedulerResult if (errors != null) { for (Object msg: errors) { - auditLogExternalSchedulerError((String)msg); - result.addError((String)msg); + auditLogExternalSchedulerError((String) msg); + result.addError((String) msg); } } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java index 85f595250f7..52349ea6d88 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscovery.java @@ -38,7 +38,7 @@ public class ExternalSchedulerDiscovery { @Inject private AuditLogDirector auditLogDirector; - protected ExternalSchedulerDiscovery() {} + protected ExternalSchedulerDiscovery() { } /** * Discover external schedulers and process its policy units. This operation may take time and is recommended to run @@ -99,7 +99,7 @@ private void markExternalPoliciesAsDisabled(List units) { } } - public void markAllExternalPoliciesAsDisabled(){ + public void markAllExternalPoliciesAsDisabled() { markExternalPoliciesAsDisabled(policyUnitDao.getAll()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryUnit.java index 8fcaa3b588e..7216f4d2b77 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerDiscoveryUnit.java @@ -1,6 +1,6 @@ package org.ovirt.engine.core.bll.scheduling.external; -public class ExternalSchedulerDiscoveryUnit{ +public class ExternalSchedulerDiscoveryUnit { private String name; private String description; private String regex; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java index 7a17e5ea51c..d256c860301 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/FilteringResult.java @@ -12,7 +12,7 @@ public void addHost(Guid host) { possibleHosts.add(host); } - public List getHosts(){ + public List getHosts() { return possibleHosts; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java index e2d040a2aae..85267e21315 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManager.java @@ -154,7 +154,7 @@ public void addPending(PendingResource resource) { */ public List pendingHostResources(Guid host, Class type) { return collectResources(resourcesByHost, host, res -> res.getClass().equals(type)).stream() - .map(r -> (T)r) + .map(r -> (T) r) .collect(Collectors.toList()); } @@ -166,7 +166,7 @@ public List pendingHostResources(Guid host, Class */ public List pendingVmResources(Guid vm, Class type) { return collectResources(resourcesByVm, vm, res -> res.getClass().equals(type)).stream() - .map(r -> (T)r) + .map(r -> (T) r) .collect(Collectors.toList()); } @@ -191,7 +191,7 @@ private static List collectResources(Map T getExactPendingResource(T template) { - return (T)pendingResources.get(template); + return (T) pendingResources.get(template); } /** @@ -203,7 +203,7 @@ public Iterable pendingResources(Class type) { List list = new ArrayList<>(); for (PendingResource resource: pendingResources.values()) { if (resource.getClass().equals(type)) { - list.add((T)resource); + list.add((T) resource); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java index 9f238c984bb..75f8a541159 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/pending/PendingVM.java @@ -42,7 +42,7 @@ public static Set collectForHost(PendingResourceManager manager, Guid host } public static Guid getScheduledHost(PendingResourceManager manager, VM vm) { - PendingVM template = new PendingVM((Guid)null, vm); + PendingVM template = new PendingVM((Guid) null, vm); PendingVM pending = manager.getExactPendingResource(template); return pending == null ? null : pending.getHost(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java index 99c354978e5..9c821d74dee 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EmulatedMachineFilterPolicyUnit.java @@ -49,7 +49,7 @@ public List filter(SchedulingContext context, List hosts, VM vm, PerHo /* find compatible hosts */ for (VDS host : hosts) { String supportedEmulatedMachines = host.getSupportedEmulatedMachines(); - if(StringUtils.isNotEmpty(supportedEmulatedMachines)) { + if (StringUtils.isNotEmpty(supportedEmulatedMachines)) { if (Arrays.asList(supportedEmulatedMachines.split(",")).contains(requiredEmulatedMachine)) { hostsToRunOn.add(host); log.debug("Host {} wasn't filtered out as it supports the VM required emulated machine ({})", diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java index fd1ace02e23..dd410e73b48 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionCPUWeightPolicyUnit.java @@ -98,7 +98,7 @@ private int calcAddedSharedVmsLoad(VDS vds, List vmGroup) { .filter(vm -> !vds.getId().equals(vm.getRunOnVds())) .filter(vm -> !vm.getCpuPinningPolicy().isExclusive()) // If the VM is running, use its current CPU load, otherwise use the config value - .mapToInt(vm -> vm.getRunOnVds() != null && vm.getStatisticsData() != null && vm.getUsageCpuPercent() != null ? + .mapToInt(vm -> vm.getRunOnVds() != null && vm.getStatisticsData() != null && vm.getUsageCpuPercent() != null ? vm.getUsageCpuPercent() * VmCpuCountHelper.getRuntimeNumOfCpu(vm, vds) : vcpuLoadPerCore * VmCpuCountHelper.getRuntimeNumOfCpu(vm, vds)) .sum(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java index c2e09a644f3..f849f485e15 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java @@ -33,7 +33,7 @@ public PinToHostPolicyUnit(PolicyUnit policyUnit, public List filter(SchedulingContext context, List hosts, VM vm, PerHostMessages messages) { if (vm.getMigrationSupport() == MigrationSupport.PINNED_TO_HOST) { // host has been specified for pin to host. - if(vm.getDedicatedVmForVdsList().size() > 0) { + if (vm.getDedicatedVmForVdsList().size() > 0) { List dedicatedHostsList = new LinkedList<>(); for (VDS host : hosts) { if (vm.getDedicatedVmForVdsList().contains(host.getId())) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java index f39a2f32202..dfef2f6bd3a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java @@ -77,7 +77,7 @@ public PowerSavingBalancePolicyUnit(PolicyUnit policyUnit, public List balance(Cluster cluster, List hosts, Map parameters) { - final List migrationRule = super.balance(cluster, hosts, parameters); + final List migrationRule = super.balance(cluster, hosts, parameters); List allHosts = vdsDao.getAllForCluster(cluster.getId()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java index 20f9da22201..be9e7584424 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingCPUWeightPolicyUnit.java @@ -59,7 +59,7 @@ public List> score(SchedulingContext context, List host } // Using negative score - int score = -(int)Math.round(calcHostScore(vmGroup, cpuLoadHelper, 0)); + int score = -(int) Math.round(calcHostScore(vmGroup, cpuLoadHelper, 0)); scores.add(new Pair<>(vds.getId(), score)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java index be00f0a0bb3..652d069bbd7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingMemoryWeightPolicyUnit.java @@ -99,7 +99,7 @@ private int calcHostScore(float hostSchedulingMem, float maxMemory, float lowMem } // Scores are in the interval [1, MaxSchedulerWeight] - return (int)((hostSchedulingMem / maxMemory) * (getMaxSchedulerWeight() - 1)) + 1; + return (int) ((hostSchedulingMem / maxMemory) * (getMaxSchedulerWeight() - 1)) + 1; } private float getMaxMemoryOfVdsInCluster(List hosts) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java index 7d9e145ef7e..b459725c8e9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java @@ -148,7 +148,7 @@ private Set getAcceptableHosts(List hosts, .map(VM::getRunOnVds) .collect(Collectors.toSet()); - Supplier vmNames = new MemoizingSupplier<>(() -> getVmNames(vmGroup));// Compute the intersection of hosts with positive and negative affinity and report that + Supplier vmNames = new MemoizingSupplier<>(() -> getVmNames(vmGroup)); // Compute the intersection of hosts with positive and negative affinity and report that // contradicting rules to the log unacceptableHosts.retainAll(acceptableHosts); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/AffinityGroupsQueryBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/AffinityGroupsQueryBase.java index 552765891f2..fe553929a48 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/AffinityGroupsQueryBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/queries/AffinityGroupsQueryBase.java @@ -53,7 +53,7 @@ protected void checkBrokenGroups(List groups) { for (AffinityGroup group : groups) { Set vmIds = AffinityValidator.unpackAffinityGroupVmsFromLabels(group, labelsMap); - List runningVms = vmIds.stream() + List runningVms = vmIds.stream() .map(runningVmsMap::get) .filter(Objects::nonNull) .collect(Collectors.toList()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java index 1c8cf6bad8e..5e404cfee50 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/FindVmAndDestinations.java @@ -53,7 +53,7 @@ public List invoke(List sourceHosts, VmDao vmDao, ResourceManager resourceManager) { - Map> vmsForHost = getMigratableVmsRunningOnHosts(vmDao, + Map> vmsForHost = getMigratableVmsRunningOnHosts(vmDao, sourceHosts.stream().map(VDS::getId).collect(Collectors.toList())); List results = new ArrayList<>(); @@ -64,12 +64,12 @@ public List invoke(List sourceHosts, migratableVms.forEach(vm -> vm.setStatisticsData(resourceManager.getVmManager(vm.getId(), false).getStatistics())); migratableVms.sort(VmCpuUsageComparator.INSTANCE); - for (VM vm : migratableVms){ + for (VM vm : migratableVms) { // Check if vm not over utilize memory or CPU of destination hosts List validDestinationHosts = getValidHosts( destinationHosts, cluster, vm, highCpuUtilization, requiredMemory); - if (!validDestinationHosts.isEmpty()){ + if (!validDestinationHosts.isEmpty()) { // Add the current host, it is possible it is the best host after all, // because the balancer does not know about affinity for example validDestinationHosts.add(sourceHost); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java index 0e4b4165d61..ffbe8be66d7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/utils/VdsCpuUnitPinningHelper.java @@ -163,7 +163,7 @@ private List allocateDedicatedCpus(List cpuTopology, VM int amountOfVSocketsInPSockets = Integer.MAX_VALUE; if (!vm.getvNumaNodeList().isEmpty()) { int highestAmountOfvNumaNodesInSocket = getVirtualNumaNodesInSocket(cpuTopology, vm, hostId, cpusInChosenSocket.get(0).getSocket()); - int vNumaNodesInVirtualSocket = (int) Math.ceil((float)vm.getvNumaNodeList().size() / (float)vm.getNumOfSockets()); + int vNumaNodesInVirtualSocket = (int) Math.ceil((float) vm.getvNumaNodeList().size() / (float) vm.getNumOfSockets()); amountOfVSocketsInPSockets = highestAmountOfvNumaNodesInSocket / vNumaNodesInVirtualSocket; } // coreCount is based on the VM topology @@ -212,7 +212,7 @@ private List allocateIsolatedThreadsCpus(List cpuTopolog int amountOfVSocketsInPSockets = Integer.MAX_VALUE; if (!vm.getvNumaNodeList().isEmpty()) { int highestAmountOfvNumaNodesInSocket = getVirtualNumaNodesInSocket(cpuTopology, vm, hostId, cpusInChosenSocket.get(0).getSocket()); - int vNumaNodesInVirtualSocket = (int) Math.ceil((float)vm.getvNumaNodeList().size() / (float)vm.getNumOfSockets()); + int vNumaNodesInVirtualSocket = (int) Math.ceil((float) vm.getvNumaNodeList().size() / (float) vm.getNumOfSockets()); amountOfVSocketsInPSockets = highestAmountOfvNumaNodesInSocket / vNumaNodesInVirtualSocket; } // coreCount is based on the VM topology @@ -257,7 +257,7 @@ private void releaseDedicatedCpu(Guid vmId, List cpusToBeAllocated) private void releaseIsolateThreadsCpu(Guid vmId, List cpusToBeAllocated) { VdsCpuUnit cpuUnit = cpusToBeAllocated.get(cpusToBeAllocated.size() - 1); - int coreId = cpuUnit.getCore(); + int coreId = cpuUnit.getCore(); int socketId = cpuUnit.getSocket(); List cpusToRemove = getCpusInCore(getCoresInSocket(cpusToBeAllocated, socketId), coreId); cpusToRemove.forEach(vdsCpuUnit -> { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java index dc13c239bfc..fb498f2c66a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateSnapshotForVmCommand.java @@ -394,7 +394,7 @@ private boolean performLiveSnapshot(final Snapshot snapshot) { } private CreateSnapshotForVmParameters createLiveSnapshotParameters(final Snapshot snapshot) { - CreateSnapshotForVmParameters params = new CreateSnapshotForVmParameters(); + CreateSnapshotForVmParameters params = new CreateSnapshotForVmParameters(); params.setVmId(getParameters().getVmId()); params.setSnapshot(snapshot); params.setSaveMemory(getParameters().isSaveMemory()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java index a37c7b75f50..75f57cbd6e9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskCommandBase.java @@ -146,7 +146,7 @@ protected void syncChildCommandList(RemoveSnapshotSingleDiskParameters parameter .map(CommandEntity::getId) .collect(Collectors.toList()); if (childCommandIds.size() != parameters.getChildCommands().size()) { - parameters.getChildCommands().put(parameters.getCommandStep(), childCommandIds.get(childCommandIds.size()-1)); + parameters.getChildCommands().put(parameters.getCommandStep(), childCommandIds.get(childCommandIds.size() - 1)); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java index 685db6be836..19aebe7d9c6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java @@ -597,7 +597,7 @@ protected void restoreSnapshotAndRemoveObsoleteSnapshots(Snapshot targetSnapshot && image.getDiskStorageType() != DiskStorageType.MANAGED_BLOCK_STORAGE) { imagesToRestore.add(image); } else { - List cinderDiskFromPreviewSnapshot = intersection.stream().filter(diskImage-> + List cinderDiskFromPreviewSnapshot = intersection.stream().filter(diskImage -> diskImage.getId().equals(image.getId())).collect(Collectors.toList()); if (!cinderDiskFromPreviewSnapshot.isEmpty()) { imagesToRestore.add(cinderDiskFromPreviewSnapshot.get(0)); @@ -620,13 +620,13 @@ protected void restoreSnapshotAndRemoveObsoleteSnapshots(Snapshot targetSnapshot // Set the active snapshot's images as target images for restore, because they are what we keep. getParameters().setImages(imagesFromActiveSnapshot); imagesFromActiveSnapshot.forEach(image -> { - List cinderDiskFromPreviewSnapshot = imagesFromPreviewSnapshot.stream().filter(diskImage-> + List cinderDiskFromPreviewSnapshot = imagesFromPreviewSnapshot.stream().filter(diskImage -> diskImage.getId().equals(image.getId())).collect(Collectors.toList()); if (!cinderDiskFromPreviewSnapshot.isEmpty()) { if (image.getDiskStorageType() == DiskStorageType.IMAGE || image.getDiskStorageType() == DiskStorageType.MANAGED_BLOCK_STORAGE) { imagesToRestore.add(image); - } else if (image.getDiskStorageType() == DiskStorageType.CINDER){ + } else if (image.getDiskStorageType() == DiskStorageType.CINDER) { CinderDisk cinderVolume = getInitialCinderVolumeToDelete(image); if (cinderVolume != null) { imagesToRestore.add(cinderVolume); @@ -733,7 +733,7 @@ private List getRedundantVolumesToDeleteAfterCommitSnapshot(Guid diskId, S private Set getCriticalSnapshotsChain(List imagesFromActiveSnapshot, List cinderImagesForPreviewedSnapshot) { Set criticalSnapshotsChain = new HashSet<>(); for (DiskImage image : cinderImagesForPreviewedSnapshot) { - List cinderDiskFromSnapshot = imagesFromActiveSnapshot.stream().filter(diskImage-> + List cinderDiskFromSnapshot = imagesFromActiveSnapshot.stream().filter(diskImage -> diskImage.getId().equals(image.getId())).collect(Collectors.toList()); for (DiskImage diskImage : diskImageDao.getAllSnapshotsForLeaf(cinderDiskFromSnapshot.get(0).getImageId())) { criticalSnapshotsChain.add(diskImage.getVmSnapshotId()); @@ -857,7 +857,7 @@ && getSnapshot().getStatus() != SnapshotStatus.IN_PREVIEW) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_VM_SNAPSHOT_NOT_IN_PREVIEW); } - if(!canRestoreVmConfigFromSnapshot()) { + if (!canRestoreVmConfigFromSnapshot()) { return failValidation(EngineMessage.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java index 466ff42ee54..79cd7bb3653 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java @@ -153,7 +153,7 @@ public ValidationResult isSnapshotStatusOK(Guid snapshotId) { * * @return Snapshot is in the required status or not */ - private ValidationResult isSnapshotInStatus(Guid snapshotId, SnapshotStatus status, EngineMessage msg) { + private ValidationResult isSnapshotInStatus(Guid snapshotId, SnapshotStatus status, EngineMessage msg) { Snapshot snap = snapshotDao.get(snapshotId); if (snap != null && snap.getStatus() != status) { return new ValidationResult(msg, String.format("$SnapshotStatus %1$s", snap.getStatus())); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java index 515a9ce6512..76f3c051bf7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/TryBackToAllSnapshotsOfVmCommand.java @@ -317,7 +317,7 @@ public Void runInTransaction() { continue; } if (image.getDiskStorageType() == DiskStorageType.CINDER) { - cinderDisks.add((CinderDisk)image); + cinderDisks.add((CinderDisk) image); continue; } ActionReturnValue actionReturnValue = @@ -562,7 +562,7 @@ protected boolean validate() { // verify that the destination lease domain ID belongs to one of the VM's snapshots if (getParameters().getDstLeaseDomainId() != null) { if (!validate(snapshotsValidator.isLeaseDomainIdBelongsToSnapshot(getVmId(), - getParameters().getDstLeaseDomainId())) &&!getParameters().getDstLeaseDomainId() + getParameters().getDstLeaseDomainId())) && !getParameters().getDstLeaseDomainId() .equals(getVm().getLeaseStorageDomainId())) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_LEASE_DOMAIN_ID_IS_NOT_VALID); } @@ -637,7 +637,7 @@ protected boolean validate() { return false; } - if(!canRestoreVmConfigFromSnapshot()) { + if (!canRestoreVmConfigFromSnapshot()) { return failValidation(EngineMessage.MAC_POOL_NOT_ENOUGH_MAC_ADDRESSES); } return true; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java index 1a785f858cd..f8c7e5818ea 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/EntityPollingCommand.java @@ -8,5 +8,5 @@ public interface EntityPollingCommand { /** * Method to perform job fencing using the command entity (if supported). */ - default void attemptToFenceJob() {} + default void attemptToFenceJob() { } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java index 4f90834a7a9..45138a72e65 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java @@ -85,7 +85,7 @@ protected boolean validate() { // check problematic vds status if (isLegalStatus(problematicVds.getStatus())) { if (problematicVds.getSpmStatus() == VdsSpmStatus.SPM) { - if(!getStoragePool().isLocal()) { + if (!getStoragePool().isLocal()) { if (!initializeVds()) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java index fe8344074cc..9c346cb8805 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java @@ -101,31 +101,31 @@ public abstract class StorageHandlingCommandBase getLatestOVFDisk(List ovfStoreDiskImage size = Long.valueOf(diskDescriptionMap.get(OvfInfoFileConstants.Size).toString()); } } - return new Pair<>((DiskImage)ovfDisk, size); + return new Pair<>((DiskImage) ovfDisk, size); } protected List getEntitiesFromStorageOvfDisk(Guid storageDomainId, Guid storagePoolId) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectAllHostsToLunCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectAllHostsToLunCommand.java index 0e88448a700..ffc1cfc0377 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectAllHostsToLunCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectAllHostsToLunCommand.java @@ -179,7 +179,7 @@ private boolean validateConnectedLuns(VDS vds, Set processedLunIds) { res = (Map) runVdsCommand(VDSCommandType.GetDevicesVisibility, new GetDevicesVisibilityVDSCommandParameters(vds.getId(), processedLunIds.toArray(new String[processedLunIds.size()]))).getReturnValue(); - } catch(EngineException e) { + } catch (EngineException e) { handleFailure(vds, null); throw e; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java index 95ce4d47055..be71580d2fa 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ConnectStorageToVdsCommand.java @@ -171,7 +171,7 @@ private ValidationResult validateVolumeIdAndUpdatePath(StorageServerConnections } engineMessage = glusterUtil.validateVolumeForStorageDomain(glusterVolume); - if(engineMessage != null) { + if (engineMessage != null) { return new ValidationResult(engineMessage); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java index 04edbfaf919..42f69bf5018 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/DetachStorageConnectionFromStorageDomainCommand.java @@ -40,7 +40,7 @@ protected boolean validate() { || !validate(storageConnectionValidator.isISCSIConnectionAndDomain(getStorageDomain()))) { return false; } - if(!storageConnectionValidator.isConnectionForISCSIDomainAttached(getStorageDomain())) { + if (!storageConnectionValidator.isConnectionForISCSIDomainAttached(getStorageDomain())) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_STORAGE_CONNECTION_FOR_DOMAIN_NOT_EXIST); } return true; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java index fc936035421..b0ddb9dd027 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/GetAllStorageServerConnectionsQuery.java @@ -7,7 +7,7 @@ import org.ovirt.engine.core.common.queries.QueryParametersBase; import org.ovirt.engine.core.dao.StorageServerConnectionDao; -public class GetAllStorageServerConnectionsQuery

    extends QueriesCommandBase

    { +public class GetAllStorageServerConnectionsQuery

    extends QueriesCommandBase

    { @Inject private StorageServerConnectionDao storageServerConnectionDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java index 4791bbeaf5a..9528f264c83 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/RemoveStorageServerConnectionCommand.java @@ -50,7 +50,7 @@ protected boolean validate() { return failValidation(EngineMessage.ACTION_TYPE_FAILED_STORAGE_CONNECTION_ID_EMPTY); } StorageServerConnections connection = storageServerConnectionDao.get(connectionId); - if(connection == null) { + if (connection == null) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_STORAGE_CONNECTION_NOT_EXIST); } // if user passed only the connection id for removal, vdsm still needs few more details in order to disconnect, so @@ -60,7 +60,7 @@ protected boolean validate() { if (storageType.isFileDomain()) { // go to storage domain static, get all storage domains where storage field = storage connection id domains = getStorageDomainsByConnId(connectionId); - if(domains.size() > 0) { + if (domains.size() > 0) { String domainNames = createDomainNamesListFromStorageDomains(domains); return prepareFailureMessageForDomains(domainNames); } @@ -71,7 +71,7 @@ protected boolean validate() { List luns = lunDao.getAllForStorageServerConnection(connectionId); if (!luns.isEmpty()) { String volumeGroupId = null; - for(LUNs lun : luns) { + for (LUNs lun : luns) { volumeGroupId = lun.getVolumeGroupId(); if (StringUtils.isNotEmpty(volumeGroupId)) { // non empty vg id indicates there's a storage domain using the lun @@ -124,23 +124,23 @@ protected void executeCommand() { protected void populateMissingFields(StorageServerConnections connectionFromDb) { StorageServerConnections connectionFromParams = getConnection(); - if(connectionFromParams.getStorageType() == null || connectionFromParams.getStorageType().equals(StorageType.UNKNOWN)) { + if (connectionFromParams.getStorageType() == null || connectionFromParams.getStorageType().equals(StorageType.UNKNOWN)) { connectionFromParams.setStorageType(connectionFromDb.getStorageType()); } - if(StringUtils.isEmpty(connectionFromParams.getConnection())) { + if (StringUtils.isEmpty(connectionFromParams.getConnection())) { connectionFromParams.setConnection(connectionFromDb.getConnection()); } - if(connectionFromParams.getStorageType().equals(StorageType.ISCSI)){ - if(StringUtils.isEmpty(connectionFromParams.getIqn())) { + if (connectionFromParams.getStorageType().equals(StorageType.ISCSI)) { + if (StringUtils.isEmpty(connectionFromParams.getIqn())) { connectionFromParams.setIqn(connectionFromDb.getIqn()); } - if(StringUtils.isEmpty(connectionFromParams.getUserName())) { + if (StringUtils.isEmpty(connectionFromParams.getUserName())) { connectionFromParams.setUserName(connectionFromDb.getUserName()); } - if(StringUtils.isEmpty(connectionFromParams.getPassword())) { + if (StringUtils.isEmpty(connectionFromParams.getPassword())) { connectionFromParams.setPassword(connectionFromDb.getPassword()); } - if(StringUtils.isEmpty(connectionFromParams.getPort())) { + if (StringUtils.isEmpty(connectionFromParams.getPort())) { connectionFromParams.setPort(connectionFromDb.getPort()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java index d57723441c6..c182620e95a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java @@ -241,7 +241,7 @@ public boolean syncDomainInfo(StorageDomain storageDomain, Guid vdsId) { return true; } - public void addMessageToAuditLog(AuditLogType auditLogType, StorageDomain storageDomain, VDS vds){ + public void addMessageToAuditLog(AuditLogType auditLogType, StorageDomain storageDomain, VDS vds) { AuditLogable logable = new AuditLogableImpl(); logable.setVdsId(vds.getId()); logable.setVdsName(vds.getName()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java index 3cd39391836..63c5a5be367 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommand.java @@ -363,15 +363,15 @@ protected Map> getExclusiveLocks() { EngineMessage.ACTION_TYPE_FAILED_OBJECT_LOCKED)); //lock lun disks and domains, not VMs , no need to load from db. - if(getLuns()!=null) { - for(LUNs lun : getLuns()) { + if (getLuns() != null) { + for (LUNs lun : getLuns()) { Guid diskId = lun.getDiskId(); Guid storageDomainId = lun.getStorageDomainId(); - if(diskId != null) { + if (diskId != null) { locks.put(diskId.toString(), LockMessagesMatchUtil.makeLockingPair(LockingGroup.DISK, EngineMessage.ACTION_TYPE_FAILED_OBJECT_LOCKED)); } - if(storageDomainId != null) { + if (storageDomainId != null) { locks.put(storageDomainId.toString(), LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE, EngineMessage.ACTION_TYPE_FAILED_OBJECT_LOCKED)); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java index 08fc37ef071..dbcaa4f223d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/iscsibond/BaseIscsiBondCommand.java @@ -76,7 +76,7 @@ protected void connectAllHostsToStorage(List connectionIds) { .collect(Collectors.toList()); if (!failedConnectionsList.isEmpty()) { log.error("Host '{}' - '{}' encounter problems to connect to the iSCSI Storage" - + " Server. The following connections were problematic"+ "" + + + " Server. The following connections were problematic" + "" + " (connectionid=vdsm result): {}", host.getName(), host.getId(), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java index 2603826eb83..ddc3e632f39 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java @@ -546,7 +546,7 @@ private void createDiskBasedOnLun() { } protected VmDevice addManagedDeviceForDisk(Guid diskId) { - return getVmDeviceUtils().addDiskDevice( + return getVmDeviceUtils().addDiskDevice( getVmId(), diskId, shouldDiskBePlugged(), @@ -569,7 +569,7 @@ protected boolean useCallback() { } private void createDiskBasedOnImage() { - if(!getParameters().getDiskInfo().isWipeAfterDeleteSet()) { + if (!getParameters().getDiskInfo().isWipeAfterDeleteSet()) { getParameters().getDiskInfo().setWipeAfterDelete(getStorageDomain().getWipeAfterDelete()); } // create from blank template, create new vm snapshot id @@ -635,7 +635,7 @@ protected void attachImage() { @Override public CommandCallback getCallback() { - return useCallback() ? callbackProvider.get() : null; + return useCallback() ? callbackProvider.get() : null; } private void createDiskBasedOnCinder() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java index bc2d9a045b1..1cef667a71b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java @@ -99,7 +99,7 @@ protected LockProperties applyLockProperties(LockProperties lockProperties) { @Override protected boolean validate() { DiskValidator oldDiskValidator = new DiskValidator(disk); - if (!validate(oldDiskValidator.isDiskExists())){ + if (!validate(oldDiskValidator.isDiskExists())) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java index 688fdfc983e..c783737f544 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/DiskHandler.java @@ -41,7 +41,7 @@ public Disk loadActiveDisk(Guid diskId) { * Loads a disk info for selected snapshot, if no snapshot ID was specified it will load the active snapshot */ public Disk loadDiskFromSnapshot(Guid diskId, Guid snapshotId) { - return snapshotId == null ? loadActiveDisk(diskId) : + return snapshotId == null ? loadActiveDisk(diskId) : diskImageDao.getDiskSnapshotForVmSnapshot(diskId, snapshotId); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java index d30cf4c1d84..8de5993175c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java @@ -469,19 +469,19 @@ protected void endWithFailure() { public AuditLogType getAuditLogTypeValue() { switch (getActionState()) { case EXECUTE: - return getSucceeded() ? (isMoveOperation()) ? AuditLogType.USER_MOVED_DISK + return getSucceeded() ? isMoveOperation() ? AuditLogType.USER_MOVED_DISK : AuditLogType.USER_COPIED_DISK - : (isMoveOperation()) ? AuditLogType.USER_FAILED_MOVED_VM_DISK + : isMoveOperation() ? AuditLogType.USER_FAILED_MOVED_VM_DISK : AuditLogType.USER_FAILED_COPY_DISK; case END_SUCCESS: - return getSucceeded() ? (isMoveOperation()) ? AuditLogType.USER_MOVED_DISK_FINISHED_SUCCESS + return getSucceeded() ? isMoveOperation() ? AuditLogType.USER_MOVED_DISK_FINISHED_SUCCESS : AuditLogType.USER_COPIED_DISK_FINISHED_SUCCESS - : (isMoveOperation()) ? AuditLogType.USER_MOVED_DISK_FINISHED_FAILURE + : isMoveOperation() ? AuditLogType.USER_MOVED_DISK_FINISHED_FAILURE : AuditLogType.USER_COPIED_DISK_FINISHED_FAILURE; default: - return (isMoveOperation()) ? AuditLogType.USER_MOVED_DISK_FINISHED_FAILURE + return isMoveOperation() ? AuditLogType.USER_MOVED_DISK_FINISHED_FAILURE : AuditLogType.USER_COPIED_DISK_FINISHED_FAILURE; } } @@ -670,7 +670,7 @@ public List getQuotaStorageConsumptionParameters() { getDestinationQuotaId(), QuotaConsumptionParameter.QuotaAction.CONSUME, getParameters().getDestDomainId(), - (double)getImage().getSizeInGigabytes())); + (double) getImage().getSizeInGigabytes())); if (isMoveOperation()) { if (getImage().getQuotaId() != null && !Guid.Empty.equals(getImage().getQuotaId())) { @@ -678,7 +678,7 @@ public List getQuotaStorageConsumptionParameters() { getImage().getQuotaId(), QuotaConsumptionParameter.QuotaAction.RELEASE, getParameters().getSourceDomainId(), - (double)getImage().getSizeInGigabytes())); + (double) getImage().getSizeInGigabytes())); } } return list; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java index 16a41463b8f..51ac7e5bbea 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommand.java @@ -332,7 +332,7 @@ private boolean canRemoveTemplateDisk() { return failValidation(EngineMessage.VM_TEMPLATE_IMAGE_LAST_DOMAIN); } - if (!checkDerivedVmFromTemplateExists(diskImage) || !checkDerivedDisksFromDiskNotExist(diskImage)){ + if (!checkDerivedVmFromTemplateExists(diskImage) || !checkDerivedDisksFromDiskNotExist(diskImage)) { return false; } @@ -744,6 +744,6 @@ private DiskStorageType getDiskStorageType() { @Override public CommandCallback getCallback() { - return getDiskStorageType() == DiskStorageType.IMAGE ? callbackProvider.get() : null; + return getDiskStorageType() == DiskStorageType.IMAGE ? callbackProvider.get() : null; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommand.java index 4925d6cde0f..fddbc462ce2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommand.java @@ -335,7 +335,7 @@ private boolean isQcowCompatChangedOnRawDisk() { private boolean isIncrementalBackupChangedOnRawDisk() { if (getNewDisk().getDiskStorageType() == DiskStorageType.IMAGE) { DiskImage diskImage = (DiskImage) getNewDisk(); - return diskImage.getBackup() == DiskBackup.Incremental && diskImage.getVolumeFormat() == VolumeFormat.RAW; + return diskImage.getBackup() == DiskBackup.Incremental && diskImage.getVolumeFormat() == VolumeFormat.RAW; } return false; } @@ -376,7 +376,7 @@ private boolean validateCanUpdateShareable() { if (isUpdatedToShareable(getOldDisk(), getNewDisk())) { - StorageDomainStatic sds = storageDomainStaticDao.get(((DiskImage)getNewDisk()).getStorageIds().get(0)); + StorageDomainStatic sds = storageDomainStaticDao.get(((DiskImage) getNewDisk()).getStorageIds().get(0)); if (sds.getStorageType() == StorageType.GLUSTERFS) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_SHAREABLE_DISKS_NOT_SUPPORTED_ON_GLUSTER_DOMAIN); } @@ -402,7 +402,7 @@ private boolean validateCanUpdateShareable() { protected boolean validateCanUpdateReadOnly() { if (updateReadOnlyRequested()) { - if(getVm().getStatus() != VMStatus.Down && vmDeviceForVm.isPlugged()) { + if (getVm().getStatus() != VMStatus.Down && vmDeviceForVm.isPlugged()) { return failValidation(EngineMessage.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN); } DiskVmElementValidator diskVmElementValidator = getDiskVmElementValidator(getNewDisk(), getDiskVmElement()); @@ -792,7 +792,7 @@ public Map getJobMessageProperties() { .map(VM::getName) .sorted() .collect(Collectors.joining(", ")); - jobProperties.put("vm", vmNames.isEmpty()? "N/A" : vmNames); + jobProperties.put("vm", vmNames.isEmpty() ? "N/A" : vmNames); } return jobProperties; } @@ -886,7 +886,7 @@ public List getQuotaStorageConsumptionParameters() { QuotaStorageConsumptionParameter.QuotaAction.RELEASE, //TODO: Shared Disk? oldDiskImage.getStorageIds().get(0), - (double)oldDiskImage.getSizeInGigabytes())); + (double) oldDiskImage.getSizeInGigabytes())); } } return list; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java index 83e8a11e02c..693fd4bdcbb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommand.java @@ -138,7 +138,7 @@ private Guid getDiskId() { @Override public boolean validate() { - if (!validateQuota()){ + if (!validateQuota()) { return false; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotDiskCommand.java index 768c89a7b73..f476b2cde93 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotDiskCommand.java @@ -36,7 +36,7 @@ public RemoveCinderSnapshotDiskCommand(T parameters, CommandContext cmdContext) @Override protected void executeCommand() { - registerRollbackHandler((TransactionRollbackListener)() -> { + registerRollbackHandler((TransactionRollbackListener) () -> { TransactionSupport.executeInNewTransaction(() -> { if (!getParameters().isLeaveLocked()) { DiskImage diskImage = getImage(); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java index a94be0ff924..a169960101d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java @@ -149,7 +149,7 @@ public boolean performNextOperation(int completedChildCount) { getParameters().getChildCommandsParameters().get(completedChildCount - 1).getRemovedVolume(); removeDiskFromDbCallBack(cinderVolume); - if(getParameters().getChildCommandsParameters().size() == completedChildCount){ + if (getParameters().getChildCommandsParameters().size() == completedChildCount) { return false; } getParameters().setRemovedVolumeIndex(completedChildCount); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java index 205e5dc1240..239a4d25c2e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java @@ -255,7 +255,7 @@ private boolean performStorageOperation() { @Override public CommandCallback getCallback() { - if (isUsingSPDMFlow()){ + if (isUsingSPDMFlow()) { return callbackProvider.get(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyManagedBlockDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyManagedBlockDiskCommand.java index 417344fd24a..8ca1712900d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyManagedBlockDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyManagedBlockDiskCommand.java @@ -125,7 +125,7 @@ protected void executeCommand() { @Override public boolean performNextOperation(int completedChildCount) { - switch(getParameters().getStage()) { + switch (getParameters().getStage()) { case LEASE_CREATION: if (!saveLease()) { setCommandStatus(CommandStatus.FAILED); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java index 230a2162eb4..018c3ec5305 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java @@ -215,7 +215,7 @@ public static boolean setDiskAlias(BaseDisk disk, VM vm, int count) { return false; } - String vmName = nullSafeGetVmName(vm); + String vmName = nullSafeGetVmName(vm); disk.setDiskAlias(getSuggestedDiskAlias(disk, vmName, count)); return true; } @@ -565,7 +565,7 @@ public void fillImagesBySnapshots(VM vm) { * List of Disk objects to aggregate their snapshots * @return List of active DiskImages objects which related to their snapshots */ - public Collection aggregateDiskImagesSnapshots(Collection images){ + public Collection aggregateDiskImagesSnapshots(Collection images) { Map diskImagesMap = new HashMap<>(); // Get active diskImages diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java index a08219453cf..fb142f61fd0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RemoveImageCommand.java @@ -51,7 +51,7 @@ * This command responsible to removing image, contains all created snapshots. */ @InternalCommandAttribute -@NonTransactiveCommandAttribute(forceCompensation=true) +@NonTransactiveCommandAttribute(forceCompensation = true) public class RemoveImageCommand extends BaseImagesCommand { private static final Set ACTIONS_NOT_REQUIRED_DB_OPERATION = new HashSet<>( diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java index 1c6c42f0795..b8d16d1b7fe 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java @@ -381,7 +381,7 @@ protected ImageActionsVDSCommandParameters getImageActionsParameters(Guid vdsId) } protected String getImageAlias() { - return getParameters().getAddDiskParameters() != null ? + return getParameters().getAddDiskParameters() != null ? getParameters().getAddDiskParameters().getDiskInfo().getDiskAlias() : getDiskImage().getDiskAlias(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/AddManagedBlockStorageDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/AddManagedBlockStorageDiskCommand.java index c13467cf770..6074eaea444 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/AddManagedBlockStorageDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/AddManagedBlockStorageDiskCommand.java @@ -179,7 +179,7 @@ private ManagedBlockStorageDisk createDisk() { * @return The next GiB multiple in bytes */ private long getDiskSize(long size) { - long correctedSize = (long) Math.ceil((double)size / (double)SizeConverter.BYTES_IN_GB); + long correctedSize = (long) Math.ceil((double) size / (double) SizeConverter.BYTES_IN_GB); return SizeConverter.convert(correctedSize, SizeConverter.SizeUnit.GiB, SizeConverter.SizeUnit.BYTES) .longValue(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/RemoveManagedBlockStorageSnapshotCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/RemoveManagedBlockStorageSnapshotCommand.java index 77bcfec41fb..8e57e3ee507 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/RemoveManagedBlockStorageSnapshotCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/managedblock/RemoveManagedBlockStorageSnapshotCommand.java @@ -68,7 +68,7 @@ protected void executeCommand() { getCorrelationId()); returnValue = cinderlibExecutor.runCommand(CinderlibExecutor.CinderlibCommand.REMOVE_SNAPSHOT, params); - } catch(Exception e) { + } catch (Exception e) { log.error("Failed executing snapshot deletion", e); return; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java index b605a7a13b4..3b929304e4b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddLocalStorageDomainCommand.java @@ -74,7 +74,7 @@ protected void executeCommand() { .runInternalAction( ActionType.AttachStorageDomainToPool, new AttachStorageDomainToPoolParameters(getStorageDomain().getId(), getStoragePool().getId())); - if(!returnValue.getSucceeded()) { + if (!returnValue.getSucceeded()) { getReturnValue().setSucceeded(false); getReturnValue().setFault(returnValue.getFault()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java index a19ad204fb7..1dd37718978 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddSANStorageDomainCommand.java @@ -47,7 +47,7 @@ protected void executeCommand() { // status to be locked getStorageDomain().setStorage(""); addStorageDomainInDb(); - if(StringUtils.isEmpty(storage)) { + if (StringUtils.isEmpty(storage)) { storage = createVG(); } getStorageDomain().setStorage(storage); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java index 4b566215072..47ab32533c2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java @@ -82,7 +82,7 @@ protected void updateStaticDataDefaults() { } private void updateStorageDomainWipeAfterDelete() { - if(getStorageDomain().getStorageStaticData().getWipeAfterDelete() == null) { + if (getStorageDomain().getStorageStaticData().getWipeAfterDelete() == null) { getStorageDomain().getStorageStaticData().setWipeAfterDelete( WipeAfterDeleteUtils.getDefaultWipeAfterDeleteFlag( getStorageDomain().getStorageStaticData().getStorageType())); @@ -90,14 +90,14 @@ private void updateStorageDomainWipeAfterDelete() { } private void updateSpaceThresholds() { - if(getStorageDomain().getWarningLowSpaceIndicator() == null) { + if (getStorageDomain().getWarningLowSpaceIndicator() == null) { getStorageDomain().setWarningLowSpaceIndicator(Config.getValue(ConfigValues.WarningLowSpaceIndicator)); } - if(getStorageDomain().getWarningLowConfirmedSpaceIndicator() == null) { + if (getStorageDomain().getWarningLowConfirmedSpaceIndicator() == null) { getStorageDomain().getStorageStaticData().setWarningLowConfirmedSpaceIndicator( Config.getValue(ConfigValues.WarningLowSpaceIndicator)); } - if(getStorageDomain().getCriticalSpaceActionBlocker() == null) { + if (getStorageDomain().getCriticalSpaceActionBlocker() == null) { getStorageDomain().setCriticalSpaceActionBlocker(Config.getValue(ConfigValues.CriticalSpaceActionBlocker)); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java index 323e1def929..3f1742c4a28 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DeactivateStorageDomainWithOvfUpdateCommand.java @@ -137,7 +137,7 @@ protected boolean shouldPerformOvfUpdate() { } private StoragePoolIsoMap loadStoragePoolIsoMap() { - return storagePoolIsoMapDao.get + return storagePoolIsoMapDao.get (new StoragePoolIsoMapId(getParameters().getStorageDomainId(), getParameters().getStoragePoolId())); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java index 9eaba3d6ac8..2daa4dbc6ca 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/DetachStorageDomainFromPoolCommand.java @@ -35,7 +35,7 @@ import org.ovirt.engine.core.dao.profiles.DiskProfileDao; import org.ovirt.engine.core.utils.transaction.TransactionSupport; -@NonTransactiveCommandAttribute(forceCompensation=true) +@NonTransactiveCommandAttribute(forceCompensation = true) public class DetachStorageDomainFromPoolCommand extends StorageDomainCommandBase { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetManagedBlockStorageStatsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetManagedBlockStorageStatsCommand.java index a91e460907b..9e35b41f1db 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetManagedBlockStorageStatsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetManagedBlockStorageStatsCommand.java @@ -56,7 +56,7 @@ protected void executeCommand() { getCorrelationId()); returnValue = cinderlibExecutor.runCommand(CinderlibExecutor.CinderlibCommand.STORAGE_STATS, params); - if(returnValue.getSucceed()) { + if (returnValue.getSucceed()) { storageStats = JsonHelper.jsonToMap(returnValue.getOutput()); } } catch (Exception e) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsByVmTemplateIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsByVmTemplateIdQuery.java index 6f6c093f325..f72e8c5393a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsByVmTemplateIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsByVmTemplateIdQuery.java @@ -45,7 +45,7 @@ protected void executeQueryCommand() { Set domains = new HashSet<>(); for (Disk templateDisk : templateDisks) { - domains.addAll(((DiskImage)templateDisk).getStorageIds()); + domains.addAll(((DiskImage) templateDisk).getStorageIds()); } for (Guid domainId : domains) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java index 2ba29e0e95f..520a8ecbf36 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommand.java @@ -237,7 +237,7 @@ private boolean fetchStorageDomainInfo() { null)); if (allDomainsQuery.getSucceeded()) { for (StorageDomain sd : (List) allDomainsQuery.getReturnValue()) { - if(sd.getId().equals(getParameters().getStorageDomainId())){ + if (sd.getId().equals(getParameters().getStorageDomainId())) { heStorageDomain = sd; return true; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java index 4522e3e8431..7ed138a6e4f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java @@ -282,7 +282,7 @@ public boolean requiresDbUpdate() { } }; - protected final LunHandler noOp = luns -> {}; + protected final LunHandler noOp = luns -> { }; protected interface LunHandler extends Consumer> { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java index 03d5cd36e96..ba5a0df92c5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java @@ -25,7 +25,7 @@ import org.ovirt.engine.core.utils.ObjectIdentityChecker; public class UpdateStorageDomainCommand extends - StorageDomainManagementCommandBase implements RenamedEntityInfoProvider { + StorageDomainManagementCommandBase implements RenamedEntityInfoProvider { @Inject private StorageDomainStaticDao storageDomainStaticDao; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/ScheduleGlusterStorageSyncCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/ScheduleGlusterStorageSyncCommand.java index 15508ad06b8..38c246d946a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/ScheduleGlusterStorageSyncCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/ScheduleGlusterStorageSyncCommand.java @@ -57,7 +57,7 @@ protected void setActionMessageParameters() { @Override protected Map> getExclusiveLocks() { - return Collections.singletonMap(getStorageDomainId().toString() + ";" +getGeoRepSession().toString(), + return Collections.singletonMap(getStorageDomainId().toString() + ";" + getGeoRepSession().toString(), LockMessagesMatchUtil.makeLockingPair(LockingGroup.GLUSTER_STORAGE_DOMAIN_SYNC, new LockMessage(EngineMessage.STORAGE_DOMAIN_SYNC_SCHEDULING_IN_PROGRESS))); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java index 6faed984173..38d0655a850 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java @@ -152,7 +152,7 @@ public void init() { getParameters().setImageGroupID(getImageGroupId()); getParameters().setCommandType(getActionType()); - getParameters().setDestinationImageId(((DiskImage)getDiskImageByDiskId(getParameters().getImageGroupID())) + getParameters().setDestinationImageId(((DiskImage) getDiskImageByDiskId(getParameters().getImageGroupID())) .getImageId()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java index 61b6e5a41f0..ed2234b700b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStorageDomainCommand.java @@ -464,7 +464,7 @@ public boolean performNextOperation(int completedChildCount) { return false; } - private void setOvfUpdateStep(OvfUpdateStep step){ + private void setOvfUpdateStep(OvfUpdateStep step) { getParameters().setOvfUpdateStep(step); persistCommand(getParameters().getParentCommand(), true); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperationFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperationFactory.java index 307d91bb9fe..03fa987f7ba 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperationFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ActivateDeactivateSingleAsyncOperationFactory.java @@ -31,7 +31,7 @@ public void initialize(List parameters) { if (!(parameters.get(0) instanceof List)) { throw new IllegalArgumentException(); } - List l = new ArrayList((List)parameters.get(0)); + List l = new ArrayList((List) parameters.get(0)); if (!l.isEmpty() && !(l.get(0) instanceof VDS)) { throw new IllegalArgumentException(); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java index 33a39e7b74b..d54b8891827 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AddStoragePoolWithStoragesCommand.java @@ -163,7 +163,7 @@ protected void executeCommand() { } private boolean updateStorageDomainsInDb() { - boolean result = TransactionSupport.executeInNewTransaction(() -> { + boolean result = TransactionSupport.executeInNewTransaction(() -> { for (Guid storageDomainId : getParameters().getStorages()) { StorageDomain storageDomain = storageDomainDao.get(storageDomainId); if (storageDomain != null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java index d36361684e3..dba609c564c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java @@ -52,7 +52,7 @@ protected boolean validate() { return failValidation(EngineMessage.VDS_NOT_EXIST); } - if(!getVds().getClusterSupportsVirtService()){ + if (!getVds().getClusterSupportsVirtService()) { return failValidation(EngineMessage.CANNOT_FORCE_SELECT_SPM_HOST_DOES_NOT_SUPPORT_VIRT_SERVICES); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java index d0fc911e4fa..6d269615ecf 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/RemoveStoragePoolCommand.java @@ -86,7 +86,7 @@ protected void executeCommand() { if (!storageDomains.isEmpty()) { if (!getParameters().isForceDelete() && !getAllRunningVdssInPool().isEmpty()) { - if(!regularRemoveStorageDomains(storageDomains)) { + if (!regularRemoveStorageDomains(storageDomains)) { setSucceeded(false); return; } @@ -158,7 +158,7 @@ private void forceRemoveStorageDomains(List storageDomains) { private boolean regularRemoveStorageDomains(List storageDomains) { boolean retVal = true; final StorageDomain masterDomain = - storageDomains.stream().filter(s -> s.getStorageDomainType() == StorageDomainType.Master).findFirst().orElse(null); + storageDomains.stream().filter(s -> s.getStorageDomainType() == StorageDomainType.Master).findFirst().orElse(null); lockStorageDomain(masterDomain); // destroying a pool is an SPM action. We need to connect all hosts // to the pool. Later on, during spm election, one of the hosts will @@ -280,7 +280,7 @@ protected boolean validate() { return false; } if (!getParameters().isForceDelete()) { - if(poolDomains.size() > 1) { + if (poolDomains.size() > 1) { return failValidation(EngineMessage.ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS); } if (!poolDomains.isEmpty() && !canDetachStorageDomainWithVmsAndDisks(poolDomains.get(0))) { @@ -322,7 +322,7 @@ protected boolean validateDomainsInMaintenance(List domainsList) @Override public AuditLogType getAuditLogTypeValue() { - if (getParameters().isForceDelete()){ + if (getParameters().isForceDelete()) { return getSucceeded() ? AuditLogType.USER_FORCE_REMOVE_STORAGE_POOL : AuditLogType.USER_FORCE_REMOVE_STORAGE_POOL_FAILED; } return getSucceeded() ? AuditLogType.USER_REMOVE_STORAGE_POOL : AuditLogType.USER_REMOVE_STORAGE_POOL_FAILED; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java index 67cbcac4fa2..7244e2ae6a1 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java @@ -13,7 +13,7 @@ * Class which encapsulates logic of figuring out macPoolId for data center based on pools used by data centers * clusters. */ -public abstract class StoragePoolQueryBase

    extends QueriesCommandBase

    { +public abstract class StoragePoolQueryBase

    extends QueriesCommandBase

    { @Inject protected StoragePoolDao storagePoolDao; @@ -39,7 +39,7 @@ private void setMacPoolReference(Object dataCenterQueryResult) { } if (dataCenterQueryResult instanceof StoragePool) { - dataCenterQueryResult((StoragePool)dataCenterQueryResult); + dataCenterQueryResult((StoragePool) dataCenterQueryResult); return; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java index 4226a2a2833..e54daba14a0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java @@ -53,8 +53,7 @@ import org.ovirt.engine.core.utils.transaction.TransactionSupport; @NonTransactiveCommandAttribute -public class UpdateStoragePoolCommand extends - StoragePoolManagementCommandBase implements RenamedEntityInfoProvider{ +public class UpdateStoragePoolCommand extends StoragePoolManagementCommandBase implements RenamedEntityInfoProvider { @Inject private AuditLogDirector auditLogDirector; @@ -128,7 +127,7 @@ private boolean shouldSetNewMacPoolOnAllClusters(Guid newMacPoolId) { } private void updateQuotaCache() { - if(wasQuotaEnforcementChanged()){ + if (wasQuotaEnforcementChanged()) { getQuotaManager().removeStoragePoolFromCache(getStoragePool().getId()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java index b3344a29cf7..e7767de9899 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java @@ -35,7 +35,7 @@ public CommandsCacheImpl() { private void initializeCache() { if (!cacheInitialized) { - synchronized(LOCK) { + synchronized (LOCK) { if (!cacheInitialized) { List cmdEntities = commandEntityDao.getAll(); for (CommandEntity cmdEntity : cmdEntities) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java index 3c2991f1c22..d27810b63a9 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsRepository.java @@ -222,7 +222,7 @@ public void removeCommand(Guid commandId) { private void initChildHierarchy() { if (!childHierarchyInitialized) { - synchronized(LOCK) { + synchronized (LOCK) { if (!childHierarchyInitialized) { childHierarchy.clear(); getCommands(false).forEach(this::buildCmdHierarchy); @@ -255,7 +255,7 @@ private void updateCmdHierarchy(Guid cmdId) { public void removeAllCommandsBeforeDate(final DateTime cutoff) { commandsCache.removeAllCommandsBeforeDate(cutoff); - synchronized(LOCK) { + synchronized (LOCK) { childHierarchyInitialized = false; } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java index 4f61040e329..cc09772211f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/SPMAsyncTask.java @@ -469,7 +469,7 @@ public void clearAsyncTask(boolean forceDelete) { onTaskCleanFailure(); } else { setState(AsyncTaskState.Cleared); - shouldGracefullyDeleteTask = true; + shouldGracefullyDeleteTask = true; } } //A task should be removed from DB if forceDelete is set to true, or if it was cleared successfully. diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java index fd917bffa29..30645a2a5c0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterUtil.java @@ -249,7 +249,7 @@ public Map getGlusterIpaddressAsMap(Map networkNam Optional> result = networkNameObjectMap.entrySet().stream().filter(v -> v.getValue().getCluster().isGluster()).findFirst(); - if(result.isPresent()) { + if (result.isPresent()) { networkName = result.get().getKey(); } else { @@ -265,13 +265,13 @@ public Map getGlusterIpaddressAsMap(Map networkNam Optional> hostGlusterIpresult = hostGlusterIpMap.entrySet().stream().filter(x -> x.getValue().equals(null)).findAny(); - if(hostGlusterIpresult.isPresent()) { + if (hostGlusterIpresult.isPresent()) { return null; } return hostGlusterIpMap; } - public List getGlusterIpaddressUtil(Guid hostId){ + public List getGlusterIpaddressUtil(Guid hostId) { return interfaceDao.getAllInterfacesForVds(hostId); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java index a610727082a..5ace28cca5e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/PermissionSubject.java @@ -49,7 +49,7 @@ public void setActionGroup(ActionGroup actionGroup) { this.actionGroup = actionGroup; } - public EngineMessage getMessage(){ + public EngineMessage getMessage() { return message; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java index 0cc574dbd40..e2a13a7c9af 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java @@ -1788,7 +1788,7 @@ dstCluster, new VmRngDevice(device)).isValid()) { if (isSoundEnabled) { if (hasSound) { - updateSoundDevice(srcVmBase, dstVmBase, CompatibilityVersionUtils.getEffective(dstVmBase, dstCluster), isSoundEnabled); + updateSoundDevice(srcVmBase, dstVmBase, CompatibilityVersionUtils.getEffective(dstVmBase, dstCluster), isSoundEnabled); } else { addSoundDevice(dstVmBase, () -> dstCluster); } @@ -2116,7 +2116,7 @@ private void setNewIdInImportedCollections(VmBase vmBase) { public boolean vmDeviceChanged(Guid vmId, VmDeviceGeneralType deviceGeneralType, String deviceTypeName, boolean deviceEnabled) { List vmDevices = deviceTypeName != null ? - vmDeviceDao.getVmDeviceByVmIdTypeAndDevice(vmId, deviceGeneralType, deviceTypeName): + vmDeviceDao.getVmDeviceByVmIdTypeAndDevice(vmId, deviceGeneralType, deviceTypeName) : vmDeviceDao.getVmDeviceByVmIdAndType(vmId, deviceGeneralType); return deviceEnabled == vmDevices.isEmpty(); @@ -2133,7 +2133,7 @@ public boolean vmDeviceChanged(Guid vmId, VmDeviceGeneralType deviceGeneralType, public boolean vmDeviceChanged(Guid vmId, VmDeviceGeneralType deviceGeneralType, String deviceTypeName, VmDevice device) { List vmDevices = deviceTypeName != null ? - vmDeviceDao.getVmDeviceByVmIdTypeAndDevice(vmId, deviceGeneralType, deviceTypeName): + vmDeviceDao.getVmDeviceByVmIdTypeAndDevice(vmId, deviceGeneralType, deviceTypeName) : vmDeviceDao.getVmDeviceByVmIdAndType(vmId, deviceGeneralType); if (device == null) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java index 63f52328322..01803360c0c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java @@ -190,7 +190,7 @@ public int getStaticOverheadInMb(VM vm) { */ @Override public long getSnapshotMemorySizeInBytes(VM vm) { - long videoRam = (long)videoDeviceSettings.totalVideoRAMSizeMb(vm, + long videoRam = (long) videoDeviceSettings.totalVideoRAMSizeMb(vm, VmDeviceCommonUtils.isSingleQxlPci(vm.getStaticData())); return (vm.getVmMemSizeMb() + 200 + videoRam) * 1024 * 1024; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java index 7e6a445f863..06545c0e5f0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/AffinityValidator.java @@ -61,7 +61,7 @@ public static Result newFailed(ValidationResult validationResult) { return new Result(validationResult, null); } - public static final Result VALID = newValid((a, b) -> {}); + public static final Result VALID = newValid((a, b) -> { }); } @Inject diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java index e6ed1c90739..cdfcdd12444 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java @@ -510,13 +510,13 @@ private StoragePool getDataCenterOfNewCluster() { public List getLowDeviceSpaceVolumes() { List volumes = new ArrayList<>(); - if(cluster.supportsGlusterService()) { + if (cluster.supportsGlusterService()) { List glusterVolumeEntities = glusterVolumeDao.getByClusterId(cluster.getId()); - if(glusterVolumeEntities != null && !glusterVolumeEntities.isEmpty()) { - for(GlusterVolumeEntity glusterVolumeEntity: glusterVolumeEntities) { + if (glusterVolumeEntities != null && !glusterVolumeEntities.isEmpty()) { + for (GlusterVolumeEntity glusterVolumeEntity: glusterVolumeEntities) { if (((glusterVolumeEntity.getAdvancedDetails().getCapacityInfo().getUsedSize().doubleValue() / glusterVolumeEntity.getAdvancedDetails().getCapacityInfo().getTotalSize().doubleValue()) - * 100) > (Integer)Config.getValue(ConfigValues.StorageDeviceSpaceLimit)) { + * 100) > (Integer) Config.getValue(ConfigValues.StorageDeviceSpaceLimit)) { volumes.add(glusterVolumeEntity.getName()); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java index db7916e47fb..d97255ce4b7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java @@ -60,7 +60,7 @@ public ValidationResult interfaceHasNameSet() { .when(iface.getName() == null); } - public ValidationResult interfaceAlreadyLabeledWith(String label) { + public ValidationResult interfaceAlreadyLabeledWith(String label) { return ValidationResult.failWith(EngineMessage.INTERFACE_ALREADY_LABELED, ReplacementUtils.createSetVariableString(VAR_LABELED_NIC, iface.getName()), ReplacementUtils.createSetVariableString(VAR_NIC_LABEL, label)) diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java index a90846d26a0..0f6a2751e0c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/IsRoleNetworkIpConfigurationValid.java @@ -56,7 +56,7 @@ private boolean hasBootProtocolOtherThanNoneOnIpv6(IpConfiguration ipConfigurati * must be in sync with {@link #validate(NetworkAttachment)} */ public boolean validateAddressesOnExistingNic(VdsNetworkInterface nic) { - if (networkCluster.isMigration() || networkCluster.isDefaultRoute() || networkCluster.isDisplay() || networkCluster.isGluster()) { + if (networkCluster.isMigration() || networkCluster.isDefaultRoute() || networkCluster.isDisplay() || networkCluster.isGluster()) { return StringUtils.isNotEmpty(nic.getIpv4Address()) || StringUtils.isNotEmpty(nic.getIpv6Address()); } return StringUtils.isNotEmpty(nic.getIpv4Address()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java index dd644b4bdf7..7bcdb49f646 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentValidator.java @@ -64,7 +64,7 @@ public ValidationResult networkExists() { */ // User did not specify neither id nor name. - if (networkId ==null && networkName == null) { + if (networkId == null && networkName == null) { return new ValidationResult(EngineMessage.NETWORK_ATTACHMENT_NETWORK_ID_OR_NAME_IS_NOT_SET); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java index cc415529708..5698d34c31f 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java @@ -206,7 +206,7 @@ public boolean canRunVm(List messages, StoragePool storagePool, validate(snapshotsValidator.vmNotDuringSnapshot(vm.getId()), messages) && (runInUnknownStatus && vm.getStatus() == VMStatus.Unknown || validate(validateVmStatusUsingMatrix(vm), messages)) && validate(validateStoragePoolUp(vm, storagePool, getVmImageDisks()), messages) && - validate(validateIsoPath(vm, runVmParam.getDiskPath(), runVmParam.getFloppyPath(), activeIsoDomainId), messages) && + validate(validateIsoPath(vm, runVmParam.getDiskPath(), runVmParam.getFloppyPath(), activeIsoDomainId), messages) && validate(vmDuringInitialization(vm), messages) && validate(validateStatelessVm(vm, runVmParam.getRunAsStateless()), messages) && validate(validateFloppy(), messages) && @@ -700,7 +700,7 @@ private Set getInterfaceNetworkNames() { private List getClusterNetworks() { if (cachedClusterNetworks == null) { - cachedClusterNetworks = networkDao.getAllForCluster(vm.getClusterId()); + cachedClusterNetworks = networkDao.getAllForCluster(vm.getClusterId()); } return cachedClusterNetworks; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java index dbf27d0a762..9005e2f9675 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicMacsUtils.java @@ -49,7 +49,7 @@ public ValidationResult validateThereIsEnoughOfFreeMacs(List vmNetworkInterfaces) { vmNetworkInterfaces.stream() .filter(vmNetworkInterface -> StringUtils.isEmpty(vmNetworkInterface.getMacAddress())) - .forEach(e->e.setMacAddress(null)); + .forEach(e -> e.setMacAddress(null)); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java index f416322a967..d64ae2f9746 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java @@ -285,13 +285,13 @@ VmDeviceUtils getVmDeviceUtils() { return Injector.get(VmDeviceUtils.class); } - public ValidationResult isPinnedVmRunningOnDedicatedHost(VM recentVm, VmStatic paramVm){ + public ValidationResult isPinnedVmRunningOnDedicatedHost(VM recentVm, VmStatic paramVm) { boolean isPinned = paramVm.getMigrationSupport() == MigrationSupport.PINNED_TO_HOST; Guid vdsId = recentVm.getRunOnVds(); List hostList = paramVm.getDedicatedVmForVdsList(); // If hostList is empty -> all hosts are allowed - if (isPinned && vdsId != null && !hostList.isEmpty() && !hostList.contains(vdsId)){ + if (isPinned && vdsId != null && !hostList.isEmpty() && !hostList.contains(vdsId)) { // VM is NOT running on a dedicated host // fail with error message String hostName = String.format("$hostName %1$s", recentVm.getRunOnVdsName()); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java index 5415b1b8f1a..b9b6a632b27 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java @@ -30,7 +30,7 @@ final class VlanUntaggedNetworkExclusivenessValidator implements NetworkExclusiv */ @Override public boolean isNetworkExclusive(List networksOnIface) { - return networksOnIface.stream().filter(untaggedNetworkPredicate).count() <= 1; + return networksOnIface.stream().filter(untaggedNetworkPredicate).count() <= 1; } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java index 3a8ec687087..6d47b0757ad 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java @@ -80,7 +80,7 @@ public ValidationResult isUsingScsiReservationValid(VM vm, DiskVmElement dve, Lu return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_SGIO_IS_FILTERED); } } - return ValidationResult.VALID; + return ValidationResult.VALID; } public ValidationResult validateConnectionsInLun(StorageType storageType) { @@ -89,7 +89,7 @@ public ValidationResult validateConnectionsInLun(StorageType storageType) { case UNKNOWN: return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_DISK_LUN_HAS_NO_VALID_TYPE); case ISCSI: - LUNs luns = ((LunDisk)disk).getLun(); + LUNs luns = ((LunDisk) disk).getLun(); if (luns.getLunConnections() == null || luns.getLunConnections().isEmpty()) { return new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_DISK_LUN_ISCSI_MISSING_CONNECTION_PARAMS); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java index c30323c47a5..db3fe024cd6 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java @@ -401,7 +401,7 @@ public ValidationResult isStorageFormatCompatibleWithDomain() { } } - return validationSucceeded? ValidationResult.VALID : new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST, + return validationSucceeded ? ValidationResult.VALID : new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST, String.format("$storageFormat %1$s", storageDomain.getStorageFormat())); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java index 57ce120e820..1a9907b124a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/businessentities/SeparateNewAndModifiedInstances.java @@ -9,7 +9,7 @@ public class SeparateNewAndModifiedInstances { private final List> updatedEntities = new ArrayList<>(); public SeparateNewAndModifiedInstances(List> businessEntities) { - for (BusinessEntity businessEntity : businessEntities) { + for (BusinessEntity businessEntity : businessEntities) { boolean withoutId = businessEntity.getId() == null; if (withoutId) { newEntities.add(businessEntity); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java index eae4e90916a..fe45ee6e986 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleCommandConfig.java @@ -260,7 +260,7 @@ public List build() { ansibleCommand.add(artifactsDir); ansibleCommand.add("-i"); ansibleCommand.add(String.valueOf(this.uuid)); - } catch(Exception e) { + } catch (Exception e) { throw new RuntimeException(e.getMessage(), e); } return ansibleCommand; @@ -316,7 +316,7 @@ private void createExtraVarsFile(File env) { try { extraVars.createNewFile(); Files.writeString(extraVars.toPath(), vars); - } catch(IOException ex) { + } catch (IOException ex) { throw new AnsibleRunnerCallException( String.format("Failed to create host variables file '%s':", extraVars.toString()), ex); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleExecutor.java index 3cec31e0f73..03edb52b6c4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleExecutor.java @@ -179,7 +179,7 @@ public AnsibleReturnValue runCommand(AnsibleCommandConfig commandConfig, int tim log.error("Error executing playbook: {}", message); log.debug("InventoryException: ", ex); ret.setStderr(message); - ret.setAnsibleReturnCode(message.contains(SSH_TIMEOUT) ? AnsibleReturnCode.UNREACHABLE: AnsibleReturnCode.FAIL); + ret.setAnsibleReturnCode(message.contains(SSH_TIMEOUT) ? AnsibleReturnCode.UNREACHABLE : AnsibleReturnCode.FAIL); } catch (Exception ex) { log.error("Exception: {}", ex.getMessage()); log.debug("Exception: ", ex); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java index a4819e03186..e99efd85720 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerClient.java @@ -99,7 +99,7 @@ public void processEvents(AnsibleReturnValue returnValue, BiConsumer fn, AnsibleRunnerLogger runnerLogger) { String jobEvents = getJobEventsDir(returnValue.getPlayUuid()); - while(true){ + while (true) { // get next event String event = getEventFileName(returnValue.getPlayUuid(), returnValue.getLastEventId() + 1); if (event == null) { @@ -302,7 +302,7 @@ private JsonNode getEvent(String eventPath) { ); } currentNode = mapper.readTree(jsonOutput); - } catch(Exception ex) { + } catch (Exception ex) { throw new AnsibleRunnerCallException("Failed to read event: %1$s", eventPath); } return currentNode; diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerLogger.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerLogger.java index db4df94097a..71f1640e087 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerLogger.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/ansible/AnsibleRunnerLogger.java @@ -36,7 +36,7 @@ public Path getLogFile() { return logFile; } - public void log(String str, Object ...params) { + public void log(String str, Object ... params) { if (str == null) { return; } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/cinderlib/CinderlibExecutor.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/cinderlib/CinderlibExecutor.java index 08ba34f8c82..f8650a47df2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/cinderlib/CinderlibExecutor.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/common/utils/cinderlib/CinderlibExecutor.java @@ -26,8 +26,8 @@ public class CinderlibExecutor { private static final String CINDERLIB_DIR = "/cinderlib"; private static final String CINDERLIB_DB_USER = "CINDERLIB_DB_USER"; private static final String CINDERLIB_DB_PASSWORD = "CINDERLIB_DB_PASSWORD"; - private static final String CINDERLIB_DB_HOST= "CINDERLIB_DB_HOST"; - private static final String CINDERLIB_DB_PORT="CINDERLIB_DB_PORT"; + private static final String CINDERLIB_DB_HOST = "CINDERLIB_DB_HOST"; + private static final String CINDERLIB_DB_PORT = "CINDERLIB_DB_PORT"; private static final String CINDERLIB_DB_DATABASE = "CINDERLIB_DB_DATABASE"; private final String urlTemplate = "postgresql+psycopg2://%s:%s@%s:%s/%s"; private String url; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java index 9070cbdb427..cf10f5e8803 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java @@ -38,7 +38,7 @@ import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.core.utils.MockConfigDescriptor; import org.ovirt.engine.core.utils.MockConfigExtension; -import org.ovirt.engine.core.utils.MockedConfig; +import org.ovirt.engine.core.utils.MockedConfig; @ExtendWith(MockConfigExtension.class) diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java index 13443cdcab2..9853fdadcc1 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmTemplateCommandTest.java @@ -235,17 +235,17 @@ public void testDiskAliasNotEmpty() { } @Test - public void testPermissionsForAddingTemplateDedicatedHostNotChanged(){ + public void testPermissionsForAddingTemplateDedicatedHostNotChanged() { setupDedicatedHostForVmAndTemplate(true); List permissionCheckSubjects = cmd.getPermissionCheckSubjects(); - for(PermissionSubject permissionSubject : permissionCheckSubjects){ + for (PermissionSubject permissionSubject : permissionCheckSubjects) { assertNotEquals(ActionGroup.EDIT_ADMIN_TEMPLATE_PROPERTIES, permissionSubject.getActionGroup()); } } @Test - public void testPermissionsForAddingTemplateDedicatedHostChanged(){ + public void testPermissionsForAddingTemplateDedicatedHostChanged() { setupDedicatedHostForVmAndTemplate(false); PermissionSubject editDefaultHostPermission = new PermissionSubject(vm.getStoragePoolId(), @@ -265,7 +265,7 @@ private void verifyPermissions(PermissionSubject editDefaultHostPermission, Perm assertEquals(permissionSubject.getObjectType(), editDefaultHostPermission.getObjectType()); } - private void setupDedicatedHostForVmAndTemplate(boolean setDefaultHostForTemplate){ + private void setupDedicatedHostForVmAndTemplate(boolean setDefaultHostForTemplate) { Guid hostId = Guid.newGuid(); vm.setDedicatedVmForVdsList(Collections.singletonList(hostId)); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java index b6cb6d13b4c..7b66093230e 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java @@ -126,7 +126,7 @@ public void testExtractVariableDeclarationsForStaticMsgs() { public void testExtractVariableDeclarationsForDynamicMsgs() { String msg1_1 = "ACTION_TYPE_FAILED_TEMPLATE_IS_USED_FOR_CREATE_VM"; String msg1_2 = "$VmName Vm1"; - String msg2 = "IRS_FAILED_CREATING_SNAPSHOT"; + String msg2 = "IRS_FAILED_CREATING_SNAPSHOT"; String msg3_1 = "ACTION_TYPE_FAILED_VM_SNAPSHOT_HAS_NO_CONFIGURATION"; String msg3_2 = "$VmName Vm2"; String msg3_3 = "$SnapshotName Snapshot"; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java index 20094dc23e1..14163c20b55 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolCommandTestAbstract.java @@ -51,7 +51,7 @@ import org.ovirt.engine.core.dao.VmTemplateDao; import org.ovirt.engine.core.dao.network.VmNicDao; import org.ovirt.engine.core.utils.MockConfigDescriptor; -import org.ovirt.engine.core.utils.MockedConfig; +import org.ovirt.engine.core.utils.MockedConfig; public abstract class CommonVmPoolCommandTestAbstract extends BaseCommandTest { private final Guid clusterId = Guid.newGuid(); @@ -63,7 +63,7 @@ public abstract class CommonVmPoolCommandTestAbstract extends BaseCommandTest { private Cluster cluster = mockCluster(); protected VM testVm = mockVm(); protected VmPool vmPools = mockVmPools(); - protected List vms = mockVms(); + protected List vms = mockVms(); protected static int VM_COUNT = 5; protected VmTemplate vmTemplate = mockVmTemplate(); protected StoragePool storagePool = mockStoragePool(); @@ -216,7 +216,7 @@ private VM mockVm() { } private List mockVms() { - List vms = new ArrayList<>(); + List vms = new ArrayList<>(); vms.add(mockVm()); return vms; } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java index 55135eb1f23..756ed2a1525 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/LabelActionParametersTest.java @@ -42,7 +42,7 @@ private void validateLabelNameLength(Label label, boolean isValidLabelName) { List validationMessages = ValidationUtils.validateInputs(new ArrayList<>(), parameters); - if(isValidLabelName){ + if (isValidLabelName) { assertThat(validationMessages).isEmpty(); } else { assertThat(validationMessages) diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunnerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunnerTest.java index 5091dc37d47..49ecc5f025a 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunnerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/PrevalidatingMultipleActionsRunnerTest.java @@ -17,7 +17,7 @@ import org.ovirt.engine.core.common.action.ActionType; import org.ovirt.engine.core.common.action.DiskProfileParameters; -public class PrevalidatingMultipleActionsRunnerTest extends MultipleActionsRunnerBaseTest{ +public class PrevalidatingMultipleActionsRunnerTest extends MultipleActionsRunnerBaseTest { private static CommandContext commandContext = CommandContext.createContext(new DiskProfileParameters().getSessionId()).withCompensationContext(NoOpCompensationContext.getInstance()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java index 87ef2cb93fe..4cd17a0e333 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java @@ -363,7 +363,7 @@ public void removeLastHost() { @MethodSource("removeWithAnsiblePlaybookScenarios") public void auditAnsibleRemoveVdsPlaybookExecution(AnsibleReturnCode ansibleReturnCode, VDSStatus vdsStatus, - AuditLogType expectedAuditLogType) { + AuditLogType expectedAuditLogType) { mockVdsWithStatus(vdsStatus); mockIsGlusterEnabled(true); mockHasMultipleClusters(false); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunnerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunnerTest.java index a4f33053211..d7dcf4fdaf7 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunnerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SequentialMultipleActionsRunnerTest.java @@ -16,7 +16,7 @@ import org.ovirt.engine.core.common.action.ActionType; import org.ovirt.engine.core.common.action.DiskProfileParameters; -public class SequentialMultipleActionsRunnerTest extends MultipleActionsRunnerBaseTest{ +public class SequentialMultipleActionsRunnerTest extends MultipleActionsRunnerBaseTest { private static CommandContext commandContext = CommandContext.createContext(new DiskProfileParameters().getSessionId()).withCompensationContext(NoOpCompensationContext.getInstance()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java index 477322f603c..51749814acb 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java @@ -539,7 +539,7 @@ public void randomAdditionalRngDeviceUsed() { @Test @MockedConfig("configForClusterWithVirtGlusterServicesNotAllowed") - public void memoryOptimizationWithoutKsmOrBallooning(){ + public void memoryOptimizationWithoutKsmOrBallooning() { final Cluster cluster = createDefaultCluster(); cluster.setMaxVdsMemoryOverCommit(150); cluster.setEnableKsm(false); @@ -551,7 +551,7 @@ public void memoryOptimizationWithoutKsmOrBallooning(){ @Test @MockedConfig("configForClusterWithVirtGlusterServicesNotAllowed") - public void memoryOptimizationLowerThenZeroWithoutKsmOrBallooning(){ + public void memoryOptimizationLowerThenZeroWithoutKsmOrBallooning() { final Cluster cluster = createDefaultCluster(); cluster.setMaxVdsMemoryOverCommit(-52); cluster.setEnableKsm(false); @@ -563,7 +563,7 @@ public void memoryOptimizationLowerThenZeroWithoutKsmOrBallooning(){ @Test @MockedConfig("configForClusterWithVirtGlusterServicesNotAllowed") - public void memoryOptimizationWithoutBallooning(){ + public void memoryOptimizationWithoutBallooning() { final Cluster cluster = createDefaultCluster(); cluster.setMaxVdsMemoryOverCommit(0); cluster.setEnableKsm(true); @@ -575,7 +575,7 @@ public void memoryOptimizationWithoutBallooning(){ @Test @MockedConfig("configForClusterWithVirtGlusterServicesNotAllowed") - public void memoryOptimizationWithoutKsm(){ + public void memoryOptimizationWithoutKsm() { final Cluster cluster = createDefaultCluster(); cluster.setMaxVdsMemoryOverCommit(200); cluster.setEnableKsm(false); @@ -587,7 +587,7 @@ public void memoryOptimizationWithoutKsm(){ @Test @MockedConfig("configForClusterWithVirtGlusterServicesNotAllowed") - public void memoryOptimizationWithKsmAndBallooning(){ + public void memoryOptimizationWithKsmAndBallooning() { final Cluster cluster = createDefaultCluster(); cluster.setMaxVdsMemoryOverCommit(200); cluster.setEnableKsm(true); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java index 8cad8798ef3..082825c719d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmHandlerTest.java @@ -112,7 +112,7 @@ private void populateVmWithDisks(List disks, VM vm) { false, "", null, - disk.getDiskStorageType() == DiskStorageType.IMAGE ? ((DiskImage)disk).getSnapshotId() : null, + disk.getDiskStorageType() == DiskStorageType.IMAGE ? ((DiskImage) disk).getSnapshotId() : null, null); vm.getManagedVmDeviceMap().put(disk.getId(), device); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java index 812c7a72cb3..56faf068b0b 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/common/comparator/NumericSuffixNameableComparatorTest.java @@ -39,7 +39,7 @@ public void compare(String name1, String name2, int expected) { assertThat(underTest.compare(nameable1, nameable2), expectedMatcher); } - public static Stream compare() { + public static Stream compare() { return Stream.of( Arguments.of(null, null, 0), Arguments.of(null, "", -1), diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java index ebc74b06a9e..9e0f7d45f59 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommandTest.java @@ -69,7 +69,7 @@ import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.compat.Version; import org.ovirt.engine.core.utils.MockConfigDescriptor; -import org.ovirt.engine.core.utils.MockedConfig; +import org.ovirt.engine.core.utils.MockedConfig; import org.ovirt.engine.core.utils.RandomUtils; import org.ovirt.engine.core.utils.RandomUtilsSeedingExtension; import org.ovirt.engine.core.vdsbroker.vdsbroker.CloudInitHandler; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicFlowTestUtils.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicFlowTestUtils.java index d0d1d11a496..dbd3f8b7ee8 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicFlowTestUtils.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicFlowTestUtils.java @@ -32,7 +32,7 @@ private static String printMapping(ExternalVnicProfileMapping mapping) { StringBuilder sb = new StringBuilder(); sb.append(mapping.getSourceNetworkName()).append(", ") .append(mapping.getSourceProfileName()).append(", ") - .append(mapping.getTargetProfileId() != null ? mapping.getTargetProfileId().toString(): "null").append(", ") + .append(mapping.getTargetProfileId() != null ? mapping.getTargetProfileId().toString() : "null").append(", ") .append(mapping.getTargetNetworkName()).append(", ") .append(mapping.getTargetProfileName()); return sb.toString(); @@ -74,11 +74,11 @@ private static void printContext(MapVnicContext ctx, String ctxName) { } } - static MapVnicContext makeCtx(Guid clusterId, ExternalVnicProfileMapping mapping, VmNetworkInterface vnic){ + static MapVnicContext makeCtx(Guid clusterId, ExternalVnicProfileMapping mapping, VmNetworkInterface vnic) { return new MapVnicContext().setClusterId(clusterId).setProfileMapping(mapping).setOvfVnic(vnic); } - static MapVnicContext makeCtx(Guid clusterId, VmNetworkInterface vnic){ + static MapVnicContext makeCtx(Guid clusterId, VmNetworkInterface vnic) { return new MapVnicContext().setClusterId(clusterId).setOvfVnic(vnic); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicsFlowTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicsFlowTest.java index 5029c953932..30f3ef334a8 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicsFlowTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/exportimport/vnics/MapVnicsFlowTest.java @@ -35,7 +35,7 @@ public class MapVnicsFlowTest { private static final ExternalVnicProfileMapping NO_SOURCE_MAPPING = new ExternalVnicProfileMapping(null, null, PROFILE_ID); private static final ExternalVnicProfileMapping NO_TARGET_MAPPING = new ExternalVnicProfileMapping(NETWORK_NAME, PROFILE2_NAME, null); - private static final ExternalVnicProfileMapping FULL_MAPPING = new ExternalVnicProfileMapping(NETWORK_NAME, PROFILE1_NAME, PROFILE_ID); + private static final ExternalVnicProfileMapping FULL_MAPPING = new ExternalVnicProfileMapping(NETWORK_NAME, PROFILE1_NAME, PROFILE_ID); private MapVnicsFlow underTest; @@ -48,11 +48,11 @@ public static Stream flow() { Pair someMappingsAndNullOvfs = testSomeMappingsAndNullOvfs(); return Stream.of( - Arguments.of(nullMappingsAndNullOvfs.getFirst(), nullMappingsAndNullOvfs.getSecond() ), - Arguments.of(nullMappingsAndEmptyOvfs.getFirst(), nullMappingsAndEmptyOvfs.getSecond() ), - Arguments.of(emptyMappingsAndEmptyOvfs.getFirst(), emptyMappingsAndEmptyOvfs.getSecond()), - Arguments.of(emptyMappingsAndNullOvfs.getFirst(), emptyMappingsAndNullOvfs.getSecond() ), - Arguments.of(someMappingsAndNullOvfs.getFirst(), someMappingsAndNullOvfs.getSecond() ) + Arguments.of(nullMappingsAndNullOvfs.getFirst(), nullMappingsAndNullOvfs.getSecond() ), + Arguments.of(nullMappingsAndEmptyOvfs.getFirst(), nullMappingsAndEmptyOvfs.getSecond() ), + Arguments.of(emptyMappingsAndEmptyOvfs.getFirst(), emptyMappingsAndEmptyOvfs.getSecond()), + Arguments.of(emptyMappingsAndNullOvfs.getFirst(), emptyMappingsAndNullOvfs.getSecond() ), + Arguments.of(someMappingsAndNullOvfs.getFirst(), someMappingsAndNullOvfs.getSecond() ) ); } @@ -141,7 +141,7 @@ private static Pair testSomeMappingsAndNullOvfs /** * setup a context with user input - mappings and ovf vnics - that would be under test */ - private static MapVnicsContext setupContext(List mappings, List vnics, String name){ + private static MapVnicsContext setupContext(List mappings, List vnics, String name) { return new MapVnicsContext(name).setUserMappings(mappings).setOvfVnics(vnics); } } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java index 752e936eb21..ffc15456b4b 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java @@ -248,7 +248,7 @@ public void validateFailsOnSameServer() { @Test public void validateFailsOnSameServerIncreasingReplica() { initTestCommand(volumeIdRepl, getBricks(volumeIdRepl, 2, true), 3, 0, false); - GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); + GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); vol.setVolumeType(GlusterVolumeType.DISTRIBUTED_REPLICATE); vol.setReplicaCount(2); doReturn(vol).when(volumeDao).getById(volumeIdRepl); @@ -262,7 +262,7 @@ public void validateSucceedsonServerCheckIncreasingReplica() { bricks.add(getBrick(volumeIdRepl, Guid.newGuid(), "/brick2")); initTestCommand(volumeIdRepl, bricks, 3, 0, false); doReturn(getVdsStatic()).when(vdsStaticDao).get(any()); - GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); + GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); vol.setVolumeType(GlusterVolumeType.DISTRIBUTED_REPLICATE); vol.setReplicaCount(2); doReturn(vol).when(volumeDao).getById(volumeIdRepl); @@ -276,7 +276,7 @@ public void validateSucceedsonServerCheck() { bricks.add(getBrick(volumeIdRepl, Guid.newGuid(), "/brick2")); initTestCommand(volumeIdRepl, bricks, 2, 0, false); doReturn(getVdsStatic()).when(vdsStaticDao).get(any()); - GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); + GlusterVolumeEntity vol = getMultiBrickVolume(volumeIdRepl, 4); vol.setVolumeType(GlusterVolumeType.DISTRIBUTED_REPLICATE); vol.setReplicaCount(2); doReturn(vol).when(volumeDao).getById(volumeIdRepl); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java index fd993d2df53..117af8fe366 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommandTest.java @@ -111,7 +111,7 @@ public void prepareMocks() { doReturn(getCluster(true, Version.v4_3)).when(clusterDao).get(any()); } - private GlusterVolumeEntity getVolume(int brickCount, boolean withDuplicateBricks){ + private GlusterVolumeEntity getVolume(int brickCount, boolean withDuplicateBricks) { return getVolume(brickCount, withDuplicateBricks, GlusterVolumeType.DISTRIBUTE, 0, false); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQueryTest.java index a6c92efaf80..ff9f253a308 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeGeoRepSessionsQueryTest.java @@ -17,7 +17,7 @@ import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.dao.gluster.GlusterGeoRepDao; -public class GetGlusterVolumeGeoRepSessionsQueryTest extends AbstractQueryTest>{ +public class GetGlusterVolumeGeoRepSessionsQueryTest extends AbstractQueryTest> { private Guid masterVolumeId = Guid.newGuid(); private Guid sessionId = Guid.newGuid(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java index fd6bed3a69d..89e1c082282 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java @@ -123,7 +123,7 @@ protected VDS getServer(Guid id, String name, Guid clusterId) { } protected VDS getServer(Guid id, String name, Guid clusterId, VDSStatus status) { - VDS server = new VDS(); + VDS server = new VDS(); server.setId(id); server.setVdsName(name); server.setStatus(status); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java index 13994e510cb..2e42c5b71c0 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJobTest.java @@ -102,7 +102,7 @@ private Object getHookContentVDSReturnVal() { private List getHooksList(int listCount, boolean setIds) { List hookList = new ArrayList<>(); - for (int i=0; i< listCount; i++) { + for (int i = 0; i < listCount; i++) { hookList.add(getHook( i , setIds)); } return hookList; @@ -115,7 +115,7 @@ private GlusterHookEntity getHook(int index, boolean setId) { hook.setStatus(GlusterHookStatus.ENABLED); hook.setGlusterCommand("create"); hook.setStage("PRE"); - hook.setName("hook-"+index); + hook.setName("hook-" + index); if (setId) { hook.setId(EXISTING_HOOK_IDS[index]); hook.setClusterId(CLUSTER_GUIDS[0]); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java index 7facca678a6..d1455133550 100755 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java @@ -174,7 +174,7 @@ private Step createStep(Guid taskGuid) { Calendar stepTime = Calendar.getInstance(); if (taskGuid.equals(TASK_GUIDS[2])) { //only create TASK_GUIDS[2] as older job - stepTime.set(Calendar.HOUR, stepTime.get(Calendar.HOUR) -1); + stepTime.set(Calendar.HOUR, stepTime.get(Calendar.HOUR) - 1); } step.setStartTime(stepTime.getTime()); return step; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java index ab8ad1b5394..62dcbd2630c 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterHooksCommandTest.java @@ -52,7 +52,7 @@ private Cluster getCluster() { } protected VDS getServer() { - VDS server = new VDS(); + VDS server = new VDS(); server.setId(Guid.newGuid()); server.setVdsName("VDS1"); server.setStatus(VDSStatus.Up); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java index d3f2438c101..1d7ba4324b7 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommandTest.java @@ -101,7 +101,7 @@ private List getBricks(Guid volumeId, int n) { } protected VDS getServer() { - VDS server = new VDS(); + VDS server = new VDS(); server.setId(Guid.newGuid()); server.setVdsName("VDS1"); server.setStatus(VDSStatus.Up); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeBrickCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeBrickCommandTest.java index c3fc19cd02e..a7b69bd63b9 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeBrickCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeBrickCommandTest.java @@ -109,13 +109,13 @@ private GlusterVolumeEntity getVolume(Guid volumeId, GlusterVolumeType volumeTyp volumeEntity.setName("test-vol"); volumeEntity.addAccessProtocol(AccessProtocol.GLUSTER); volumeEntity.addTransportType(TransportType.TCP); - if(volumeType.equals(GlusterVolumeType.DISTRIBUTED_REPLICATE)) { + if (volumeType.equals(GlusterVolumeType.DISTRIBUTED_REPLICATE)) { volumeEntity.setStatus((volumeId == volumeId1) ? GlusterStatus.UP : GlusterStatus.DOWN); volumeEntity.setBricks(getBricks(volumeId, "distrib", 2)); volumeEntity.setVolumeType(GlusterVolumeType.DISTRIBUTED_REPLICATE); volumeEntity.setClusterId(clusterId); return volumeEntity; - } else if(volumeType.equals(GlusterVolumeType.REPLICATE)) { + } else if (volumeType.equals(GlusterVolumeType.REPLICATE)) { volumeEntity.setStatus(GlusterStatus.UP); volumeEntity.setBricks(getBricks(volumeId, "repl", brickCount)); volumeEntity.setVolumeType(GlusterVolumeType.REPLICATE); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java index 785e50b2504..2751dde9dee 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResumeGeoRepSessionCommandTest.java @@ -21,7 +21,7 @@ protected ResumeGeoRepSessionCommand createCommand() { } protected GlusterGeoRepSession getGeoRepSession(Guid gSessionId, GeoRepSessionStatus status, Guid masterVolumeID) { - GlusterGeoRepSession session = super.getGeoRepSession(gSessionId, status); + GlusterGeoRepSession session = super.getGeoRepSession(gSessionId, status); session.setMasterVolumeId(startedVolumeId); return session; } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java index 99bea4f1219..1d2d0fd7a8c 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommandTest.java @@ -119,7 +119,7 @@ public void executeCommandFailedWhenServerIdPresent() { mockForReadContent(false, EngineError.GlusterHookNotFound); try { cmd.executeCommand(); - }catch (EngineException e) { + } catch (EngineException e) { assertEquals(EngineError.GlusterHookNotFound, e.getErrorCode()); } verify(hooksDao, never()).updateGlusterHook(any()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessorTest.java index 70a92fd7269..2ba88e76252 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/events/GlusterEventsProcessorTest.java @@ -11,7 +11,7 @@ public class GlusterEventsProcessorTest { @Test public void testEventsSerialize() { JsonObjectDeserializer deserializer = new JsonObjectDeserializer(); - String jsonBody="{'event': 'BRICK_CONNECTED', 'message': " + String jsonBody = "{'event': 'BRICK_CONNECTED', 'message': " + "{'peer': 'SERVER1', " + "'volume': 'vmstore', 'brick': '/gluster_bricks/vmstore/vmstore'}, " + "'nodeid': '82e53643-48ca-4808-a759-dfaaebc28914', 'ts': 1554962105}"; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/CopyHostNetworksHelperTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/CopyHostNetworksHelperTest.java index 6b72514bd3c..d5d0f830de9 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/CopyHostNetworksHelperTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/CopyHostNetworksHelperTest.java @@ -457,7 +457,7 @@ void printIfaceAttachment(String ifaceName, Guid networkId) { printShape(ifaceName); String networkName = toNetworkName(networkId); printShape(networkName); - printout.append(" " + prefix() + ifaceName + " -> " + prefix() + networkName); + printout.append(" " + prefix() + ifaceName + " -> " + prefix() + networkName); } printIfaceAttachment = true; } @@ -465,7 +465,7 @@ void printIfaceAttachment(String ifaceName, Guid networkId) { void printVlanToNetwork(Integer vlanId, Guid networkId) { String networkName = toNetworkName(networkId); printShape(networkName); - printout.append(" " + prefix() + toVlanName(vlanId) + " -> " + prefix() + networkName); + printout.append(" " + prefix() + toVlanName(vlanId) + " -> " + prefix() + networkName); printIfaceAttachment = false; } @@ -529,7 +529,7 @@ void printDigraphSuffix() { } void printDigraphPrefix() { - switch(node){ + switch (node) { case SOURCE: printout.append("digraph ScenarioResult {\n" + "\n" diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java index f1cf04be649..12c66f60c67 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java @@ -1181,7 +1181,7 @@ public void testAddNetworkToNicAlongWithAddingItIntoBond() { VdsNetworkInterface nicA = createNic("nicA"); VdsNetworkInterface nicB = createNic("nicB"); - NetworkAttachment networkAttachment = createNetworkAttachment(networkA, (Guid)null); + NetworkAttachment networkAttachment = createNetworkAttachment(networkA, (Guid) null); networkAttachment.setNicId(nicA.getId()); networkAttachment.setNicName(nicA.getName()); networkAttachment.setNetworkId(networkA.getId()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java index 1ca0b783a47..4e5fe3b9ee5 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java @@ -35,7 +35,7 @@ public class UnmanagedNetworkValidatorTest { private UnmanagedNetworkValidator validator = new UnmanagedNetworkValidator(); @Test - public void testFilterNicsWithUnmanagedNetworks(){ + public void testFilterNicsWithUnmanagedNetworks() { VdsNetworkInterface nicManaged = createNicWithNetworkImplementationDetails("eth0", true); VdsNetworkInterface nicUnmanaged = createNicWithNetworkImplementationDetails("eth1", false); List existingInterfaces = Arrays.asList(nicManaged, nicUnmanaged); @@ -45,14 +45,14 @@ public void testFilterNicsWithUnmanagedNetworks(){ } @Test - public void testFilterNicsWithUnmanagedNetworksNetworkImplementationDetailsIsNull(){ + public void testFilterNicsWithUnmanagedNetworksNetworkImplementationDetailsIsNull() { VdsNetworkInterface nicWithNetworkImplementationsDetailsNull = createNic("eth1"); List existingInterfaces = Collections.singletonList(nicWithNetworkImplementationsDetailsNull); Set unmanagedNicsSet = validator.filterNicsWithUnmanagedNetworks(existingInterfaces, Collections.emptySet()); assertTrue(unmanagedNicsSet.isEmpty()); } - public void testFilterNicsWithUnmanagedNetworksUmngmtNetRemoved(){ + public void testFilterNicsWithUnmanagedNetworksUmngmtNetRemoved() { VdsNetworkInterface nicWithUnmanagedToBeRemoved = createNicWithNetworkImplementationDetails("eth_unmanaged1_toBeRemoved", false); VdsNetworkInterface nicWithUnmanaged = createNicWithNetworkImplementationDetails("eth_unmanaged", false); @@ -69,7 +69,7 @@ public void testFilterNicsWithUnmanagedNetworksUmngmtNetRemoved(){ } @Test - public void testValidateLabels(){ + public void testValidateLabels() { String nicWithUnmanagedNetwork = "eth_unmanaged"; NicLabel label = new NicLabel(null, "eth1", "label1"); @@ -91,7 +91,7 @@ public void testValidateLabels(){ } @Test - public void testValidateLabelsForVlan(){ + public void testValidateLabelsForVlan() { Nic nic = createNic("eth0"); NicLabel label = new NicLabel(null, "eth1", "label1"); @@ -121,7 +121,7 @@ public void testValidateLabelsForVlan(){ } @Test - public void testValidateAttachements(){ + public void testValidateAttachements() { String unmanagedNicName = "eth0"; NetworkAttachment attachement1 = new NetworkAttachment(); attachement1.setNetworkName("network1"); @@ -151,7 +151,7 @@ public void testValidateAttachements(){ } @Test - public void testValidateAttachementsForVlans(){ + public void testValidateAttachementsForVlans() { String unmanagedBaseNicName = "eth0"; NetworkAttachment attachement1 = new NetworkAttachment(); @@ -183,7 +183,7 @@ public void testValidateAttachementsForVlans(){ } @Test - public void testValidateRemovedUnmanagedNetworks(){ + public void testValidateRemovedUnmanagedNetworks() { String networkName = "networkName"; Nic nic = createNicWithNetworkImplementationDetails("eth0", false); @@ -218,7 +218,7 @@ public void testValidateRemovedUnmanagedNetworks(){ ReplacementUtils.createSetVariableString(NETWORK, unmanagedNetworkNotPresentOnAnyNic))); } - private Nic createNic(String name){ + private Nic createNic(String name) { Nic nic = new Nic(); nic.setName(name); return nic; @@ -236,7 +236,7 @@ public VdsNetworkInterface createVlanNic(VdsNetworkInterface baseNic, String nic return vlanNic; } - private Nic createNicWithNetworkImplementationDetails(String name, boolean isManaged){ + private Nic createNicWithNetworkImplementationDetails(String name, boolean isManaged) { Nic nic = createNic(name); NetworkImplementationDetails networkImplementationDetails1 = new NetworkImplementationDetails(true, isManaged); nic.setNetworkImplementationDetails(networkImplementationDetails1); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacsStorageTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacsStorageTest.java index 77542216d93..dfbc2d666be 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacsStorageTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacsStorageTest.java @@ -34,7 +34,7 @@ public class MacsStorageTest { private static final int RANGE_TO = 19; private static final int NUMBER_OF_MACS = 12; private static final boolean ALLOW_DUPLICATES = true; - private static final List RANGE_BOUNDARIES =Arrays.asList( + private static final List RANGE_BOUNDARIES = Arrays.asList( RANGE_FROM, RANGE_FROM + NUMBER_OF_MACS / 3, RANGE_FROM + NUMBER_OF_MACS / 3 * 2, @@ -100,7 +100,7 @@ private void addRangesToStorage(List ranges, MacsStorage macsStorage) { } private void mockAvailableMacsInRange(List ranges, List rangesWithoutAvailableMacs) { - for(int i = 0; i < ranges.size(); i++) { + for (int i = 0; i < ranges.size(); i++) { Range range = ranges.get(i); boolean shouldBeEmpty = rangesWithoutAvailableMacs.contains(i); when(range.getAvailableCount()).thenReturn(shouldBeEmpty ? 0 : 1); @@ -109,7 +109,7 @@ private void mockAvailableMacsInRange(List ranges, List rangesWi private List createMockedRanges(int count) { List result = new ArrayList<>(count); - for(int i = 0; i < count; i++) { + for (int i = 0; i < count; i++) { result.add(mock(Range.class)); } return result; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/RangeTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/RangeTest.java index a097688e706..e197835f3b4 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/RangeTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/RangeTest.java @@ -88,7 +88,7 @@ public void testFreeMac() { assertThat(rangeOf10Macs.getAvailableCount(), is(0)); assertThat(rangeOf10Macs.containsDuplicates(), is(false)); - for(int i = 1; i <= NUMBER_OF_MACS; i++) { + for (int i = 1; i <= NUMBER_OF_MACS; i++) { rangeOf10Macs.freeMac(allocatedMacs.remove(0)); assertThat(rangeOf10Macs.getAvailableCount(), is(i)); assertThat(rangeOf10Macs.containsDuplicates(), is(false)); @@ -160,7 +160,7 @@ public void testMaxSizeRange() { public void testOrderOrAcquiredMACs() { Range range = new Range(new LongRange(0, 5)); List usedMacs = Arrays.asList(0, 2, 4); - for(int i = 0; i < 5; i++) { + for (int i = 0; i < 5; i++) { boolean usedMac = usedMacs.contains(i); if (usedMac) { boolean allowDuplicates = false; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VmNicFilterParameterCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VmNicFilterParameterCommandTest.java index 5532da8dee7..f709142f8b4 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VmNicFilterParameterCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VmNicFilterParameterCommandTest.java @@ -54,7 +54,7 @@ protected void validId(boolean isValid) { } private void validVmInterfaceId(boolean isValid) { - vmNicFilterParameter.setVmInterfaceId(isValid? Guid.newGuid() : null); + vmNicFilterParameter.setVmInterfaceId(isValid ? Guid.newGuid() : null); when(validator.vmInterfaceHavingIdExists(vmNicFilterParameter.getVmInterfaceId())).thenReturn( isValid ? ValidationResult.VALID : new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_INVALID_NIC_FILTER_PARAMETER_INTERFACE)); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/VmNicFilterParameterAnnotationTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/VmNicFilterParameterAnnotationTest.java index f50a0399fd7..e9cd4b9f64c 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/VmNicFilterParameterAnnotationTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/VmNicFilterParameterAnnotationTest.java @@ -61,7 +61,7 @@ public void validate(String name, String value, Guid vmInterfaceId, String expec validator.validate(vmNicFilterParameter, VALIDATE_GROUPS); boolean expectViolations = expectedErrorMessage != null; - assertTrue(expectViolations != violations.isEmpty()); + assertTrue(expectViolations != violations.isEmpty()); if (expectViolations) { assertEquals(expectedErrorMessage, violations.iterator().next().getMessage()); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java index 39829ab96eb..96578325ccf 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/pm/FenceProxyLocatorTest.java @@ -382,6 +382,6 @@ private void mockFenceAgents() { } private boolean shouldHostBeUnreachable(VDSStatus status) { - return status != VDSStatus.Up && status != VDSStatus.NonOperational; + return status != VDSStatus.Up && status != VDSStatus.NonOperational; } } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java index ea66855ae48..3da0ff23c83 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/AddCpuProfileCommandTest.java @@ -22,7 +22,7 @@ import org.ovirt.engine.core.compat.Guid; import org.ovirt.engine.core.dao.profiles.CpuProfileDao; -public class AddCpuProfileCommandTest extends BaseCommandTest{ +public class AddCpuProfileCommandTest extends BaseCommandTest { private static final Guid CLUSTER_ID = Guid.newGuid(); private static final String PROFILE_NAME = "profile name"; private static final String SESSION_ID = "S3SS10N1D"; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java index 04644197263..63237f48fd5 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/CpuProfileHelperTest.java @@ -71,7 +71,7 @@ public void testNullClusterId() { VmBase vmBase = createVmBase(cpuProfile1.getId()); vmBase.setClusterId(null); - ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); + ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); assertThat(res, failsWith(EngineMessage.ACTION_TYPE_CPU_PROFILE_CLUSTER_NOT_PROVIDED)); } @@ -79,7 +79,7 @@ public void testNullClusterId() { public void testNonExistingCpuProfile() { VmBase vmBase = createVmBase(Guid.newGuid()); - ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); + ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); assertThat(res, failsWith(EngineMessage.ACTION_TYPE_FAILED_CPU_PROFILE_NOT_FOUND)); } @@ -88,7 +88,7 @@ public void testDifferentClusters() { VmBase vmBase = createVmBase(cpuProfile1.getId()); vmBase.setClusterId(Guid.newGuid()); - ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); + ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); assertThat(res, failsWith(EngineMessage.ACTION_TYPE_CPU_PROFILE_NOT_MATCH_CLUSTER)); } @@ -96,7 +96,7 @@ public void testDifferentClusters() { public void testNoPermission() { VmBase vmBase = createVmBase(cpuProfile2.getId()); - ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); + ValidationResult res = cpuProfileHelper.setAndValidateCpuProfile(vmBase, USER_1_ID); assertThat(res, failsWith(EngineMessage.ACTION_TYPE_NO_PERMISSION_TO_ASSIGN_CPU_PROFILE)); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java index 005af5e7d2f..6b15cd54ac3 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java @@ -84,7 +84,7 @@ public void setUp() { command = new CommandBase( param, CommandContext.createContext(param.getSessionId())) { @Override - protected void executeCommand() {} + protected void executeCommand() { } @Override public List getPermissionCheckSubjects() { diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java index a738be201db..0a2629bbc23 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPoliciesTest.java @@ -25,7 +25,7 @@ public class InternalClusterPoliciesTest { @Test public void testConfiguredPolicyCreation() { assertNotNull(InternalClusterPolicies.getClusterPolicies()); - assertNotEquals(0, (long)InternalClusterPolicies.getClusterPolicies().size()); + assertNotEquals(0, (long) InternalClusterPolicies.getClusterPolicies().size()); } @Test @@ -98,8 +98,8 @@ public void testPolicyCreation() { funcMap.put(pair.getFirst(), pair.getSecond()); } - assertEquals(1, (long)funcMap.get(getUnitId(HaReservationWeightPolicyUnit.class))); - assertEquals(2, (long)funcMap.get(getUnitId(VmAffinityWeightPolicyUnit.class))); + assertEquals(1, (long) funcMap.get(getUnitId(HaReservationWeightPolicyUnit.class))); + assertEquals(2, (long) funcMap.get(getUnitId(VmAffinityWeightPolicyUnit.class))); } private Guid getUnitId(Class unit) { diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManagerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManagerTest.java index a06f077055e..733b3334760 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManagerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/pending/PendingResourceManagerTest.java @@ -93,7 +93,7 @@ public void testAddPending() { Set pending = PendingVM.collectForHost(manager, host.getId()); assertEquals(2, pending.size()); assertEquals(11, PendingCpuCores.collectForHost(manager, host.getId())); - assertEquals(1024+768, PendingMemory.collectForHost(manager, host.getId())); + assertEquals(1024 + 768, PendingMemory.collectForHost(manager, host.getId())); assertEquals(host.getId(), PendingVM.getScheduledHost(manager, vm1)); assertEquals(host.getId(), PendingVM.getScheduledHost(manager, vm2)); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/AbstractPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/AbstractPolicyUnitTest.java index 5c8014c9662..68ad51ea015 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/AbstractPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/AbstractPolicyUnitTest.java @@ -61,7 +61,7 @@ Object convert(Class type, String value, Map> cach if (converter != null) { return converter.invoke(type, value); } - } catch (NoSuchMethodException|InvocationTargetException|IllegalAccessException ex) { + } catch (NoSuchMethodException | InvocationTargetException | IllegalAccessException ex) { // ignore and try the next method } @@ -74,7 +74,7 @@ Object convert(Class type, String value, Map> cach return null; } return constructor.newInstance(value); - } catch (NoSuchMethodException|InstantiationException|IllegalAccessException|InvocationTargetException ex) { + } catch (NoSuchMethodException | InstantiationException | IllegalAccessException | InvocationTargetException ex) { // ignore and try the next method } @@ -90,7 +90,7 @@ E setField(E entity, String fieldName, String value, Map fieldType = f.getType(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java index d644e49430c..a9e91a443b7 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/CpuPinningPolicyUnitTest.java @@ -90,7 +90,7 @@ public void setUp() { @Test public void shouldHandleEmptyHostList() { vm.setCpuPinning("1#0_2#3"); - final List filteredHost = policyUnit.filter(new SchedulingContext(cluster, Collections.emptyMap()), new ArrayList<>(), vm, mock(PerHostMessages.class)); + final List filteredHost = policyUnit.filter(new SchedulingContext(cluster, Collections.emptyMap()), new ArrayList<>(), vm, mock(PerHostMessages.class)); assertThat(filteredHost, is(empty())); assertThat(messages(), is(empty())); } @@ -132,13 +132,13 @@ public void shouldDetectOfflineCpu() { } @Test - public void shouldExcludeHostWithoutCpuInformation(){ + public void shouldExcludeHostWithoutCpuInformation() { vm.setCpuPinning("1#0_2#4"); assertThat(filter(), not(hasItem(hostWithoutCpus))); } @Test - public void shouldHandleExcludedCpu(){ + public void shouldHandleExcludedCpu() { vm.setCpuPinning("1#3-5,^4"); assertThat(filter(), hasItem(hostWithCpus)); assertThat(messages(), hasSize(1)); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java index 6f9152eb4b1..3cc57a3f27d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/EvenDistributionWeightPolicyUnitTest.java @@ -70,7 +70,7 @@ public static Stream> mockConfiguration() { private EvenDistributionCPUWeightPolicyUnit evenDistributionCPUWeightPolicyUnit = new EvenDistributionCPUWeightPolicyUnit(null, new PendingResourceManager()); @InjectMocks - private EvenDistributionMemoryWeightPolicyUnit evenDistributionMemoryWeightPolicyUnit = new EvenDistributionMemoryWeightPolicyUnit(null, new PendingResourceManager()); + private EvenDistributionMemoryWeightPolicyUnit evenDistributionMemoryWeightPolicyUnit = new EvenDistributionMemoryWeightPolicyUnit(null, new PendingResourceManager()); @BeforeEach public void setUp() { @@ -106,7 +106,7 @@ protected void testScore(T unit, } } - protected Guid selectedBestHost(T unit, VM vm, ArrayList hosts) { + protected Guid selectedBestHost(T unit, VM vm, ArrayList hosts) { List> scores = unit.score( new SchedulingContext(new Cluster(), Collections.emptyMap()), hosts, diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyTestBase.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyTestBase.java index 9fb7dd3957f..b9d6b2ebf5d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyTestBase.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyTestBase.java @@ -52,7 +52,7 @@ protected static VDS createHost(int nodeCount, long nodeSize, int coresPerNode) node.setNumaNodeStatistics(new NumaNodeStatistics()); node.getNumaNodeStatistics().setMemFree(nodeSize); - node.setCpuIds(IntStream.range(i * coresPerNode, (i+1) * coresPerNode) + node.setCpuIds(IntStream.range(i * coresPerNode, (i + 1) * coresPerNode) .boxed() .collect(Collectors.toList()) ); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnitTest.java index ee31d258eef..a47d07e66ae 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaPolicyUnitTest.java @@ -24,7 +24,7 @@ @ExtendWith(MockitoExtension.class) @MockitoSettings(strictness = Strictness.LENIENT) -public class NumaPolicyUnitTest extends NumaPolicyTestBase{ +public class NumaPolicyUnitTest extends NumaPolicyTestBase { private static final long NODE_SIZE = 1024; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaWeightPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaWeightPolicyUnitTest.java index 18951b722f4..b2ce333fb73 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaWeightPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/NumaWeightPolicyUnitTest.java @@ -28,7 +28,7 @@ @ExtendWith({MockitoExtension.class, MockConfigExtension.class}) @MockitoSettings(strictness = Strictness.LENIENT) -public class NumaWeightPolicyUnitTest extends NumaPolicyTestBase{ +public class NumaWeightPolicyUnitTest extends NumaPolicyTestBase { public static Stream> mockConfiguration() { return Stream.of( @@ -37,7 +37,7 @@ public static Stream> mockConfiguration() { } @InjectMocks - private NumaWeightPolicyUnit unit = new NumaWeightPolicyUnit(null, null); + private NumaWeightPolicyUnit unit = new NumaWeightPolicyUnit(null, null); private VM vm; private VDS host1; diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java index 72ebf5d8c51..37d522b2cf0 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingWeightPolicyUnitTest.java @@ -74,7 +74,7 @@ public static Stream> mockConfiguration() { private VdsManager vdsManager; @InjectMocks - private PowerSavingCPUWeightPolicyUnit powerSavingCPUWeightPolicyUnit = new PowerSavingCPUWeightPolicyUnit(null, new PendingResourceManager()); + private PowerSavingCPUWeightPolicyUnit powerSavingCPUWeightPolicyUnit = new PowerSavingCPUWeightPolicyUnit(null, new PendingResourceManager()); @InjectMocks private PowerSavingMemoryWeightPolicyUnit powerSavingMemoryWeightPolicyUnit = new PowerSavingMemoryWeightPolicyUnit(null, new PendingResourceManager()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnitTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnitTest.java index cb7c351a8d6..678428790b0 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnitTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PreferredHostsWeightPolicyUnitTest.java @@ -50,7 +50,7 @@ public void testHostPreference() { results.put(r.getFirst(), r.getSecond()); } - assertEquals(0, (long)results.get(host2.getId())); + assertEquals(0, (long) results.get(host2.getId())); assertNotEquals(0, (long) results.get(host1.getId())); assertNotEquals(0, (long) results.get(host3.getId())); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java index 601f3caf35a..7b6722ee5b2 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandTest.java @@ -88,7 +88,7 @@ public void setUp() { doReturn(ValidationResult.VALID).when(diskImagesValidator).diskImagesSnapshotsNotAttachedToOtherVms(false); } - private void mockStorageDomain(){ + private void mockStorageDomain() { StorageDomain storageDomain = new StorageDomain(); storageDomain.setStorageType(StorageType.NFS); doReturn(storageDomain).when(cmd).getStorageDomain(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java index 094b5f79b10..8f68d6b4401 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandTest.java @@ -96,7 +96,7 @@ public void setUp() { spySdValidator(); } - private void mockStorageDomain(){ + private void mockStorageDomain() { StorageDomain storageDomain = new StorageDomain(); storageDomain.setStorageType(StorageType.NFS); doReturn(storageDomain).when(cmd).getStorageDomain(); @@ -277,7 +277,7 @@ private DiskImage mockSourceImage() { private List mockDisksList(int numberOfDisks) { List disksList = new ArrayList<>(numberOfDisks); for (int index = 0; index < numberOfDisks; index++) { - DiskImage image =createDiskImage(STORAGE_DOMAIN_ID); + DiskImage image = createDiskImage(STORAGE_DOMAIN_ID); disksList.add(image); } doReturn(disksList).when(cmd).getSourceImages(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java index 8ce376f480b..f757d7aceaf 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotVmConfigurationHelperTest.java @@ -73,7 +73,7 @@ public void testIllegalImageReturnedByQuery() { snapshotVmConfigurationHelper.markImagesIllegalIfNotInDb(existingVm, existingSnapshotId); for (Disk diskImage : existingVm.getDiskMap().values()) { - assertEquals(ImageStatus.ILLEGAL, ((DiskImage)diskImage).getImageStatus()); + assertEquals(ImageStatus.ILLEGAL, ((DiskImage) diskImage).getImageStatus()); } } } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java index cbcd8f6fdb8..f96a4e56e66 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/AddStorageServerConnectionCommandTest.java @@ -177,8 +177,8 @@ public void addISCSIEmptyConn() { @Test public void isConnWithSameDetailsExist() { - StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3650", "user1", "mypassword123"); - StorageServerConnections existingConn = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3650", "user1", "mypassword123"); + StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3650", "user1", "mypassword123"); + StorageServerConnections existingConn = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3650", "user1", "mypassword123"); existingConn.setId(Guid.newGuid().toString()); when(iscsiStorageHelper.findConnectionsByAddressPortAndIqn(newISCSIConnection)).thenReturn(Collections.singletonList(existingConn)); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java index 41cae02765e..f4b799a0bed 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/connection/UpdateStorageServerConnectionCommandTest.java @@ -486,7 +486,7 @@ public void succeedValidatePosix() { @Test public void succeedUpdateNFSCommandWithDomain() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -532,7 +532,7 @@ public void succeedUpdateNFSCommandNoDomain() { @Test public void failUpdateStats() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -559,7 +559,7 @@ public void failUpdateStats() { @Test public void failUpdateConnectToStorage() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -584,7 +584,7 @@ public void failUpdateConnectToStorage() { @Test public void isConnWithSameDetailsExistFileDomains() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -612,7 +612,7 @@ public void isConnWithSameDetailsExistFileDomains() { @Test public void isConnWithSameDetailsExistSameConnection() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -627,7 +627,7 @@ public void isConnWithSameDetailsExistSameConnection() { @Test public void isConnWithSameDetailsExistNoConnections() { - StorageServerConnections newNFSConnection = createNFSConnection( + StorageServerConnections newNFSConnection = createNFSConnection( "multipass.my.domain.tlv.company.com:/export/allstorage/data2", StorageType.NFS, NfsVersion.V4, @@ -642,7 +642,7 @@ public void isConnWithSameDetailsExistNoConnections() { @Test public void isConnWithSameDetailsExistBlockDomains() { - StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3260", "user1", "mypassword123"); + StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3260", "user1", "mypassword123"); StorageServerConnections connection1 = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3260", "user1", "mypassword123"); when(iscsiStorageHelper.findConnectionsByAddressPortAndIqn(newISCSIConnection)).thenReturn(Collections.singletonList(connection1)); @@ -652,7 +652,7 @@ public void isConnWithSameDetailsExistBlockDomains() { @Test public void isConnWithSameDetailsExistCheckSameConn() { - StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3260", "user1", "mypassword123"); + StorageServerConnections newISCSIConnection = createISCSIConnection("1.2.3.4", StorageType.ISCSI, "iqn.2013-04.myhat.com:aaa-target1", "3260", "user1", "mypassword123"); when(iscsiStorageHelper.findConnectionsByAddressPortAndIqn(newISCSIConnection)).thenReturn(Collections.singletonList(newISCSIConnection)); boolean isExists = !command.isConnWithSameDetailsExists(newISCSIConnection, null).isEmpty(); assertTrue(isExists); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java index 93f29944d6e..1e9e935afd5 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommandTest.java @@ -897,8 +897,8 @@ public void testValidateQuota() { mockEntities(storageId); Guid quotaId = Guid.newGuid(); - ((DiskImage)command.getParameters().getDiskInfo()).setSize(1); - ((DiskImage)command.getParameters().getDiskInfo()).setQuotaId(quotaId); + ((DiskImage) command.getParameters().getDiskInfo()).setSize(1); + ((DiskImage) command.getParameters().getDiskInfo()).setQuotaId(quotaId); doReturn(ValidationResult.VALID).when(quotaValidator).isValid(); doReturn(ValidationResult.VALID).when(quotaValidator).isDefinedForStoragePool(any(Guid.class)); @@ -927,7 +927,7 @@ public void testValidateFailsForPassDiscard() { command, EngineMessage.ACTION_TYPE_FAILED_PASS_DISCARD_NOT_SUPPORTED_BY_DISK_INTERFACE); } - private void clearValidationMessages(){ + private void clearValidationMessages() { command.getReturnValue() .getValidationMessages() .clear(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java index 1326384b295..c24c99df080 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/RemoveDiskCommandTest.java @@ -119,7 +119,7 @@ public void testValidateTemplateEntity() { ArrayList storageIds = new ArrayList<>(); storageIds.add(domain.getId()); storageIds.add(Guid.newGuid()); - ((DiskImage)disk).setStorageIds(storageIds); + ((DiskImage) disk).setStorageIds(storageIds); doReturn(domain).when(cmd).getStorageDomain(); doReturn(new VmTemplate()).when(cmd).getVmTemplate(); @@ -138,7 +138,7 @@ public void testValidateTemplateWithNoDomain() { @Test public void testValidateOvfDiskNotIllegal() { - ((DiskImage)disk).setImageStatus(ImageStatus.OK); + ((DiskImage) disk).setImageStatus(ImageStatus.OK); disk.setContentType(DiskContentType.OVF_STORE); ValidateTestUtils.runAndAssertValidateFailure(cmd, EngineMessage.ACTION_TYPE_FAILED_OVF_DISK_NOT_IN_APPLICABLE_STATUS); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommandTest.java index c5efe559257..db0e226740b 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/UpdateDiskCommandTest.java @@ -526,7 +526,7 @@ public void testAmendAndUpdate() { initializeCommand(); command.executeVmCommand(); List phaseList = command.getParameters().getDiskUpdatePhases(); - UpdateDiskParameters.Phase phase = phaseList.get(phaseList.size()-1); + UpdateDiskParameters.Phase phase = phaseList.get(phaseList.size() - 1); assertEquals(UpdateDiskParameters.Phase.UPDATE_DISK, phase); } @@ -544,7 +544,7 @@ public void testAmendExtendAndUpdate() { initializeCommand(); command.executeVmCommand(); List phaseList = command.getParameters().getDiskUpdatePhases(); - UpdateDiskParameters.Phase phase = phaseList.get(phaseList.size()-1); + UpdateDiskParameters.Phase phase = phaseList.get(phaseList.size() - 1); assertEquals(UpdateDiskParameters.Phase.UPDATE_DISK, phase); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java index bf0b8ab648c..ced0047d325 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/cinder/GetUnregisteredCinderDisksByStorageDomainIdQueryTest.java @@ -79,7 +79,7 @@ public void executeQueryCommand() { assertDiskFromVolume(volumes.get(2), result.get(1)); } - private void assertDiskFromVolume(Volume volume, CinderDisk disk) { + private void assertDiskFromVolume(Volume volume, CinderDisk disk) { assertEquals(volume.getId(), disk.getId().toString()); assertEquals(volume.getName(), disk.getDiskAlias()); assertEquals(volume.getSize().intValue(), disk.getSizeInGigabytes()); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java index f709a3d98a9..c61ae54c176 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandlerTest.java @@ -211,7 +211,7 @@ public void testAggregateDiskImagesSnapshots() { @Test public void testAggregateDiskImagesSnapshotsWithEmptyList() { - Collection result = imagesHandler.aggregateDiskImagesSnapshots(Collections.emptyList()); + Collection result = imagesHandler.aggregateDiskImagesSnapshots(Collections.emptyList()); assertTrue(result.isEmpty(), "should return an empty list"); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java index 4a1717e9331..b32627a1676 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java @@ -81,7 +81,7 @@ public class TransferDiskImageCommandTest extends BaseCommandTest { @Spy @InjectMocks - private TransferDiskImageCommand transferImageCommand = + private TransferDiskImageCommand transferImageCommand = new TransferDiskImageCommand<>(new TransferDiskImageParameters(), null); public static Stream> mockConfiguration() { diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQueryTest.java index 149314b679f..2ac6940771f 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/lun/GetLunsByVgIdQueryTest.java @@ -44,7 +44,7 @@ public class GetLunsByVgIdQueryTest extends AbstractQueryTest cmd = - new AddStorageDomainCommon<>(new StorageDomainManagementParameter(), null){}; + new AddStorageDomainCommon<>(new StorageDomainManagementParameter(), null) { }; public static Stream> mockConfiguration() { return Stream.of(MockConfigDescriptor.of(ConfigValues.StorageDomainNameSizeLimit, 10)); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportExportRepoImageCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportExportRepoImageCommandTest.java index 71314a2fcc4..2aeaef49733 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportExportRepoImageCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/repoimage/ImportExportRepoImageCommandTest.java @@ -40,7 +40,7 @@ public void setUp() { diskStorageDomain.setStoragePoolId(storagePoolId); diskStorageDomain.setStatus(StorageDomainStatus.Active); - storagePool = new StoragePool(); + storagePool = new StoragePool(); storagePool.setId(storagePoolId); storagePool.setStatus(StoragePoolStatus.Up); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java index 51fb89d6ea8..a74776ed644 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/GlusterUtilTest.java @@ -126,7 +126,7 @@ public void testGetGlusterIpv4address() { VdsNetworkInterface vdsNetworkInterfaceClusterHost = new VdsNetworkInterface(); VdsNetworkInterface vdsNetworkInterfaceClusterHost2 = new VdsNetworkInterface(); List vdsNetworkInterfaceOldHostList = new ArrayList<>(); - List vdsNetworkInterfaceClusterHostList= new ArrayList<>(); + List vdsNetworkInterfaceClusterHostList = new ArrayList<>(); List vdsNetworkInterfaceClusterHost2List = new ArrayList<>(); VDS vds1 = new VDS(); @@ -178,7 +178,7 @@ public void testGetGlusterIpv6address() { VdsNetworkInterface vdsNetworkInterfaceClusterHostIpv6 = new VdsNetworkInterface(); VdsNetworkInterface vdsNetworkInterfaceClusterHost2Ipv6 = new VdsNetworkInterface(); List vdsNetworkInterfaceOldHostListIpv6 = new ArrayList<>(); - List vdsNetworkInterfaceClusterHostListIpv6= new ArrayList<>(); + List vdsNetworkInterfaceClusterHostListIpv6 = new ArrayList<>(); List vdsNetworkInterfaceClusterHost2ListIpv6 = new ArrayList<>(); VDS vds1 = new VDS(); diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java index 2d91052ea48..737e9049f83 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java @@ -323,10 +323,10 @@ public void networkInUseByOneVm() { @Test public void networkInUseByManyVms() { VM vm1 = mock(VM.class); - when(vm1.getName()).thenReturn(NAMEABLE_NAME+1); + when(vm1.getName()).thenReturn(NAMEABLE_NAME + 1); VM vm2 = mock(VM.class); - when(vm2.getName()).thenReturn(NAMEABLE_NAME+2); + when(vm2.getName()).thenReturn(NAMEABLE_NAME + 2); networkNotUsedByVmsTest(failsWithManyNetworkInUse(), Arrays.asList(vm1, vm2)); } @@ -352,10 +352,10 @@ public void networkInUseByOneHost() { @Test public void networkInUseByManyHosts() { VDS host1 = mock(VDS.class); - when(host1.getName()).thenReturn(NAMEABLE_NAME+1); + when(host1.getName()).thenReturn(NAMEABLE_NAME + 1); VDS host2 = mock(VDS.class); - when(host2.getName()).thenReturn(NAMEABLE_NAME+2); + when(host2.getName()).thenReturn(NAMEABLE_NAME + 2); networkNotUsedByHostsTest(failsWithManyNetworkInUse(), Arrays.asList(host1, host2)); } @@ -381,10 +381,10 @@ public void networkInUseByOneTemplate() { @Test public void networkInUseByManyTemplates() { VmTemplate template1 = mock(VmTemplate.class); - when(template1.getName()).thenReturn(NAMEABLE_NAME+1); + when(template1.getName()).thenReturn(NAMEABLE_NAME + 1); VmTemplate template2 = mock(VmTemplate.class); - when(template2.getName()).thenReturn(NAMEABLE_NAME+2); + when(template2.getName()).thenReturn(NAMEABLE_NAME + 2); networkNotUsedByTemplatesTest(failsWithManyNetworkInUse(), Arrays.asList(template1, template2)); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java index dd3e5365eb1..3f72a6ab0c1 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java @@ -235,14 +235,14 @@ private void passthroughIsLinkedCommon(boolean isPassthrough, boolean isLinked, } @Test - public void forbidEmptyProfileForHostedEngineVm(){ + public void forbidEmptyProfileForHostedEngineVm() { vm.setOrigin(OriginType.HOSTED_ENGINE); assertThat(validator.validateProfileNotEmptyForHostedEngineVm(vm), failsWith(EngineMessage.HOSTED_ENGINE_VM_CANNOT_HAVE_NIC_WITH_EMPTY_PROFILE)); } @Test - public void allowEmptyProfileForNonHostedEngineVm(){ + public void allowEmptyProfileForNonHostedEngineVm() { vm.setOrigin(OriginType.RHEV); assertThat(validator.validateProfileNotEmptyForHostedEngineVm(vm), isValid()); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java index ce7a7e2a200..cfaa1a1e258 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java @@ -429,7 +429,7 @@ public void nonPassthroughProfileContainsPortMirroringAndQos() { } @Test - public void testValidNetworkFilterIdUseDefaultNoFilterId(){ + public void testValidNetworkFilterIdUseDefaultNoFilterId() { assertThat(validator.validUseDefaultNetworkFilterFlag(true), isValid()); } @@ -445,12 +445,12 @@ public void testValidNetworkFilterIdUseDefaultWithFilterId() { } @Test - public void testValidNetworkFilterIdNoDefaultNoFilterId(){ + public void testValidNetworkFilterIdNoDefaultNoFilterId() { assertThat(validator.validUseDefaultNetworkFilterFlag(false), isValid()); } @Test - public void testValidNetworkFilterIdNoDefaultWithFilterId(){ + public void testValidNetworkFilterIdNoDefaultWithFilterId() { when(vnicProfile.getNetworkFilterId()).thenReturn(Guid.newGuid()); assertThat(validator.validUseDefaultNetworkFilterFlag(false), isValid()); } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java index 87a2c84fa6b..c3c4a4633c6 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/MultipleStorageDomainsValidatorTest.java @@ -116,7 +116,7 @@ public void testAllDomainsNotBackupDomainsOneBackup() { @Test public void testAllDomainsWithinThresholdAllOk() { - domain1.getStorageDynamicData().setAvailableDiskSize(CRITICAL_SPACE_THRESHOLD +1); + domain1.getStorageDynamicData().setAvailableDiskSize(CRITICAL_SPACE_THRESHOLD + 1); domain2.getStorageDynamicData().setAvailableDiskSize(CRITICAL_SPACE_THRESHOLD); domain1.setCriticalSpaceActionBlocker(CRITICAL_SPACE_THRESHOLD); domain2.setCriticalSpaceActionBlocker(CRITICAL_SPACE_THRESHOLD); @@ -134,7 +134,7 @@ public void testAllDomainsWithinThresholdsOneLacking() { } @Test - public void testAllDomainsHaveSpaceForNewDisksSuccess(){ + public void testAllDomainsHaveSpaceForNewDisksSuccess() { List sdIds = Arrays.asList(sdId1, sdId2); List disksList = generateDisksList(NUM_DISKS, sdIds); @@ -146,7 +146,7 @@ public void testAllDomainsHaveSpaceForNewDisksSuccess(){ } @Test - public void testAllDomainsHaveSpaceForNewDisksFail(){ + public void testAllDomainsHaveSpaceForNewDisksFail() { List sdIds = Arrays.asList(sdId1, sdId2); List disksList = generateDisksList(NUM_DISKS, sdIds); @@ -160,7 +160,7 @@ public void testAllDomainsHaveSpaceForNewDisksFail(){ } @Test - public void testAllDomainsHaveSpaceForClonedDisksSuccess(){ + public void testAllDomainsHaveSpaceForClonedDisksSuccess() { List sdIds = Arrays.asList(sdId1, sdId2); List disksList = generateDisksList(NUM_DISKS, sdIds); @@ -172,7 +172,7 @@ public void testAllDomainsHaveSpaceForClonedDisksSuccess(){ } @Test - public void testAllDomainsHaveSpaceForClonedDisksFail(){ + public void testAllDomainsHaveSpaceForClonedDisksFail() { List sdIds = Arrays.asList(sdId1, sdId2); List disksList = generateDisksList(NUM_DISKS, sdIds); @@ -186,7 +186,7 @@ public void testAllDomainsHaveSpaceForClonedDisksFail(){ } @Test - public void testAllDomainsHaveSpaceForAllDisksSuccess(){ + public void testAllDomainsHaveSpaceForAllDisksSuccess() { List sdIdsForNew = Arrays.asList(sdId1, sdId2); List sdIdsForCloned = Arrays.asList(sdId2, sdId3); List disksListForNew = generateDisksList(NUM_DISKS, sdIdsForNew); @@ -200,7 +200,7 @@ public void testAllDomainsHaveSpaceForAllDisksSuccess(){ } @Test - public void testAllDomainsHaveSpaceForAllDisksFail(){ + public void testAllDomainsHaveSpaceForAllDisksFail() { List sdIdsForNew = Arrays.asList(sdId1, sdId2); List sdIdsForCloned = Arrays.asList(sdId2, sdId3); List disksListForNew = generateDisksList(NUM_DISKS, sdIdsForNew); @@ -216,7 +216,7 @@ public void testAllDomainsHaveSpaceForAllDisksFail(){ } @Test - public void testAllDomainsHaveSpaceForMergeSuccess(){ + public void testAllDomainsHaveSpaceForMergeSuccess() { StorageDomainValidator storageDomainValidator = mock(StorageDomainValidator.class); List subchain = createSubchain(Collections.singletonList(sdId1)); doReturn(storageDomainValidator).when(validator).getStorageDomainValidator(any()); @@ -226,7 +226,7 @@ public void testAllDomainsHaveSpaceForMergeSuccess(){ } @Test - public void testAllDomainsHaveSpaceForMergeFail(){ + public void testAllDomainsHaveSpaceForMergeFail() { StorageDomainValidator storageDomainValidator = mock(StorageDomainValidator.class); List subchain = createSubchain(Collections.singletonList(sdId1)); doReturn(new ValidationResult(EngineMessage.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN)). @@ -238,7 +238,7 @@ public void testAllDomainsHaveSpaceForMergeFail(){ } @Test - public void testAllDomainsHaveSpaceForMergeBrokenSubchainFail(){ + public void testAllDomainsHaveSpaceForMergeBrokenSubchainFail() { StorageDomainValidator storageDomainValidator = mock(StorageDomainValidator.class); List subchain = new ArrayList<>(); doReturn(new ValidationResult(EngineMessage.ERROR_CANNOT_REMOVE_SNAPSHOT_ILLEGAL_IMAGE)). diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java index b4c97316e62..3be5d0007fa 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java @@ -137,7 +137,7 @@ public void testCanAttachMultipleISOOrExport() { ValidationResult attachMultipleISOOrExportResult = validator.validateDomainCanBeAttachedToPool(); assertThat("Attaching domain of type " + type + " succeeded though another domain of the same type already exists in the pool", attachMultipleISOOrExportResult, - failsWith(type == StorageDomainType.ISO ? EngineMessage.ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN : + failsWith(type == StorageDomainType.ISO ? EngineMessage.ERROR_CANNOT_ATTACH_MORE_THAN_ONE_ISO_DOMAIN : EngineMessage.ERROR_CANNOT_ATTACH_MORE_THAN_ONE_EXPORT_DOMAIN)); } } diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java index 8a269abf9e4..9fa9963446d 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/utils/ovf/OvfManagerTest.java @@ -127,7 +127,7 @@ public void setUp() { when(osRepository.getArchitectureFromOS(anyInt())).thenReturn(ArchitectureType.x86_64); when(osRepository.getUniqueOsNames()).thenReturn(osIdsToNames); when(osRepository.getOsIdByUniqueName(any())).thenAnswer( - invocation-> osIdsToNames.entrySet() + invocation -> osIdsToNames.entrySet() .stream() .filter(k -> invocation.getArguments()[0].equals(k.getValue())) .map(Map.Entry::getKey) @@ -180,7 +180,7 @@ public void testVmOvfCreationDefaultGraphicsDeviceFallbackToSupported() throws E VM vm = createVM(); vm.setDefaultDisplayType(DisplayType.qxl); vm.setVmOs(EXISTING_OS_ID); - String xml = manager.exportVm(vm, new FullEntityOvfData(vm), Version.getLast()); + String xml = manager.exportVm(vm, new FullEntityOvfData(vm), Version.getLast()); assertNotNull(xml); final VM newVm = new VM(); FullEntityOvfData fullEntityOvfData = new FullEntityOvfData(newVm); diff --git a/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingServlet.java b/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingServlet.java index 5355dc66680..c71c7429e94 100644 --- a/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingServlet.java +++ b/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingServlet.java @@ -60,7 +60,7 @@ public void doGet(final HttpServletRequest request, */ File getFile(final File brandingRootPath, final String path) { File result = null; - String mergedPath = new File(brandingRootPath.getAbsolutePath(), path == null ? "": path).getAbsolutePath(); + String mergedPath = new File(brandingRootPath.getAbsolutePath(), path == null ? "" : path).getAbsolutePath(); if (path != null && ServletUtils.isSane(mergedPath)) { // Return a result relative to the branding root path. result = new File(mergedPath); diff --git a/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java b/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java index cbfaaa6dcae..83c174e1939 100644 --- a/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java +++ b/backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java @@ -397,8 +397,8 @@ private String readTemplateFile(final String templateKey) { try ( InputStream in = new FileInputStream(templateFileName); Reader reader = new InputStreamReader(in, StandardCharsets.UTF_8); - BufferedReader bufferedReader= new BufferedReader(reader); - ){ + BufferedReader bufferedReader = new BufferedReader(reader); + ) { String currentLine; while ((currentLine = bufferedReader.readLine()) != null) { if (!currentLine.startsWith("#")) { // # is comment. diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java index cf6dfd760ac..dc2bc859569 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java @@ -199,7 +199,7 @@ public enum ActionType { DestroyImage(239, QuotaDependency.STORAGE), MergeExtend(241, QuotaDependency.STORAGE), SparsifyImage(244, ActionGroup.SPARSIFY_DISK, QuotaDependency.NONE), - AmendImageGroupVolumes(245, ActionGroup.EDIT_DISK_PROPERTIES, QuotaDependency.NONE), + AmendImageGroupVolumes(245, ActionGroup.EDIT_DISK_PROPERTIES, QuotaDependency.NONE), ColdMergeSnapshotSingleDisk(246, QuotaDependency.STORAGE), PrepareMerge(247, QuotaDependency.STORAGE), ColdMerge(248, QuotaDependency.STORAGE), diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java index c0f7ae1b693..abf8e747830 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromSnapshotParameters.java @@ -14,7 +14,7 @@ public class AddVmFromSnapshotParameters extends AddVmParameters implements Seri private static final long serialVersionUID = -3400982291165788716L; //Unique Identifier of Source Snapshot - @NotNull(message="VALIDATION_SOURCE_SNAPSHOT_ID_NOT_NULL") + @NotNull(message = "VALIDATION_SOURCE_SNAPSHOT_ID_NOT_NULL") private Guid sourceSnapshotId; public AddVmFromSnapshotParameters() { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java index ef6331d5a83..893101852cd 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateFromSnapshotParameters.java @@ -11,7 +11,7 @@ public class AddVmTemplateFromSnapshotParameters extends AddVmTemplateParameters private static final long serialVersionUID = -486319959050997796L; //Unique Identifier of Source Snapshot - @NotNull(message="VALIDATION_SOURCE_SNAPSHOT_ID_NOT_NULL") + @NotNull(message = "VALIDATION_SOURCE_SNAPSHOT_ID_NOT_NULL") private Guid sourceSnapshotId; public AddVmTemplateFromSnapshotParameters() { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneVmParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneVmParameters.java index b411f619840..6e2bf4b5be5 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneVmParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CloneVmParameters.java @@ -88,7 +88,7 @@ public Map> getSrcToDstChainMap() { return srcToDstChainMap; } - public void setSrcToDstChainMap(Map> srcToDstChainMap) { + public void setSrcToDstChainMap(Map> srcToDstChainMap) { this.srcToDstChainMap = srcToDstChainMap; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java index 680c9c6baaa..625471b62a9 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateCinderSnapshotParameters.java @@ -3,7 +3,7 @@ import org.ovirt.engine.core.common.businessentities.Snapshot.SnapshotType; import org.ovirt.engine.core.compat.Guid; -public class CreateCinderSnapshotParameters extends ImagesContainterParametersBase{ +public class CreateCinderSnapshotParameters extends ImagesContainterParametersBase { private SnapshotType snapshotType; public CreateCinderSnapshotParameters(Guid imageId) { diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java index d3d792c9afe..8d3c39a31cc 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/DestroyImageParameters.java @@ -13,7 +13,7 @@ public class DestroyImageParameters extends StorageDomainParametersBase { private boolean postZero; private boolean force; - private DestroyImageParameters() {} + private DestroyImageParameters() { } public DestroyImageParameters( Guid vdsId, diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java index 00efdc39448..489dbbef7b7 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java @@ -5,7 +5,7 @@ public class FenceVdsActionParameters extends VdsActionParameters { private static final long serialVersionUID = 6174371941176548263L; - private boolean changeHostToMaintenanceOnStart=false; + private boolean changeHostToMaintenanceOnStart = false; /* * If the power management policy is responsible for this action diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotSetAmountOfMemoryParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotSetAmountOfMemoryParameters.java index be2e921651d..4ec69cd1116 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotSetAmountOfMemoryParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HotSetAmountOfMemoryParameters.java @@ -2,7 +2,7 @@ import org.ovirt.engine.core.common.businessentities.VmStatic; -public class HotSetAmountOfMemoryParameters extends VmManagementParametersBase { +public class HotSetAmountOfMemoryParameters extends VmManagementParametersBase { private PlugAction plugAction; private int numaNode; diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromConfParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromConfParameters.java index db1f20232fc..0c7c57a87f2 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromConfParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromConfParameters.java @@ -27,7 +27,7 @@ public class ImportVmFromConfParameters extends ImportVmParameters implements Im private List affinityGroups; private Set dbUsers; - private Map> userToRoles = new HashMap<>(); + private Map> userToRoles = new HashMap<>(); private List