Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

A redundant asserts #46

Open
janus opened this issue May 3, 2015 · 1 comment
Open

A redundant asserts #46

janus opened this issue May 3, 2015 · 1 comment

Comments

@janus
Copy link

janus commented May 3, 2015

Just noticed that assert macro was used twice on the same argument without change of state, any reason for this? Could be found inside carp_reg_inc and carp_reg_dec (https://github.com/tekknolagi/carp/blob/master/src/carp_registers.c#L89):

carp_bool carp_reg_inc (carp_value regs[], carp_reg reg) {
  assert(regs != NULL);

  assert(regs != NULL);
@tekknolagi
Copy link
Owner

@janus thank you for making an issue! That is indeed a typo. I am very slowly re-writing Carp, so I will not fix this immediately — but you should feel free to make a pull request if you like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants