Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading an empty relation #495

Closed
brendt opened this issue Sep 27, 2024 · 2 comments
Closed

Loading an empty relation #495

brendt opened this issue Sep 27, 2024 · 2 comments
Labels
Bug Something isn't working Triage New issues that need to be reviewed by the Tempest team.

Comments

@brendt
Copy link
Member

brendt commented Sep 27, 2024

Tempest Version

1.0-alpha1

PHP Version

8.3

Operating System

MacOS

Description

Loading a relation without any entries will result in null for the parent model

Steps to Reproduce

A:hasMany(B)

A::query->with('B') // without any entires

A will be null (because of inner join)

@brendt brendt added Bug Something isn't working Triage New issues that need to be reviewed by the Tempest team. labels Sep 27, 2024
@brendt
Copy link
Member Author

brendt commented Oct 2, 2024

Fixed with #493

@blackshadev
Copy link
Contributor

@brendt #493 is merged so can this be closed?

@brendt brendt closed this as completed Oct 8, 2024
@brendt brendt added this to the v1.0.0-alpha.3 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage New issues that need to be reviewed by the Tempest team.
Projects
None yet
Development

No branches or pull requests

2 participants