From ab0b67aa2613579420e247c332584459952bf0f5 Mon Sep 17 00:00:00 2001 From: Maxim Fateev Date: Wed, 3 Jul 2024 12:11:04 -0700 Subject: [PATCH] Demonstates a bug with calling the same child workflow twice from the same workflow --- child-workflow/child_workflow.go | 4 ++++ child-workflow/parent_workflow.go | 12 ++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/child-workflow/child_workflow.go b/child-workflow/child_workflow.go index 702e4bf2..3a49ae60 100644 --- a/child-workflow/child_workflow.go +++ b/child-workflow/child_workflow.go @@ -2,11 +2,15 @@ package child_workflow import ( "go.temporal.io/sdk/workflow" + "time" ) // @@@SNIPSTART samples-go-child-workflow-example-child-workflow-definition // SampleChildWorkflow is a Workflow Definition func SampleChildWorkflow(ctx workflow.Context, name string) (string, error) { + if name == "World" { + workflow.Sleep(ctx, time.Hour) + } logger := workflow.GetLogger(ctx) greeting := "Hello " + name + "!" logger.Info("Child workflow execution: " + greeting) diff --git a/child-workflow/parent_workflow.go b/child-workflow/parent_workflow.go index 604ba7cc..0dc665cf 100644 --- a/child-workflow/parent_workflow.go +++ b/child-workflow/parent_workflow.go @@ -1,6 +1,7 @@ package child_workflow import ( + enumspb "go.temporal.io/api/enums/v1" "go.temporal.io/sdk/workflow" ) @@ -13,12 +14,19 @@ func SampleParentWorkflow(ctx workflow.Context) (string, error) { logger := workflow.GetLogger(ctx) cwo := workflow.ChildWorkflowOptions{ - WorkflowID: "ABC-SIMPLE-CHILD-WORKFLOW-ID", + WorkflowID: "ABC-SIMPLE-CHILD-WORKFLOW-ID", + WorkflowIDReusePolicy: enumspb.WORKFLOW_ID_REUSE_POLICY_TERMINATE_IF_RUNNING, } ctx = workflow.WithChildOptions(ctx, cwo) var result string - err := workflow.ExecuteChildWorkflow(ctx, SampleChildWorkflow, "World").Get(ctx, &result) + err := workflow.ExecuteChildWorkflow(ctx, SampleChildWorkflow, "World").GetChildWorkflowExecution().Get(ctx, nil) + if err != nil { + logger.Error("Parent execution received child execution failure.", "Error", err) + return "", err + } + + err = workflow.ExecuteChildWorkflow(ctx, SampleChildWorkflow, "Foo").Get(ctx, &result) if err != nil { logger.Error("Parent execution received child execution failure.", "Error", err) return "", err