Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding knitout-to-kcode comparison feature to html file #28

Open
gabrielle-ohlson opened this issue Feb 27, 2021 · 2 comments
Open

adding knitout-to-kcode comparison feature to html file #28

gabrielle-ohlson opened this issue Feb 27, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@gabrielle-ohlson
Copy link
Collaborator

gabrielle-ohlson commented Feb 27, 2021

Since we've been talking about adding a feature to show the respective source knitout lines of code alongside each output kcode pass for debugging, I was thinking the html webpage could be a good place to do that.

Maybe in a live visualizer kind of fashion—where you can toggle the visibility of the source knitout and either:

  1. clicking on the lines of code for a kcode pass highlights & scrolls to the corresponding knitout (& vice versa)
  2. or the kcode is labeled with the line numbers for the corresponding knitout (and vice versa)
@gabrielle-ohlson gabrielle-ohlson added the enhancement New feature or request label Feb 27, 2021
@ixchow
Copy link
Member

ixchow commented Feb 27, 2021

I have been viewing the index.html as a way for folks to try things out before diving in deeper, which means the primary design goal is to make it uncomplicated and clear to a first-time user. This means -- from my viewpoint -- eliminating clutter (possibly including any display of input or output files).

So I think that this enhancement -- while useful -- doesn't belong in index.html .

@gabrielle-ohlson
Copy link
Collaborator Author

alright, that makes sense to me. maybe we add a separate html file that is for debugging/has more advanced features?

@gabrielle-ohlson gabrielle-ohlson changed the title adding knitout-to-kcode comparison feature to index.html adding knitout-to-kcode comparison feature to html file Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants