Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local categorization (highlighting) #11

Open
alekseyt opened this issue Apr 3, 2019 · 1 comment
Open

local categorization (highlighting) #11

alekseyt opened this issue Apr 3, 2019 · 1 comment

Comments

@alekseyt
Copy link

alekseyt commented Apr 3, 2019

I've being looking into syntax highlighting for Lua in vscode and noticed this oddity (Light+ theme):

image

Note that in first case local is highlighted purple, but in second case local is highlighted blue.

I think this happens because first time local is categorized as "keyword.control" ("keyword.control.lua" actually), but in second case (function regex) it is categorized as "storage.modifier" ("storage.modifier.local.lua"). This isn't visible when "storage.modifier" and "keyword.control" has the same color.

vscode's Lua file claims that it was imported from https://github.com/textmate/lua.tmbundle/blob/master/Syntaxes/Lua.plist

Is it a bug or expected behavior?

@Sainan
Copy link

Sainan commented Apr 13, 2023

The fix would be as easy as removing local from the keyword.control capture. Although if you're gonna open a PR, maybe do it against https://github.com/LuaLS/lua.tmbundle since that's at least maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants