Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpr dependency not building on Windows MSVS 2015 #18

Closed
ShamanTcler opened this issue Aug 11, 2020 · 4 comments · Fixed by #19
Closed

cpr dependency not building on Windows MSVS 2015 #18

ShamanTcler opened this issue Aug 11, 2020 · 4 comments · Fixed by #19
Assignees
Labels
devops To do with devops (test, CI/CD, gitops etc)

Comments

@ShamanTcler
Copy link

conan install . --install-folder C:/Users/xxxx/github/cpplot/build/release
Configuration:
[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=14
os=Windows
os_build=Windows
[options]
[build_requires]
[env]

ERROR: cpr/1.5.0: Error in configure() method, line 39
if self.options["libcurl"].with_openssl == False: # 'is False' doesn't work here (see conan-io/conan#3620)
ConanException: option 'with_openssl' doesn't exist
Possible options are []

I was using the conan-center as my remote.

@thclark thclark changed the title Windows MSVS 2015 build attempt, pulled the latest version ..and found cpr dependency not building on Windows MSVS 2015 Aug 11, 2020
@thclark
Copy link
Owner

thclark commented Aug 11, 2020

OK. So, the cpr library isn't presently used. It's there in the build system from when I was messing with plotly online (it's used in online.h to post figures to plotly online.

I'd like to come back to whether an online feature should be kept - so cross-referencing #10 as some discussion should be made.

However, in the meantime at least, I'm quite happy with removing the cpr dependency because I don't think it's actually linked anywhere.

Give me half an hour.

@thclark thclark self-assigned this Aug 11, 2020
@thclark thclark added the devops To do with devops (test, CI/CD, gitops etc) label Aug 11, 2020
@thclark
Copy link
Owner

thclark commented Aug 11, 2020

OK. 36 minutes. Give that a try @ShamanTcler

@thclark thclark closed this as completed Aug 11, 2020
@thclark thclark linked a pull request Aug 11, 2020 that will close this issue
@ShamanTcler
Copy link
Author

Update I switched to using conan-cmake (https://github.com/conan-io/cmake-conan) in the CMakelists.txt file and then gave it:

conan_cmake_run(
REQUIRES
eigen/3.3.7
nlohmann_json/3.8.0
boost/1.73.0
glog/0.4.0
gtest/1.10.0
tbb/2020.1
IMPORTS
${CONANIMPORTS}
BASIC_SETUP
CMAKE_TARGETS
)

And it compiled but did not link.

The switch to using conan-cmake was because it gets rid of the install issue... though you do need to have a conan.cmake file...

@thclark
Copy link
Owner

thclark commented Aug 12, 2020

Have you still got the same problem of not linking against cpr? or is it a new problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops To do with devops (test, CI/CD, gitops etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants