Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom url #103

Open
CodeDoctorDE opened this issue Oct 7, 2023 · 5 comments
Open

Adding custom url #103

CodeDoctorDE opened this issue Oct 7, 2023 · 5 comments
Labels
enhancement New feature or request feature request Community suggested features that haven't been brought into the project yet help wanted Extra attention is needed

Comments

@CodeDoctorDE
Copy link

Related to joelshepherd#170.

Hello,
I found your repo in the forks tab in tabliss and i want to thank you for further updating it.
I want to add devian images in my new tab but I couldn't find a way without adding them manually using "Upload images".

We could add a new "Custom source" option with properties: URL, Header (Authorization).

@the-wright-jamie
Copy link
Owner

Good idea! I will look into it - however, a lot of these require a custom implementation of the client side of the API so this would probably have to be implemented discreetly. I see that original issue that you have linked to, and certainly if there was a way to it in a similar fashion as to what @artfulrobot was suggesting it'll make it a whole lot easier - but it also might get the project in trouble as this is not the correct way to access these APIs. I'll investigate, and get back to you 🙂

@the-wright-jamie the-wright-jamie added enhancement New feature or request help wanted Extra attention is needed feature request Community suggested features that haven't been brought into the project yet labels Oct 7, 2023
@CodeDoctorDE
Copy link
Author

Oh yeah,
I didn't look if there was a devianart api but it looks like you need to do a few extra steps for this (https://u-scripts.blogspot.com/2010/01/how-to-get-random-pictures-from.html).

@artfulrobot
Copy link

FYI my interest was to fetch from a url I control, so I could serve up a random photo from my own collection.

@CodeDoctorDE
Copy link
Author

That's also a good idea. Supporting custom urls can solve multiple problems

@the-wright-jamie
Copy link
Owner

I'll see what I can do, it's an interesting problem. I still need to review the current issues and decide what is to be developed this month. This is quite a large issue, so I might not bring it in this month. I'd like to focus on expanding test coverage this month because

  1. As an engineer, writing tests is a weak point for me but it is an extremely important aspect of software engineering so I'd like to learn more about writing good tests
  2. Expanding test coverage makes it easier to ensure that PRs do not break other behaviors, making it easier to verify if I should merge contributions.

I'm always open to pull requests, so if anyone reading this has any idea on how this should be implemented your contributions will be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Community suggested features that haven't been brought into the project yet help wanted Extra attention is needed
Development

No branches or pull requests

3 participants