-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up search URL handling #56
Comments
@geealbers I think my only one of my key issues here is the how we want the Netlify implementation to work. Should I be able to use the this https://cva10.netlify.com/ and https://www.getty.edu/publications/cva10/ ? or should this just work -> https://www.getty.edu/publications/cva10/. If that is the case then adding the baseURL will break https://cva10.netlify.com/ or we can do something like https://cva10.netlify.com/publications/cva10/ but I think for search to add these we need to add the baseURL param for HUGO. Let me see what I can find in terms of how lunr works when URLs are relative. |
I think it's fine for us to break https://cva10.netlify.com/ once the publication is live. And in fact, it's a little weird that it's discoverable there at all. Is there a way to even deactivate that URL? |
looking at this here -> #61 |
@geealbers ok cool I will take a look I think we can do something but I am not sure about deactivating it. So I think I will try and get this working with a baseURL and then that will solve the search issue. I will let you know once the pull request is ready. |
Just posting this here so we don't lose track of it. From the email:
The text was updated successfully, but these errors were encountered: