Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing link-config #84

Open
thehydroimpulse opened this issue Dec 22, 2014 · 4 comments
Open

Consider removing link-config #84

thehydroimpulse opened this issue Dec 22, 2014 · 4 comments

Comments

@thehydroimpulse
Copy link
Owner

If we want to be compatible with the stable Rust 1.0, we won't be able to depend on or use syntax extensions, which link-config is composed of. Not to mention it's breaking every other day because of the compiler churn.

@jimfleming
Copy link

👍 for this. Just tried using nanomsg.rs today: alexcrichton/link-config#18

@thehydroimpulse
Copy link
Owner Author

@jimfleming We have a 1.0 branch that is fully functioning right now. I'm thinking of just making that the master branch and pushing to crates.io (which removes link-config)

@jimfleming
Copy link

Great, thanks. I'll switch to that branch for now.

@blabaere
Copy link
Collaborator

blabaere commented Feb 5, 2015

In this situation, we submit a PR to the link-config maintainer with the simplest fix possible, and he usually merges it in the following minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants