Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute callback even if visibility didn't change #115

Open
onemanclapping opened this issue Oct 25, 2016 · 1 comment
Open

Execute callback even if visibility didn't change #115

onemanclapping opened this issue Oct 25, 2016 · 1 comment

Comments

@onemanclapping
Copy link

onemanclapping commented Oct 25, 2016

        // Don't forward if no relevant infomation changed
        if (!info.changed) {
          return false;
        }

Updating from 1.x to 2.x I noticed this, which kinda ruined a use case of mine. I basically have a growing list with a spinner at the end. When the spinner is visible, the content is rendered but the spinner element is kept for further growing the list when the user scrolls some more.

Problem: if the initial value of the list sub-set is small, the spinner is immediately seen and more data rendered. If the spinner is still visible (big screens), nothing happens because effectively nothing changed in terms of visibility, but I want the callback to be called anyway.

Could you consider making this optional? I can make a PR if you agree. Thanks!

onemanclapping added a commit to onemanclapping/ng-lazy-render that referenced this issue Oct 25, 2016
onemanclapping added a commit to onemanclapping/ng-lazy-render that referenced this issue Oct 25, 2016
@thenikso
Copy link
Owner

Yes I think that having it optional makes a lot of sense. Especially if it breaks use cases with 1.0. PRs are very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants