Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Design] Introduce GCP Secrets for Gen AI services #1695

Closed
Benvii opened this issue Jul 22, 2024 · 0 comments · Fixed by #1697
Closed

[Design] Introduce GCP Secrets for Gen AI services #1695

Benvii opened this issue Jul 22, 2024 · 0 comments · Fixed by #1697
Assignees
@Benvii

Comments

@Benvii
Copy link
Member

Benvii commented Jul 22, 2024 •
edited
Loading

Write a design proposals for the introduction of GCP Secret Manager.

Feature #1696
@Benvii Benvii self-assigned this Jul 22, 2024
This was referenced Jul 22, 2024
Open
Merged
Benvii added a commit to CreditMutuelArkea/tock that referenced this issue Jul 23, 2024
@Benvii
📝 Introduce GCP Secrets PR design, Fixes theopenconversationkit#1695
cb79622
Benvii added a commit to CreditMutuelArkea/tock that referenced this issue Jul 31, 2024
@Benvii
📝 [Doc] GCP Secrets :intro mention about how GCP project location is …
7b07613 
…found, Fixes theopenconversationkit#1695
Benvii added a commit that referenced this issue Sep 3, 2024
@Benvii @AurelienSylvan @assouktim
[Design] Introduce GCP Secrets for Gen AI services (#1697)
8a080df 
* 🚧 WIP attempt to have mardown design with images working and jekyll site with images ..

* 📝 Introduce GCP Secrets PR design, Fixes #1695

* 🚧 Design GCP secret add iAdvize and mongodb

* 📝 Design GCP handle provider independently for each secrets set (mongodb, gen-ai, iAdvize)

* Updating changes

* 📝 [Doc] GCP Secrets :intro mention about how GCP project location is found, Fixes #1695

* Fixing typo

Co-authored-by: AurelienSylvan <[email protected]>

* 📝 Add mention of the open source implementation of Mongo cred for AWS.

assouktim comment #1697 (comment)

* 📝 Fix wrong secret name

Comment from AurelienSylvan #1697 (comment)

* Typo

Co-authored-by: AurelienSylvan <[email protected]>

* 📝 Rename from project number to project ID, also remove unused variables for NLP API

* Project num to ID fixes and mongo env variable fixes

Co-authored-by: assouktim <[email protected]>

* 📝 tock_gcp_secret_project_number ==> tock_gcp_project_id

Comment from assouktim #1697 (comment)

* 📝 Add renamed environment variables

* fix title

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Update docs/_en/dev/feature-technical-designs/1696-gcp-secrets.md

* Reviews

---------

Co-authored-by: AurelienSylvan <[email protected]>
Co-authored-by: assouktim <[email protected]>
Co-authored-by: Mohamed ASSOUKTI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Benvii Benvii

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Design] Introduce GCP Secrets for Gen AI services CreditMutuelArkea/tock
1 participant
@Benvii