Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return custom result/error types #46

Open
thewh1teagle opened this issue Nov 5, 2024 · 0 comments
Open

Return custom result/error types #46

thewh1teagle opened this issue Nov 5, 2024 · 0 comments
Labels
feature New feature or request

Comments

@thewh1teagle
Copy link
Owner

thewh1teagle commented Nov 5, 2024

Currently we use eyre::{Result,bail} but but Rust standard is to return custom types from crates.
I'm not sure we gonna use it only because it's standard because it requires more work. so need to see if it's worth it other than the fact.
eg. How really useful to external library that uses sherpa-rs is to know that the error is InvalidPointer returned from sherpa... seems like not much...

@thewh1teagle thewh1teagle added the feature New feature or request label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant