Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input for past admission data #51

Closed
6 tasks done
thibautjombart opened this issue Apr 1, 2020 · 4 comments
Closed
6 tasks done

Add input for past admission data #51

thibautjombart opened this issue Apr 1, 2020 · 4 comments
Labels
enhancement New feature or request priority This needs to get done first

Comments

@thibautjombart
Copy link
Owner

thibautjombart commented Apr 1, 2020

We should provide a template and facilities for inputing data on past admissions. This would have to be optional, so the default behaviour remains the current inputs.

Items

  • box tick input to uncover the file upload input, below the current data inputs
  • reactive UI to show template download / file upload if the box above is ticked
  • a template file, with 2 columns (date in format yyyy-mm-dd and n_admissions)
  • a button for downloading template file (.xlsx)
  • a button for uploading data
  • an internal function in R/ to check / process uploaded data (with meaningfull errors where relevant)

Notes

There are ways to edit tables from shiny directly e.g.:
https://blog.rstudio.com/2018/03/29/dt-0-4/

But I think uploading xlsx is safer

@thibautjombart thibautjombart added enhancement New feature or request priority This needs to get done first labels Apr 1, 2020
@thibautjombart
Copy link
Owner Author

@samclifford tagging you here but feel free to un-assign; probably best done after the 1 tab reform (#42)

@samclifford
Copy link
Collaborator

I love the idea of a downloadable template. Suggest we also include a data dictionary as the second sheet if it's going to be an XLSX format.

For the error checking I'm thinking it might be worth running a date cleaner from https://github.com/reconhub/linelist rather than being sticklers for the date format. So long as it's unambiguous that's the main thing.

@thibautjombart
Copy link
Owner Author

I love the idea of a downloadable template. Suggest we also include a data dictionary as the second sheet if it's going to be an XLSX format.

For the error checking I'm thinking it might be worth running a date cleaner from https://github.com/reconhub/linelist rather than being sticklers for the date format. So long as it's unambiguous that's the main thing.

Yep, and yep, totally agreed :)

@thibautjombart
Copy link
Owner Author

Done as of ad1c056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority This needs to get done first
Projects
None yet
Development

No branches or pull requests

2 participants