-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom LoS distribution #71
Comments
Considering it might be worth adding a boxplot horizontally under the barplot that we visualise with in order to show more than just the 95% quantile. Gamma and Weibull with the same mean and variance will have different skewness and kurtosis and, probably more importantly, median. Could be useful visual feedback for user. |
And with this implemented it might be worth having the Zhou parameter sets provide feedback with the 95% CI under the selectInput. |
adding functions to incorporate weibull distribution #71
@pearsonca has mentioned that it might be worth moving towards using the same sort of approach to LoS distributions as gets reported in the studies cited by the LoS review paper. This is most often the 25%, 50% and 75% quantiles. Specifying three numbers for a two parameter distribution would require moving to a call to |
The |
Feedback from authors of LoS review is to include the China distributions as well as the rest of the world. Added in c721730 |
We can continue to parametrise these in terms of mean and cv for users, but it might be worth considering asking if they want to use a Weibull via a drop-down menu. This would mean reworking
los_gamma()
to be a more general function that accepts an argument specifying whether the distribution to be used is one of gamma or weibull (or any other).This would require checking which parameters are to be passed on to the distribution. There's no closed form solution for moment matching a weibull, but we have λ = μ/Γ(1 + 1/k) and then we solve the following for k: CV^2 - (Γ(1 + 2/k))/(Γ(1 + 1/k))^2 + 1 = 0 and substitute the result into the equation for λ
The text was updated successfully, but these errors were encountered: