-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison filters do not support case-insensitive matching #115
Comments
Hey @BrandonGoddard-at thanks for reporting this issue, I've reread the RFC and, I think you're right this should be case insensitive. Do you mind looking at the issue and opening a pull request for this? |
Yes, at least for the standard cases in the core schema (i.e. group name filters). I've got a pretty blunt patch that we applied since all of our string fields we cared about were case insensitive. It looks something like this:
but If I have time I'll see if I can properly put up a PR that makes this an option on |
it would be awesome 🤓 |
Hello, |
@duaribiju I had no time to work on it, and it seems that @BrandonGoddard-at had no time neither. If you want to give it a try you are welcome. |
I believe there is an issue where comparison filters on string type attributes do not support case insensitive matching. I think this should be supported based on reading
https://datatracker.ietf.org/doc/html/rfc7643#section-7
and
https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.2.2
i.e. a filter of
displayName eq \"TestGroup\"
should matchtestGroup
andTestGROUP
, etc.I ran into this issue when trying to get an Azure AD app approved, and it looks like this is their interpretation of the spec as well
The text was updated successfully, but these errors were encountered: