-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show notification settings #8
Comments
I have implemented this feature. |
nice to see someone already building upon that :) , i think until the pull request #110 can get fully accepted into master it will still take some time because of the Theming thing(issue #9). I could try to get the changes for the settings menu into a separate pull request. @dbrgn Or does it make more sense to make a WIP branch for settings features ? |
@FloThinksPi maybe you could extract the (empty) settings dialog to a separate pull request, if you're well-versed with cherry-picking / rebasing :) We could then merge that to master so that @IndianaDschones can integrate the notification settings. |
@IndianaDschones the (empty) settings dialog and the settings service have now been merged to master! |
@dbrgn I think we can merge the notification settings today. I´ll performe some tests and if everything goes well, we´re ready to go 😄 |
@IndianaDschones btw, I did some small changes to notifications in #108. Shouldn't affect you though. |
Make it possible to enable/disable desktop notifications.
The text was updated successfully, but these errors were encountered: