Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notification settings #8

Closed
dbrgn opened this issue Feb 15, 2017 · 6 comments
Closed

Show notification settings #8

dbrgn opened this issue Feb 15, 2017 · 6 comments
Labels
feature New feature! good first issue If you want to get your hands dirty, this is a good start!

Comments

@dbrgn
Copy link
Contributor

dbrgn commented Feb 15, 2017

Make it possible to enable/disable desktop notifications.

@dbrgn dbrgn added good first issue If you want to get your hands dirty, this is a good start! feature New feature! labels Feb 15, 2017
@IndianaDschones
Copy link
Contributor

I have implemented this feature.
But I will wait untill the pull request #110 is merged into master in order to integrate the notification settings into the settings and to store the preference in loacal storage.

@FloThinksPi
Copy link
Contributor

FloThinksPi commented Mar 2, 2017

nice to see someone already building upon that :) , i think until the pull request #110 can get fully accepted into master it will still take some time because of the Theming thing(issue #9). I could try to get the changes for the settings menu into a separate pull request. @dbrgn Or does it make more sense to make a WIP branch for settings features ?

@dbrgn
Copy link
Contributor Author

dbrgn commented Mar 2, 2017

@FloThinksPi maybe you could extract the (empty) settings dialog to a separate pull request, if you're well-versed with cherry-picking / rebasing :) We could then merge that to master so that @IndianaDschones can integrate the notification settings.

@dbrgn
Copy link
Contributor Author

dbrgn commented Mar 6, 2017

@IndianaDschones the (empty) settings dialog and the settings service have now been merged to master!

@IndianaDschones
Copy link
Contributor

@dbrgn I think we can merge the notification settings today. I´ll performe some tests and if everything goes well, we´re ready to go 😄

@dbrgn
Copy link
Contributor Author

dbrgn commented Mar 7, 2017

@IndianaDschones btw, I did some small changes to notifications in #108. Shouldn't affect you though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature! good first issue If you want to get your hands dirty, this is a good start!
Development

No branches or pull requests

3 participants