Mavenisation of the code base

[mjw99]

Would it be possible to Mavenise the codebase?

I have made an initial attempt with this POM file:

<?xml version="1.0" encoding="UTF-8"?>

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
	<modelVersion>4.0.0</modelVersion>

	<groupId>com.actelion.research.datawarrior</groupId>
	<artifactId>datawarrior</artifactId>
	<version>1.0-SNAPSHOT</version>

	<name>datawarrior</name>
	<url>https://github.com/thsa/datawarrior</url>

	<properties>
		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
		<maven.compiler.source>1.8</maven.compiler.source>
		<maven.compiler.target>1.8</maven.compiler.target>
	</properties>

	<dependencies>
		<dependency>
			<groupId>org.apache.commons</groupId>
			<artifactId>commons-math</artifactId>
			<version>2.2</version>
		</dependency>

		<dependency>
			<groupId>com.actelion.research</groupId>
			<artifactId>openchemlib</artifactId>
			<version>2022.5.0</version>
		</dependency>

		<dependency>
			<groupId>org.openmolecules.fx</groupId>
			<artifactId>fxmolviewer</artifactId>
			<version>0.0.1-SNAPSHOT</version>
		</dependency>

		<dependency>
			<groupId>org.openjfx</groupId>
			<artifactId>javafx-controls</artifactId>
			<version>11.0.2</version>
		</dependency>
		<dependency>
			<groupId>org.openjfx</groupId>
			<artifactId>javafx-swing</artifactId>
			<version>11.0.2</version>
		</dependency>
		<dependency>
			<groupId>org.openjfx</groupId>
			<artifactId>javafx-web</artifactId>
			<version>11.0.2</version>
		</dependency>

		<dependency>
			<groupId>org.scijava</groupId>
			<artifactId>jep</artifactId>
			<version>2.4.2</version>
		</dependency>

		<dependency>
			<groupId>javax.vecmath</groupId>
			<artifactId>vecmath</artifactId>
			<version>1.5.2</version>
		</dependency>

		<dependency>
			<groupId>org.apache.xmlgraphics</groupId>
			<artifactId>batik</artifactId>
			<version>1.11</version>
			<type>pom</type>
		</dependency>

		<dependency>
			<groupId>org.apache.xmlgraphics</groupId>
			<artifactId>batik-svggen</artifactId>
			<version>1.11</version>
		</dependency>

		<dependency>
			<groupId>org.apache.xmlgraphics</groupId>
			<artifactId>batik-swing</artifactId>
			<version>1.11</version>
		</dependency>

		<dependency>
			<groupId>org.apache.xmlgraphics</groupId>
			<artifactId>batik-transcoder</artifactId>
			<version>1.11</version>
		</dependency>

		<dependency>
			<groupId>org.eclipse.ecf</groupId>
			<artifactId>org.json</artifactId>
			<version>1.0.0.v201011060100</version>
		</dependency>

		<dependency>
			<groupId>uk.ac.cam.ch.opsin</groupId>
			<artifactId>opsin-core</artifactId>
			<version>2.5.0</version>
		</dependency>

		<dependency>
			<groupId>net.sourceforge.jmol</groupId>
			<artifactId>jmol</artifactId>
			<version>14.31.10</version>
		</dependency>

		<dependency>
			<groupId>org.pushing-pixels</groupId>
			<artifactId>radiance-common</artifactId>
			<version>5.0.0</version>
		</dependency>

		<dependency>
			<groupId>org.pushing-pixels</groupId>
			<artifactId>radiance-theming</artifactId>
			<version>5.0.0</version>
		</dependency>

		<dependency>
			<groupId>io.github.dan2097</groupId>
			<artifactId>jna-inchi-all</artifactId>
			<version>1.0</version>
		</dependency>

	</dependencies>

	<build>
		<pluginManagement>
			<plugins>
				<plugin>
					<artifactId>maven-clean-plugin</artifactId>
					<version>3.1.0</version>
				</plugin>
				<plugin>
					<artifactId>maven-resources-plugin</artifactId>
					<version>3.2.0</version>
				</plugin>
				<plugin>
					<artifactId>maven-compiler-plugin</artifactId>
					<version>3.8.1</version>
				</plugin>
				<plugin>
					<artifactId>maven-surefire-plugin</artifactId>
					<version>3.0.0-M5</version>
				</plugin>
			</plugins>
		</pluginManagement>
	</build>
</project>

However, I think the following is needed:

1. Migration to https://github.com/kirill-grouchnikov/radiance
2. Deployment of https://github.com/thsa/fxmolviewer to Maven central (also see Initial mavenisation and CI fxmolviewer#8 )
3. A fix for InchiStereo usage
4. A few other minor fixes

[mjw99]

I have something quite close now at https://github.com/mjw99/datawarrior however I think there is breakage with the addition of CompoundTableConstants.cColumnPropertyCompoundProperty

[mjw99]

OK, the above fork, with its instructions, all works now.

[thsa]

Thank you Mark for the effort. Once the maven stuff is fully working, we should integrate it into the original DataWarrior repository to avoid confusion. It should, however, just be one of two standard methods to build. Some of the libs provided with the DataWarrior project were substancially reduced in size manually, which the maven build, unfortunately, cannot accomplish. MMFF libraries are also a little delicate. A newer version with newer dependencies didn't work anymore. Best wishes, Thomas

…

________________________________ Von: Mark J. Williamson ***@***.***> Gesendet: Donnerstag, 30. Juni 2022 20:35 An: thsa/datawarrior ***@***.***> Cc: Subscribed ***@***.***> Betreff: Re: [thsa/datawarrior] Mavenisation of the code base (Issue #6) I have something quite close now at https://github.com/mjw99/datawarrior<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmjw99%2Fdatawarrior&data=05%7C01%7Cthomas.sander%40idorsia.com%7C42fda1daeeb04cba166308da5ac73ea9%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C637922109032725621%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=D3%2Fxu1MgZzcSObsAPOwCpL%2ByrpJc3xs95m2v5bzqvBU%3D&reserved=0> however I think there is breakage with the addition of CompoundTableConstants.cColumnPropertyCompoundProperty — Reply to this email directly, view it on GitHub<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthsa%2Fdatawarrior%2Fissues%2F6%23issuecomment-1171548070&data=05%7C01%7Cthomas.sander%40idorsia.com%7C42fda1daeeb04cba166308da5ac73ea9%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C637922109032725621%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Cn%2BZAOPpLLlIrmGXoJ3Y7pMapdBWHYLNYLEzs0CWK00%3D&reserved=0>, or unsubscribe<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACNFEBUHLDEFEFLNCMXUSYDVRXSFLANCNFSM5VYER4HQ&data=05%7C01%7Cthomas.sander%40idorsia.com%7C42fda1daeeb04cba166308da5ac73ea9%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C637922109032725621%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Hl0bAkmWoKhjg5vimzNKl4XTBF0whNrly0cTZ5vlvp0%3D&reserved=0>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

________________________________ The information of this email and in any file transmitted with it is strictly confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, any copying, distribution or any other use of this email is prohibited and may be unlawful. In such case, you should please notify the sender immediately and destroy this email. The content of this email is not legally binding unless confirmed by letter. Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of the sender's company.

[mjw99]

Dear Thomas,

Many thanks for the update; I wonder if this could be used to reduce the size of some of the libs?
Also, as discussed, I have updated the PR here on fxmolviewer.

Thanks,

Mark