Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About 'self.test_labels[0:self.win_size]' in the line 187-192 of data_loader.py #48

Open
DongJKang opened this issue Aug 16, 2023 · 1 comment

Comments

@DongJKang
Copy link

I really appreciate your work and thanks a lot for sharing this work with us!

I am now following your code step by step to understand the model and apply it to my data.
And while I'm doing this, I got a question.

In the line 187-192 of data_loader.py
The code is written like this.

187 def getitem(self, index):
***
190 return np.float32(self.train[index:index + self.win_size]), np.float32(self.test_labels[0:self.win_size])
192 return np.float32(self.val[index:index + self.win_size]), np.float32(self.test_labels[0:self.win_size])

Shouldn't the '0' be changed to 'index'?
self.test_labels[0:self.win_size] -> self.test_labels[index:index + self.win_size]

If there's anything that I missed please let me know.

@maikouSart
Copy link

it's not important, they don't use labels in train mode and val mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants