Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: M4 outsample_window may be set improperly #665

Open
AdamAbate-6 opened this issue Jan 21, 2025 · 0 comments
Open

Bug: M4 outsample_window may be set improperly #665

AdamAbate-6 opened this issue Jan 21, 2025 · 0 comments

Comments

@AdamAbate-6
Copy link

See https://github.com/thuml/Time-Series-Library/blob/main/data_provider/data_loader.py#L362

The min value possible for cut_point is 1. This can cause a negative star to the indexing range on line 363. Lines 362 and 363 should read more like this:

outsample_window = sampled_timeseries[
                           max(1, cut_point - self.label_len):min(len(sampled_timeseries), cut_point + self.pred_len)]

in order to avoid the bottom end of the indexing range being negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant