Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing stopped at messages when engine fit fails #1109

Closed
simonpcouch opened this issue Apr 9, 2024 · 1 comment · Fixed by #1117
Closed

Timing stopped at messages when engine fit fails #1109

simonpcouch opened this issue Apr 9, 2024 · 1 comment · Fixed by #1117
Labels
bug an unexpected problem or unintended behavior

Comments

@simonpcouch
Copy link
Contributor

Intentionally introducing a failure:

# with extract_fit_time():
# pak::pak("tidymodels/parsnip@fd5124c")

library(parsnip)
library(modeldata)
  
boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument
#> Timing stopped at: 0.002 0.001 0.003

Created on 2024-04-09 with reprex v2.1.0

Before #853:

# with CRAN:
library(parsnip)
library(modeldata)


boost_tree(mtry = tune::tune()) %>%
  set_mode("regression") %>%
  fit(bill_length_mm ~ ., data = penguins)
#> Error in min(denom, x): invalid 'type' (language) of argument

Created on 2024-04-09 with reprex v2.1.0

This showed up in snaps on bonsai.

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant