Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test for base R error in execution tests #1195

Open
simonpcouch opened this issue Sep 10, 2024 · 2 comments
Open

remove test for base R error in execution tests #1195

simonpcouch opened this issue Sep 10, 2024 · 2 comments
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Contributor

Not sure that this was the original intent of the test:

Code
res <- parsnip::fit(hpc_xgboost, class ~ novar, data = hpc, control = ctrl)
Condition
Error:
! object 'novar' not found

Noticed this in the transition to snapshot testing in #1190.

@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Sep 10, 2024
@simonpcouch
Copy link
Contributor Author

There are actually quite a bit of these:

# keras execution, classification
Code
res <- parsnip::fit(hpc_keras, class ~ novar, data = hpc, control = ctrl)
Condition
Error:
! object 'novar' not found

# nnet execution, classification
Code
res <- parsnip::fit(hpc_nnet, class ~ novar, data = hpc, control = ctrl)
Condition
Error:
! object 'novar' not found

Let's do all of these in one swoop if we do remove. :)

@simonpcouch simonpcouch changed the title address uninformative error in boost_tree() tests remove test for base R error in execution tests Sep 10, 2024
@simonpcouch
Copy link
Contributor Author

Another:

Code
fit(hpc_basic, hpc_bad_form, data = hpc, control = ctrl)
Condition
Error:
! object 'term' not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

1 participant