diff --git a/R/fit.R b/R/fit.R index 108b009..5bc4719 100644 --- a/R/fit.R +++ b/R/fit.R @@ -103,10 +103,12 @@ make_inner_split <- function(object, data) { class = if (is.null(method)) "mc_split" else method ) + # add_tailor(prop) is the proportion to train the postprocessor, while + # rsample::mc_cv(prop) is the proportion to train the model (#247) prop <- object$post$actions$tailor$prop rsample::inner_split( mocked_split, - list(prop = if (is.null(prop)) 2/3 else prop) + list(prop = if (is.null(prop)) 2/3 else 1 - prop) ) } diff --git a/R/post-action-tailor.R b/R/post-action-tailor.R index 68dc503..84e85e2 100644 --- a/R/post-action-tailor.R +++ b/R/post-action-tailor.R @@ -20,7 +20,7 @@ #' @param prop The proportion of the data in [fit.workflow()] that should be #' held back specifically for estimating the postprocessor. Only relevant for #' postprocessors that require estimation---see section Data Usage below to -#' learn more. Defaults to 2/3. +#' learn more. Defaults to 1/3. #' #' @param method The method with which to split the data in [fit.workflow()], #' as a character vector. Only relevant for postprocessors that diff --git a/man/add_tailor.Rd b/man/add_tailor.Rd index 4002db4..34d99d3 100644 --- a/man/add_tailor.Rd +++ b/man/add_tailor.Rd @@ -22,7 +22,7 @@ will handle training internally.} \item{prop}{The proportion of the data in \code{\link[=fit.workflow]{fit.workflow()}} that should be held back specifically for estimating the postprocessor. Only relevant for postprocessors that require estimation---see section Data Usage below to -learn more. Defaults to 2/3.} +learn more. Defaults to 1/3.} \item{method}{The method with which to split the data in \code{\link[=fit.workflow]{fit.workflow()}}, as a character vector. Only relevant for postprocessors that