-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with phpBB 3.3.0 #71
Comments
I am getting the same issue and would love to see this updated to 3.3.0. |
The fix for that error message is pretty trivial. You just need to add quotes around any values that start with @ in that listed file. That gets rid of the error. The extension seems to work for me under phpBB3 with these changes. Not sure if other compatibility fixes are needed. Changes to ext/tierra/topicsolved/config/services.yml: 5c5
< - @tierra.topicsolved.topicsolved
---
> - "@tierra.topicsolved.topicsolved"
9,11c9,11
< - @tierra.topicsolved.topicsolved
< - @controller.helper
< - @template
---
> - "@tierra.topicsolved.topicsolved"
> - "@controller.helper"
> - "@template"
17,19c17,19
< - @tierra.topicsolved.topicsolved
< - @template
< - @request
---
> - "@tierra.topicsolved.topicsolved"
> - "@template"
> - "@request"
25,30c25,30
< - @dbal.conn
< - @user
< - @auth
< - @dispatcher
< - %core.root_path%
< - %core.php_ext%
---
> - "@dbal.conn"
> - "@user"
> - "@auth"
> - "@dispatcher"
> - "%core.root_path%"
> - "%core.php_ext%" |
Hi @tierra, could you update your extension? Or do you want I submit a new PR for that? Regards. |
Bonjour |
Take a look, here: https://www.phpbb.com/customise/db/extension/topic_solved/support/topic/215181?p=754206#p754206. ;) |
Merci Galixe . |
Take care too. ;) |
This is incorrect you don't want double quotes, you want single quotes. |
Thanks, PR submitted: #74. |
Is this repo abandoned? |
Just updated to the new version of PHPBB, and unfortunately, this extension broke with the update. It's a super useful one for my RPG group, so I'd love to see an update.
The text was updated successfully, but these errors were encountered: