Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with phpBB 3.3.0 #71

Open
notsoencrypted opened this issue Feb 17, 2020 · 11 comments
Open

Incompatibility with phpBB 3.3.0 #71

notsoencrypted opened this issue Feb 17, 2020 · 11 comments

Comments

@notsoencrypted
Copy link

Just updated to the new version of PHPBB, and unfortunately, this extension broke with the update. It's a super useful one for my RPG group, so I'd love to see an update.

image

@Hippie459MN
Copy link

I am getting the same issue and would love to see this updated to 3.3.0.

@aberkvam
Copy link

aberkvam commented Mar 1, 2020

The fix for that error message is pretty trivial. You just need to add quotes around any values that start with @ in that listed file. That gets rid of the error. The extension seems to work for me under phpBB3 with these changes. Not sure if other compatibility fixes are needed.

Changes to ext/tierra/topicsolved/config/services.yml:

5c5
<             - @tierra.topicsolved.topicsolved
---
>             - "@tierra.topicsolved.topicsolved"
9,11c9,11
<             - @tierra.topicsolved.topicsolved
<             - @controller.helper
<             - @template
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@controller.helper"
>             - "@template"
17,19c17,19
<             - @tierra.topicsolved.topicsolved
<             - @template
<             - @request
---
>             - "@tierra.topicsolved.topicsolved"
>             - "@template"
>             - "@request"
25,30c25,30
<             - @dbal.conn
<             - @user
<             - @auth
<             - @dispatcher
<             - %core.root_path%
<             - %core.php_ext%
---
>             - "@dbal.conn"
>             - "@user"
>             - "@auth"
>             - "@dispatcher"
>             - "%core.root_path%"
>             - "%core.php_ext%"

@Galixte Galixte mentioned this issue Apr 2, 2020
@Galixte
Copy link
Contributor

Galixte commented Apr 2, 2020

Hi @tierra,

could you update your extension? Or do you want I submit a new PR for that?

Regards.

@philmusic39
Copy link

Bonjour
dommage , c'est une extension des plus pratique dans mon forum.
j'ai fait la modification , vider le cache , mais il n'y a pas de changement.
je suis en phpbb 3.3.0.
Y a t-il une autre astuce que je ne vois pas.
Merci pour votre soutien.

@Galixte
Copy link
Contributor

Galixte commented Jun 18, 2020

Bonjour
dommage , c'est une extension des plus pratique dans mon forum.
j'ai fait la modification , vider le cache , mais il n'y a pas de changement.
je suis en phpbb 3.3.0.
Y a t-il une autre astuce que je ne vois pas.
Merci pour votre soutien.

Take a look, here: https://www.phpbb.com/customise/db/extension/topic_solved/support/topic/215181?p=754206#p754206. ;)

@philmusic39
Copy link

Merci Galixe .
j'ai re-installé , modifier et tout fonctionne.
Je suis ravi , vous faites un excellent travail.
bonne continuation et protéger vous bien .

@Galixte
Copy link
Contributor

Galixte commented Jun 18, 2020

Take care too. ;)

@rmcgirr83
Copy link

"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

@Galixte
Copy link
Contributor

Galixte commented Jun 21, 2020

"@dbal.conn"

This is incorrect you don't want double quotes, you want single quotes.

Thanks, PR submitted: #74.

@boczpeter
Copy link

Is this repo abandoned?
Why is PR#1 not yet accepted and the ext updated to work with current stable phpbb?

@gremirarunico
Copy link

This Issue shouldn't have been solved with this commit 531c116 by @Galixte ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants