Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellchecker caching #56

Open
chr15k opened this issue Jan 8, 2025 · 2 comments
Open

Spellchecker caching #56

chr15k opened this issue Jan 8, 2025 · 2 comments

Comments

@chr15k
Copy link
Contributor

chr15k commented Jan 8, 2025

Detailed description

I've submitted a PR here: peckphp/peck#51 to add caching for aspell->check() using Symfony's caching component. I noticed this feature is part of your roadmap and was curious about the feasibility of incorporating this implementation into the package (and expanding on it where necessary). What are your thoughts?

Possible implementation

peckphp/peck#51

@tigitz
Copy link
Owner

tigitz commented Jan 8, 2025

Uh oh, interesting. I didn't know about @nunomaduro's Peck project. It seems to envision what I had in mind as one of the final products for php-spellchecker.

To be honest, I’ve had some ups and downs in motivation to develop php-spellchecker further since its inception. It was mainly a way to fill the gap in the PHP ecosystem for a reliable and extensible spellchecking library, but also a means to publicly showcase my skills.

But if a small group of people is genuinely interested, I could commit to making the library the reliable underlying spellchecking engine for PeckPHP in partnership with its maintainers and continue developing it further.

So yes, I'll happily accept a PR that adds a cache mechanism based on PSR interfaces.

@chr15k
Copy link
Contributor Author

chr15k commented Jan 9, 2025

Nice! That makes sense and I reckon it would be great to continue development on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants